From nobody Fri May 17 01:44:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.com ARC-Seal: i=1; a=rsa-sha256; t=1681116432; cv=none; d=zohomail.com; s=zohoarc; b=EdWePEEIO0OSLHUGJSqYu0qxTgiT78UBOC5sMp8QxJrFXWVdhRFjglXl531kBBv4iVDAMvZIij1NFwkljauDwyzatnP0D2EQc9KJOpaDJ958AAhF8Kd3qvrhVKu9sbj/CqJioGA9pSf7pMrgms1sLaw+UBmrWH9fx/I1obcDeOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681116432; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=RdztJx/oyOON0vgfJPqkyc6f/SUKBKiefGCYyoBMIMQ=; b=MtHD/ElG2LCI5nkH9wUPQYadn0dj616ScZBP+20CxWQAA+D6EFygOTNeT/94+NWzx573ESN+IcQaF1fN89ayEpKhuGjPP7HAEkM6FD9fEZuJ1yirUajudjujzdDXUQbz456R3d5s3WLhcqQ4QLjSwZempzJdBou0g2GwNOWLTas= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681116432267140.65092893055794; Mon, 10 Apr 2023 01:47:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plnAN-0005xr-Er; Mon, 10 Apr 2023 04:46:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plnAG-0005xU-0L; Mon, 10 Apr 2023 04:46:16 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plnAD-0007pc-Ay; Mon, 10 Apr 2023 04:46:15 -0400 Received: from mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:47ac:0:640:70fa:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 2BA6060163; Mon, 10 Apr 2023 11:35:00 +0300 (MSK) Received: from dellarbn.yandex.net (unknown [2a02:6b8:b081:b401::1:1f]) by mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id lYPUCF0OcKo0-sMqn7sOw; Mon, 10 Apr 2023 11:34:59 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1681115699; bh=RdztJx/oyOON0vgfJPqkyc6f/SUKBKiefGCYyoBMIMQ=; h=Message-Id:Date:Cc:Subject:To:From; b=0v+kHT/CtjTEb0Y1HIo30hnL1ou73eVLKcqELN0Pj+ZYpLKWhueze1Lsa2l60ijKO BKIe0+oRTLVRyjU3JvAJHt6kuvHfvXBcDi+NxF9vbzvJjbHDQ+ZH9jyROjVMNDzk+D Yjv/Xf1Hhjj2u8zOCSPQfFDQPr2exKDJVvqb9UBg= Authentication-Results: mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.com From: Andrey Ryabinin To: Raphael Norwitz , "Michael S. Tsirkin" , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Yongji Xie , Chai Wen , Ni Xun , d-tatianin@yandex-team.com, yc-core@yandex-team.com, Andrey Ryabinin Subject: [PATCH] block/vhost-user-blk: Fix hang on boot for some odd guests Date: Mon, 10 Apr 2023 10:35:09 +0200 Message-Id: <20230410083509.3311-1-arbn@yandex-team.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=arbn@yandex-team.com; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.com) X-ZM-MESSAGEID: 1681116434079100001 Content-Type: text/plain; charset="utf-8" Some guests hang on boot when using the vhost-user-blk-pci device, but boot normally when using the virtio-blk device. The problem occurs because the guest advertises VIRTIO_F_VERSION_1 but kicks the virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK, causing vdev->start_on_kick to be false in vhost_user_blk_handle_output() and preventing the device from starting. Fix this by removing the check for vdev->start_on_kick to ensure that the device starts after the kick. This aligns the behavior of 'vhost-user-blk-pci' device with 'virtio-blk' as it does the similar thing in its virtio_blk_handle_output() function. Fixes: 110b9463d5c8 ("vhost-user-blk: start vhost when guest kicks") Signed-off-by: Andrey Ryabinin --- hw/block/vhost-user-blk.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c index aff4d2b8cbd..448ead448f3 100644 --- a/hw/block/vhost-user-blk.c +++ b/hw/block/vhost-user-blk.c @@ -279,10 +279,6 @@ static void vhost_user_blk_handle_output(VirtIODevice = *vdev, VirtQueue *vq) Error *local_err =3D NULL; int i, ret; =20 - if (!vdev->start_on_kick) { - return; - } - if (!s->connected) { return; } --=20 2.39.2