From: Carlos Santos <casantos@redhat.com>
It is not useful when configuring with --enable-trace-backends=nop.
Signed-off-by: Carlos Santos <casantos@redhat.com>
---
Changes v1->v2:
Install based on chosen trace backend, not on chosen emulators.
Changes v2->v3:
Add missing comma
Changes v3->v4:
Fix array comparison:
get_option('trace_backends') != [ 'nop' ]
not
get_option('trace_backends') != 'nop'
---
trace/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace/meson.build b/trace/meson.build
index 8e80be895c..30b1d942eb 100644
--- a/trace/meson.build
+++ b/trace/meson.build
@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
input: trace_events_files,
command: [ 'cat', '@INPUT@' ],
capture: true,
- install: true,
+ install: get_option('trace_backends') != [ 'nop' ],
install_dir: qemu_datadir)
if 'ust' in get_option('trace_backends')
--
2.31.1
On Fri, 7 Apr 2023 at 21:05, <casantos@redhat.com> wrote: > > From: Carlos Santos <casantos@redhat.com> > > It is not useful when configuring with --enable-trace-backends=nop. > > Signed-off-by: Carlos Santos <casantos@redhat.com> > --- > Changes v1->v2: > Install based on chosen trace backend, not on chosen emulators. > Changes v2->v3: > Add missing comma > Changes v3->v4: > Fix array comparison: > get_option('trace_backends') != [ 'nop' ] > not > get_option('trace_backends') != 'nop' > --- > trace/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block-next tree: https://gitlab.com/stefanha/qemu/-/commit/d0380c64b4002e6da3b6e205468030d9e76dcc4a Stefan
Copying Stefan as the trace subsystem maintainer On Fri, Apr 07, 2023 at 10:04:10PM -0300, casantos@redhat.com wrote: > From: Carlos Santos <casantos@redhat.com> > > It is not useful when configuring with --enable-trace-backends=nop. > > Signed-off-by: Carlos Santos <casantos@redhat.com> > --- > Changes v1->v2: > Install based on chosen trace backend, not on chosen emulators. > Changes v2->v3: > Add missing comma > Changes v3->v4: > Fix array comparison: > get_option('trace_backends') != [ 'nop' ] > not > get_option('trace_backends') != 'nop' > --- > trace/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trace/meson.build b/trace/meson.build > index 8e80be895c..30b1d942eb 100644 > --- a/trace/meson.build > +++ b/trace/meson.build > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', > input: trace_events_files, > command: [ 'cat', '@INPUT@' ], > capture: true, > - install: true, > + install: get_option('trace_backends') != [ 'nop' ], > install_dir: qemu_datadir) > > if 'ust' in get_option('trace_backends') > -- > 2.31.1 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
© 2016 - 2024 Red Hat, Inc.