block/nfs: do not use qatomic_mb_set

[PATCH for-8.1] block/nfs: do not use qatomic_mb_set

Paolo Bonzini posted 1 patch 1 year ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230406100830.240914-1-pbonzini@redhat.com

Maintainers: Peter Lieven <pl@kamp.de>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

block/nfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH for-8.1] block/nfs: do not use qatomic_mb_set

Posted by Paolo Bonzini 1 year ago

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/nfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/nfs.c b/block/nfs.c
index 351dc6ec8d14..0ee63f44deb0 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -727,8 +727,8 @@ nfs_get_allocated_file_size_cb(int ret, struct nfs_context *nfs, void *data,
         error_report("NFS Error: %s", nfs_get_error(nfs));
     }
 
-    /* Set task->complete before reading bs->wakeup.  */
-    qatomic_mb_set(&task->complete, 1);
+    /* Memory barrier already included in bdrv_wakeup(), via aio_wait_kick().  */
+    qatomic_set(&task->complete, 1);
     bdrv_wakeup(task->bs);
 }
 
-- 
2.39.2

Re: [PATCH for-8.1] block/nfs: do not use qatomic_mb_set

Posted by Stefan Hajnoczi 1 year ago

On Thu, 6 Apr 2023 at 06:09, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/nfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>