tests/qemu-iotests: serialise all the qemu-iotests

[RFC PATCH] tests/qemu-iotests: serialise all the qemu-iotests

Posted by Alex Bennée 2 years, 10 months ago

Something on OpenBSD fails with multiple tests running at once and
fiddling with J=1 on invocation just made everything else very slow.

Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/qemu-iotests/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index a162f683ef..d572205a60 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats
            depends: qemu_iotests_binaries,
            env: qemu_iotests_env,
            protocol: 'tap',
+           is_parallel : false,
            timeout: 180,
            suite: suites)
   endforeach
-- 
2.39.2

Re: [RFC PATCH] tests/qemu-iotests: serialise all the qemu-iotests

Posted by Daniel P. Berrangé 2 years, 10 months ago

On Tue, Mar 21, 2023 at 11:51:02PM +0000, Alex Bennée wrote:
> Something on OpenBSD fails with multiple tests running at once and
> fiddling with J=1 on invocation just made everything else very slow.
> 
> Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tests/qemu-iotests/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index a162f683ef..d572205a60 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats
>             depends: qemu_iotests_binaries,
>             env: qemu_iotests_env,
>             protocol: 'tap',
> +           is_parallel : false,
>             timeout: 180,
>             suite: suites)
>    endforeach

This will be a massive regression for all platforms though.

The iotests run a few 100 tests. Previously the iotests harness was
serialized against all other QEMU tests, but the individual iotests
were all parallelized.

With this proposed change all 100 individual iotests are serialized,
both with each other, and with all other QEMU tests.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [RFC PATCH] tests/qemu-iotests: serialise all the qemu-iotests

Posted by Alex Bennée 2 years, 10 months ago

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Tue, Mar 21, 2023 at 11:51:02PM +0000, Alex Bennée wrote:
>> Something on OpenBSD fails with multiple tests running at once and
>> fiddling with J=1 on invocation just made everything else very slow.
>> 
>> Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>  tests/qemu-iotests/meson.build | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
>> index a162f683ef..d572205a60 100644
>> --- a/tests/qemu-iotests/meson.build
>> +++ b/tests/qemu-iotests/meson.build
>> @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats
>>             depends: qemu_iotests_binaries,
>>             env: qemu_iotests_env,
>>             protocol: 'tap',
>> +           is_parallel : false,
>>             timeout: 180,
>>             suite: suites)
>>    endforeach
>
> This will be a massive regression for all platforms though.
>
> The iotests run a few 100 tests. Previously the iotests harness was
> serialized against all other QEMU tests, but the individual iotests
> were all parallelized.
>
> With this proposed change all 100 individual iotests are serialized,
> both with each other, and with all other QEMU tests.

What about Phillipe's suggestion of doing it just for openbsd?

>
> With regards,
> Daniel


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] tests/qemu-iotests: serialise all the qemu-iotests

Posted by Philippe Mathieu-Daudé 2 years, 10 months ago

On 22/3/23 00:51, Alex Bennée wrote:
> Something on OpenBSD fails with multiple tests running at once and
> fiddling with J=1 on invocation just made everything else very slow.
> 
> Based-on: 20230318114644.1340899-1-alex.bennee@linaro.org
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/qemu-iotests/meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index a162f683ef..d572205a60 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -64,6 +64,7 @@ foreach format, speed: qemu_iotests_formats
>              depends: qemu_iotests_binaries,
>              env: qemu_iotests_env,
>              protocol: 'tap',
> +           is_parallel : false,

Per the commit description, what about:

               is_parallel: targetos != 'openbsd',

?

>              timeout: 180,
>              suite: suites)
>     endforeach