tests/tcg/xtensa: add linker.ld to CLEANFILES

[PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

Posted by Max Filippov 1 year, 1 month ago

Linker script for xtensa tests must be preprocessed for a specific
target, remove it as a part of make clean.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 tests/tcg/xtensa/Makefile.softmmu-target | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/tcg/xtensa/Makefile.softmmu-target b/tests/tcg/xtensa/Makefile.softmmu-target
index 973e55298ee4..948c0e6506bd 100644
--- a/tests/tcg/xtensa/Makefile.softmmu-target
+++ b/tests/tcg/xtensa/Makefile.softmmu-target
@@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
 LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
 
 CRT        = crt.o vectors.o
+CLEANFILES += linker.ld
 
 linker.ld: linker.ld.S
 	$(CC) $(XTENSA_INC) -E -P $< -o $@
-- 
2.30.2

Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

On 14/3/23 23:08, Max Filippov wrote:
> Linker script for xtensa tests must be preprocessed for a specific
> target, remove it as a part of make clean.
> 

Fixes: be5cac175a ("tests/tcg/xtensa: enable system tests")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>   tests/tcg/xtensa/Makefile.softmmu-target | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/tcg/xtensa/Makefile.softmmu-target b/tests/tcg/xtensa/Makefile.softmmu-target
> index 973e55298ee4..948c0e6506bd 100644
> --- a/tests/tcg/xtensa/Makefile.softmmu-target
> +++ b/tests/tcg/xtensa/Makefile.softmmu-target
> @@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
>   LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
>   
>   CRT        = crt.o vectors.o
> +CLEANFILES += linker.ld
>   
>   linker.ld: linker.ld.S
>   	$(CC) $(XTENSA_INC) -E -P $< -o $@

Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

Posted by Wilfred Mallawa 1 year, 1 month ago

On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> Linker script for xtensa tests must be preprocessed for a specific
> target, remove it as a part of make clean.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  tests/tcg/xtensa/Makefile.softmmu-target | 1 +
>  1 file changed, 1 insertion(+)
Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> diff --git a/tests/tcg/xtensa/Makefile.softmmu-target
> b/tests/tcg/xtensa/Makefile.softmmu-target
> index 973e55298ee4..948c0e6506bd 100644
> --- a/tests/tcg/xtensa/Makefile.softmmu-target
> +++ b/tests/tcg/xtensa/Makefile.softmmu-target
> @@ -26,6 +26,7 @@ ASFLAGS = -Wa,--no-absolute-literals
>  LDFLAGS = -Tlinker.ld -nostartfiles -nostdlib
>  
>  CRT        = crt.o vectors.o
> +CLEANFILES += linker.ld
>  
>  linker.ld: linker.ld.S
>         $(CC) $(XTENSA_INC) -E -P $< -o $@

Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

Posted by Max Filippov 1 year, 1 month ago

On Tue, Mar 14, 2023 at 4:41 PM Wilfred Mallawa <wilfred.mallawa@wdc.com> wrote:
>
> On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> > Linker script for xtensa tests must be preprocessed for a specific
> > target, remove it as a part of make clean.
> >
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > ---
> >  tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> >  1 file changed, 1 insertion(+)

> Wilfred Mallawa <wilfred.mallawa@wdc.com>

The tag is missing, I assume you meant Reviewed-by.

-- 
Thanks.
-- Max

Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

Posted by Wilfred Mallawa 1 year, 1 month ago

On Tue, 2023-03-14 at 17:08 -0700, Max Filippov wrote:
> On Tue, Mar 14, 2023 at 4:41 PM Wilfred Mallawa
> <wilfred.mallawa@wdc.com> wrote:
> > 
> > On Tue, 2023-03-14 at 15:08 -0700, Max Filippov wrote:
> > > Linker script for xtensa tests must be preprocessed for a
> > > specific
> > > target, remove it as a part of make clean.
> > > 
> > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > > ---
> > >  tests/tcg/xtensa/Makefile.softmmu-target | 1 +
> > >  1 file changed, 1 insertion(+)
> 
> > Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> The tag is missing, I assume you meant Reviewed-by.

Ah crap, sorry! yes I did.

Wilfred
>