[v1] Add qemu qcode support for keys F13 to F24

[PATCH] Add qemu qcode support for keys F13 to F24

Posted by Willem van de Velde 1 year, 2 months ago

To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.

Signed-off-by: Willem van de Velde <williamvdvelde@gmail.com>
---
 qapi/ui.json    | 15 ++++++++++++++-
 ui/keycodemapdb |  2 +-
 2 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/qapi/ui.json b/qapi/ui.json
index 0abba3e930..98322342f7 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -886,6 +886,19 @@
 # @lang1: since 6.1
 # @lang2: since 6.1
 #
+# @f13: since 8.0
+# @f14: since 8.0
+# @f15: since 8.0
+# @f16: since 8.0
+# @f17: since 8.0
+# @f18: since 8.0
+# @f19: since 8.0
+# @f20: since 8.0
+# @f21: since 8.0
+# @f22: since 8.0
+# @f23: since 8.0
+# @f24: since 8.0
+#
 # 'sysrq' was mistakenly added to hack around the fact that
 # the ps2 driver was not generating correct scancodes sequences
 # when 'alt+print' was pressed. This flaw is now fixed and the
@@ -918,7 +931,7 @@
             'volumeup', 'volumedown', 'mediaselect',
             'mail', 'calculator', 'computer',
             'ac_home', 'ac_back', 'ac_forward', 'ac_refresh', 'ac_bookmarks',
-            'lang1', 'lang2' ] }
+            'lang1', 'lang2','f13','f14','f15','f16','f17','f18','f19','f20','f21','f22','f23','f24' ] }
 
 ##
 # @KeyValueKind:
diff --git a/ui/keycodemapdb b/ui/keycodemapdb
index d21009b1c9..f5772a62ec 160000
--- a/ui/keycodemapdb
+++ b/ui/keycodemapdb
@@ -1 +1 @@
-Subproject commit d21009b1c9f94b740ea66be8e48a1d8ad8124023
+Subproject commit f5772a62ec52591ff6870b7e8ef32482371f22c6
-- 
2.34.1

Re: [PATCH] Add qemu qcode support for keys F13 to F24

Posted by Alex Bennée 1 year, 1 month ago

Willem van de Velde <williamvdvelde@gmail.com> writes:

> To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
> The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.
>
> Signed-off-by: Willem van de Velde <williamvdvelde@gmail.com>

Adding maintainer to CC list so this doesn't get lost.

For reference from:
https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html#cc-the-relevant-maintainer

  git config sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'

will configure git send-email to do this automatically.

> ---
>  qapi/ui.json    | 15 ++++++++++++++-
>  ui/keycodemapdb |  2 +-
>  2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/ui.json b/qapi/ui.json
> index 0abba3e930..98322342f7 100644
> --- a/qapi/ui.json
> +++ b/qapi/ui.json
> @@ -886,6 +886,19 @@
>  # @lang1: since 6.1
>  # @lang2: since 6.1
>  #
> +# @f13: since 8.0
> +# @f14: since 8.0
> +# @f15: since 8.0
> +# @f16: since 8.0
> +# @f17: since 8.0
> +# @f18: since 8.0
> +# @f19: since 8.0
> +# @f20: since 8.0
> +# @f21: since 8.0
> +# @f22: since 8.0
> +# @f23: since 8.0
> +# @f24: since 8.0
> +#
>  # 'sysrq' was mistakenly added to hack around the fact that
>  # the ps2 driver was not generating correct scancodes sequences
>  # when 'alt+print' was pressed. This flaw is now fixed and the
> @@ -918,7 +931,7 @@
>              'volumeup', 'volumedown', 'mediaselect',
>              'mail', 'calculator', 'computer',
>              'ac_home', 'ac_back', 'ac_forward', 'ac_refresh', 'ac_bookmarks',
> -            'lang1', 'lang2' ] }
> +            'lang1', 'lang2','f13','f14','f15','f16','f17','f18','f19','f20','f21','f22','f23','f24' ] }
>  
>  ##
>  # @KeyValueKind:
> diff --git a/ui/keycodemapdb b/ui/keycodemapdb
> index d21009b1c9..f5772a62ec 160000
> --- a/ui/keycodemapdb
> +++ b/ui/keycodemapdb
> @@ -1 +1 @@
> -Subproject commit d21009b1c9f94b740ea66be8e48a1d8ad8124023
> +Subproject commit f5772a62ec52591ff6870b7e8ef32482371f22c6


-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] Add qemu qcode support for keys F13 to F24

Posted by Daniel P. Berrangé 1 year, 1 month ago

On Mon, Mar 06, 2023 at 12:30:37PM +0000, Alex Bennée wrote:
> 
> Willem van de Velde <williamvdvelde@gmail.com> writes:
> 
> > To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
> > The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.
> >
> > Signed-off-by: Willem van de Velde <williamvdvelde@gmail.com>
> 
> Adding maintainer to CC list so this doesn't get lost.

FYI, since its trivial, I'm fine with queuing this myself in the next
set of misc fixes I've got collected for this release.

> 
> For reference from:
> https://qemu.readthedocs.io/en/latest/devel/submitting-a-patch.html#cc-the-relevant-maintainer
> 
>   git config sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'
> 
> will configure git send-email to do this automatically.
> 
> > ---
> >  qapi/ui.json    | 15 ++++++++++++++-
> >  ui/keycodemapdb |  2 +-
> >  2 files changed, 15 insertions(+), 2 deletions(-)
> >
> > diff --git a/qapi/ui.json b/qapi/ui.json
> > index 0abba3e930..98322342f7 100644
> > --- a/qapi/ui.json
> > +++ b/qapi/ui.json
> > @@ -886,6 +886,19 @@
> >  # @lang1: since 6.1
> >  # @lang2: since 6.1
> >  #
> > +# @f13: since 8.0
> > +# @f14: since 8.0
> > +# @f15: since 8.0
> > +# @f16: since 8.0
> > +# @f17: since 8.0
> > +# @f18: since 8.0
> > +# @f19: since 8.0
> > +# @f20: since 8.0
> > +# @f21: since 8.0
> > +# @f22: since 8.0
> > +# @f23: since 8.0
> > +# @f24: since 8.0
> > +#
> >  # 'sysrq' was mistakenly added to hack around the fact that
> >  # the ps2 driver was not generating correct scancodes sequences
> >  # when 'alt+print' was pressed. This flaw is now fixed and the
> > @@ -918,7 +931,7 @@
> >              'volumeup', 'volumedown', 'mediaselect',
> >              'mail', 'calculator', 'computer',
> >              'ac_home', 'ac_back', 'ac_forward', 'ac_refresh', 'ac_bookmarks',
> > -            'lang1', 'lang2' ] }
> > +            'lang1', 'lang2','f13','f14','f15','f16','f17','f18','f19','f20','f21','f22','f23','f24' ] }
> >  
> >  ##
> >  # @KeyValueKind:
> > diff --git a/ui/keycodemapdb b/ui/keycodemapdb
> > index d21009b1c9..f5772a62ec 160000
> > --- a/ui/keycodemapdb
> > +++ b/ui/keycodemapdb
> > @@ -1 +1 @@
> > -Subproject commit d21009b1c9f94b740ea66be8e48a1d8ad8124023
> > +Subproject commit f5772a62ec52591ff6870b7e8ef32482371f22c6
> 
> 
> -- 
> Alex Bennée
> Virtualisation Tech Lead @ Linaro
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH] Add qemu qcode support for keys F13 to F24

Posted by Daniel P. Berrangé 1 year, 2 months ago

On Wed, Mar 01, 2023 at 01:52:11PM +0100, Willem van de Velde wrote:
> To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
> The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.
> 
> Signed-off-by: Willem van de Velde <williamvdvelde@gmail.com>
> ---
>  qapi/ui.json    | 15 ++++++++++++++-
>  ui/keycodemapdb |  2 +-
>  2 files changed, 15 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|