scripts/git.orderfile: Display QAPI script changes before schema ones

[PATCH] scripts/git.orderfile: Display QAPI script changes before schema ones

Philippe Mathieu-Daudé posted 1 patch 1 year, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230224214114.26464-1-philmd@linaro.org

scripts/git.orderfile | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH] scripts/git.orderfile: Display QAPI script changes before schema ones

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

When modifying QAPI scripts and modifying C files along,
it makes sense to display QAPI changes first.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
Failed example:
https://lore.kernel.org/qemu-devel/20230224155451.20211-3-philmd@linaro.org/
---
 scripts/git.orderfile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/git.orderfile b/scripts/git.orderfile
index 8edac0380b..70adc1a74a 100644
--- a/scripts/git.orderfile
+++ b/scripts/git.orderfile
@@ -22,6 +22,8 @@ Makefile*
 *.mak
 meson.build
 
+# qapi scripts
+scripts/qapi*
 # qapi schema
 qapi/*.json
 qga/*.json
-- 
2.38.1

Re: [PATCH] scripts/git.orderfile: Display QAPI script changes before schema ones

Posted by Philippe Mathieu-Daudé 1 year, 1 month ago

Cc'ing qemu-trivial@

On 24/2/23 22:41, Philippe Mathieu-Daudé wrote:
> When modifying QAPI scripts and modifying C files along,
> it makes sense to display QAPI changes first.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Failed example:
> https://lore.kernel.org/qemu-devel/20230224155451.20211-3-philmd@linaro.org/
> ---
>   scripts/git.orderfile | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/git.orderfile b/scripts/git.orderfile
> index 8edac0380b..70adc1a74a 100644
> --- a/scripts/git.orderfile
> +++ b/scripts/git.orderfile
> @@ -22,6 +22,8 @@ Makefile*
>   *.mak
>   meson.build
>   
> +# qapi scripts
> +scripts/qapi*
>   # qapi schema
>   qapi/*.json
>   qga/*.json