block/qcow2: QAPI'fy Qcow2DiscardType

[PATCH 0/2] block/qcow2: QAPI'fy Qcow2DiscardType

Philippe Mathieu-Daudé posted 2 patches 1 year, 2 months ago

Download series mbox

Failed in applying to current master (apply log)

Maintainers: Eric Blake <eblake@redhat.com>, Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>, John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Markus Armbruster <armbru@redhat.com>

block/qcow2-bitmap.c   | 12 ++++++------
block/qcow2-cluster.c  | 32 ++++++++++++++++----------------
block/qcow2-refcount.c | 36 ++++++++++++++++++------------------
block/qcow2-snapshot.c |  8 ++++----
block/qcow2.c          | 26 +++++++++++++-------------
block/qcow2.h          | 19 +++++--------------
qapi/block-core.json   | 10 ++++++++++
7 files changed, 72 insertions(+), 71 deletions(-)

Expand all Fold all

[PATCH 0/2] block/qcow2: QAPI'fy Qcow2DiscardType

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

QAPI seems designed to maintain such enums,
so convert Qcow2DiscardType to be QAPI generated.
Besides, this is how Qcow2CompressionType is maintained.

Philippe Mathieu-Daudé (2):
  block/qcow2: Rename QCOW2_DISCARD_TYPE enum definitions
  block/qcow2: QAPI'fy Qcow2DiscardType

 block/qcow2-bitmap.c   | 12 ++++++------
 block/qcow2-cluster.c  | 32 ++++++++++++++++----------------
 block/qcow2-refcount.c | 36 ++++++++++++++++++------------------
 block/qcow2-snapshot.c |  8 ++++----
 block/qcow2.c          | 26 +++++++++++++-------------
 block/qcow2.h          | 19 +++++--------------
 qapi/block-core.json   | 10 ++++++++++
 7 files changed, 72 insertions(+), 71 deletions(-)

-- 
2.38.1

Re: [PATCH 0/2] block/qcow2: QAPI'fy Qcow2DiscardType

Posted by Richard Henderson 1 year, 2 months ago

On 2/24/23 05:20, Philippe Mathieu-Daudé wrote:
> QAPI seems designed to maintain such enums,
> so convert Qcow2DiscardType to be QAPI generated.
> Besides, this is how Qcow2CompressionType is maintained.
> 
> Philippe Mathieu-Daudé (2):
>    block/qcow2: Rename QCOW2_DISCARD_TYPE enum definitions
>    block/qcow2: QAPI'fy Qcow2DiscardType

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~