[v3] linux-user: Fix unaligned memory access in prlimit64 syscall

[PATCH v3 0/2] linux-user: Fix unaligned memory access in prlimit64 syscall

Ilya Leoshkevich posted 2 patches 1 year, 2 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230224003907.263914-1-iii@linux.ibm.com

Maintainers: Laurent Vivier <laurent@vivier.eu>, "Alex Bennée" <alex.bennee@linaro.org>

linux-user/generic/target_resource.h        |  4 +-
linux-user/syscall.c                        |  8 ++--
tests/tcg/multiarch/linux/linux-fork-trap.c | 51 +++++++++++++++++++++
3 files changed, 57 insertions(+), 6 deletions(-)
create mode 100644 tests/tcg/multiarch/linux/linux-fork-trap.c

Expand all Fold all

[PATCH v3 0/2] linux-user: Fix unaligned memory access in prlimit64 syscall

Posted by Ilya Leoshkevich 1 year, 2 months ago

v2: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg07017.html
v2 -> v3: Fix __put_user() argument order mixup.
          I tested v2 only against sh4, where the original problem was
          discovered, but it regresses aarch64.

v1: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg06999.html
v1 -> v2: Fix by using proper target_rlimit64 alignment (Richard).
          Use __get_user() and __put_user() (Philippe - if I understood
          the suggestion correctly).

Hi,

Richard reported [1] that the new linux-fork-trap test was failing
under UBSan [2], so it was excluded from the PR.

This is a resend of the test plus the fix for the additional issue that
it uncovered.

[1] https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg06130.html
[2] https://gitlab.com/qemu-project/qemu/-/jobs/3807471447#L5064

Best regards,
Ilya

Ilya Leoshkevich (2):
  linux-user: Fix unaligned memory access in prlimit64 syscall
  tests/tcg/linux-test: Add linux-fork-trap test

 linux-user/generic/target_resource.h        |  4 +-
 linux-user/syscall.c                        |  8 ++--
 tests/tcg/multiarch/linux/linux-fork-trap.c | 51 +++++++++++++++++++++
 3 files changed, 57 insertions(+), 6 deletions(-)
 create mode 100644 tests/tcg/multiarch/linux/linux-fork-trap.c

-- 
2.39.1