From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194322; cv=none; d=zohomail.com; s=zohoarc; b=Wf6nj2PXJDsz4k69lxM/oeQg/e+Gz+j/28+yDyRRn7GqiBI1rQhAuRBwqDwVRW0Hd3znqBU0Igvd48D1g6o5cbUyT0JOc68clSY0nysTUcWa/0DETziihpy0Z8qhxc6T7qrUdwUrD5T2FiZ9zBXsO1Y13+OOEHn0W73GTOToc9M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194322; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wWu2Li0HdtRyVbKb/qvrvVuTsZ+F9Z5D4ZsK6YGQoVI=; b=AlOJJpskRn7m4ZFBwok/ha8PlRwHOjEvhWetbqQuxT0aIeThRHo7wnTpfBd8j+m9pL/H2IFtlxhF21VJr/A6t6fN8ngZWRYk+C+hbrowhu/0gOMGVzK6Dk7Wvhoqy00QGgGoNJNCYh5lHVVaUgcpesDVD8cy3/7EVBCfRDrlvmo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194322372759.0005116261185; Thu, 23 Feb 2023 15:18:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKqm-0008VJ-SO; Thu, 23 Feb 2023 18:18:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKqk-0008V9-EP for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:06 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKqi-0000Ry-TV for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:06 -0500 Received: by mail-wm1-x32a.google.com with SMTP id az36so671649wmb.1 for ; Thu, 23 Feb 2023 15:18:04 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id u16-20020a05600c441000b003eafc47eb09sm571786wmn.43.2023.02.23.15.18.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wWu2Li0HdtRyVbKb/qvrvVuTsZ+F9Z5D4ZsK6YGQoVI=; b=lj9M2Mafl9UAuQ3IL09b432c7nvJHA2y5nfxlSA1rbHRGirABBZ0l7XMN6OKxjZ6bs HZKk+DnUDoVp6z2q6TM/0inCFB5awJAtiVLkaO60R58+o29kVYDrxPW4fFMJKFQ9am6w 69hXBDMLhQKj3zG6SYCOhCXchNcdLAUzFMGsXc1JZEB0ddBatQUJ+C6ocCQWh73Ad1BF QfwXLVUx2tA4ZDvwxbhqjW4D7uAugp+uZUy8SfKSf2MDzkhQVUKxAaWxfFa+Gtt0C2hc 6pQ9I8acWpW7E5hHQ6fVW9gEqcXKRgjP88geZeAmM1AdZsyuWM281xMQeK1cCoaSdVEu ox1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wWu2Li0HdtRyVbKb/qvrvVuTsZ+F9Z5D4ZsK6YGQoVI=; b=C1v/L2OrqbJnyTVAOqlC61Yuln6cGe6oOidKeWY0wE1zModNud+WMdV5xhaEH4ZHoV zvsaLHQ0Avx061ig8Ce4qU1IU15G4iI8GrsStGeRAl3vd9SRQhgUqWNkTkdiuCKZwRB4 Ff2KyyO62f18y860nxuLimPJljrTNePZp1d/m+Ruc1mOfzTlI2AzbEPERXYrNysSr//a XrzClewJV3W4YCZOz+JSEFs3IUcudbjzvG2JXq/G/g8368WBVoyt/3zFb8IfseW9acvz 2zvM0Qn6aU79rcxMcDjIUHUNo9yIhdXZDQ216T5dXyhanspU9xId+pPyP76VhEvu2B+d 49bw== X-Gm-Message-State: AO0yUKWaXq74pHSbqv4bqAGMkJrLRKNkM+8vl2T/tF3zq5tYiLU3WIyx TztWpo7bKZvhPcox+QRjzYJ/VBEqZmc2Vzn5 X-Google-Smtp-Source: AK7set9xGP6wlkpIE/BCD0V0qLLTGQaYqfSFBZSK13N3kTCSIPsh1qtKZxFKoT3x5lf9YeloeaZ+Wg== X-Received: by 2002:a05:600c:30d3:b0:3d5:365b:773e with SMTP id h19-20020a05600c30d300b003d5365b773emr5351712wmn.39.1677194283002; Thu, 23 Feb 2023 15:18:03 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v4 1/7] dump: Replace tswapN() -> cpu_to_dumpN() Date: Fri, 24 Feb 2023 00:17:49 +0100 Message-Id: <20230223231755.81633-2-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194322735100002 All uses of tswap in that file are wrong, and should be using cpu_to_dumpN, which correctly tests the endianness of the output. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index 279b07f09b..7101169ecb 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -907,13 +907,13 @@ static void get_note_sizes(DumpState *s, const void *= note, if (dump_is_64bit(s)) { const Elf64_Nhdr *hdr =3D note; note_head_sz =3D sizeof(Elf64_Nhdr); - name_sz =3D tswap64(hdr->n_namesz); - desc_sz =3D tswap64(hdr->n_descsz); + name_sz =3D cpu_to_dump64(s, hdr->n_namesz); + desc_sz =3D cpu_to_dump64(s, hdr->n_descsz); } else { const Elf32_Nhdr *hdr =3D note; note_head_sz =3D sizeof(Elf32_Nhdr); - name_sz =3D tswap32(hdr->n_namesz); - desc_sz =3D tswap32(hdr->n_descsz); + name_sz =3D cpu_to_dump32(s, hdr->n_namesz); + desc_sz =3D cpu_to_dump32(s, hdr->n_descsz); } =20 if (note_head_size) { --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194333; cv=none; d=zohomail.com; s=zohoarc; b=GeIoeMMyhClo7ZpwSafdiZPiWFSCPISXPWoiw/2n4N4p4/jvVBnAZ88BcGEpIMVKA1DU03BSZFd9GsOn/ASUsyjDNDuWGvqnlmFbkpnCUplZT3ACPkyZk/aeTgBtFQ/PfkBAMzEMjQ+HmPWgcVjh/6ol7zMlJPqfdpCFsjaFzv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194333; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A3Lx/mtOBWkhA4XGJqZifqoY0L2i4FrcNzgDZGb4hiw=; b=bIOxiWwGX2AKD87RD67o9pywRiKdnmoHAHRS2hS3Vqm0du9o0ddr+mUa8z+evy9ICtCxZVNfGSAVcN19W5GNlhpAbpx2DbYYGqPLUjUOysApks2rdYGWDJCQsvUxQf5B3VO4rGfDv0tEm+UJ3XGVljoWqPgJqz7rNnFJgt/ST4A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167719433328179.16106454785347; Thu, 23 Feb 2023 15:18:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKqr-0008Vy-TJ; Thu, 23 Feb 2023 18:18:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKqp-0008Vj-IA for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:11 -0500 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKqn-0000T0-Vy for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:11 -0500 Received: by mail-wm1-x32f.google.com with SMTP id fm20-20020a05600c0c1400b003ead37e6588so857493wmb.5 for ; Thu, 23 Feb 2023 15:18:09 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id v22-20020a1cf716000000b003e1fee8baacsm758351wmh.25.2023.02.23.15.18.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A3Lx/mtOBWkhA4XGJqZifqoY0L2i4FrcNzgDZGb4hiw=; b=kMTb0RUtsQU4GqDDSpGtidlgHuVx8RX/IY30nkhnHgrJ0lJjVBEhlJyXuAvGZU134K rtnhiHo4jIJqTlE3HL/6as8Uaq4kEhA6B6bNNLPN8I/vqIIC9sBvfL9Md/2lRZdZN8qI JqiD/pLhp1UTHP7elxg5o+JQ/Jqg1w07WFH1AA+uXcu4BqHR1c2VIjqLRGOJBZAOMaYC vBzZDvRFD6mY4ztsxGpMh4LbN22LZ3GFkV1U6fim2KlWa19l6HNsPyHb5g5jyf9D/zYf rLaU+S8tJtapqCYFQaaI7xaIs50JTrsyHP0mpLjQKZbOGMNqSFCuBufSeh5yIVzICpGx Q5Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A3Lx/mtOBWkhA4XGJqZifqoY0L2i4FrcNzgDZGb4hiw=; b=qbUeBaC1OND49vyhXKlWAdTOiuAN/yu0kPLzwrCMPGKF5+aMJrzWWwBlnbtFmnR6nq 3d/iC9ab9DYAMlDabkN3zGhEkrHTghOzzSskaNdtZN0Kgbr+P1CkNTK/TeVaIkNqHHfx XwxqRfn/EqSPLlNuNoFztQ+WTgjHHJqx66YXKwp+cvD73noUOrtf3CymfNTwGNT2obCp m3cI1auKIykxauVqi9ePyYOc9dnZsHnBu7G0aWODtUYPPu61V3oJPZck2UHt5z9rkIkA bYLnUuX0JPtaQO0AeO5s/DWL1O4AuX53sUF5eSLd+J8bbASQkPKlHD2sGRHzLMcuFY92 U8hw== X-Gm-Message-State: AO0yUKWEaS1U7+n17wJrpDJgtKjR7J4p9ylxFp7myd15Bld3+Tccq1qV 7YJuzQwYhoK8E6ASa1TH6sYuMpO7apA/ufVf X-Google-Smtp-Source: AK7set95dWP/ESeVzWvSUIhTXhBFq0DurpKCiN/y8Sdz2xMEAa2YBcj7FTLs2o17UX3JJs0MqriJuA== X-Received: by 2002:a05:600c:810:b0:3db:2e06:4091 with SMTP id k16-20020a05600c081000b003db2e064091mr10609938wmp.37.1677194288110; Thu, 23 Feb 2023 15:18:08 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Date: Fri, 24 Feb 2023 00:17:50 +0100 Message-Id: <20230223231755.81633-3-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194334797100003 TARGET_PAGE_SIZE is target specific. In preparation of making dump.c target-agnostic, replace the compile-time TARGET_PAGE_SIZE definition by runtime qemu_target_page_size(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dump/dump.c b/dump/dump.c index 7101169ecb..3784a9054d 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -15,6 +15,7 @@ #include "qemu/cutils.h" #include "elf.h" #include "exec/hwaddr.h" +#include "exec/target_page.h" #include "monitor/monitor.h" #include "sysemu/kvm.h" #include "sysemu/dump.h" @@ -1859,7 +1860,7 @@ static void dump_init(DumpState *s, int fd, bool has_= format, } =20 if (!s->dump_info.page_size) { - s->dump_info.page_size =3D TARGET_PAGE_SIZE; + s->dump_info.page_size =3D qemu_target_page_size(); } =20 s->note_size =3D cpu_get_note_size(s->dump_info.d_class, --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194362; cv=none; d=zohomail.com; s=zohoarc; b=cT5DonXlc59sC9vVMOMKWUX6o2+sFinHk/Iizfvm6pFFkIU8FkozGkG3RNpe/nJWJsDr2tmowhE2PosTL+iL5qNWFpywJut+3YAMuxGK+N98KYMeuOu7Obij9vXYdiNwZmw10Y3qQaJeRjmqvaUeb8DHL+K7c9egt3QJj4vWcOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194362; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YodLQ6Jy9StluVoxn7rMSmPHABPnJhceDgMNZVIgnqg=; b=egk0Ae7MFqUCXWVdsjr52sev5TgN8IW6Q125QB3qxSMWovYxG6Htos5Z+LOCCNAOOS6kHcJOEi61RxXyZDcXrH5jYIJPSjTBptF8Nb5aQF0NsJJqmi4VWwsiilcU7AM+W9NGrfLpoNIWgnrL87v1lz3Wd1g+hxcDpP572V3AWUw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194362140302.926537107973; Thu, 23 Feb 2023 15:19:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKqz-00005S-4R; Thu, 23 Feb 2023 18:18:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKqv-00004z-1r for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:18 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKqt-0000Tz-II for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:16 -0500 Received: by mail-wr1-x436.google.com with SMTP id j2so12062892wrh.9 for ; Thu, 23 Feb 2023 15:18:15 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id iw8-20020a05600c54c800b003e70a7c1b73sm743589wmb.16.2023.02.23.15.18.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YodLQ6Jy9StluVoxn7rMSmPHABPnJhceDgMNZVIgnqg=; b=dD0eu13AiHPkBpWeOpOuxOHSQFyf8qaDNZL4ohACPWUqiwZG0FEXl7gHJ7/mUjMuIU gQrnhqOX+rjrG+o8Vs9NgcFpznkR8iTnWhlLfxbabQSDI3BRMJVfcPLm4uEYMZ4GUAzQ n6ANllaEoQNlcEpK+WeccGeED8TryjpqyrkQlmQpZOzgHR/ErRicnH1N4jlWGJct/w7S 9q+jJ09Pzf5F4s2odLp8U39aSWpaGWCplqpCHn+DoLS83mn8LyadlulU3dGMDv92B1yo EFKTYRFRzoVwnwbMob2DpqZJh4nSqglPQzu5RKjKCXZ60nm+NDNZenQtXbo13mWPoU8W Rt0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YodLQ6Jy9StluVoxn7rMSmPHABPnJhceDgMNZVIgnqg=; b=QL+5DNUQGQVDNJdNkln8n6VtzN2xtP07zDxMJJ8FUKfE3o6M/zEmQQ1+64KtfgxrH6 1/mXxqCJBj7zmMLNYmKdevFFTcU2Kv9I90ia1Fq4umUS3ol+oX7vi/VFn4lDoSu3NtBm nswaTAvKAX1xcLpIrO+Hz1d/fsc9oiopTRBdEB6HW9F3n1SSmg/9cGdNapyOSSBba1Nu Q6TBIAg4I25M5vklI5TvZli2A6Sz2xgYYoKs3JDpc0i6KWD3Wsdd49NUROUv86RgOc+4 FYwDVq7CKrFlf3S/R4GRC5sU9RorjE3oObu38L1KrOOD9dnmIVtVnun3dXrXTrIFQhoR 0kGQ== X-Gm-Message-State: AO0yUKWlA96c05gGF/3f/T2MmX1im8uWlyrstEPsug9XJ4VNpNMzDNUT RlHHZ589eT+NOg4XrqNmEGmrUgfj9LrZa5lV X-Google-Smtp-Source: AK7set9qH57vuXYEmvJqUiztfqyeRV4ODthIE45KaAXfMf5c374shWRrB9VdJk87B2ZAqlcxx24Feg== X-Received: by 2002:a05:6000:103:b0:2c5:4ffa:ba55 with SMTP id o3-20020a056000010300b002c54ffaba55mr11930694wrx.69.1677194293830; Thu, 23 Feb 2023 15:18:13 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/7] dump: Correct headers included Date: Fri, 24 Feb 2023 00:17:51 +0100 Message-Id: <20230223231755.81633-4-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194362859100003 "qemu/win_dump_defs.h" is only required by win_dump.c, but win_dump.h requires "sysemu/dump.h" which declares the DumpState type. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/win_dump.c | 1 + dump/win_dump.h | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dump/win_dump.c b/dump/win_dump.c index f20b6051b6..12b7da5da0 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -21,6 +21,7 @@ #include "qapi/qmp/qerror.h" #include "qemu/error-report.h" #include "hw/misc/vmcoreinfo.h" +#include "qemu/win_dump_defs.h" #include "win_dump.h" =20 static size_t win_dump_ptr_size(bool x64) diff --git a/dump/win_dump.h b/dump/win_dump.h index b8c25348f4..56f63683c3 100644 --- a/dump/win_dump.h +++ b/dump/win_dump.h @@ -11,7 +11,7 @@ #ifndef WIN_DUMP_H #define WIN_DUMP_H =20 -#include "qemu/win_dump_defs.h" +#include "sysemu/dump.h" =20 void create_win_dump(DumpState *s, Error **errp); =20 --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194322; cv=none; d=zohomail.com; s=zohoarc; b=ieRacxWU1zXX5YiFnVONcy8Uq7XwyEWRJr05dQIxyEmvvgxIUQioFtN0wOEdVBESe0A0OSCIwVjtYlofUSpDhFra+0QkBkne5iSFprAb6w0u5XGAYP7yYuN9mOliVulMxaNpp7Fb3YVXzIS388VCq78UZSBrNe7nJxlHd0JiDzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194322; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3swxdcDHt7SWz/NHP9p3WXbEpqYOBVxykbO5R3hJM2k=; b=gPGWa0gZQDH5wB1OHZWXFTbntDnsh0a4zek5tRi2OrOv2FcN2/a0FAnRekqoDT8IqfLj9s+cD7OMOeikUv2T0SWNMpsfOaEoHmuACSNVdZWvmFb02kp7li+kgrH7UftkITXnwDDNsAlNWvW1iOQBO3+5G5HZzNV5I+AV+1D7Ea0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194322107913.3249534958888; Thu, 23 Feb 2023 15:18:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKr4-00006c-IO; Thu, 23 Feb 2023 18:18:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKr2-00006L-Nu for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:24 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKr0-0000Uc-1r for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:23 -0500 Received: by mail-wm1-x332.google.com with SMTP id l7-20020a05600c4f0700b003e79fa98ce1so637688wmq.2 for ; Thu, 23 Feb 2023 15:18:20 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id n33-20020a05600c502100b003e8dc7a03basm744716wmr.41.2023.02.23.15.18.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3swxdcDHt7SWz/NHP9p3WXbEpqYOBVxykbO5R3hJM2k=; b=GUhG9Cp/xmzJeun4ct0s9wOfLBSh+VPuuF80imKKQYwKfRqBaYxOATm0jNXvCcZV50 GYSjyB75lrdpys5KLTsXPMyl70vCOmXN3091zF8q63QuNwUmk6T0xvMf0HQn/PL8BPrg w6vMxlC9E6Wt+3LPAAV3nKKnHXqx+ZXAUE3PvZQ4UxxnuWAnaoAHUQJzVtuuVrOpnj+T bFXU/67CpeQTnpy3JK9bROAXZvD4l3U2C1CIATVaU6SsBkR1Nx2XRocGGtH/iPHSOf3S oBzAy/t12w1mxVdl7MkFQDnU3nbEL5rTE2axnJG0MHZ56zuoYo83BbRlyTSsO6WCF+5m 5ATw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3swxdcDHt7SWz/NHP9p3WXbEpqYOBVxykbO5R3hJM2k=; b=urYYRXJd7ycVNLpqhpQI8MzEfu4bueRh/AuIR9WoDHhq8AEciXJ9SJy/jecP5sa+5K ohXuSqDqLLYpT3Uq9z5ITpCE3WibpQEiT7TH/3Vqk3lP/0R/+bUiS5XbfAsBvAKL8DOM aEnOTmMk52EtABdBWxz+AMuBru4oDEZPFjNhCHX6rvCGHOuV1ybicruKs4p8/owfKkpN J732drFoW6izDCSlcgG/wvb8g5kiPhcpwUTxnqRwzxXfHbAT0dFACkCMUmWSAM8PdwFu 52k1RqH6pWGjqDA+MExrX8Piep72WAAfX6uG5Sw7cSWv2I55e4ESrgvdWr0Qf0shQOt5 KayQ== X-Gm-Message-State: AO0yUKXjbt1vKVuKkRmv0Q4gE49zQiiD5A8tL4oS/LGTyRPlhjPCcMEf U41cm8a0BN0bAw+Tp2/6/R9UcEnwsohHOg3h X-Google-Smtp-Source: AK7set/dQmAfiBB+27PaofkG4lJGIEFaLiagYWmh8oWkC9NBSZhVpqYIjaqbfKq5Wbyr0hHk6RQE4Q== X-Received: by 2002:a05:600c:3b85:b0:3ea:e7f7:65e2 with SMTP id n5-20020a05600c3b8500b003eae7f765e2mr1155976wms.26.1677194299096; Thu, 23 Feb 2023 15:18:19 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 4/7] dump: Introduce win_dump_available() Date: Fri, 24 Feb 2023 00:17:52 +0100 Message-Id: <20230223231755.81633-5-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194322816100007 Remove a pair of TARGET_X86_64 #ifdef'ry by introducing the win_dump_available() method. We'll soon extract it to a stub file for non-x86 targets. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 23 +++++++++++++---------- dump/win_dump.c | 5 +++++ dump/win_dump.h | 3 +++ 3 files changed, 21 insertions(+), 10 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index 3784a9054d..c356a88be1 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -30,9 +30,15 @@ #include "qemu/main-loop.h" #include "hw/misc/vmcoreinfo.h" #include "migration/blocker.h" - -#ifdef TARGET_X86_64 #include "win_dump.h" + +#ifndef TARGET_X86_64 +bool win_dump_available(Error **errp) +{ + error_setg(errp, "Windows dump is only available for x86-64"); + + return false; +} #endif =20 #include @@ -2130,12 +2136,10 @@ void qmp_dump_guest_memory(bool paging, const char = *file, } #endif =20 -#ifndef TARGET_X86_64 - if (has_format && format =3D=3D DUMP_GUEST_MEMORY_FORMAT_WIN_DMP) { - error_setg(errp, "Windows dump is only available for x86-64"); + if (has_format && format =3D=3D DUMP_GUEST_MEMORY_FORMAT_WIN_DMP + && !win_dump_available(errp)) { return; } -#endif =20 #if !defined(WIN32) if (strstart(file, "fd:", &p)) { @@ -2217,10 +2221,9 @@ DumpGuestMemoryCapability *qmp_query_dump_guest_memo= ry_capability(Error **errp) QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_KDUMP_SNAPPY); #endif =20 - /* Windows dump is available only if target is x86_64 */ -#ifdef TARGET_X86_64 - QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_WIN_DMP); -#endif + if (win_dump_available(NULL)) { + QAPI_LIST_APPEND(tail, DUMP_GUEST_MEMORY_FORMAT_WIN_DMP); + } =20 return cap; } diff --git a/dump/win_dump.c b/dump/win_dump.c index 12b7da5da0..ffeef4b738 100644 --- a/dump/win_dump.c +++ b/dump/win_dump.c @@ -24,6 +24,11 @@ #include "qemu/win_dump_defs.h" #include "win_dump.h" =20 +bool win_dump_available(Error **errp) +{ + return true; +} + static size_t win_dump_ptr_size(bool x64) { return x64 ? sizeof(uint64_t) : sizeof(uint32_t); diff --git a/dump/win_dump.h b/dump/win_dump.h index 56f63683c3..9abce289ac 100644 --- a/dump/win_dump.h +++ b/dump/win_dump.h @@ -13,6 +13,9 @@ =20 #include "sysemu/dump.h" =20 +/* Windows dump is available only if target is x86_64 */ +bool win_dump_available(Error **errp); + void create_win_dump(DumpState *s, Error **errp); =20 #endif /* WIN_DUMP_H */ --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194369; cv=none; d=zohomail.com; s=zohoarc; b=WOmy6CFQqMR3FA25IjggTpsVa+TPlKlzPTa1JTbRg/wbAnZHkVHIQoTfIYZhVss/lrrjQOqUhBJQ8XeJbjPfhAZBekCYsOf+HCyFiNh7j2ysi+Z0pODOIly1KnIKaTQK88l6u4KN1JqFPvAZk/MoxU9q4pnkUsw0ZdWtXsp1RDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194369; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/SzNes+PKphnz/4Kg6fNH0K4F/X2m+UTPTjILWJZzx8=; b=EB8uJxkx3lnMabSlaWRwienzyVuYbwkWwy8dqsN9kPI/TE3gTfH4/O5/zMvpdPJrhYZyf6xI5zeh1hpZ0JpK5raPWmc2BftTvIeENuAEDyphK8G3v5+hUKz1/HiwvYVyaG0/djObAwjooQS5dm3QQReU12C1BUmK54dRbDieFUE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194369550396.27198049986; Thu, 23 Feb 2023 15:19:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKr8-00007B-Ei; Thu, 23 Feb 2023 18:18:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKr6-00006h-1k for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:28 -0500 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKr4-0000VJ-Jk for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:27 -0500 Received: by mail-wm1-x336.google.com with SMTP id iv11-20020a05600c548b00b003dc52fed235so640341wmb.1 for ; Thu, 23 Feb 2023 15:18:26 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id az11-20020a05600c600b00b003e1202744f2sm753577wmb.31.2023.02.23.15.18.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/SzNes+PKphnz/4Kg6fNH0K4F/X2m+UTPTjILWJZzx8=; b=tUvZxM0XEzoCE0vAdl/M0nfQSMZD/Sx3q0J1YkuKkF/dIgo5e072Bq1W932SuCQijM bgzSxflSR0LPZ3KVBRwkTFrgbVslOpYIys/MwsJ8iM/iR0aOtNuBtcPhFHD/tl41f68F ExqdhGmhROzmiRkbkAu5ohWytEa7E7xVM90K1ZNsOnMNL794aamWdTtBtF8vi7Acu1px ki210O3qBec84UUHeHSzmBZNiwxjEgXNjVsBwClYr/lfQTb6Fo7bPStrQ21dy6jpp6sQ q3KSNZOn1KWpEsEuIH+H9LbGkqQS0CCybEOqCn7kfY7WPEK+BfUtj/Czwjnq6OAL/9/r J3YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/SzNes+PKphnz/4Kg6fNH0K4F/X2m+UTPTjILWJZzx8=; b=DCjUODN4os7pKw95Ne3p6lyCNKY84PgKI8RE2Dhwjc6NxW58INnLUxjuy44Nwp8/ej WjF0cCFHA4IAbyd+Ac10fahZWmbVcJWsrBRxD4Nwl9BGiWc5obzxACx3vz9ruxfIcPPG +/eabzkOI29ej6FH/9n91NHSXrEFHrwf7CH45VmuOd+K765TjLXoGfPanSoOkHWS5SPz zY+PFnW691JWnVl4bKfGAMcHgySLVVfiUK5lL7rR1FH6a+6jaVqHXQjYtOst0LE5UJ28 96uc/g5ekjjw4do5zkSjFeS9jtGccUxjfhSRIq8EmtEIyUhQ3z/4xiM6+08ZB7rsL4sF fmoA== X-Gm-Message-State: AO0yUKXdS0vHWxh0vEURO5XTgcvlxaCz/3Vx2fCylDWAxOPA+j+OPHOx VWnVyEuR7eqNCqaEOtW4W8bI0cWM/pxU4N1h X-Google-Smtp-Source: AK7set+HpwT0f92FKCVpekQzk9/yek/k4/Al4Ev36SJdMdzd5tmJLdEghB6zGogLqawPf6jO6CStKQ== X-Received: by 2002:a05:600c:3420:b0:3e2:c67:1c7f with SMTP id y32-20020a05600c342000b003e20c671c7fmr10389765wmp.10.1677194304933; Thu, 23 Feb 2023 15:18:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 5/7] dump: Introduce create_win_dump() Date: Fri, 24 Feb 2023 00:17:53 +0100 Message-Id: <20230223231755.81633-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194370912100007 Remove another TARGET_X86_64 #ifdef'ry by introducing a create_win_dump() stub. We'll extract it to a stub file for non-x86 targets in the next commit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- dump/dump.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dump/dump.c b/dump/dump.c index c356a88be1..b33a613d45 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -39,6 +39,11 @@ bool win_dump_available(Error **errp) =20 return false; } + +void create_win_dump(DumpState *s, Error **errp) +{ + win_dump_available(errp); +} #endif =20 #include @@ -2031,9 +2036,7 @@ static void dump_process(DumpState *s, Error **errp) DumpQueryResult *result =3D NULL; =20 if (s->has_format && s->format =3D=3D DUMP_GUEST_MEMORY_FORMAT_WIN_DMP= ) { -#ifdef TARGET_X86_64 create_win_dump(s, errp); -#endif } else if (s->has_format && s->format !=3D DUMP_GUEST_MEMORY_FORMAT_EL= F) { create_kdump_vmcore(s, errp); } else { --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194322; cv=none; d=zohomail.com; s=zohoarc; b=hLXhnzoEJoc6jvV6cYnTmz9+ALQozFvdb2bYMHKhzwhnOq+Lu9u1NIAS9luFWXm2e0L5bcuglGnb5GuCKcKeSavbWHNNl4Sb9dSm7DPaHgOUnmFx9B5uT68J2H/xxXasN2deEVLIWVQCLYi1WwQ2AcrbBwhcrIupVMgBVD28jso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194322; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pc+uWjRhNl81loTW604SLsJvgt5iDIM0pzxWzAFHTyw=; b=JSQERWU7AgvE8stOul0hneT6zr8FuGTLZcyrYSrtW4iXanXDkJiwhAzs7Kb2d+iZBxRC4laSNdNVPTOqKwZK7f2u3CJ/TBVmO20npwlssi0xKqGEvjxJW7oVDYGitdK3bn0TInuBbc5MP1aMYCHvSzrKwRbMlRcp8ACV9MrH/MM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194322108771.2399531855801; Thu, 23 Feb 2023 15:18:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKrD-00007s-BS; Thu, 23 Feb 2023 18:18:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKrC-00007k-2i for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:34 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKrA-0000Vt-5J for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:33 -0500 Received: by mail-wr1-x42a.google.com with SMTP id t15so12351254wrz.7 for ; Thu, 23 Feb 2023 15:18:31 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id e16-20020adfe390000000b002c54c8e70b1sm11449411wrm.9.2023.02.23.15.18.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pc+uWjRhNl81loTW604SLsJvgt5iDIM0pzxWzAFHTyw=; b=VwF7F5J/WHO8Q6TQav31X0j0wxgfd5PbHwMQGiA8AzDKhhQS0MD6q2py3+7ORPaRR8 8phHUh7mTi3k4qhnOj5Z4cUKIuhyOFBSBCRJlXETmKZsyr1mUPDur9KB6TYGMYCKwpJP DVUD4wa0dr8fwEhJWZjGvVpJzarJu4SZxWLdY77F86lwnBoKrGXcjPNAsPoFtXiaMhAK 4d66TUopJOWBa96fzCNFJik1ti4Kj8FwOFvFAxSzrkLDG6vMyiAHkQNcxwjhMkSQFBb6 RrzZ9KbQvPhatVttYA891GGbwG/A2kbPn+tHgYfuqD2aJ+d65DjL+H2ryDFYwj+1e+Ax oLbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pc+uWjRhNl81loTW604SLsJvgt5iDIM0pzxWzAFHTyw=; b=qm8Yu6yPW0yihcaI6OZHkP+F97m2SiiYpuOG+7uKXJpNhP+hH8eiAFacdu41rZ6re5 9hz41+RmaLmk4zg4Wy7gApjpsENmrpZK8wFYSaGoW1FtnzXnpEyCNuLnO5FSb5T6fWA0 DYtHx3pTo7PcALLMmuzAvbL34YwwgRUTVgKMjNv942HRQvhBONfnNTdVGs0b+zZ0L09F H4oUGHzZxY3jUdNDNqaxrfEU/ojIoXeygeMVYOgrk3fYQqdA+gW6Zgegg9r6niB+LvvR GMBFRyWbtuSftmuAkfQt4iSMHoklKPHygRBSKyeznc5Rt4xXHnNBn6W0SgnDNAPfG126 +XCg== X-Gm-Message-State: AO0yUKXNjCs2CJwNjlRXnwQcYYeua7e3r12Hk4XnZ3M/CCNaAgXk25jN YjqKlev567SYcupig/9w2kjFSecOomK046OZ X-Google-Smtp-Source: AK7set8Z/mlds5imz4sj60SQatj0wKqVqyzUqSa2tkezIBTT7+J0kw+c/XMQd/fPKImTZcespOZ/Iw== X-Received: by 2002:adf:dcc5:0:b0:2c7:ce2:6479 with SMTP id x5-20020adfdcc5000000b002c70ce26479mr6427257wrm.40.1677194310431; Thu, 23 Feb 2023 15:18:30 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 6/7] dump: Build once by adding stubs for non-x86 targets Date: Fri, 24 Feb 2023 00:17:54 +0100 Message-Id: <20230223231755.81633-7-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194322739100003 Extract non-x86 stubs to win_dump-stub.c. We can now build dump.o once for system emulation. Update meson. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- dump/dump.c | 14 -------------- dump/meson.build | 6 ++++-- dump/win_dump-stub.c | 23 +++++++++++++++++++++++ 3 files changed, 27 insertions(+), 16 deletions(-) create mode 100644 dump/win_dump-stub.c diff --git a/dump/dump.c b/dump/dump.c index b33a613d45..7cde3e326e 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -32,20 +32,6 @@ #include "migration/blocker.h" #include "win_dump.h" =20 -#ifndef TARGET_X86_64 -bool win_dump_available(Error **errp) -{ - error_setg(errp, "Windows dump is only available for x86-64"); - - return false; -} - -void create_win_dump(DumpState *s, Error **errp) -{ - win_dump_available(errp); -} -#endif - #include #ifdef CONFIG_LZO #include diff --git a/dump/meson.build b/dump/meson.build index 2eff29c3ea..6ae07e6fed 100644 --- a/dump/meson.build +++ b/dump/meson.build @@ -1,4 +1,6 @@ softmmu_ss.add(files('dump-hmp-cmds.c')) =20 -specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy,= lzo]) -specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], if_true: files(= 'win_dump.c')) +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, = lzo]) +specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], + if_true: files('win_dump.c'), + if_false: files('win_dump-stub.c')) diff --git a/dump/win_dump-stub.c b/dump/win_dump-stub.c new file mode 100644 index 0000000000..87cb699e3d --- /dev/null +++ b/dump/win_dump-stub.c @@ -0,0 +1,23 @@ +/* + * Windows crashdump stubs for non-x86 targets + * + * Copyright (c) 2023 Linaro Ltd + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "win_dump.h" + +bool win_dump_available(Error **errp) +{ + error_setg(errp, "Windows dump is only available for x86-64"); + + return false; +} + +void create_win_dump(DumpState *s, Error **errp) +{ + win_dump_available(errp); +} --=20 2.38.1 From nobody Tue May 14 22:54:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1677194366; cv=none; d=zohomail.com; s=zohoarc; b=ElEvMwB9M6kicDgT+qQDYjrnA8l5ec/BqWg+zev3xhazGxATey5TLm0eRToeTjFXOMP7uJAu/dB21isymMCnFOLvMTmaPybp1VDS0KqtpuHf5iVqxlE9rBRezWuV9qxbAS0eXEKeOi2qJZBj3P1JLJmF/p58uBQVN+ucLyrbR/E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677194366; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MU+ruNFcMxjYNRIZZwSLh+qUkPoKgiT+z5IyxNl3xk0=; b=Vd/P5jpuuKGfK5MeZZEvZu6Jxnk6j7xiC/4jr/xj1vs3BtrNoO7wdjNTbF4prATGQWdnbmIWsoG1rG285cl7qjPRBSdu0ihUcuY4P03ZlVInkOOQfXVtQqn+KvSQCYcoyBPTj6aV+oKWMTKBokcabc4jHoHoBQJgNxTKWPR0iTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677194366239649.5942410745201; Thu, 23 Feb 2023 15:19:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVKrH-00009a-OU; Thu, 23 Feb 2023 18:18:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVKrF-00008L-Su for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:37 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVKrE-0000Vt-CR for qemu-devel@nongnu.org; Thu, 23 Feb 2023 18:18:37 -0500 Received: by mail-wr1-x42a.google.com with SMTP id t15so12351386wrz.7 for ; Thu, 23 Feb 2023 15:18:36 -0800 (PST) Received: from localhost.localdomain ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id f5-20020a1c6a05000000b003dfe5190376sm715100wmc.35.2023.02.23.15.18.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 15:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MU+ruNFcMxjYNRIZZwSLh+qUkPoKgiT+z5IyxNl3xk0=; b=pkpnpdSaNx/9vRw7tB+m1weBupRcTLPhaBTE8t5BLaNAqRnJYH5YBmcTzyxMTxtbpi opyHGmasbSASO03fqOHPiCQJPTOcFYcnYld/FG3H5I8MSKZzXL7jZDqhjgls8797hyrn EPhPyjkaEgo4Tp1ICkFwK5VYfllSEybQ7H4KKq57YnpSmsZdE5Fq4SFHauAgL7DF2Z+Y ooLRWlNFk0o7yPfgHuSTogofdGXEqJfIXNSZoPsXUiZd/yanEVTzd94OjooAFQj5ULqL xOjZqHv/1jM5z63w0ELnt4WkvWZzquVzBwpnlhgBOkpUf5vsoQHbmeW+2mRDp0zqTlbk BY6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MU+ruNFcMxjYNRIZZwSLh+qUkPoKgiT+z5IyxNl3xk0=; b=k4Dh8oIkvCRHyhUS0XE4iV+J50zEHdkx94OcORM+pMHaxjnktuidtzG+4XkALjt13s 0RFpGNeWYF000gqyBsVrYAMQohubmbTdjmRT6DZ1SfLyEmKiXP2JFSaYp9HfosjbiTFJ VKqBS3VuEbeuGCcmqevvQU3S4Z/PdmD1VLCJc9RMme28/jh/XsHQfINwDf0VEca90F3Z +EgSFe/68UwqlSUcP7bSPpzsP2sehUez9hfb0XDAPbxMBkAASOZ8sJfnlYeVflLVw/kG FDnJCtOYFCWy4c/8Z4OSm/v6vy2aq5uYXd71h36QLit+78h5F8fSlerRhCIAyKY3bycM bJQg== X-Gm-Message-State: AO0yUKXuJUkGdaPMYdTELai5N34kdGUM/VPhmI+S0O2WuBiVohjjc/tm PAEsjLuFuXZzinkb4pK2Q+N1bLYKfhknNp/n X-Google-Smtp-Source: AK7set+qMAzSVqNbxdDgg96+aO0d+LuSzOLTYjKlgsVIRPNauwIr0PdT2VfcDpe0gIkfX1GOyFvlpg== X-Received: by 2002:adf:f292:0:b0:2c7:1b4b:d729 with SMTP id k18-20020adff292000000b002c71b4bd729mr553600wro.65.1677194315410; Thu, 23 Feb 2023 15:18:35 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , Janosch Frank , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 7/7] dump: Rename x86-specific file as win_dump_x86.c Date: Fri, 24 Feb 2023 00:17:55 +0100 Message-Id: <20230223231755.81633-8-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230223231755.81633-1-philmd@linaro.org> References: <20230223231755.81633-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1677194366866100001 win_dump.c is x86 specific. Rename it as such in case someone is willing to add win_dump-aarch64 :) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- dump/meson.build | 2 +- dump/{win_dump.c =3D> win_dump-x86.c} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename dump/{win_dump.c =3D> win_dump-x86.c} (99%) diff --git a/dump/meson.build b/dump/meson.build index 6ae07e6fed..d899949a73 100644 --- a/dump/meson.build +++ b/dump/meson.build @@ -2,5 +2,5 @@ softmmu_ss.add(files('dump-hmp-cmds.c')) =20 softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files('dump.c'), snappy, = lzo]) specific_ss.add(when: ['CONFIG_SOFTMMU', 'TARGET_X86_64'], - if_true: files('win_dump.c'), + if_true: files('win_dump-x86.c'), if_false: files('win_dump-stub.c')) diff --git a/dump/win_dump.c b/dump/win_dump-x86.c similarity index 99% rename from dump/win_dump.c rename to dump/win_dump-x86.c index ffeef4b738..5ee9a1d764 100644 --- a/dump/win_dump.c +++ b/dump/win_dump-x86.c @@ -1,5 +1,5 @@ /* - * Windows crashdump + * Windows crashdump for x86 targets * * Copyright (c) 2018 Virtuozzo International GmbH * --=20 2.38.1