[v4] target: Restrict 'qapi-commands-machine.h' to system emulation

[PATCH v4 0/4] target: Restrict 'qapi-commands-machine.h' to system emulation

Philippe Mathieu-Daudé posted 4 patches 1 year, 2 months ago

Diff against v1 v2 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230223155540.30370-1-philmd@linaro.org

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Song Gao <gaosong@loongson.cn>, Xiaojuan Yang <yangxiaojuan@loongson.cn>, Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>

target/arm/{monitor.c => arm-qmp-cmds.c} | 28 +++++++++
target/arm/helper.c                      | 29 ----------
target/arm/meson.build                   |  2 +-
target/i386/cpu.c                        | 74 +++++++++++++-----------
target/loongarch/cpu.c                   | 27 ---------
target/loongarch/loongarch-qmp-cmds.c    | 37 ++++++++++++
target/loongarch/meson.build             |  1 +
target/ppc/cpu-qom.h                     |  2 +
target/ppc/cpu_init.c                    | 48 +--------------
target/ppc/meson.build                   |  2 +-
target/ppc/{monitor.c => ppc-qmp-cmds.c} | 50 +++++++++++++++-
11 files changed, 159 insertions(+), 141 deletions(-)
rename target/arm/{monitor.c => arm-qmp-cmds.c} (90%)
create mode 100644 target/loongarch/loongarch-qmp-cmds.c
rename target/ppc/{monitor.c => ppc-qmp-cmds.c} (78%)

Expand all Fold all

[PATCH v4 0/4] target: Restrict 'qapi-commands-machine.h' to system emulation

Posted by Philippe Mathieu-Daudé 1 year, 2 months ago

All series reviewed, can patches be picked by corresponding
maintainers, or should I include them in on of my PRs?

The "qapi-commands-machine.h" header is not generated in user-only
emulation. This series removes its use in user-emu code by moving
the QMP code depending on this header into a separate sysemu unit.

Since v3:
- Addressed Markus' review comments

Since v2:
- Rebased
- Renamed target/$foo/monitor.c -> target/$foo/$foo-qmp-cmds.c (Markus)

Since v1:
- renamed cpu-monitor.c -> monitor.c on loongarch

Philippe Mathieu-Daudé (4):
  target/arm: Restrict 'qapi-commands-machine.h' to system emulation
  target/i386: Restrict 'qapi-commands-machine.h' to system emulation
  target/loongarch: Restrict 'qapi-commands-machine.h' to system
    emulation
  target/ppc: Restrict 'qapi-commands-machine.h' to system emulation

 target/arm/{monitor.c => arm-qmp-cmds.c} | 28 +++++++++
 target/arm/helper.c                      | 29 ----------
 target/arm/meson.build                   |  2 +-
 target/i386/cpu.c                        | 74 +++++++++++++-----------
 target/loongarch/cpu.c                   | 27 ---------
 target/loongarch/loongarch-qmp-cmds.c    | 37 ++++++++++++
 target/loongarch/meson.build             |  1 +
 target/ppc/cpu-qom.h                     |  2 +
 target/ppc/cpu_init.c                    | 48 +--------------
 target/ppc/meson.build                   |  2 +-
 target/ppc/{monitor.c => ppc-qmp-cmds.c} | 50 +++++++++++++++-
 11 files changed, 159 insertions(+), 141 deletions(-)
 rename target/arm/{monitor.c => arm-qmp-cmds.c} (90%)
 create mode 100644 target/loongarch/loongarch-qmp-cmds.c
 rename target/ppc/{monitor.c => ppc-qmp-cmds.c} (78%)

-- 
2.38.1

Re: [PATCH v4 0/4] target: Restrict 'qapi-commands-machine.h' to system emulation

Posted by Markus Armbruster 1 year, 2 months ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> All series reviewed, can patches be picked by corresponding
> maintainers, or should I include them in on of my PRs?
>
> The "qapi-commands-machine.h" header is not generated in user-only
> emulation. This series removes its use in user-emu code by moving
> the QMP code depending on this header into a separate sysemu unit.

Queued.  Thanks!