From nobody Tue May 14 09:04:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1676993456; cv=none; d=zohomail.com; s=zohoarc; b=m/PHXnJSrj+4e9YZwL4oOgRMN6RFYTgU4moRruyAWFKZb9WtiR5TYrPKHb75f8H8fGih5GNxSwa4aZAKTbGMm4f5Fa5tnKH2JW8sUBW4oyIpxlW6VTqd8we4JPpvQBQHw12fPZEzXvkDOFNxEMQnzvR/cs/E6I1Tyjuo6BTsxKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676993456; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JGLiZUBdLguQ8v1zIoAL8gWJ2AVvRrGKswtrTjBu1+w=; b=W7dmLHgpv5ctG8iGjJgoLK6iGgPKXPOQotLWDcBGkz3QR9RL/HlPtRuobtepB4WvVC/eCeBy2zhjcabIQDAui0HcX/WllGVR8mwYvQLq50Pe7KJIr4SSQtg+2rO9h6s5uJ07DMYpbKmogWhrx/g832Q+pHk9jGOyxD2BKU4JILg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676993456742268.48841605116365; Tue, 21 Feb 2023 07:30:56 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUUbS-0002hE-3a; Tue, 21 Feb 2023 10:30:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUUb4-0002GC-Td for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:26 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUUb2-0000Va-Mt for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:26 -0500 Received: by mail-wr1-x435.google.com with SMTP id 6so4463100wrb.11 for ; Tue, 21 Feb 2023 07:30:24 -0800 (PST) Received: from volterra.localdomain ([2a01:e0a:5cc:caa0:c49d:d14a:e6ed:555a]) by smtp.gmail.com with ESMTPSA id r1-20020adfdc81000000b002c5503a8d21sm2803417wrj.70.2023.02.21.07.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JGLiZUBdLguQ8v1zIoAL8gWJ2AVvRrGKswtrTjBu1+w=; b=QjVk0rCAum3q/9kpJVw30TOeUo6FvzLqy1Rg2zI5T3femKiwABrXqrQXDaOv4cZnne P9NUEnI4wOv9kuu5X8CEzjh8t5fkCYzpWvH2KVIxomrZb53jQj/T8rHgHvNvfSzV49RQ T0VnPU7wRf7b/f/kbC1mVBlf1EHfG+iJTe6rpISFovMJ2KyswDrVn5VCEljIOslI1mX6 F7sGr68u3UPmtovE8Ms8p+K5fXe6WRJ/cm+o1zkJ40A9CJACuI1H+pjOk1xCqokle4qo xkb1EkR1fWLm3EyQVYEBM4JmviIObjtagJF7o4GYTGukDqFZXwza55DyBO9KQZGrbCZb E6xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGLiZUBdLguQ8v1zIoAL8gWJ2AVvRrGKswtrTjBu1+w=; b=a29k/t6yXwBSP05G/nRBSFJbnC2M+L657qDcfM1/eJyZjM5OdXkwnZveYBvURU5E88 +WEVqyp28j+FrLRrZZBH39jIO9GTUC9wQlkLU23j9tpOfFY1UqMxEnYpU1WubQJc34fH 078ST7R1i34QMp3ip6J3nRhE3yFqOvVxLHLxaKWWeG7+LVajqjk6hSR+ubqSq7xyE9o2 3yox4UvFELdXPFVbBbNejP9/ZV0AgvPjdy9kKLgnAcsOfcxXUMRLVvy+NlCVZZ6/vHYz wi2eLh/KQtiPapd7QUX0sMayYGHtwdZ72i0dAO2Q1U900yb5M1WGDU+rGbRWvGoX823U ciTQ== X-Gm-Message-State: AO0yUKXtftLlfixE4EsXPybr/avDsSNWlNNVdtKmsmKWX5P312n6MvZo kyCOCcJVQ1qkBNmplGHQrA8TCAO1HNB6J6X0EII= X-Google-Smtp-Source: AK7set+u9BG9xH2i0wuOnTjC/0fhYSQvkWJfgcrrru/lsPi9C3mGqidJJDzTxjzgAqMzE9Af6IfJ1Q== X-Received: by 2002:a5d:4e0e:0:b0:2c6:8e3a:f701 with SMTP id p14-20020a5d4e0e000000b002c68e3af701mr3632593wrt.56.1676993422981; Tue, 21 Feb 2023 07:30:22 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org, richard.henderson@linaro.org, alex.bennee@linaro.org, peter.maydell@linaro.org, philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v4 1/4] util/cacheflush: fix cache on windows-arm64 Date: Tue, 21 Feb 2023 16:30:03 +0100 Message-Id: <20230221153006.20300-2-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221153006.20300-1-pierrick.bouvier@linaro.org> References: <20230221153006.20300-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=pierrick.bouvier@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1676993459625100003 Content-Type: text/plain; charset="utf-8" ctr_el0 access is privileged on this platform and fails as an illegal instruction. Windows does not offer a way to flush data cache from userspace, and only FlushInstructionCache is available in Windows API. The generic implementation of flush_idcache_range uses, __builtin___clear_cache, which already use the FlushInstructionCache function. So we rely on that. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson --- util/cacheflush.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/util/cacheflush.c b/util/cacheflush.c index 2c2c73e085..06c2333a60 100644 --- a/util/cacheflush.c +++ b/util/cacheflush.c @@ -121,8 +121,12 @@ static void sys_cache_info(int *isize, int *dsize) static bool have_coherent_icache; #endif =20 -#if defined(__aarch64__) && !defined(CONFIG_DARWIN) -/* Apple does not expose CTR_EL0, so we must use system interfaces. */ +#if defined(__aarch64__) && !defined(CONFIG_DARWIN) && !defined(CONFIG_WIN= 32) +/* + * Apple does not expose CTR_EL0, so we must use system interfaces. + * Windows neither, but we use a generic implementation of flush_idcache_r= ange + * in this case. + */ static uint64_t save_ctr_el0; static void arch_cache_info(int *isize, int *dsize) { @@ -225,7 +229,11 @@ static void __attribute__((constructor)) init_cache_in= fo(void) =20 /* Caches are coherent and do not require flushing; symbol inline. */ =20 -#elif defined(__aarch64__) +#elif defined(__aarch64__) && !defined(CONFIG_WIN32) +/* + * For Windows, we use generic implementation of flush_idcache_range, that + * performs a call to FlushInstructionCache, through __builtin___clear_cac= he. + */ =20 #ifdef CONFIG_DARWIN /* Apple does not expose CTR_EL0, so we must use system interfaces. */ --=20 2.30.2 From nobody Tue May 14 09:04:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1676993476; cv=none; d=zohomail.com; s=zohoarc; b=kaIvJ87uwLV+04y6Gd7KwBlmP3W2YjeevFWPtRo0wStxh6XJs8+N3jd92k3J24X8D8IqoIlpPu2+Ony5/SH1eHsprno4tUC/vrKLwuhl+tSmo7US/AOYJn0fZDPqWV4cPIlauyrW5TpJttILY32LRDFXpcKxCERzNjrlK/8wKsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676993476; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uZPnixULi6oi31J0KFtxJqQtIdv2DOflsZD/AW7cSSI=; b=Sx9/T/akI6nv40lShNsDZb6TQ+j4MGN89qVZ8vX6V2njc4mM9vtsu05cWMwsPuBxlvRbP0sIQVkP3Wd2k8xuaDK/s0ezXe5wEo7n8CsdSJze5JhM/3oQudLWq/nOtWLVsf4ok2HcCx/CF9LeKgtP97cdFtbrtBQapAMFtiKN0d4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676993476697639.7025180040271; Tue, 21 Feb 2023 07:31:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUUbU-0002qh-B7; Tue, 21 Feb 2023 10:30:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUUb6-0002Hk-Ic for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:37 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUUb4-0000Vi-ND for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:28 -0500 Received: by mail-wr1-x431.google.com with SMTP id l25so4465338wrb.3 for ; Tue, 21 Feb 2023 07:30:26 -0800 (PST) Received: from volterra.localdomain ([2a01:e0a:5cc:caa0:c49d:d14a:e6ed:555a]) by smtp.gmail.com with ESMTPSA id r1-20020adfdc81000000b002c5503a8d21sm2803417wrj.70.2023.02.21.07.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uZPnixULi6oi31J0KFtxJqQtIdv2DOflsZD/AW7cSSI=; b=BxQqYzIBpxFR3ZXJGVnQQk4r13ifC2dVus/Q3MNOxr0reLbWBR68Oy/obt4HWOWQ3m rsBWuiYgK7eVyH3Vmkvb+eC0V7YiqQBqsi+UsP5MSfSTsOEhtzu9RbjXFxgE6HPOa9S6 BwpBSN3NgUADsJBTc3CePNlIY9ApVIu+SD/LFXONecaIvgNHSsMlneENRwfd1Nh8gCuT WGlsoZP9xH3xEKAJd1Q9Kx/Lv2wHxfPJhKRfJCwHsxIYxQQkPL0Qzzc200UIfMdNqz2z 9/UDTXNJRM+mesA0AKp81BQsW/bYnQp9UFSJOrbFU9Ykg7Jt56Gey6TQcMvgJT6xCcZc dwxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uZPnixULi6oi31J0KFtxJqQtIdv2DOflsZD/AW7cSSI=; b=28BkHpnD3iQfozlCmokSETImn5+m2OMaXWOMxlKmCpkuNtNduHRYJ4iJDI2D78Ji9f 86XtbU3snEqPc8bGXqNnuXGRabof6eYM/Z79lF63r0HXN6/zSS0AJ9Ay33I1L/4fEEdU 3sT5SHGDKsyvNVA7+xNQ90bOsg/Z0ZsuGIru94O/STkejb33tUw5LA+YEuWwImpHQFH3 BfnC7R5cZxSTDnZdh0GVM1w8F/kFwSG6xW/ospyPK4iFSBDF12EUautNyj3WLlz0y0S+ lS5YiXWyIwvweYlLs+vqq8nMAucjQF0o9a/2XF2OuvigKU8TcLxrK1B+Q/olztFqHUcl D5Rw== X-Gm-Message-State: AO0yUKUd5GGtgNEW49ZbxDUc0F1uR5juUDHJDrjk5+GvncR6Zi/cWysY MnQbc7K/WDAGDFAyMXqfNxTBPVL40b2gcZCMraY= X-Google-Smtp-Source: AK7set9rqdB0MnV22Q2Bue0sxXYXGs7LHS94B0dzCC/TddUkfaEBtp2nbFGLxhoOZJDKycQ/HQbKgA== X-Received: by 2002:adf:ce11:0:b0:2c5:4d17:f688 with SMTP id p17-20020adfce11000000b002c54d17f688mr5560650wrn.15.1676993423962; Tue, 21 Feb 2023 07:30:23 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org, richard.henderson@linaro.org, alex.bennee@linaro.org, peter.maydell@linaro.org, philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v4 2/4] sysemu/os-win32: fix setjmp/longjmp on windows-arm64 Date: Tue, 21 Feb 2023 16:30:04 +0100 Message-Id: <20230221153006.20300-3-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221153006.20300-1-pierrick.bouvier@linaro.org> References: <20230221153006.20300-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=pierrick.bouvier@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1676993477595100001 Content-Type: text/plain; charset="utf-8" Windows implementation of setjmp/longjmp is done in C:/WINDOWS/system32/ucrtbase.dll. Alas, on arm64, it seems to *always* perform stack unwinding, which crashes from generated code. By using alternative implementation built in mingw, we avoid doing stack unwinding and this fixes crash when calling longjmp. Signed-off-by: Pierrick Bouvier Acked-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/sysemu/os-win32.h | 28 ++++++++++++++++++++++++---- meson.build | 21 +++++++++++++++++++++ 2 files changed, 45 insertions(+), 4 deletions(-) diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h index 5b38c7bd04..97d0243aee 100644 --- a/include/sysemu/os-win32.h +++ b/include/sysemu/os-win32.h @@ -51,14 +51,34 @@ typedef struct sockaddr_un { extern "C" { #endif =20 -#if defined(_WIN64) -/* On w64, setjmp is implemented by _setjmp which needs a second parameter. +#if defined(__aarch64__) +/* + * On windows-arm64, setjmp is available in only one variant, and longjmp = always + * does stack unwinding. This crash with generated code. + * Thus, we use another implementation of setjmp (not windows one), coming= from + * mingw, which never performs stack unwinding. + */ +#undef setjmp +#undef longjmp +/* + * These functions are not declared in setjmp.h because __aarch64__ defines + * setjmp to _setjmpex instead. However, they are still defined in libming= wex.a, + * which gets linked automatically. + */ +extern int __mingw_setjmp(jmp_buf); +extern void __attribute__((noreturn)) __mingw_longjmp(jmp_buf, int); +#define setjmp(env) __mingw_setjmp(env) +#define longjmp(env, val) __mingw_longjmp(env, val) +#elif defined(_WIN64) +/* + * On windows-x64, setjmp is implemented by _setjmp which needs a second p= arameter. * If this parameter is NULL, longjump does no stack unwinding. * That is what we need for QEMU. Passing the value of register rsp (defau= lt) - * lets longjmp try a stack unwinding which will crash with generated code= . */ + * lets longjmp try a stack unwinding which will crash with generated code. + */ # undef setjmp # define setjmp(env) _setjmp(env, NULL) -#endif +#endif /* __aarch64__ */ /* QEMU uses sigsetjmp()/siglongjmp() as the portable way to specify * "longjmp and don't touch the signal masks". Since we know that the * savemask parameter will always be zero we can safely define these diff --git a/meson.build b/meson.build index a76c855312..b676c831b3 100644 --- a/meson.build +++ b/meson.build @@ -2470,6 +2470,27 @@ if targetos =3D=3D 'windows' }''', name: '_lock_file and _unlock_file')) endif =20 +if targetos =3D=3D 'windows' + mingw_has_setjmp_longjmp =3D cc.links(''' + #include + int main(void) { + /* + * These functions are not available in setjmp header, but may be + * available at link time, from libmingwex.a. + */ + extern int __mingw_setjmp(jmp_buf); + extern void __attribute__((noreturn)) __mingw_longjmp(jmp_buf, int); + jmp_buf env; + __mingw_setjmp(env); + __mingw_longjmp(env, 0); + } + ''', name: 'mingw setjmp and longjmp') + + if cpu =3D=3D 'aarch64' and not mingw_has_setjmp_longjmp + error('mingw must provide setjmp/longjmp for windows-arm64') + endif +endif + ######################## # Target configuration # ######################## --=20 2.30.2 From nobody Tue May 14 09:04:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1676993472; cv=none; d=zohomail.com; s=zohoarc; b=G8SXs6YO/NioKzwqacsrIFGwKOi4WiQTS/G55gBaFvZxYCvzHE3bH7zPjDqlFiBEm57mo4LV/ruxFOkJqyh/mzytsKvuEHAar1pUl7J2b7vLIYPeoXxCUJ2JaR0/3aVitrKNbfxaJ8Ievbkw+8/viPcN2B56U9KIt+hmMCzZo8k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676993472; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aqBt2Wco0xHaQqloNdEBhTt2U0GhCudNuL+urVRzaIs=; b=NxNANg60j87ik42Vb2BJHiLjtFS29rSXbQC2MOm6f6TdBzgOQkIYRTNQwLsKTEYSYYKRBCFK+1bLY2nBZTuypjaraY0ZBI8Z6bvBGbqb9TipeJq/RsZ5coVMhS6krdlVPeU18bNxk9ic+tqmNMJAjpg7BCU3Fs3SS3MrZxdfCUc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676993472869533.3008399624528; Tue, 21 Feb 2023 07:31:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUUbT-0002nI-38; Tue, 21 Feb 2023 10:30:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUUb6-0002Hj-9y for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:37 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUUb4-0000Vp-LX for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:28 -0500 Received: by mail-wr1-x42b.google.com with SMTP id p8so4998040wrt.12 for ; Tue, 21 Feb 2023 07:30:26 -0800 (PST) Received: from volterra.localdomain ([2a01:e0a:5cc:caa0:c49d:d14a:e6ed:555a]) by smtp.gmail.com with ESMTPSA id r1-20020adfdc81000000b002c5503a8d21sm2803417wrj.70.2023.02.21.07.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aqBt2Wco0xHaQqloNdEBhTt2U0GhCudNuL+urVRzaIs=; b=yFkw8vnO0W08mYQXdGF9v//kpmBSkvorlyt8LTQym6NDyBlZETlnf2JRQKDHIXRYl6 Nm28kxr+vL5C2Q4Zo3ggkJtoWsZeIfOz/Q12H3siw52hrmpRbZrBnA871qJSQxFWPvaX mfE6d4bkxujdhIcGTaacdy33bsldCY1nBQ//5blVzmCv6sJE09P4ZlhXbnqXoN3LTH3R j0lDFdYjRcw+fkX3i1d4HvplCgVvUcKwgQVzyfNk2n6B5ZQKWmsiDcIwKouyPW/w98kI Dfl5e2zZxG1eHGDPuSmfewTQ7urlwL9vK9bwBUS5/y4YeiZMZ2C2Okbi2kUo/s6d62TE kMhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aqBt2Wco0xHaQqloNdEBhTt2U0GhCudNuL+urVRzaIs=; b=E7QPHRqX8Y49wnAtFXm8ijP0aTSMVwE+XaZWZVfBGGLGxekXJCRaOmPhO1jp299Gyz L6+CjAnbygf+T4f2rJEJ+5YSWhZywutMsFwiLjXcrPdHqKIZWXxwg4dAJy8vSdxnyeCE lwlmtvdbCAFafGTBmnjN4MiAApvRYQfViIjzK/3+baZ979/QgwoHK0LRd5p/aq3UrCkv pDNFSmWnfxceThX9IE1Ov0rmmbejBWfQUT+YYUY8+bke1ySp1PhXiXMqcrBPwxd3bbeD tsrt+ax6SmbyvccWuO/X9xMg0tuc1J9IbE0OCz3ABPhwwurPr1yFjTLAouDx5ic/h/Z9 Othg== X-Gm-Message-State: AO0yUKWf5uto/d5N/vU1nOHIjKrcMJRlGeN76juVJ3+aco2n/alObWH2 I+Kbswc6UAMED1/4ym0hcvoEZQ2H0kEFH7VEeLI= X-Google-Smtp-Source: AK7set9c88itMNFe57dLt5jCslblq1ZDwW3n3ckDXQNn7QTI007nLqEszeyb17XJo+RJXcRpzIPQBQ== X-Received: by 2002:a5d:49c1:0:b0:2c5:5ca4:ef14 with SMTP id t1-20020a5d49c1000000b002c55ca4ef14mr3900482wrs.9.1676993424952; Tue, 21 Feb 2023 07:30:24 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org, richard.henderson@linaro.org, alex.bennee@linaro.org, peter.maydell@linaro.org, philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v4 3/4] qga/vss-win32: fix warning for clang++-15 Date: Tue, 21 Feb 2023 16:30:05 +0100 Message-Id: <20230221153006.20300-4-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221153006.20300-1-pierrick.bouvier@linaro.org> References: <20230221153006.20300-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=pierrick.bouvier@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1676993473518100001 Reported when compiling with clang-windows-arm64. ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitiali= zed whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here return hr; ^~ Signed-off-by: Pierrick Bouvier Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure") Reviewed-by: Konstantin Kostiuk Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- qga/vss-win32/install.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index b57508fbe0..b8087e5baa 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -518,7 +518,7 @@ namespace _com_util /* Stop QGA VSS provider service using Winsvc API */ STDAPI StopService(void) { - HRESULT hr; + HRESULT hr =3D S_OK; SC_HANDLE manager =3D OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); SC_HANDLE service =3D NULL; =20 --=20 2.30.2 From nobody Tue May 14 09:04:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1676993462; cv=none; d=zohomail.com; s=zohoarc; b=a+49DODzcabh0/ClhcgkVI4qs4d0T/jfyxwnFwaP2zBJDJjlM+5imS4XwF2/X4OEi/xu65P4KndOV8P08Ioi45+fEVbP7Mk9TAhGHWJ2DDDtEgWplwfNq3WckS6v+jm28LC6SHXomRKf74c2G/3tv3N73Urijzvlm2jIgx2ZrpU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676993462; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6qn/yx6q7lkoNAawrOJ+PdaXBlkustX5jFFPd6NUzvQ=; b=i0AJFW6DKV8AlEdF2QyGV7t73Ke6mf+Sl/mjA8GjPHj/fZ9BIidne2whKr72M4rsMGdodnpyitNpvyH+/0b1L+AurB+QFTfopLlqLYHeaic7Ulc62WwwLS6bwEdNunsqhK0hEQzR74J6t+Q//Kvo1/9sAEtzrI6jCdRbgkmkAV4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676993462938132.34177491049365; Tue, 21 Feb 2023 07:31:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUUbR-0002en-CI; Tue, 21 Feb 2023 10:30:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUUb7-0002Kk-JY for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:37 -0500 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pUUb5-0000W1-O2 for qemu-devel@nongnu.org; Tue, 21 Feb 2023 10:30:29 -0500 Received: by mail-wr1-x435.google.com with SMTP id j2so4689123wrh.9 for ; Tue, 21 Feb 2023 07:30:27 -0800 (PST) Received: from volterra.localdomain ([2a01:e0a:5cc:caa0:c49d:d14a:e6ed:555a]) by smtp.gmail.com with ESMTPSA id r1-20020adfdc81000000b002c5503a8d21sm2803417wrj.70.2023.02.21.07.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Feb 2023 07:30:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6qn/yx6q7lkoNAawrOJ+PdaXBlkustX5jFFPd6NUzvQ=; b=ml40aHavkBRi/dbzj4cK6sMbIjJ7JFkzV7+TNrTJgbkpCdNYnLWnhPMNYwKz+MYnjN z7BXniOl2kWi58pbWWFOH5yfgLNP378Fl/KazgRzJG/C6al8wrmy7Jlsbcv9tSgHZZw2 oe2dwj9Wm9EbQH+pnxJJTz5qMQQ4BOoumK6tDEXd3N164bkNDJ9CDl4epqLYcRkVZVdW fwfz1k9/lx4KuuGhNkGGR9gj1lFC0x8bEeHWs0NaZNSY3u4jQ1n9ERFhmgMD7McLAjV1 K9FKF7DRZBpItrScj24f5yOavNsMJbFruGw1X/KQ4bgyBDty1XWR4A8O1hpLW7h3nj+0 hZiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qn/yx6q7lkoNAawrOJ+PdaXBlkustX5jFFPd6NUzvQ=; b=29Ajy9NSQk8PZ6gnf4Qu4gP7zqCs+802ji3o7YeUhAC7OH/1K/LcCfD5MVLq0WDodU CRDsyV8q77irMw103XjiwU/nZaMCXh3WazA/lLNP1TVDb5sYJdr8CVK7UpVwNkWpvYRx i2ArvniQDarAhcZKgrJuCGPsGLCQYYPcF5EFpPpOmd3YBXq+SCDSUO/5R9FQLxcfzjdw 7AGSOU6NwUsn1DFp/d36DIOxHMgqshd8hk/8XaMDLMRiWtjKe+a4nW/6rpDCNC+Dld3b bTplyHIauwu3sCH51U18EEUHoJQPMZAM4lrWOXH8waryAgldY13lAZxUbn7CH1UdKKhs H7ww== X-Gm-Message-State: AO0yUKUMOC68LGdObG5TQ7JZQDh9alpreI3RrA+0OMyR83b9qSZDK2GT Bb5chnzxJElqOtjv0RoTy/wnyK1xKsmHDuBEkpQ= X-Google-Smtp-Source: AK7set97zCrajucTg+TJPKe8pFWK92MiIybBZCTqpIjC0Vf5ma6gRQix/2MSL8G1okOVYY3cOPGMMA== X-Received: by 2002:adf:f748:0:b0:2c5:534d:eebb with SMTP id z8-20020adff748000000b002c5534deebbmr3036071wrp.13.1676993425859; Tue, 21 Feb 2023 07:30:25 -0800 (PST) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: sw@weilnetz.de, kkostiuk@redhat.com, clg@kaod.org, richard.henderson@linaro.org, alex.bennee@linaro.org, peter.maydell@linaro.org, philmd@linaro.org, Pierrick Bouvier Subject: [PATCH v4 4/4] target/ppc: fix warning with clang-15 Date: Tue, 21 Feb 2023 16:30:06 +0100 Message-Id: <20230221153006.20300-5-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230221153006.20300-1-pierrick.bouvier@linaro.org> References: <20230221153006.20300-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=pierrick.bouvier@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1676993463541100001 Content-Type: text/plain; charset="utf-8" When compiling for windows-arm64 using clang-15, it reports a sometimes uninitialized variable. This seems to be a false positive, as a default case guards switch expressions, preventing to return an uninitialized value, but clang seems unhappy with assert(0) definition. Change code to g_assert_not_reached() fix the warning. Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/ppc/dfp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index cc024316d5..5967ea07a9 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -121,7 +121,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r= , uint8_t rmc, case 3: /* use FPSCR rounding mode */ return; default: - assert(0); /* cannot get here */ + g_assert_not_reached(); } } else { /* r =3D=3D 1 */ switch (rmc & 3) { @@ -138,7 +138,7 @@ static void dfp_set_round_mode_from_immediate(uint8_t r= , uint8_t rmc, rnd =3D DEC_ROUND_HALF_DOWN; break; default: - assert(0); /* cannot get here */ + g_assert_not_reached(); } } decContextSetRounding(&dfp->context, rnd); --=20 2.30.2