From nobody Wed May 15 14:34:03 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676982392; cv=none; d=zohomail.com; s=zohoarc; b=dUmqrsX4VZWUaDC/eo4OMY9Zt7t+cr6lTkXPqefjZ16zsKbV1Ce8vPnTTOcbhPud/Ink1KE9DCs2P5SB5I5EeDc6534TGC6v/w82fgcwNRKMwMJ94jmuCjX8kkSkk76DLtqsqx46h5Pdm/w7cJwRGEwuqQFWMbNXRDhi0+lPXG4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676982392; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=COUpfO7V0vdDQF1zQcHqVR86UssH2a7JfJT9OjWEai0=; b=B4LVdq5emRPy23/6rMAepliuizNMWYenRFC1hUde2jh1bt/92AxdVC19QijOVfSw3L+MUa62veMeq0hD71QHGTq3jD2SsscBHbookxDWzy9g6CEg2NRoZPHYMuSyGNVefWDM8LUx+o1ezXYvuLe7kqCM2XUmcjUuLdT6hMUFxa8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676982392774100.27482530265763; Tue, 21 Feb 2023 04:26:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pURi0-0003Je-20; Tue, 21 Feb 2023 07:25:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURho-0003JG-5N for qemu-devel@nongnu.org; Tue, 21 Feb 2023 07:25:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURhZ-0002Hm-6W for qemu-devel@nongnu.org; Tue, 21 Feb 2023 07:24:58 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-9G5Io1qjM0yASsGI5jDUWQ-1; Tue, 21 Feb 2023 07:24:54 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2709785CBE0; Tue, 21 Feb 2023 12:24:54 +0000 (UTC) Received: from thuth.com (dhcp-192-205.str.redhat.com [10.33.192.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C997400DB36; Tue, 21 Feb 2023 12:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676982295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=COUpfO7V0vdDQF1zQcHqVR86UssH2a7JfJT9OjWEai0=; b=IJBBh5v6Z/yZqqx7StzCNhQ/XFyX+Zb6gbGMpTtVzid0pLYNBSM1i1Z4p2Ha90oL7rXFk6 OQVNwZoX2o8xUo4r+zINaHnsKoiNDrf7L2y31HtZnXOHxpxH0lWXsmGvKVQM4YBoT3B2zh 4uRDigLWzkHRqPgvRmH+G5xnJWYzAyc= X-MC-Unique: 9G5Io1qjM0yASsGI5jDUWQ-1 From: Thomas Huth To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Steve Sistare , Thomas Huth Subject: [PATCH] qemu-keymap: Silence memory leak warning from Clang's sanitizer Date: Tue, 21 Feb 2023 13:24:40 +0100 Message-Id: <20230221122440.612281-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676982393664100001 Content-Type: text/plain; charset="utf-8" When compiling QEMU with "--enable-sanitizers --enable-xkbcommon --cc=3Dcla= ng" there is a memory leak warning when running qemu-keymap: $ ./qemu-keymap -f pc-bios/keymaps/de -l de =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D610321=3D=3DERROR: LeakSanitizer: detected memory leaks Direct leak of 136 byte(s) in 1 object(s) allocated from: #0 0x5642830d0820 in __interceptor_calloc.part.11 asan_malloc_linux.cp= p.o #1 0x7f31873b8d2b in xkb_state_new (/lib64/libxkbcommon.so.0+0x1dd2b) = (BuildId: dd32581e2248833243f3f646324ae9b98469f025) SUMMARY: AddressSanitizer: 136 byte(s) leaked in 1 allocation(s). It can be silenced by properly releasing the "state" again after it has been used. Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell --- qemu-keymap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-keymap.c b/qemu-keymap.c index 4095b654a6..229866e004 100644 --- a/qemu-keymap.c +++ b/qemu-keymap.c @@ -226,6 +226,8 @@ int main(int argc, char *argv[]) =20 state =3D xkb_state_new(map); xkb_keymap_key_for_each(map, walk_map, state); + xkb_state_unref(state); + state =3D NULL; =20 /* add quirks */ fprintf(outfile, --=20 2.31.1