From nobody Thu May 16 01:40:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676915906; cv=none; d=zohomail.com; s=zohoarc; b=PhkbPe3rl2cPTJrJcK+TqVJW1Fa7w/5ogyGmfMzIaYj79yVV4BSXssUkK4q+z+tLsPagD8RWhxBPbyE3M0LLhSj9w4DJzkCC3gDfHz6WIEunEn+yDFTs76vvfofhKpHjv9zJvuisESdIpst+YCV34KAUVfgJqz5OLo8he+61az8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676915906; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Halr+Athvze6RFN4X0DlEuLuoZ1b2w1l3BtaIuNr8+w=; b=Wf694ErfRhkInjrlzeo9yQsWvrGloFj4ifsJvF/1j7ZFQYdMmL9QMudnr7cOAhdzE+wy22w5DpPhv93/jAthQiRkzgjxKgdgKO5rfXS4PNGSzeHzXCscZKQIYXb3HkvcLn8bZFCSZFTnuCLEO8G3FDiY4v/pXEKgx7NjIUBXc2o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676915906345693.6989870893019; Mon, 20 Feb 2023 09:58:26 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pUAQP-0000uG-8U; Mon, 20 Feb 2023 12:58:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUAQN-0000u6-FD for qemu-devel@nongnu.org; Mon, 20 Feb 2023 12:58:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pUAQL-0004FA-Tt for qemu-devel@nongnu.org; Mon, 20 Feb 2023 12:58:03 -0500 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-lbuHlt2IPkime8v-lWk3ZA-1; Mon, 20 Feb 2023 12:56:47 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D183E1C0514A for ; Mon, 20 Feb 2023 17:56:46 +0000 (UTC) Received: from centennial.enunes.eu.com (unknown [10.43.17.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 391C62026D4B; Mon, 20 Feb 2023 17:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676915880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Halr+Athvze6RFN4X0DlEuLuoZ1b2w1l3BtaIuNr8+w=; b=M/9eR0cc4jj2VwmZOKoYB1qyRPhMYrWMlJ9tOVDslP5OWhBMjvcz+KSOFa2/KeuDoi41L+ ixGHPF2b0aX+DWOSAf8A7xHrbzorhIBjtYNkVUQ6klkIUIowQvgcetxym5/zwcnpB2CbTP N07FkoLeY3Qiw6HTg4qv3mLbbnmf0NE= X-MC-Unique: lbuHlt2IPkime8v-lWk3ZA-1 From: Erico Nunes To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, Erico Nunes Subject: [PATCH] ui/gtk: fix passing y0_top parameter to scanout Date: Mon, 20 Feb 2023 18:56:05 +0100 Message-Id: <20230220175605.43759-1-ernunes@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=ernunes@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676915908004100001 Content-Type: text/plain; charset="utf-8" The dmabuf->y0_top flag is passed to .dpy_gl_scanout_dmabuf(), however in the gtk ui both implementations dropped it when doing the next scanout_texture call. Fixes flipped linux console using vhost-user-gpu with the gtk ui display. Signed-off-by: Erico Nunes Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/gtk-egl.c | 2 +- ui/gtk-gl-area.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index e84431790c..557668e418 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -256,7 +256,7 @@ void gd_egl_scanout_dmabuf(DisplayChangeListener *dcl, } =20 gd_egl_scanout_texture(dcl, dmabuf->texture, - false, dmabuf->width, dmabuf->height, + dmabuf->y0_top, dmabuf->width, dmabuf->height, 0, 0, dmabuf->width, dmabuf->height); =20 if (dmabuf->allow_fences) { diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 7696df1f6b..c384a1516b 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -298,7 +298,7 @@ void gd_gl_area_scanout_dmabuf(DisplayChangeListener *d= cl, } =20 gd_gl_area_scanout_texture(dcl, dmabuf->texture, - false, dmabuf->width, dmabuf->height, + dmabuf->y0_top, dmabuf->width, dmabuf->heig= ht, 0, 0, dmabuf->width, dmabuf->height); =20 if (dmabuf->allow_fences) { --=20 2.39.2