[v2] Remove C virtiofsd

[PATCH v2 0/4] Remove C virtiofsd

Dr. David Alan Gilbert (git) posted 4 patches 1 year, 2 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230215184310.161283-1-dgilbert@redhat.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, "Alex Bennée" <alex.bennee@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>

MAINTAINERS                                   |    2 -
docs/about/deprecated.rst                     |   18 -
docs/about/removed-features.rst               |   13 +
docs/conf.py                                  |    4 -
docs/meson.build                              |    1 -
docs/tools/index.rst                          |    1 -
docs/tools/virtiofsd.rst                      |  403 --
meson.build                                   |    1 -
meson_options.txt                             |    2 -
.../ci/org.centos/stream/8/x86_64/configure   |    2 -
.../org.centos/stream/8/x86_64/test-avocado   |    7 -
scripts/coverity-scan/COMPONENTS.md           |    3 -
scripts/meson-buildoptions.sh                 |    3 -
tests/avocado/virtiofs_submounts.py           |  217 -
tools/meson.build                             |   13 -
tools/virtiofsd/50-qemu-virtiofsd.json.in     |    5 -
tools/virtiofsd/buffer.c                      |  350 --
tools/virtiofsd/fuse_common.h                 |  837 ---
tools/virtiofsd/fuse_i.h                      |  107 -
tools/virtiofsd/fuse_log.c                    |   40 -
tools/virtiofsd/fuse_log.h                    |   75 -
tools/virtiofsd/fuse_lowlevel.c               | 2732 ----------
tools/virtiofsd/fuse_lowlevel.h               | 1988 --------
tools/virtiofsd/fuse_misc.h                   |   59 -
tools/virtiofsd/fuse_opt.c                    |  446 --
tools/virtiofsd/fuse_opt.h                    |  272 -
tools/virtiofsd/fuse_signals.c                |   93 -
tools/virtiofsd/fuse_virtio.c                 | 1081 ----
tools/virtiofsd/fuse_virtio.h                 |   33 -
tools/virtiofsd/helper.c                      |  409 --
tools/virtiofsd/meson.build                   |   18 -
tools/virtiofsd/passthrough_helpers.h         |   51 -
tools/virtiofsd/passthrough_ll.c              | 4521 -----------------
tools/virtiofsd/passthrough_seccomp.c         |  182 -
tools/virtiofsd/passthrough_seccomp.h         |   14 -
35 files changed, 13 insertions(+), 13990 deletions(-)
delete mode 100644 docs/tools/virtiofsd.rst
delete mode 100644 tests/avocado/virtiofs_submounts.py
delete mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in
delete mode 100644 tools/virtiofsd/buffer.c
delete mode 100644 tools/virtiofsd/fuse_common.h
delete mode 100644 tools/virtiofsd/fuse_i.h
delete mode 100644 tools/virtiofsd/fuse_log.c
delete mode 100644 tools/virtiofsd/fuse_log.h
delete mode 100644 tools/virtiofsd/fuse_lowlevel.c
delete mode 100644 tools/virtiofsd/fuse_lowlevel.h
delete mode 100644 tools/virtiofsd/fuse_misc.h
delete mode 100644 tools/virtiofsd/fuse_opt.c
delete mode 100644 tools/virtiofsd/fuse_opt.h
delete mode 100644 tools/virtiofsd/fuse_signals.c
delete mode 100644 tools/virtiofsd/fuse_virtio.c
delete mode 100644 tools/virtiofsd/fuse_virtio.h
delete mode 100644 tools/virtiofsd/helper.c
delete mode 100644 tools/virtiofsd/meson.build
delete mode 100644 tools/virtiofsd/passthrough_helpers.h
delete mode 100644 tools/virtiofsd/passthrough_ll.c
delete mode 100644 tools/virtiofsd/passthrough_seccomp.c
delete mode 100644 tools/virtiofsd/passthrough_seccomp.h

Expand all Fold all

[PATCH v2 0/4] Remove C virtiofsd

Posted by Dr. David Alan Gilbert (git) 1 year, 2 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a
in v7.0 in favour of the Rust implementation at
 
  https://gitlab.com/virtio-fs/virtiofsd
 
since then, the Rust version has had more development and
has held up well.  It's time to say goodbye to the C version
that got us going.

v2:
  After comments on the v1 series, I've removed the Avocado
test.

Dr. David Alan Gilbert (4):
  virtiofsd: Remove test
  virtiofsd: Remove build and docs glue
  virtiofsd: Remove source
  virtiofsd: Swing deprecated message to removed-features

 MAINTAINERS                                   |    2 -
 docs/about/deprecated.rst                     |   18 -
 docs/about/removed-features.rst               |   13 +
 docs/conf.py                                  |    4 -
 docs/meson.build                              |    1 -
 docs/tools/index.rst                          |    1 -
 docs/tools/virtiofsd.rst                      |  403 --
 meson.build                                   |    1 -
 meson_options.txt                             |    2 -
 .../ci/org.centos/stream/8/x86_64/configure   |    2 -
 .../org.centos/stream/8/x86_64/test-avocado   |    7 -
 scripts/coverity-scan/COMPONENTS.md           |    3 -
 scripts/meson-buildoptions.sh                 |    3 -
 tests/avocado/virtiofs_submounts.py           |  217 -
 tools/meson.build                             |   13 -
 tools/virtiofsd/50-qemu-virtiofsd.json.in     |    5 -
 tools/virtiofsd/buffer.c                      |  350 --
 tools/virtiofsd/fuse_common.h                 |  837 ---
 tools/virtiofsd/fuse_i.h                      |  107 -
 tools/virtiofsd/fuse_log.c                    |   40 -
 tools/virtiofsd/fuse_log.h                    |   75 -
 tools/virtiofsd/fuse_lowlevel.c               | 2732 ----------
 tools/virtiofsd/fuse_lowlevel.h               | 1988 --------
 tools/virtiofsd/fuse_misc.h                   |   59 -
 tools/virtiofsd/fuse_opt.c                    |  446 --
 tools/virtiofsd/fuse_opt.h                    |  272 -
 tools/virtiofsd/fuse_signals.c                |   93 -
 tools/virtiofsd/fuse_virtio.c                 | 1081 ----
 tools/virtiofsd/fuse_virtio.h                 |   33 -
 tools/virtiofsd/helper.c                      |  409 --
 tools/virtiofsd/meson.build                   |   18 -
 tools/virtiofsd/passthrough_helpers.h         |   51 -
 tools/virtiofsd/passthrough_ll.c              | 4521 -----------------
 tools/virtiofsd/passthrough_seccomp.c         |  182 -
 tools/virtiofsd/passthrough_seccomp.h         |   14 -
 35 files changed, 13 insertions(+), 13990 deletions(-)
 delete mode 100644 docs/tools/virtiofsd.rst
 delete mode 100644 tests/avocado/virtiofs_submounts.py
 delete mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in
 delete mode 100644 tools/virtiofsd/buffer.c
 delete mode 100644 tools/virtiofsd/fuse_common.h
 delete mode 100644 tools/virtiofsd/fuse_i.h
 delete mode 100644 tools/virtiofsd/fuse_log.c
 delete mode 100644 tools/virtiofsd/fuse_log.h
 delete mode 100644 tools/virtiofsd/fuse_lowlevel.c
 delete mode 100644 tools/virtiofsd/fuse_lowlevel.h
 delete mode 100644 tools/virtiofsd/fuse_misc.h
 delete mode 100644 tools/virtiofsd/fuse_opt.c
 delete mode 100644 tools/virtiofsd/fuse_opt.h
 delete mode 100644 tools/virtiofsd/fuse_signals.c
 delete mode 100644 tools/virtiofsd/fuse_virtio.c
 delete mode 100644 tools/virtiofsd/fuse_virtio.h
 delete mode 100644 tools/virtiofsd/helper.c
 delete mode 100644 tools/virtiofsd/meson.build
 delete mode 100644 tools/virtiofsd/passthrough_helpers.h
 delete mode 100644 tools/virtiofsd/passthrough_ll.c
 delete mode 100644 tools/virtiofsd/passthrough_seccomp.c
 delete mode 100644 tools/virtiofsd/passthrough_seccomp.h

-- 
2.39.1

Re: [PATCH v2 0/4] Remove C virtiofsd

Posted by Stefan Hajnoczi 1 year, 2 months ago

On Wed, Feb 15, 2023 at 06:43:06PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a
> in v7.0 in favour of the Rust implementation at
>  
>   https://gitlab.com/virtio-fs/virtiofsd
>  
> since then, the Rust version has had more development and
> has held up well.  It's time to say goodbye to the C version
> that got us going.
> 
> v2:
>   After comments on the v1 series, I've removed the Avocado
> test.
> 
> Dr. David Alan Gilbert (4):
>   virtiofsd: Remove test
>   virtiofsd: Remove build and docs glue
>   virtiofsd: Remove source
>   virtiofsd: Swing deprecated message to removed-features
> 
>  MAINTAINERS                                   |    2 -
>  docs/about/deprecated.rst                     |   18 -
>  docs/about/removed-features.rst               |   13 +
>  docs/conf.py                                  |    4 -
>  docs/meson.build                              |    1 -
>  docs/tools/index.rst                          |    1 -
>  docs/tools/virtiofsd.rst                      |  403 --
>  meson.build                                   |    1 -
>  meson_options.txt                             |    2 -
>  .../ci/org.centos/stream/8/x86_64/configure   |    2 -
>  .../org.centos/stream/8/x86_64/test-avocado   |    7 -
>  scripts/coverity-scan/COMPONENTS.md           |    3 -
>  scripts/meson-buildoptions.sh                 |    3 -
>  tests/avocado/virtiofs_submounts.py           |  217 -
>  tools/meson.build                             |   13 -
>  tools/virtiofsd/50-qemu-virtiofsd.json.in     |    5 -
>  tools/virtiofsd/buffer.c                      |  350 --
>  tools/virtiofsd/fuse_common.h                 |  837 ---
>  tools/virtiofsd/fuse_i.h                      |  107 -
>  tools/virtiofsd/fuse_log.c                    |   40 -
>  tools/virtiofsd/fuse_log.h                    |   75 -
>  tools/virtiofsd/fuse_lowlevel.c               | 2732 ----------
>  tools/virtiofsd/fuse_lowlevel.h               | 1988 --------
>  tools/virtiofsd/fuse_misc.h                   |   59 -
>  tools/virtiofsd/fuse_opt.c                    |  446 --
>  tools/virtiofsd/fuse_opt.h                    |  272 -
>  tools/virtiofsd/fuse_signals.c                |   93 -
>  tools/virtiofsd/fuse_virtio.c                 | 1081 ----
>  tools/virtiofsd/fuse_virtio.h                 |   33 -
>  tools/virtiofsd/helper.c                      |  409 --
>  tools/virtiofsd/meson.build                   |   18 -
>  tools/virtiofsd/passthrough_helpers.h         |   51 -
>  tools/virtiofsd/passthrough_ll.c              | 4521 -----------------
>  tools/virtiofsd/passthrough_seccomp.c         |  182 -
>  tools/virtiofsd/passthrough_seccomp.h         |   14 -
>  35 files changed, 13 insertions(+), 13990 deletions(-)
>  delete mode 100644 docs/tools/virtiofsd.rst
>  delete mode 100644 tests/avocado/virtiofs_submounts.py
>  delete mode 100644 tools/virtiofsd/50-qemu-virtiofsd.json.in
>  delete mode 100644 tools/virtiofsd/buffer.c
>  delete mode 100644 tools/virtiofsd/fuse_common.h
>  delete mode 100644 tools/virtiofsd/fuse_i.h
>  delete mode 100644 tools/virtiofsd/fuse_log.c
>  delete mode 100644 tools/virtiofsd/fuse_log.h
>  delete mode 100644 tools/virtiofsd/fuse_lowlevel.c
>  delete mode 100644 tools/virtiofsd/fuse_lowlevel.h
>  delete mode 100644 tools/virtiofsd/fuse_misc.h
>  delete mode 100644 tools/virtiofsd/fuse_opt.c
>  delete mode 100644 tools/virtiofsd/fuse_opt.h
>  delete mode 100644 tools/virtiofsd/fuse_signals.c
>  delete mode 100644 tools/virtiofsd/fuse_virtio.c
>  delete mode 100644 tools/virtiofsd/fuse_virtio.h
>  delete mode 100644 tools/virtiofsd/helper.c
>  delete mode 100644 tools/virtiofsd/meson.build
>  delete mode 100644 tools/virtiofsd/passthrough_helpers.h
>  delete mode 100644 tools/virtiofsd/passthrough_ll.c
>  delete mode 100644 tools/virtiofsd/passthrough_seccomp.c
>  delete mode 100644 tools/virtiofsd/passthrough_seccomp.h
> 
> -- 
> 2.39.1
> 

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>