include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

[PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

Thomas Huth posted 1 patch 1 year, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230215152233.210024-1-thuth@redhat.com

Maintainers: Beniamino Galvani <b.galvani@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Strahinja Jankovic <strahinja.p.jankovic@gmail.com>

include/hw/arm/allwinner-a10.h | 2 --
hw/arm/allwinner-a10.c         | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

Posted by Thomas Huth 1 year, 2 months ago

pci_device.h is not needed at all in allwinner-a10.h, and serial.h
is only needed by the corresponding .c file.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 include/hw/arm/allwinner-a10.h | 2 --
 hw/arm/allwinner-a10.c         | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/hw/arm/allwinner-a10.h b/include/hw/arm/allwinner-a10.h
index 79e0c80568..095afb225d 100644
--- a/include/hw/arm/allwinner-a10.h
+++ b/include/hw/arm/allwinner-a10.h
@@ -1,9 +1,7 @@
 #ifndef HW_ARM_ALLWINNER_A10_H
 #define HW_ARM_ALLWINNER_A10_H
 
-#include "hw/char/serial.h"
 #include "hw/arm/boot.h"
-#include "hw/pci/pci_device.h"
 #include "hw/timer/allwinner-a10-pit.h"
 #include "hw/intc/allwinner-a10-pic.h"
 #include "hw/net/allwinner_emac.h"
diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
index dc1966ff7a..b7ca795c71 100644
--- a/hw/arm/allwinner-a10.c
+++ b/hw/arm/allwinner-a10.c
@@ -18,6 +18,7 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "qemu/module.h"
+#include "hw/char/serial.h"
 #include "hw/sysbus.h"
 #include "hw/arm/allwinner-a10.h"
 #include "hw/misc/unimp.h"
-- 
2.31.1

Re: [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

Posted by Peter Maydell 1 year, 2 months ago

On Wed, 15 Feb 2023 at 15:22, Thomas Huth <thuth@redhat.com> wrote:
>
> pci_device.h is not needed at all in allwinner-a10.h, and serial.h
> is only needed by the corresponding .c file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  include/hw/arm/allwinner-a10.h | 2 --
>  hw/arm/allwinner-a10.c         | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)

Applied to target-arm.next, thanks.

-- PMM

Re: [PATCH] include/hw/arm/allwinner-a10.h: Remove superfluous includes from the header

Posted by Alex Bennée 1 year, 2 months ago

Thomas Huth <thuth@redhat.com> writes:

> pci_device.h is not needed at all in allwinner-a10.h, and serial.h
> is only needed by the corresponding .c file.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro