From nobody Sat May 18 10:08:07 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676464937; cv=none; d=zohomail.com; s=zohoarc; b=DwXEdSDBi3WO3mXqJjBAtnIFzpJHukzUaGG1gefn9Zi0rAjIZ/Tc73IynIl0kAEDBxV7/x1+OVmBkOCWdmWQfQegG2OGTMLITPmDKzlDoVautxjLpuHnUXMc2LMzMfbarB2oJ+DfLa6/zRpqeaU83UgFglizH4ZGwt1MuGOvDNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676464937; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=W2bWFXnxSXm3p6ku6c5ZTy/bxcUN8kx8nS3B4lj75KE=; b=dOnlWQMx7mlig1bwzRCFH0Idp9ydmwxKrWyAKdn6iK+Kl2g0G6egdZA3gCFlAGKQJ+egHJa78cypJj5T7sJ0BZQxyaxyB7rL6QngcLTRRLy+KpWWqXodAkgJlwkvvI1sa5hGZwm1+wOSGF0x/nAxPm+xFZIgrZNR8RA5+JLU41U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676464937163684.2011143023728; Wed, 15 Feb 2023 04:42:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSH6J-000376-PR; Wed, 15 Feb 2023 07:41:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSH6I-00036u-7S for qemu-devel@nongnu.org; Wed, 15 Feb 2023 07:41:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSH6G-00031y-MU for qemu-devel@nongnu.org; Wed, 15 Feb 2023 07:41:29 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-rzl0rsXNNaWsUsGzrENGPg-1; Wed, 15 Feb 2023 07:41:25 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D2A8884343; Wed, 15 Feb 2023 12:41:25 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 512122026D4B; Wed, 15 Feb 2023 12:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676464886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=W2bWFXnxSXm3p6ku6c5ZTy/bxcUN8kx8nS3B4lj75KE=; b=Fc2bEPq3luxh3VLKqQ1UzOAhF1WCd6UXeUhrjDvr21V5uzO0qZ9Y1O0setbFCN6MwTQGo8 GivXMLDBS7skZ3Dn/EbcSPfGq9+LnmsdAgyPZRPjJ14/TIxkfE/hfHyFuN5HPZEi18VlHr rWclTU8XHQaIOT15PixbBFfn6WDDjDM= X-MC-Unique: rzl0rsXNNaWsUsGzrENGPg-1 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Laurent Vivier , Peter Maydell Subject: [PATCH] tests/qtest/rtl8139-test: Make the test less verbose by default Date: Wed, 15 Feb 2023 13:41:22 +0100 Message-Id: <20230215124122.72037-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676464939035100003 Content-Type: text/plain; charset="utf-8" We are facing the issues that some test logs in the gitlab CI are too big (and thus cut off). The rtl8139-test is one of the few qtests that prints many lines of output by default when running with V=3D1, so it contributes to this problem. Almost all other qtests are silent with V=3D1 and only print debug messages with V=3D2 and higher. Thus let's change the rtl8139-test to behave more like the other tests and only print the debug messages with V=3D2 (or higher). Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 --- tests/qtest/rtl8139-test.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c index 8fa3313cc3..1beb83805c 100644 --- a/tests/qtest/rtl8139-test.c +++ b/tests/qtest/rtl8139-test.c @@ -12,6 +12,8 @@ #include "libqos/pci-pc.h" #include "qemu/timer.h" =20 +static int verbosity_level; + /* Tests only initialization so far. TODO: Replace with functional tests */ static void nop(void) { @@ -45,12 +47,16 @@ static QPCIDevice *get_device(void) static unsigned __attribute__((unused)) in_##name(void) \ { \ unsigned res =3D qpci_io_read##len(dev, dev_bar, (val)); \ - g_test_message("*%s -> %x", #name, res); \ + if (verbosity_level >=3D 2) { \ + g_test_message("*%s -> %x", #name, res); \ + } \ return res; \ } \ static void out_##name(unsigned v) \ { \ - g_test_message("%x -> *%s", v, #name); \ + if (verbosity_level >=3D 2) { \ + g_test_message("%x -> *%s", v, #name); \ + } \ qpci_io_write##len(dev, dev_bar, (val), v); \ } =20 @@ -195,6 +201,11 @@ static void test_init(void) int main(int argc, char **argv) { int ret; + char *v_env =3D getenv("V"); + + if (v_env) { + verbosity_level =3D atoi(v_env); + } =20 qtest_start("-device rtl8139"); =20 --=20 2.31.1