From nobody Fri May 17 08:25:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1676385593; cv=none; d=zohomail.com; s=zohoarc; b=nfxSBla08IZa5w283zteCOLV208EoeF30MjfSWXzaeicxYt2xRSsLKUWIdZ2foGqIwPMzycTRsZdDWFu67wQxyba4SkUYY9KQdwHF+LxYSxbsz8EAab7MwsmTk0iAYodcCOdgdqmITVJ5o6Bt8E1+3uId22K8DziezWm2zWIBEk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676385593; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=/tkFcJJ1Y47pZW2VuATYZtN7rgZ3xel84Wyul7+m0sM=; b=Xnt49RSbzRTB0vEPV6kOODru5/UQXe714AKxN9z83BtA21z6YwN2fs/I4wZnL5s+jN3Qm63DJqAvNR+ctn3ukffiEgVsGeuasLYzl5bZZVMHOjn2jdUk5mdEMkLuiBq3dxxvKG5WqFvrRBXekaOfc1l+dxUjXCtUSDOfvq+MYTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676385593845324.1690355290658; Tue, 14 Feb 2023 06:39:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRw1R-00065t-P5; Tue, 14 Feb 2023 09:11:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRw1Q-00065S-7I for qemu-devel@nongnu.org; Tue, 14 Feb 2023 09:11:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRw1O-0003y5-IK for qemu-devel@nongnu.org; Tue, 14 Feb 2023 09:11:03 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-12-X9hOYXKeNzC_dQPzLvqYZw-1; Tue, 14 Feb 2023 09:11:00 -0500 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9751C100F907; Tue, 14 Feb 2023 14:10:59 +0000 (UTC) Received: from thuth.com (unknown [10.39.192.14]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63EE2492B03; Tue, 14 Feb 2023 14:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676383861; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=/tkFcJJ1Y47pZW2VuATYZtN7rgZ3xel84Wyul7+m0sM=; b=YBB/6Gp2sVuRGLqsYNxow0rTQFuQ7uTBik9UzSLEG2zp0D44/z12vD2EO368HmZ+23J9Ua 91VW/Md9lsOKD5mjrMh0R7EBhiRgzh/zbmUZ/ujeg1wDDvA5SCDMUZz7yj858pcgtvUrC2 dA0z7QI9ky4j+KB1tz74st02EAuE4sk= X-MC-Unique: X9hOYXKeNzC_dQPzLvqYZw-1 From: Thomas Huth To: qemu-s390x@nongnu.org, David Hildenbrand , frankja@linux.ibm.com Cc: qemu-devel@nongnu.org, Richard Henderson , Ilya Leoshkevich Subject: [PATCH] target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes() Date: Tue, 14 Feb 2023 15:10:56 +0100 Message-Id: <20230214141056.680969-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1676385595861100003 Content-Type: text/plain; charset="utf-8" "note_size" can be smaller than sizeof(note), so unconditionally calling memset(notep, 0, sizeof(note)) could cause a memory corruption here in case notep has been allocated dynamically, thus let's use note_size as length argument for memset() instead. Fixes: 113d8f4e95 ("s390x: pv: Add dump support") Signed-off-by: Thomas Huth Reported-by: Sebastian Mitterle Reviewed-by: Janosch Frank Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/s390x/arch_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c index a2329141e8..a7c44ba49d 100644 --- a/target/s390x/arch_dump.c +++ b/target/s390x/arch_dump.c @@ -248,7 +248,7 @@ static int s390x_write_elf64_notes(const char *note_nam= e, notep =3D g_malloc(note_size); } =20 - memset(notep, 0, sizeof(note)); + memset(notep, 0, note_size); =20 /* Setup note header data */ notep->hdr.n_descsz =3D cpu_to_be32(content_size); --=20 2.31.1