[v4] Fix deadlock when dying because of a signal

[PATCH v4 0/4] Fix deadlock when dying because of a signal

Ilya Leoshkevich posted 4 patches 1 year, 2 months ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230214140829.45392-1-iii@linux.ibm.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Laurent Vivier <laurent@vivier.eu>, "Alex Bennée" <alex.bennee@linaro.org>

cpus-common.c                               | 12 ++++-
include/hw/core/cpu.h                       |  4 +-
linux-user/main.c                           | 10 ++--
linux-user/microblaze/cpu_loop.c            | 10 +++-
linux-user/syscall.c                        |  1 +
tests/tcg/multiarch/linux/linux-fork-trap.c | 51 +++++++++++++++++++++
6 files changed, 78 insertions(+), 10 deletions(-)
create mode 100644 tests/tcg/multiarch/linux/linux-fork-trap.c

Expand all Fold all

[PATCH v4 0/4] Fix deadlock when dying because of a signal

Posted by Ilya Leoshkevich 1 year, 2 months ago

Based-on: <20230202005204.2055899-1-richard.henderson@linaro.org>
("[PATCH 00/14] linux-user/sparc: Handle missing traps")

v3: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg03534.html
v3 -> v4: Add printfs to the test in order to make the uncaught signals
          less scary:

          $ build/x86_64-linux-user/qemu-x86_64 build/tests/tcg/x86_64-linux-user/linux-fork-trap
          about to trigger fault...
          qemu: uncaught target signal 4 (Illegal instruction) - core dumped
          faulting thread exited cleanly

v2: https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg03299.html
v2 -> v3: Use exclusive_context_count = 1 instead of
          exclusive_context_count++ in the non-recursive case.

v1: https://lists.gnu.org/archive/html/qemu-devel/2023-01/msg07251.html
v1 -> v2: Drop the sparc patch (superseded by Richard's series).
          Add the end_exclusive() fix.

Hi,

wasmtime testsuite found a deadlock in qemu_plugin_user_exit().
I tracked it down to one of my earlier patches, which introduced
cleanup in dump_core_and_abort().

Patches 1 and 2 fix the issue, patch 3 fixes __builtin_trap()
handling in microblaze, which is needed for patch 4, that adds a test.

Best regards,
Ilya

Ilya Leoshkevich (4):
  linux-user: Always exit from exclusive state in fork_end()
  cpus: Make {start,end}_exclusive() recursive
  linux-user/microblaze: Handle privileged exception
  tests/tcg/linux-test: Add linux-fork-trap test

 cpus-common.c                               | 12 ++++-
 include/hw/core/cpu.h                       |  4 +-
 linux-user/main.c                           | 10 ++--
 linux-user/microblaze/cpu_loop.c            | 10 +++-
 linux-user/syscall.c                        |  1 +
 tests/tcg/multiarch/linux/linux-fork-trap.c | 51 +++++++++++++++++++++
 6 files changed, 78 insertions(+), 10 deletions(-)
 create mode 100644 tests/tcg/multiarch/linux/linux-fork-trap.c

-- 
2.39.1

Re: [PATCH v4 0/4] Fix deadlock when dying because of a signal

Posted by Richard Henderson 1 year, 2 months ago

On 2/14/23 04:08, Ilya Leoshkevich wrote:
> Based-on:<20230202005204.2055899-1-richard.henderson@linaro.org>
> ("[PATCH 00/14] linux-user/sparc: Handle missing traps")
> 
> v3:https://lists.gnu.org/archive/html/qemu-devel/2023-02/msg03534.html
> v3 -> v4: Add printfs to the test in order to make the uncaught signals
>            less scary:
> 
>            $ build/x86_64-linux-user/qemu-x86_64 build/tests/tcg/x86_64-linux-user/linux-fork-trap
>            about to trigger fault...
>            qemu: uncaught target signal 4 (Illegal instruction) - core dumped
>            faulting thread exited cleanly

Queued to tcg-next, thanks.


r~