From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322627; cv=none; d=zohomail.com; s=zohoarc; b=Ht3qcVoDrr7efFndmeSHCGYgaJh3jmIQg5RUEGDAesRX4rXEsdwYyYlv+ilTMWQPhWvdUBZs0bt4zX6s7iaQRWXBFX0KDNNeAM4XacC0g9xAtQBbO7sLqA+MtczQbhTqtiMC64wUUBZtDZW4rzJB2urN0I6U56Zwy0RWJMUoj+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322627; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+e4y96VVf22+nC2D5nzDeVlvErNsuSzZkd1RPow2jPs=; b=WfXtg0teqYy7BjFi4AcdsE7POMXzCpU5vO71QbWRQKwXaNZ6gwDkowv/GN0nPYM7rZEPUoNxPvWY4M8LUiXL2YbRzC58EUWZLPQlk26aTjrWmT6dX+33npO4g2YoQ6JJbPZYQ1onyYw9aXqacjGunMLcWE7F/Jvs/7RnmlvVkSI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322627806311.1488490730328; Mon, 13 Feb 2023 13:10:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg56-00075q-Rr; Mon, 13 Feb 2023 16:09:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg55-00075S-9Y for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:47 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg53-0000z6-RQ for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:47 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 64D4B224AE; Mon, 13 Feb 2023 21:09:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0657E138E6; Mon, 13 Feb 2023 21:09:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YJ+oLxan6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+e4y96VVf22+nC2D5nzDeVlvErNsuSzZkd1RPow2jPs=; b=gA/QyZ87vlRju1fh+IT1V/u30r6vEwbl2FFquYDuf9V9NAfKY3YV3jCPCg3Iw2xVuySkDN E1H4+d8PsZiRm79K0eErMOywvlQ40U232gPjvKMtYT4/5KdDeHrPb2D3ippRkN+RVp2EbZ 0t4o/hdpez/qsvFH8WPn6yqv+l/4fl4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322584; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+e4y96VVf22+nC2D5nzDeVlvErNsuSzZkd1RPow2jPs=; b=3tQuSEyrACSsC5O+mchwmliBXB9hvsOxfGyQ7c6n5hZrzlfbCeR3oDR13E0BsO4F9uQ2zf ddQ8IdteOEF6xuBA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 01/12] tests/qtest: Skip PXE tests for missing devices Date: Mon, 13 Feb 2023 18:07:27 -0300 Message-Id: <20230213210738.9719-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322630007100009 Content-Type: text/plain; charset="utf-8" Check if the devices we're trying to add are present in the QEMU binary. They could have been removed from the build via Kconfig or the --without-default-devices option. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/pxe-test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c index 52f0b5c67c..62b6eef464 100644 --- a/tests/qtest/pxe-test.c +++ b/tests/qtest/pxe-test.c @@ -108,6 +108,10 @@ static void test_batch(const testdef_t *tests, bool ip= v6) const testdef_t *test =3D &tests[i]; char *testname; =20 + if (!qtest_has_device(test->model)) { + continue; + } + testname =3D g_strdup_printf("pxe/ipv4/%s/%s", test->machine, test->model); qtest_add_data_func(testname, test, test_pxe_ipv4); --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322629; cv=none; d=zohomail.com; s=zohoarc; b=dfMYtnoArfEbkgHzevbB7ZfzuxcE0+nxBLvOktI4hITBrqPo2SxDwf3lMi9xtl5x6F/eWUd1OiRRIHGLo5IXqPVFlToBsADm7dQzMAay1pVMX4rjZrbt749+JLJjkYtcrLvd5YH1EsU6+HV9H4SRcQ8CRJuJNXMTuiB6zRHM6Oc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322629; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lZIZOkc8thDizwpWbxSX9OaD5uzJdmuunMWzVxRza38=; b=RmZscCRDtAKROZA/EImku6++c0LR4MSo0TaVjj9yKqrAKgVVU2sd33AnavemvsaX2Et49ERQRrMfS8Wu8gLuFy6NabuN4i8vqtQPr+8R8qF987k2qqNnr+LheUzwH8Ugq09uPhBoO7n2YF0hZ7dHCi7Y0OsUlN5bnOUtoA2fgZI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322629450180.1773688154501; Mon, 13 Feb 2023 13:10:29 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg59-00076k-Pd; Mon, 13 Feb 2023 16:09:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg58-00076D-2a for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:50 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg56-0000zk-Lp for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:49 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9ACED20354; Mon, 13 Feb 2023 21:09:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D5479138E6; Mon, 13 Feb 2023 21:09:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QD2OJhin6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZIZOkc8thDizwpWbxSX9OaD5uzJdmuunMWzVxRza38=; b=L9Pp+uEmyG34KtVAegnu7Vvz01eYH1j2l5Ngj+heAqwdjqwme92Ti7EcDze6N3qOZ0aDLA 41Ulub9S1Zd0Oj7oxeAqL997y3ryFwZoD+jhkgfAoIk7UAhYluRp+KGrczdK5CdNa+tTAA bVd7ZtIJECIR8dAI62B2onAhQ/9+k/g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322587; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lZIZOkc8thDizwpWbxSX9OaD5uzJdmuunMWzVxRza38=; b=EzZi3mnPnzjZ9cxsqXjZHpaRpGQX1txv+EtjUyLVb+G+83g1RNO3C8IUbeQ7y0XWKb+X9f hoZjM5G8IH1zP4Cw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Alexander Bulekov , Paolo Bonzini , Bandan Das , Stefan Hajnoczi , Darren Kenny , Qiuhao Li , Fam Zheng , Laurent Vivier Subject: [PATCH v3 02/12] tests/qtest: Do not run lsi53c895a test if device is not present Date: Mon, 13 Feb 2023 18:07:28 -0300 Message-Id: <20230213210738.9719-3-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322629941100006 Content-Type: text/plain; charset="utf-8" The tests are built once for all the targets, so as long as one QEMU binary is built with CONFIG_LSI_SCSI_PCI=3Dy, this test will run. However some binaries might not include the device. So check this again in runtime. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/fuzz-lsi53c895a-test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/fuzz-lsi53c895a-test.c b/tests/qtest/fuzz-lsi53c89= 5a-test.c index 392a7ae7ed..a9254b455d 100644 --- a/tests/qtest/fuzz-lsi53c895a-test.c +++ b/tests/qtest/fuzz-lsi53c895a-test.c @@ -112,6 +112,10 @@ static void test_lsi_do_dma_empty_queue(void) =20 int main(int argc, char **argv) { + if (!qtest_has_device("lsi53c895a")) { + return 0; + } + g_test_init(&argc, &argv, NULL); =20 qtest_add_func("fuzz/lsi53c895a/lsi_do_dma_empty_queue", --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322709; cv=none; d=zohomail.com; s=zohoarc; b=YYobQFVHPzfL6qSCC50ZSqyLeKuCqPvHEjhgpfH/NMEgxryUFRhjwKQxKSLL1FqfwyKfvECxL4lvZ0bTLvPKv3M3eOaVcKiKQgdqJGzPszJ9JZoY2P1T8rN90NmksAjmxicYWtcGFhRNTOMS5oOnw/3gIlLhxnEnxSlepEi67K8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322709; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iMmpeDPXQ6B2fr5wfyy1WJVjlaU7gNZqaXsvRsePt+c=; b=RKIyf7HaPSEMvpHIaPZaaBBBJRGAu0SROIlqD2YuwEbZNuPf9obaG1P9meUGl+msudeN7jl9NBb79/VDOuE1DltsoS86uSBRLVKvzHmh09G8ceS5kqbdbb1vKI+l4oiZNql80kHUTZ1Dpbdknb2bz9+niExKlZSBhX/Z+XN5JJ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167632270977445.81309126130702; Mon, 13 Feb 2023 13:11:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5F-0007AP-DQ; Mon, 13 Feb 2023 16:09:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5A-00076x-1V for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:52 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg58-000101-IR for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:51 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 78BC1224AE; Mon, 13 Feb 2023 21:09:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 178E8138E6; Mon, 13 Feb 2023 21:09:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uJuqMxun6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMmpeDPXQ6B2fr5wfyy1WJVjlaU7gNZqaXsvRsePt+c=; b=oKBdWaEPFX32GqOQePmrGNMo8D3oPXK+GjpRz7Lq1N/+8rsUjyOgHGpt1ppXs8MbNYAlJi PH1zo+0LvKCZZDKiACrWHItKATj2e5EUCuwTe3VgmAPvAL/BAPSp/8UMczhMsPSAIdizrD zcVCvT+SzYpo6tbb9Z5KB4tPCsQNI1w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMmpeDPXQ6B2fr5wfyy1WJVjlaU7gNZqaXsvRsePt+c=; b=iyQohj0v0Hp6/p2+/d/sadldYWsdIjgPP/q5EYFojZPNrdg1rrgESMq3j72w9PzHlAvHxQ yYLDG017/RKZxYBg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c Date: Mon, 13 Feb 2023 18:07:29 -0300 Message-Id: <20230213210738.9719-4-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322710357100005 Content-Type: text/plain; charset="utf-8" This test depends on the presence of the pcie-root-port device. Add a build time dependency. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index e97616d327..5c8b031ce0 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -73,7 +73,8 @@ qtests_i386 =3D \ (config_all_devices.has_key('CONFIG_ESP_PCI') ? ['am53c974-test'] : []) = + \ (config_host.has_key('CONFIG_POSIX') and = \ config_all_devices.has_key('CONFIG_ACPI_ERST') ? ['erst-test'] : []) + = \ - (config_all_devices.has_key('CONFIG_VIRTIO_NET') and = \ + (config_all_devices.has_key('CONFIG_PCIE_PORT') and = \ + config_all_devices.has_key('CONFIG_VIRTIO_NET') and = \ config_all_devices.has_key('CONFIG_Q35') and = \ config_all_devices.has_key('CONFIG_VIRTIO_PCI') and = \ slirp.found() ? ['virtio-net-failover'] : []) + = \ --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322707; cv=none; d=zohomail.com; s=zohoarc; b=H4rXQQpKi7xzTyHT/Q91nYxEaVLwZZyAWSOACk/zZq2UlGaRhY2pOSyTmLRW1JlYQYVUaAg9XaQ3WfUhI06xbLBtyMOz6wVSqcEVk5mFEoxIJ+HbGZhW5fzQV5YovAulwEAJ8/NPhmiKYHFLiJqXgkxYvJNiu3qQ5Rs8Dszr/nM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322707; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qMZMXw7r7/vh0LOIXqEEOcMJKJSCztwLsxWN4dBRKcw=; b=DQoudD+RyxjZcyfOdAhpl2flA0TkJD1xbVKlxt5sQBcBgt4tpua+Ve5gM3HSRPFAVS+dNmBq6EH8xAtGyqDUpaq7a97pMKoCUBJg0q9VpCuUkqhkAWmF9jmt9TzKGC6J3m9ImDenadAPT9P2yIUAFUnWllZkZwCo4wlvcP1GrLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322707000331.550954205975; Mon, 13 Feb 2023 13:11:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5F-0007AQ-FD; Mon, 13 Feb 2023 16:09:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5C-00078E-6K for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:55 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5A-00010j-Qv for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:53 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 57F51224AF; Mon, 13 Feb 2023 21:09:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EA07B138E6; Mon, 13 Feb 2023 21:09:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id sH5pKx2n6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMZMXw7r7/vh0LOIXqEEOcMJKJSCztwLsxWN4dBRKcw=; b=IGDvIGcdi2CzNe/al2KvC4kbr5vGeIqqWr8Tvv8WwgznXDrLht6C8pxcJkTu0L5fVNVDhu r6M7YI49YrkeK+Tfo9heDepjt1h4RgW+NES5KRY1dk0rEGzsMgicsfK+X1BF5JC4JXvPWI 1LtH4XvUp8mT3ICq8dg/QmrDLfakKAc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qMZMXw7r7/vh0LOIXqEEOcMJKJSCztwLsxWN4dBRKcw=; b=YzIk568OSON3xEO1SwrYHwfd4n6Bs8qxgtRr/Euq0J5Dcgm0jdn+9lZSxl97kKcx3ZCwV+ v8RF4kRho4BgokDw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 04/12] tests/qtest: Don't build virtio-serial-test.c if device not present Date: Mon, 13 Feb 2023 18:07:30 -0300 Message-Id: <20230213210738.9719-5-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322708409100001 Content-Type: text/plain; charset="utf-8" The virtconsole device might not be present in the QEMU build that is being tested. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/meson.build | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 5c8b031ce0..84cd07bbb9 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -255,10 +255,14 @@ qos_test_ss.add( 'virtio-net-test.c', 'virtio-rng-test.c', 'virtio-scsi-test.c', - 'virtio-serial-test.c', 'virtio-iommu-test.c', 'vmxnet3-test.c', ) + +if config_all_devices.has_key('CONFIG_VIRTIO_SERIAL') + qos_test_ss.add(files('virtio-serial-test.c')) +endif + if config_host.has_key('CONFIG_POSIX') qos_test_ss.add(files('e1000e-test.c')) endif --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322712; cv=none; d=zohomail.com; s=zohoarc; b=kqhSQ4xoQ/7nSTVxaDKTfrGP6ukEe7wJlexuez+bp1L6NrKFBvD5hdtiGjR4rgLnKqhQCsmq2KDec1tBjOC4R81iYoDX24+Q5glSS4dltHByhP1uVdzJyN4mUE+oiHPLh1t9f76WFzSxYosFIrv1WNg0nnCxjHYDxj9u+1cN4Jo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322712; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LikIgyxVUj4YLyeoxIbokts71/bEVCMUXA5N5gnmk3w=; b=nZcnMUpcRATxLI0f81Lr0y6TlEm2nRhA8Qlv4NOzbb1thqypp4mzePXkGHiPRXqMM2NsJ4sGjW4sPywl+kpkYS26g4eB3cwi3ULvT5RXDUt9sWMqqtAUx8ixibq+HYJtf04id+1EM2rHx7jxm96pENKRMItMo8uy7BAgIEfb6Ic= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322712141818.2640262807164; Mon, 13 Feb 2023 13:11:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5L-0007B9-2M; Mon, 13 Feb 2023 16:10:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5D-00078a-T5 for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:55 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5C-000116-Av for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:55 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 381E2224AE; Mon, 13 Feb 2023 21:09:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C94B8138E6; Mon, 13 Feb 2023 21:09:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KPZtIx+n6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LikIgyxVUj4YLyeoxIbokts71/bEVCMUXA5N5gnmk3w=; b=LXWfJMwHgnsg68ujno2cZcRCncGxQ4MDuKtvfISdT4V6HsKFXj+VlBjqHkwu1e1STu2wNJ c3auzi1iWrOFzhQsA7C7KfvERvIBiB3aaeK/+NSYHp4E1X3mvOxyLlPTVM/dhCv2HH2Px6 TbZqKHdttm5NQo/xwGdDkJyt5fwoSzY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322593; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LikIgyxVUj4YLyeoxIbokts71/bEVCMUXA5N5gnmk3w=; b=dYkhi7EcF75n8f0mwYbvzDG6fN84tUwIhO2z1wnZoRjYNRpLlU3RuSFHc2bEuhDeYKJ80G CZ0Fqw1elC073oCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 05/12] tests/qtest: hd-geo-test: Check for missing devices Date: Mon, 13 Feb 2023 18:07:31 -0300 Message-Id: <20230213210738.9719-6-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322712346100009 Content-Type: text/plain; charset="utf-8" Don't include tests that require devices not available in the QEMU binary. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 38 +++++++++++++++++++++++++------------- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/tests/qtest/hd-geo-test.c b/tests/qtest/hd-geo-test.c index 4a7628077b..5aa258a2b3 100644 --- a/tests/qtest/hd-geo-test.c +++ b/tests/qtest/hd-geo-test.c @@ -1090,30 +1090,42 @@ int main(int argc, char **argv) qtest_add_func("hd-geo/override/ide", test_override_ide); if (qtest_has_device("lsi53c895a")) { qtest_add_func("hd-geo/override/scsi", test_override_scsi); - qtest_add_func("hd-geo/override/scsi_2_controllers", - test_override_scsi_2_controllers); + if (qtest_has_device("virtio-scsi-pci")) { + qtest_add_func("hd-geo/override/scsi_2_controllers", + test_override_scsi_2_controllers); + } } - qtest_add_func("hd-geo/override/virtio_blk", test_override_virtio_= blk); qtest_add_func("hd-geo/override/zero_chs", test_override_zero_chs); - qtest_add_func("hd-geo/override/scsi_hot_unplug", - test_override_scsi_hot_unplug); - qtest_add_func("hd-geo/override/virtio_hot_unplug", - test_override_virtio_hot_unplug); + if (qtest_has_device("virtio-scsi-pci")) { + qtest_add_func("hd-geo/override/scsi_hot_unplug", + test_override_scsi_hot_unplug); + } + if (qtest_has_device("virtio-blk-pci")) { + qtest_add_func("hd-geo/override/virtio_hot_unplug", + test_override_virtio_hot_unplug); + qtest_add_func("hd-geo/override/virtio_blk", + test_override_virtio_blk); + } =20 if (qtest_has_machine("q35")) { qtest_add_func("hd-geo/override/sata", test_override_sata); - qtest_add_func("hd-geo/override/virtio_blk_q35", - test_override_virtio_blk_q35); qtest_add_func("hd-geo/override/zero_chs_q35", test_override_zero_chs_q35); if (qtest_has_device("lsi53c895a")) { qtest_add_func("hd-geo/override/scsi_q35", test_override_scsi_q35); } - qtest_add_func("hd-geo/override/scsi_hot_unplug_q35", - test_override_scsi_hot_unplug_q35); - qtest_add_func("hd-geo/override/virtio_hot_unplug_q35", - test_override_virtio_hot_unplug_q35); + if (qtest_has_device("virtio-scsi-pci")) { + qtest_add_func("hd-geo/override/scsi_hot_unplug_q35", + test_override_scsi_hot_unplug_q35); + } + if (qtest_has_device("virtio-blk-pci")) { + qtest_add_func("hd-geo/override/virtio_hot_unplug_q35", + test_override_virtio_hot_unplug_q35); + qtest_add_func("hd-geo/override/virtio_blk_q35", + test_override_virtio_blk_q35); + } + } } else { g_test_message("QTEST_QEMU_IMG not set or qemu-img missing; " --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322665; cv=none; d=zohomail.com; s=zohoarc; b=KBw96y+nhCAU9rgvaYQS15dxNQ7NeCrFc7VrSf/yADjTZsTTa29kgqE7UX0BjWrJMrDv7qV4u35hp7jG3cjUc8SrlPlQ2YRiLaoj/lBF2L02w75D3y2S1qwc+uNRkBEKqrDCjcNenBhSoZmhhF+K4Np72YvB8Vw45OWOQhSZAyo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322665; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xVifnKFO8e58R4MzGcfPLugFebB98MV3ryeajircXAU=; b=iQhfzGqZQ64uPEEIW5uB14kjKU4h9JsPS+TupQm3GWz3pLGoPeGt9JRdh083OUECfn1GhXoZZocJDm3AgONSVGGwm+mNxnldBGJqlsNBkEx5oxWUe6RUYnIxDeNwR7tc3VROWVqGJTsNFHIZIQGj1xsvd58JGM2s9BZAxmoV+7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322665928768.0518137655954; Mon, 13 Feb 2023 13:11:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5N-0007Ek-4J; Mon, 13 Feb 2023 16:10:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5F-0007AY-Nc for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:57 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5E-00011R-6z for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:57 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13EEE224AF; Mon, 13 Feb 2023 21:09:55 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A8268138E6; Mon, 13 Feb 2023 21:09:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uEqMGyGn6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xVifnKFO8e58R4MzGcfPLugFebB98MV3ryeajircXAU=; b=wgKn9MPos68Q9fjJw/LtJ/MxozBf2gu5/dRfiMbnaGv5031z5PjQlMrKEJCadYtdWMpX76 SvXbfKplNXsVX8j9n++M7FNdJXJQDa9FsAEn+Js3+x6mrmLy2/WnIyrgYcHHRWm0NK2ucQ A7A+qSM+u4hFUdfJcCA7XBOgqNXetW4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322595; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xVifnKFO8e58R4MzGcfPLugFebB98MV3ryeajircXAU=; b=CLD0Sg0NK4k7/jGQwkiskgVRp3zB0iRkNoSOrbFOqVolzK9XlyLHztesf0en/U8wIH9z+s k3Tbhu8kIM84NgAg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 06/12] tests/qtest: Fix coding style in device-plug-test.c Date: Mon, 13 Feb 2023 18:07:32 -0300 Message-Id: <20230213210738.9719-7-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322668059100007 Content-Type: text/plain; charset="utf-8" We should not mix declarations and statements in QEMU code. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/device-plug-test.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 5a6afa2b57..4f92617335 100644 --- a/tests/qtest/device-plug-test.c +++ b/tests/qtest/device-plug-test.c @@ -64,6 +64,7 @@ static void process_device_remove(QTestState *qtest, cons= t char *id) =20 static void test_pci_unplug_request(void) { + QTestState *qtest; const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 @@ -71,8 +72,8 @@ static void test_pci_unplug_request(void) machine_addition =3D "-machine pc"; } =20 - QTestState *qtest =3D qtest_initf("%s -device virtio-mouse-pci,id=3Dde= v0", - machine_addition); + qtest =3D qtest_initf("%s -device virtio-mouse-pci,id=3Ddev0", + machine_addition); =20 process_device_remove(qtest, "dev0"); =20 @@ -94,6 +95,7 @@ static void test_q35_pci_unplug_request(void) =20 static void test_pci_unplug_json_request(void) { + QTestState *qtest; const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 @@ -101,7 +103,7 @@ static void test_pci_unplug_json_request(void) machine_addition =3D "-machine pc"; } =20 - QTestState *qtest =3D qtest_initf( + qtest =3D qtest_initf( "%s -device \"{'driver': 'virtio-mouse-pci', 'id': 'dev0'}\"", machine_addition); =20 --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322627; cv=none; d=zohomail.com; s=zohoarc; b=botjNbBvJ9+8rF1nSttrOjlghG5VZ3lwJsLPtlZFwiFGX9Byrigf4zgb6R29O0tpRlKMWwAuP56RqeQEAo3n31U9MOlxRneqtvDIVmrZBm3J1cm8xk60fudAUBs2oOsw4X++RJRL+junsrZQo5olAOUgEwE+yk+pv7IzxJk3zq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322627; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hHKPxt4zJElPD+Cpx7MNEhU7CMVE87JnH/SfSBzg2bc=; b=XC2AdMkm9TbU+60vUAN5v/CDnsv6MITz5KeH8eobm0gxyK8i5Pu3M/JjyrMtxxev+ZLvM6qKHZWaOenO8vsUXaG7tBIWON5aq/1h8QAl+YwmdCm5B6GbwNl1K7/WrBBQMr+fHKRIe3DGUVv2yq+wSowZIIVKmyU7CdbRk9Fnb4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322627743720.3762231400756; Mon, 13 Feb 2023 13:10:27 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5O-0007F0-TH; Mon, 13 Feb 2023 16:10:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5K-0007BE-AZ for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:02 -0500 Received: from smtp-out1.suse.de ([2001:67c:2178:6::1c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5G-00011l-0S for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:09:59 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E0E16224B4; Mon, 13 Feb 2023 21:09:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 843A1138E6; Mon, 13 Feb 2023 21:09:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6E7AEiOn6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hHKPxt4zJElPD+Cpx7MNEhU7CMVE87JnH/SfSBzg2bc=; b=eiWZSr9yW3alnyPixoFTEuYDvXEA8vKoVNAXoRgXJSu8kO162AzlrxN5qJ9SSDnvnFpgSN 1iDTLsHTlRjHmNT6226XydUyBc6ftehX66ExATtbLXokc50xeMGGB4DWAlBV5jKKzLupse CDLaDFEnlz3I8fZ3h5kM/gyCN1gmEnw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322596; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hHKPxt4zJElPD+Cpx7MNEhU7CMVE87JnH/SfSBzg2bc=; b=aBvCYynNWPnIfSN5XwcKpe6qlH+cuCIHabFgC3lZWuthTbfEnSXhJ+IjnRIV1qZaxbebwQ LE83D/OfRhYavGDA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 07/12] tests/qtest: Skip unplug tests that use missing devices Date: Mon, 13 Feb 2023 18:07:33 -0300 Message-Id: <20230213210738.9719-8-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1c; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322629918100005 Content-Type: text/plain; charset="utf-8" Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/device-plug-test.c | 33 +++++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 4f92617335..01cecd6e20 100644 --- a/tests/qtest/device-plug-test.c +++ b/tests/qtest/device-plug-test.c @@ -68,6 +68,11 @@ static void test_pci_unplug_request(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -82,11 +87,17 @@ static void test_pci_unplug_request(void) =20 static void test_q35_pci_unplug_request(void) { + QTestState *qtest; + + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } =20 - QTestState *qtest =3D qtest_initf("-machine q35 " - "-device pcie-root-port,id=3Dp1 " - "-device pcie-pci-bridge,bus=3Dp1,id= =3Db1 " - "-device virtio-mouse-pci,bus=3Db1,id= =3Ddev0"); + qtest =3D qtest_initf("-machine q35 " + "-device pcie-root-port,id=3Dp1 " + "-device pcie-pci-bridge,bus=3Dp1,id=3Db1 " + "-device virtio-mouse-pci,bus=3Db1,id=3Ddev0"); =20 process_device_remove(qtest, "dev0"); =20 @@ -99,6 +110,11 @@ static void test_pci_unplug_json_request(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -114,6 +130,7 @@ static void test_pci_unplug_json_request(void) =20 static void test_q35_pci_unplug_json_request(void) { + QTestState *qtest; const char *port =3D "-device \"{'driver': 'pcie-root-port', " "'id': 'p1'}\""; =20 @@ -125,8 +142,12 @@ static void test_q35_pci_unplug_json_request(void) "'bus': 'b1', " "'id': 'dev0'}\""; =20 - QTestState *qtest =3D qtest_initf("-machine q35 %s %s %s", - port, bridge, device); + if (!qtest_has_device("virtio-mouse-pci")) { + g_test_skip("Device virtio-mouse-pci not available"); + return; + } + + qtest =3D qtest_initf("-machine q35 %s %s %s", port, bridge, device); =20 process_device_remove(qtest, "dev0"); =20 --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322712; cv=none; d=zohomail.com; s=zohoarc; b=EXEKeBVZfxDtJ6mk5pD4DQ3IfishgADSESGF8BSLqJyTg5O1zXHUiFrwaWTfgo1Q38bk22DnCLuEzaQrStLq0OaSO4wJ+GytP6v1sXzUv6ZThiMMKbfVm0KEkX03oHfoWeJosU6Fc79TchZzNRO7YLYbWi4Gb3/gdBihjyV4OaU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322712; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Fhrv9KAWG4tYYMfFMlQHvhWFeL/ATKiHt/+TeK+VO9c=; b=nZt7/eSMCxn4gSeah/d7/bcsAv7t9uPZyX+xcD+NO6H9+kT3IDj2P7/oHhJRBzW/VXeBzVkMZg1N57FWXvlzUb3Pi5MTI6MQTw4EJdT4urYiQnWGMeS4CBomIQ86TRP/tx9vav00iBJKMNcInJAioGa7ivYq2/6Ozv7FfO4Y9fw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322712627406.83034414650353; Mon, 13 Feb 2023 13:11:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5P-0007F3-9p; Mon, 13 Feb 2023 16:10:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5M-0007EQ-QX for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:04 -0500 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5J-00011z-Qo for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:04 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C3DE320357; Mon, 13 Feb 2023 21:09:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5F53E138E6; Mon, 13 Feb 2023 21:09:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aEmuCSWn6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fhrv9KAWG4tYYMfFMlQHvhWFeL/ATKiHt/+TeK+VO9c=; b=jqKFluKa18ZotHqAJ8fYKcrqNzhAduteMTDfPs+Dhekpwh1kkBclMK3pi1cDJurDvleRAM UxbR0/bAxv4+XNVRcngjBWN6UxT1drg+U0Gedz+WUbpsaxN5AkOGAJygfwaGPrpdtxAGcc SG2F7YZ6aSFDO6hH7BwGbTw8l8evdfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322598; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fhrv9KAWG4tYYMfFMlQHvhWFeL/ATKiHt/+TeK+VO9c=; b=2Db0TcmOgD9wniQCEkUh6Bm1pxz0POYJ1UBlfFfUQHo/RHDFs2L3WSIfQOvHYHrigSJZAX sL4l539sRxA9i7Cg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 08/12] tests/qtest: drive_del-test: Skip tests that require missing devices Date: Mon, 13 Feb 2023 18:07:34 -0300 Message-Id: <20230213210738.9719-9-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322714435100015 Content-Type: text/plain; charset="utf-8" Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/drive_del-test.c | 65 ++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index 9a750395a9..8a6f3ac963 100644 --- a/tests/qtest/drive_del-test.c +++ b/tests/qtest/drive_del-test.c @@ -16,6 +16,8 @@ #include "qapi/qmp/qdict.h" #include "qapi/qmp/qlist.h" =20 +static const char *qvirtio_get_dev_type(void); + static bool look_for_drive0(QTestState *qts, const char *command, const ch= ar *key) { QDict *response; @@ -40,6 +42,19 @@ static bool look_for_drive0(QTestState *qts, const char = *command, const char *ke return found; } =20 +/* + * This covers the possible absence of a device due to QEMU build + * options. + */ +static bool has_device_builtin(const char *dev) +{ + gchar *device =3D g_strdup_printf("%s-%s", dev, qvirtio_get_dev_type()= ); + bool rc =3D qtest_has_device(device); + + g_free(device); + return rc; +} + static bool has_drive(QTestState *qts) { return look_for_drive0(qts, "query-block", "device"); @@ -208,6 +223,11 @@ static void test_drive_del_device_del(void) { QTestState *qts; =20 + if (!has_device_builtin("virtio-scsi")) { + g_test_skip("Device virtio-scsi is not available"); + return; + } + /* Start with a drive used by a device that unplugs instantaneously */ qts =3D qtest_initf("-drive if=3Dnone,id=3Ddrive0,file=3Dnull-co://," "file.read-zeroes=3Don,format=3Draw" @@ -232,6 +252,11 @@ static void test_cli_device_del(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -256,6 +281,11 @@ static void test_cli_device_del_q35(void) { QTestState *qts; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + /* * -drive/-device and device_del. Start with a drive used by a * device that unplugs after reset. @@ -277,6 +307,11 @@ static void test_empty_device_del(void) { QTestState *qts; =20 + if (!has_device_builtin("virtio-scsi")) { + g_test_skip("Device virtio-scsi is not available"); + return; + } + /* device_del with no drive plugged. */ qts =3D qtest_initf("-device virtio-scsi-%s -device scsi-cd,id=3Ddev0", qvirtio_get_dev_type()); @@ -291,6 +326,11 @@ static void test_device_add_and_del(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -330,6 +370,11 @@ static void test_device_add_and_del_q35(void) { QTestState *qts; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + /* * -drive/device_add and device_del. Start with a drive used by a * device that unplugs after reset. @@ -352,6 +397,11 @@ static void test_drive_add_device_add_and_del(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -374,6 +424,11 @@ static void test_drive_add_device_add_and_del_q35(void) { QTestState *qts; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + qts =3D qtest_init("-machine q35 -device pcie-root-port,id=3Dp1 " "-device pcie-pci-bridge,bus=3Dp1,id=3Db1"); =20 @@ -395,6 +450,11 @@ static void test_blockdev_add_device_add_and_del(void) const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { machine_addition =3D "-machine pc"; } @@ -417,6 +477,11 @@ static void test_blockdev_add_device_add_and_del_q35(v= oid) { QTestState *qts; =20 + if (!has_device_builtin("virtio-blk")) { + g_test_skip("Device virtio-blk is not available"); + return; + } + qts =3D qtest_init("-machine q35 -device pcie-root-port,id=3Dp1 " "-device pcie-pci-bridge,bus=3Dp1,id=3Db1"); =20 --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322721; cv=none; d=zohomail.com; s=zohoarc; b=ldUf4q+zIw3AH0hxIVV0+1EYw5GukexPKgjwO1/6GMpUs2safNPPNmm6xOa8GCrBUwhyI1AdhoyQJ9iO2IdjGxEe8jUyfAFg6xm8gCIEKYDiLoYYSoyQMlGTycScruxjaam1ns7iPeZRmPwhQYjIBa1MQV+kFsuSMLQsJm1YE14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322721; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5+dT6k/9zBEP3vrylKQawsuBZi+XloTOrkBFNvETkQI=; b=RnEtYtQNSdSnOBccY09WzyO0CDDASGcinsqr/L662mFkHLplo/PLvrYHNz9f56adkkiyGpwJlf2C0Bz6ivlnNVLtAGqapwptcO0eLgoc1R0185BW3kwuXwoYj9JdVf6RYEUGQdXkmWoRzVMfuZKb5nLULrcbfnv5YfLHlqUD6kE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322721506603.5092845078707; Mon, 13 Feb 2023 13:12:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5R-0007GZ-8k; Mon, 13 Feb 2023 16:10:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5N-0007En-JE for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:06 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5K-000124-2m for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:04 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF75F20359; Mon, 13 Feb 2023 21:10:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 42516138E6; Mon, 13 Feb 2023 21:09:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qOpvAien6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:09:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+dT6k/9zBEP3vrylKQawsuBZi+XloTOrkBFNvETkQI=; b=tffZexZC/UO69bgaM9GDms/nBy0wR9GooLwSLz6yKfJFvE5RJsD3mW9wO0jAYiJXTbz0bk FpXOyP97O9WsVHGp0WKuutYFPDKxSWcGXwxDRyivIhWWd2KEsNTVribppMfEIZG2DFdxa/ /R0jxwGl0GLMTNeVxGpkJFxfZZmE/QE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322600; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+dT6k/9zBEP3vrylKQawsuBZi+XloTOrkBFNvETkQI=; b=DZu/nVzwkpQlapSAZPT4Wtq7GOZ3g8YYm1Q6Pd6ykg2yuMD3lDYSr6W9LDHhqhz+0Zj/wx jLnkSCbfLsRhrzDA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha Subject: [PATCH v3 09/12] tests/qtest: Check for devices in bios-tables-test Date: Mon, 13 Feb 2023 18:07:35 -0300 Message-Id: <20230213210738.9719-10-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322722396100001 Content-Type: text/plain; charset="utf-8" Do not include tests that require devices that are not available in the QEMU build. Signed-off-by: Fabiano Rosas Acked-by: Michael S. Tsirkin --- tests/qtest/bios-tables-test.c | 75 ++++++++++++++++++++++++++++++++-- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index d8c8cda58e..d29a4e47af 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -1008,6 +1008,12 @@ static void test_acpi_q35_multif_bridge(void) .machine =3D MACHINE_Q35, .variant =3D ".multi-bridge", }; + + if (!qtest_has_device("pcie-root-port")) { + g_test_skip("Device pcie-root-port is not available"); + goto out; + } + test_vm_prepare("-S" " -device virtio-balloon,id=3Dballoon0,addr=3D0x4.0x2" " -device pcie-root-port,id=3Drp0,multifunction=3Don," @@ -1043,6 +1049,7 @@ static void test_acpi_q35_multif_bridge(void) /* check that reboot/reset doesn't change any ACPI tables */ qtest_qmp_send(data.qts, "{'execute':'system_reset' }"); process_acpi_tables(&data); +out: free_test_data(&data); } =20 @@ -1396,6 +1403,11 @@ static void test_acpi_tcg_dimm_pxm(const char *machi= ne) { test_data data; =20 + if (!qtest_has_device("nvdimm")) { + g_test_skip("Device nvdimm is not available"); + return; + } + memset(&data, 0, sizeof(data)); data.machine =3D machine; data.variant =3D ".dimmpxm"; @@ -1444,6 +1456,11 @@ static void test_acpi_virt_tcg_memhp(void) .scan_len =3D 256ULL * 1024 * 1024, }; =20 + if (!qtest_has_device("nvdimm")) { + g_test_skip("Device nvdimm is not available"); + goto out; + } + data.variant =3D ".memhp"; test_acpi_one(" -machine nvdimm=3Don" " -cpu cortex-a57" @@ -1457,7 +1474,7 @@ static void test_acpi_virt_tcg_memhp(void) " -device pc-dimm,id=3Ddimm0,memdev=3Dram2,node=3D0" " -device nvdimm,id=3Ddimm1,memdev=3Dnvm0,node=3D1", &data); - +out: free_test_data(&data); =20 } @@ -1475,6 +1492,11 @@ static void test_acpi_microvm_tcg(void) { test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); test_acpi_one(" -machine microvm,acpi=3Don,ioapic2=3Doff,rtc=3Doff", &data); @@ -1485,6 +1507,11 @@ static void test_acpi_microvm_usb_tcg(void) { test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); data.variant =3D ".usb"; test_acpi_one(" -machine microvm,acpi=3Don,ioapic2=3Doff,usb=3Don,rtc= =3Doff", @@ -1496,6 +1523,11 @@ static void test_acpi_microvm_rtc_tcg(void) { test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); data.variant =3D ".rtc"; test_acpi_one(" -machine microvm,acpi=3Don,ioapic2=3Doff,rtc=3Don", @@ -1507,6 +1539,11 @@ static void test_acpi_microvm_pcie_tcg(void) { test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); data.variant =3D ".pcie"; data.tcg_only =3D true; /* need constant host-phys-bits */ @@ -1519,6 +1556,11 @@ static void test_acpi_microvm_ioapic2_tcg(void) { test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); data.variant =3D ".ioapic2"; test_acpi_one(" -machine microvm,acpi=3Don,ioapic2=3Don,rtc=3Doff", @@ -1558,6 +1600,12 @@ static void test_acpi_virt_tcg_pxb(void) .ram_start =3D 0x40000000ULL, .scan_len =3D 128ULL * 1024 * 1024, }; + + if (!qtest_has_device("pcie-root-port")) { + g_test_skip("Device pcie-root-port is not available"); + goto out; + } + /* * While using -cdrom, the cdrom would auto plugged into pxb-pcie, * the reason is the bus of pxb-pcie is also root bus, it would lead @@ -1576,7 +1624,7 @@ static void test_acpi_virt_tcg_pxb(void) " -cpu cortex-a57" " -device pxb-pcie,bus_nr=3D128", &data); - +out: free_test_data(&data); } =20 @@ -1764,6 +1812,12 @@ static void test_acpi_microvm_acpi_erst(void) gchar *params; test_data data; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + g_free(tmp_path); + return; + } + test_acpi_microvm_prepare(&data); data.variant =3D ".pcie"; data.tcg_only =3D true; /* need constant host-phys-bits */ @@ -1824,6 +1878,11 @@ static void test_acpi_q35_viot(void) .variant =3D ".viot", }; =20 + if (!qtest_has_device("virtio-iommu")) { + g_test_skip("Device virtio-iommu is not available"); + goto out; + } + /* * To keep things interesting, two buses bypass the IOMMU. * VIOT should only describes the other two buses. @@ -1834,6 +1893,7 @@ static void test_acpi_q35_viot(void) "-device pxb-pcie,bus_nr=3D0x20,id=3Dpcie.200,bus=3Dpcie= .0,bypass_iommu=3Don " "-device pxb-pcie,bus_nr=3D0x30,id=3Dpcie.300,bus=3Dpcie= .0", &data); +out: free_test_data(&data); } =20 @@ -1894,8 +1954,10 @@ static void test_acpi_virt_viot(void) .scan_len =3D 128ULL * 1024 * 1024, }; =20 - test_acpi_one("-cpu cortex-a57 " - "-device virtio-iommu-pci", &data); + if (qtest_has_device("virtio-iommu")) { + test_acpi_one("-cpu cortex-a57 " + "-device virtio-iommu-pci", &data); + } free_test_data(&data); } =20 @@ -2004,6 +2066,11 @@ static void test_acpi_microvm_oem_fields(void) test_data data; char *args; =20 + if (!qtest_has_device("virtio-blk-device")) { + g_test_skip("Device virtio-blk-device is not available"); + return; + } + test_acpi_microvm_prepare(&data); =20 args =3D test_acpi_create_args(&data, --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322645; cv=none; d=zohomail.com; s=zohoarc; b=HF+ykpvsjztZ2yS4Ukq7cmZSNA6miw12UPS7aKh686DIPLPeGnSD7wL/X5k5hkf0jBHi3K7SNZVt9FqzRXmHWdv9W46mUWAjJRTpjos2VPB8O9MdAUqEN3pYBXYktRentyO8nhWrADKLYc3/Y7uYsuxBYyV53La+WCewOiO6JFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322645; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A0htytMZ01ZPywDZQ/Ky7qQ2ND7rcYxESRt8w/s0GpM=; b=O/9bXC74Xka+H3op49p7cV20Os2DgPwIvPiEyNpOG7lf0ArarrxPulbyl8Lm5cnwIqkUusQ0h5SXLdgQNnkd+PGsCnIaywmc4gzfvdBIxYz7fmOOYNKaT7kLBNZ6hfPEoNwlbWp1FpOzle6o7+FLrMyIfBzIJPqPm6poBMkofhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322645772208.44528300042248; Mon, 13 Feb 2023 13:10:45 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5S-0007K4-6h; Mon, 13 Feb 2023 16:10:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5P-0007FH-66 for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:07 -0500 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5M-00013O-Gq for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:06 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BEB2D2035B; Mon, 13 Feb 2023 21:10:02 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5D129138E6; Mon, 13 Feb 2023 21:10:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EDwFCSmn6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:10:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A0htytMZ01ZPywDZQ/Ky7qQ2ND7rcYxESRt8w/s0GpM=; b=N/9kZLIK/eEhKDpZByfZyC7tVX8MfgpUcrOC465Ud4kytwadWkepaFtWqNgOYy4+ILU/nj Yhnk72wAH9x1pgEqB2Ev1E+iupVpCrhMmO0PZlOvqPn6k8ctm3diomrRtYM4Qomi4adVMv ydv0BEdJay+Vz6WsGPHxy1jIVV2nHkY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322602; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A0htytMZ01ZPywDZQ/Ky7qQ2ND7rcYxESRt8w/s0GpM=; b=Mx5YWX6akHqkeoMuVQdRRPtK18D9Z6gkcOj5ikxmbcUuhQ2RNk8FtgsZNl2Jw6G6tYAudC CeA0BJfqKLiHNzCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 10/12] tests/qtest: Do not include hexloader-test if loader device is not present Date: Mon, 13 Feb 2023 18:07:36 -0300 Message-Id: <20230213210738.9719-11-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322647958100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 84cd07bbb9..dbe3b1fcc9 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -197,11 +197,11 @@ qtests_arm =3D \ (config_all_devices.has_key('CONFIG_PFLASH_CFI02') ? ['pflash-cfi02-test= '] : []) + \ (config_all_devices.has_key('CONFIG_ASPEED_SOC') ? qtests_aspeed : []) += \ (config_all_devices.has_key('CONFIG_NPCM7XX') ? qtests_npcm7xx : []) + \ + (config_all_devices.has_key('CONFIG_GENERIC_LOADER') ? ['hexloader-test'= ] : []) + \ ['arm-cpu-features', 'microbit-test', 'test-arm-mptimer', - 'boot-serial-test', - 'hexloader-test'] + 'boot-serial-test'] =20 # TODO: once aarch64 TCG is fixed on ARM 32 bit host, make bios-tables-tes= t unconditional qtests_aarch64 =3D \ --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322632; cv=none; d=zohomail.com; s=zohoarc; b=lMO/J1q4wBboMQ1pwaO9BldBCPFtW/AYjreGROjr+v+Rct3ifXfS3ER5Vu+fPqr4HwdAZMx/6O9JW8WfI8miDAvbn/b1mWm8xr+b27dlF9YrAOSFCQ22pSZq6KwcnTGb4Gf13fU9T+hBVljN7ifJuYRItQeFU2YKIug1PcnmlXI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322632; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lNOgaxaBqZWtL1bb/vPjoRU9TOyq+Glv5gJiTpPG2Ec=; b=b1gt6J0N99MNoQo2G3juSIhonudjq7yhp8QO1l4wodrw8VWp6k0oJCuZe5ZgSErHoWTD+GJX4aaqVYHp0mRDjizOJBWaMa/dviYBLkgVtWZjwskdMXZwnL4DvetpmVLIwRo+oWi1dgzmOaMQOpVYEYroGDiEiaa7mzqc0mo3hSc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322632461650.6083741735579; Mon, 13 Feb 2023 13:10:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5S-0007K7-AY; Mon, 13 Feb 2023 16:10:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5Q-0007Fc-Hu; Mon, 13 Feb 2023 16:10:08 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5O-0001Fa-Bw; Mon, 13 Feb 2023 16:10:08 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E0FF0224B5; Mon, 13 Feb 2023 21:10:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EC79138E6; Mon, 13 Feb 2023 21:10:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6JadASun6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:10:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNOgaxaBqZWtL1bb/vPjoRU9TOyq+Glv5gJiTpPG2Ec=; b=KAKhOToPD5QgTY5WK4qoVGBTp8+zA94ojaWfML5dQLI4bLUNMeCG86FY8G4e3h1NuFe/Ah o/3VlZ8d5R+d2jyV355GpqeBIqjmClQR9njgvoyHs+IyzHxI7mEioGH0JJfkXSl4HZrOpf +onIcPsqVyd70F/Gii0wVvy95IDRCDY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lNOgaxaBqZWtL1bb/vPjoRU9TOyq+Glv5gJiTpPG2Ec=; b=grm6h0i4mtKtsk0tYUPrLkO91Dr/qOZe3NXh2TbqR+mTD+vHfnfqzMsiN/d8hLc0Waolym aFf8Dhu4XDlLgFBQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org Subject: [PATCH v3 11/12] tests/qemu-iotests: Require virtio-scsi-pci Date: Mon, 13 Feb 2023 18:07:37 -0300 Message-Id: <20230213210738.9719-12-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322634249100001 Content-Type: text/plain; charset="utf-8" Check that virtio-scsi-pci is present in the QEMU build before running the tests. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qemu-iotests/186 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/186 b/tests/qemu-iotests/186 index 072e54e62b..eaf13c7a33 100755 --- a/tests/qemu-iotests/186 +++ b/tests/qemu-iotests/186 @@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file fuse _require_drivers null-co +_require_devices virtio-scsi-pci =20 if [ "$QEMU_DEFAULT_MACHINE" !=3D "pc" ]; then _notrun "Requires a PC machine" --=20 2.35.3 From nobody Fri May 17 05:54:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1676322665; cv=none; d=zohomail.com; s=zohoarc; b=Ps7BARXrFCONGyjNi+OXltN5RRnwSwLzF7VHtGAVtdgqJSJkP6rszx5KlYM8crok7OEctxinvKuuZsc96VRiHB1f6pEKx2Vz2/ICrmZ0l18HoNrt/7A6ekco6uM/gyDo62w6rYliI5kYeyq+3ICO8s+5ClUhZZsc4bkin/uKy8w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1676322665; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5idIFYR58MQCZ3ucrLtJjIRpNSl15aG5VislS/yf0R0=; b=DIYrVipniwSXcTz9AQoZf0LQtV9B9jGOytlBHy0drcRin51ha4IVmkWW223rpOYIoFwT0AcK71J1GRUNxHvxmM9wTwaom4Z8b9LjdG/HqSSoeoc5SSR3IgmYaEg+LdjQLO3xJ8Uq5WV0B7+FxdcjHWvXaZNymVazeNUh3mZRkfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1676322665865422.58878262497103; Mon, 13 Feb 2023 13:11:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRg5c-0007LH-4f; Mon, 13 Feb 2023 16:10:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRg5R-0007J7-NM for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:09 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRg5Q-0001GG-46 for qemu-devel@nongnu.org; Mon, 13 Feb 2023 16:10:09 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BDAE9224B6; Mon, 13 Feb 2023 21:10:06 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5F820138E6; Mon, 13 Feb 2023 21:10:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gMqDCS2n6mPoRAAAMHmgww (envelope-from ); Mon, 13 Feb 2023 21:10:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676322606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5idIFYR58MQCZ3ucrLtJjIRpNSl15aG5VislS/yf0R0=; b=PMTEnUa9xW/A86Wpx/jNRJUFKzD8XBfKy8p3wPeUtqOX1fNldKe7I6W47mjrVLkvTHc7Tz XjNIezS04+hrLGH/sIQdB0PnimsAcwNZQG1YqOMgTCbH0Kxa12uXEcALF4kkcuKXZEnT6n lWJsZFoCYsyeHNnOMneOyTTLKpRPXdA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676322606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5idIFYR58MQCZ3ucrLtJjIRpNSl15aG5VislS/yf0R0=; b=8EFYdI6GyrXLHYokgVUEtXXoDpyMbBuqbJXojA6JumEdDktoPSOBOVYvFWBbfJQerGaA+O RWGyDCJA4Q6f0zDw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH v3 12/12] tests/qtest: bios-tables-test: Skip if missing configs Date: Mon, 13 Feb 2023 18:07:38 -0300 Message-Id: <20230213210738.9719-13-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230213210738.9719-1-farosas@suse.de> References: <20230213210738.9719-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.28; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1676322666056100001 Content-Type: text/plain; charset="utf-8" If we build with --without-default-devices, CONFIG_HPET and CONFIG_PARALLEL are set to N, which makes the respective devices go missing from acpi tables. Signed-off-by: Fabiano Rosas Reviewed-by: Thomas Huth --- tests/qtest/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index dbe3b1fcc9..222e1892fb 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -78,7 +78,9 @@ qtests_i386 =3D \ config_all_devices.has_key('CONFIG_Q35') and = \ config_all_devices.has_key('CONFIG_VIRTIO_PCI') and = \ slirp.found() ? ['virtio-net-failover'] : []) + = \ - (unpack_edk2_blobs ? ['bios-tables-test'] : []) + = \ + (unpack_edk2_blobs and = \ + config_all_devices.has_key('CONFIG_HPET') and = \ + config_all_devices.has_key('CONFIG_PARALLEL') ? ['bios-tables-test'] : = []) + \ qtests_pci + = \ qtests_cxl + = \ ['fdc-test', --=20 2.35.3