On 20/1/23 10:18, Thomas Huth wrote:
> On 20/01/2023 09.23, Philippe Mathieu-Daudé wrote:
>> Missing review: #7
>>
>> Two test were failing on Darwin when testing Fabiano's series
>> which allows building ARM targets without TCG accelerator:
>> https://lore.kernel.org/qemu-devel/20230118193518.26433-1-farosas@suse.de/
>>
>> These patches allow boot-serial / migration tests to run without
>> TCG / KVM.
>
> I just started reviewing while you were sending v3 ... please see my
> mails in reply to v2 for some comments.
Sure.
> Also, I don't quite understand why this is necessary. If you specify
> both, "-accel kvm -accel tcg" on the command line, QEMU should simply
> fall back to the second accelerator if the first one is not available?
> What's exactly the problem you are trying to solve here?
When testing Fabiano's series two tests hang, i.e. [*]:
18/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/boot-serial-test
qemu-system-aarch64: -accel tcg: invalid accelerator tcg
Maybe it is just a matter of adding HVF to the test? I'll see
when I switch back to that. Anyhow the "invalid accelerator"
warning is annoying noise when looking for real problems in the
output.
[*]
https://lore.kernel.org/qemu-devel/ab32e4db-2a6d-69f8-4b69-62a1f1c0f6ba@linaro.org/