From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1673985760; cv=none; d=zohomail.com; s=zohoarc; b=BSsEg4MSDIvv+cqZAGjgJ8odSP+euZr+foAYrSAfnTc5SwgLuh2mVMn7ddayFbo2cY9T5wKG2BQ/GHje4lpIRVeaUmZ7dbp0FTpa9sCx7p9Mdu+YosOK8lmaITpZiq8IHnpgaT3HGGDs44hFxjBfKTjR53B+O3t59H4MXNhR9jM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673985760; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JQI/hQq9twRi2qAs9giuU1jaByhc7XoUTrhQigrCPCA=; b=OhdCD9Iz0qO9fmi1S5oCvWxlpuQuKg91zM3Rq5b97fhAZkn+kRDVSHYbIYI2BsW4/n9XjtfVVosJjOIfmFxSXsgc04NqoR5LbwUnD7gf2xzQKv0638XQe+JURNR0So2ehrzeYgwYavQc6BDYNBaS8CvC+9ZKawfao5aJQJAtO5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1673985760109664.9282244516243; Tue, 17 Jan 2023 12:02:40 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHnVc-000624-KB; Tue, 17 Jan 2023 10:04:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHnVW-0005zZ-NE; Tue, 17 Jan 2023 10:04:16 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHnVU-0000WP-UC; Tue, 17 Jan 2023 10:04:14 -0500 Received: from localhost.localdomain (unknown [77.64.253.186]) by linux.microsoft.com (Postfix) with ESMTPSA id 1708420DFE9B; Tue, 17 Jan 2023 07:04:10 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1708420DFE9B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1673967851; bh=JQI/hQq9twRi2qAs9giuU1jaByhc7XoUTrhQigrCPCA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gkn8fwjp38JylkJisxsb8UEpnbDf7/IFS1TLkEAdlyD5Qi6+KUnM2xcxQyO5J7LPb GJ8TMC2tik1uNTtyDOfSuu7n5U3jjSFRYcDK0kP4VVuEb7zND39JNUg9znsLEA8Wks inQIOqnfC+HfseKddtteV8Y+UAMvdEKmpVObxVm4= From: Evgeny Iakovlev To: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v2 1/2] target/arm: implement DBGCLAIM registers Date: Tue, 17 Jan 2023 16:04:04 +0100 Message-Id: <20230117150405.2940-2-eiakovlev@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230117150405.2940-1-eiakovlev@linux.microsoft.com> References: <20230117150405.2940-1-eiakovlev@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -197 X-Spam_score: -19.8 X-Spam_bar: ------------------- X-Spam_report: (-19.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1673985761066100001 Content-Type: text/plain; charset="utf-8" The architecture does not define any functionality for the CLAIM tag bits. So we will just keep the raw bits, as per spec. Signed-off-by: Evgeny Iakovlev Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + target/arm/debug_helper.c | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 2b4bd20f9d..eddec155b0 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -494,6 +494,7 @@ typedef struct CPUArchState { uint64_t dbgbcr[16]; /* breakpoint control registers */ uint64_t dbgwvr[16]; /* watchpoint value registers */ uint64_t dbgwcr[16]; /* watchpoint control registers */ + uint64_t dbgclaim; /* DBGCLAIM bits */ uint64_t mdscr_el1; uint64_t oslsr_el1; /* OS Lock Status */ uint64_t osdlr_el1; /* OS DoubleLock status */ diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index c21739242c..6c34c6e27d 100644 --- a/target/arm/debug_helper.c +++ b/target/arm/debug_helper.c @@ -629,6 +629,29 @@ static void osdlr_write(CPUARMState *env, const ARMCPR= egInfo *ri, } } =20 +static void dbgclaimset_write(CPUARMState *env, const ARMCPRegInfo *ri, + uint64_t value) +{ + env->cp15.dbgclaim |=3D (value & 0xFF); +} + +static uint64_t dbgclaimset_read(CPUARMState *env, const ARMCPRegInfo *ri) +{ + /* CLAIM bits are RAO */ + return 0xFF; +} + +static void dbgclaimclr_write(CPUARMState *env, const ARMCPRegInfo *ri, + uint64_t value) +{ + env->cp15.dbgclaim &=3D ~(value & 0xFF); +} + +static void dbgclaimclr_raw_write(CPUARMState *env, const ARMCPRegInfo *ri= , uint64_t value) +{ + env->cp15.dbgclaim =3D value; +} + static const ARMCPRegInfo debug_cp_reginfo[] =3D { /* * DBGDRAR, DBGDSAR: always RAZ since we don't implement memory mapped @@ -712,6 +735,21 @@ static const ARMCPRegInfo debug_cp_reginfo[] =3D { .cp =3D 14, .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 2, .opc2 = =3D 0, .access =3D PL1_RW, .accessfn =3D access_tda, .type =3D ARM_CP_NOP }, + /* + * Dummy DBGCLAIM registers. + * "The architecture does not define any functionality for the CLAIM t= ag bits.", + * so we only keep the raw bits + */ + { .name =3D "DBGCLAIMSET_EL1", .state =3D ARM_CP_STATE_BOTH, + .cp =3D 14, .opc0 =3D 2, .opc1 =3D 0, .crn =3D 7, .crm =3D 8, .opc2 = =3D 6, + .type =3D ARM_CP_ALIAS, + .access =3D PL1_RW, .accessfn =3D access_tda, + .writefn =3D dbgclaimset_write, .readfn =3D dbgclaimset_read }, + { .name =3D "DBGCLAIMCLR_EL1", .state =3D ARM_CP_STATE_BOTH, + .cp =3D 14, .opc0 =3D 2, .opc1 =3D 0, .crn =3D 7, .crm =3D 9, .opc2 = =3D 6, + .access =3D PL1_RW, .accessfn =3D access_tda, + .writefn =3D dbgclaimclr_write, .raw_writefn =3D dbgclaimclr_raw_wri= te, + .fieldoffset =3D offsetof(CPUARMState, cp15.dbgclaim) }, }; =20 static const ARMCPRegInfo debug_lpae_cp_reginfo[] =3D { --=20 2.34.1 From nobody Fri Sep 20 22:16:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1673967908; cv=none; d=zohomail.com; s=zohoarc; b=crpK179ZrC+38QvZqRyAvyfX2K0GEXYiaNCApy030ZP50CHg5rFrwkQFmEYlTsJXhqhvT3QKAB+QVaSCrKD7zsE/WWWG65U7GQEK1WK0C2ZYP29rP+WlYMEw1inR1ZJismeRWoxa1QMHMgNzNcJ8t92IVInHQgC5XQowI1gUJqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1673967908; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6+WWXUG+FtOsFgttNAevqrhh9iBa3N55JRLaBzhwZOw=; b=MH37XzIBszlU8hPyYkMKhjx40SZ9mVoerhiHh5PN7oOcl+eP7dvMoDR816sXUjiUVxgTBqekrB4jdI8lk0960vpQe1GVkR4jWCQni0fc4n+TMKhwcdADx5KiiE/4s5+kcADmE5i0VczrMsSM2ioW9aKoVOal09z6F4VwV8i14JI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1673967908816479.97761408190013; Tue, 17 Jan 2023 07:05:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHnVc-00061E-8G; Tue, 17 Jan 2023 10:04:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHnVY-0005zb-DK; Tue, 17 Jan 2023 10:04:16 -0500 Received: from linux.microsoft.com ([13.77.154.182]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHnVW-0000Wl-UU; Tue, 17 Jan 2023 10:04:16 -0500 Received: from localhost.localdomain (unknown [77.64.253.186]) by linux.microsoft.com (Postfix) with ESMTPSA id 5A31A20DFE9C; Tue, 17 Jan 2023 07:04:12 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5A31A20DFE9C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1673967853; bh=6+WWXUG+FtOsFgttNAevqrhh9iBa3N55JRLaBzhwZOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bzULKc51lw2X3jXsiuNIg3XhXZ1tVlvoDPMh2E8CIUXetR3B7oMYzUTDrdo8EDnq1 kOKzJ6sgaR2ZwluOG4O0UlfPApDiQ9Lwa+hTTho2y2PjaeRWLHmwkhY48msMpq8m0E sCUHM7uAYYsnqDdRHTL38rUUnES2lKFbTdUNDR0Q= From: Evgeny Iakovlev To: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v2 2/2] target/arm: provide stubs for more external debug registers Date: Tue, 17 Jan 2023 16:04:05 +0100 Message-Id: <20230117150405.2940-3-eiakovlev@linux.microsoft.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230117150405.2940-1-eiakovlev@linux.microsoft.com> References: <20230117150405.2940-1-eiakovlev@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=13.77.154.182; envelope-from=eiakovlev@linux.microsoft.com; helo=linux.microsoft.com X-Spam_score_int: -197 X-Spam_score: -19.8 X-Spam_bar: ------------------- X-Spam_report: (-19.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.microsoft.com) X-ZM-MESSAGEID: 1673967910939100003 Content-Type: text/plain; charset="utf-8" Qemu doesn't implement Debug Communication Channel, as well as the rest of external debug interface. However, Microsoft Hyper-V tries to access some of these registers during an EL2 context switch. Since there is no architectural way to not advertise support for external debug, provide RAZ/WI stubs for OSDTRRX_EL1, OSDTRTX_EL1 and OSECCR_EL1 registers in the same way the rest of external debug is currently done. Signed-off-by: Evgeny Iakovlev Reviewed-by: Peter Maydell --- target/arm/debug_helper.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 6c34c6e27d..bc213ac91e 100644 --- a/target/arm/debug_helper.c +++ b/target/arm/debug_helper.c @@ -684,6 +684,27 @@ static const ARMCPRegInfo debug_cp_reginfo[] =3D { .opc0 =3D 2, .opc1 =3D 3, .crn =3D 0, .crm =3D 1, .opc2 =3D 0, .access =3D PL0_R, .accessfn =3D access_tda, .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, + /* + * OSDTRRX_EL1/OSDTRTX_EL1 are used for save and restore of DBGDTRRX_E= L0. + * It is a component of the Debug Communications Channel, which is not= implemented. + */ + { .name =3D "OSDTRRX_EL1", .state =3D ARM_CP_STATE_BOTH, .cp =3D 14, + .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 0, .opc2 =3D 2, + .access =3D PL1_RW, .accessfn =3D access_tda, + .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, + { .name =3D "OSDTRTX_EL1", .state =3D ARM_CP_STATE_BOTH, .cp =3D 14, + .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 3, .opc2 =3D 2, + .access =3D PL1_RW, .accessfn =3D access_tda, + .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, + /* + * OSECCR_EL1 provides a mechanism for an operating system + * to access the contents of EDECCR. EDECCR is not implemented though, + * as is the rest of external device mechanism. + */ + { .name =3D "OSECCR_EL1", .state =3D ARM_CP_STATE_BOTH, .cp =3D 14, + .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 6, .opc2 =3D 2, + .access =3D PL1_RW, .accessfn =3D access_tda, + .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, /* * DBGDSCRint[15,12,5:2] map to MDSCR_EL1[15,12,5:2]. Map all bits as * it is unlikely a guest will care. --=20 2.34.1