[PULL 00/15] First batch of s390x, qtests and misc fixes in 2023

Thomas Huth posted 15 patches 1 year, 4 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230106082853.31787-1-thuth@redhat.com
Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Greg Kurz <groug@kaod.org>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, Peter Xu <peterx@redhat.com>, Jason Wang <jasowang@redhat.com>, Michael Roth <michael.roth@amd.com>, Konstantin Kostiuk <kkostiuk@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Laurent Vivier <lvivier@redhat.com>
There is a newer version of this series
docs/about/deprecated.rst                          |  6 ++++
docs/interop/index.rst                             |  1 +
...coding.txt => vnc-ledstate-pseudo-encoding.rst} |  0
include/exec/memory-internal.h                     |  4 ---
include/exec/memory.h                              |  4 +++
include/qemu/osdep.h                               |  8 ++++-
block/file-posix.c                                 | 37 ++++++++++------------
chardev/char-fd.c                                  |  2 +-
chardev/char-pipe.c                                |  8 +++--
chardev/char-pty.c                                 |  4 +--
hw/9pfs/9p-local.c                                 |  8 ++---
hw/s390x/s390-pci-inst.c                           |  2 +-
net/l2tpv3.c                                       | 17 +++-------
net/socket.c                                       | 16 ++++------
net/tap-bsd.c                                      |  6 ++--
net/tap-linux.c                                    |  2 +-
net/tap-solaris.c                                  |  8 ++---
net/tap.c                                          | 10 ++----
os-posix.c                                         |  2 +-
qga/commands-posix.c                               |  4 +--
semihosting/syscalls.c                             |  4 +--
softmmu/vl.c                                       |  1 +
target/s390x/cpu.c                                 |  4 ++-
target/s390x/cpu_features.c                        |  4 +++
target/s390x/cpu_models.c                          |  4 ++-
target/s390x/tcg/excp_helper.c                     |  8 ++---
target/s390x/tcg/misc_helper.c                     |  1 -
tests/qtest/libqtest.c                             |  6 ++--
tests/qtest/readconfig-test.c                      |  6 ++--
tests/vhost-user-bridge.c                          |  4 +--
util/main-loop.c                                   |  4 +--
util/osdep.c                                       |  4 +--
util/vfio-helpers.c                                | 12 +++----
.gitlab-ci.d/windows.yml                           |  3 +-
MAINTAINERS                                        |  2 ++
qemu-options.hx                                    |  2 +-
scripts/meson-buildoptions.sh                      | 18 +++++++----
tests/qemu-iotests/tests/stream-under-throttle     |  2 ++
tests/vm/basevm.py                                 |  3 +-
39 files changed, 120 insertions(+), 121 deletions(-)
rename docs/interop/{vnc-ledstate-Pseudo-encoding.txt => vnc-ledstate-pseudo-encoding.rst} (100%)
[PULL 00/15] First batch of s390x, qtests and misc fixes in 2023
Posted by Thomas Huth 1 year, 4 months ago
 Hi Peter!

The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:

  .gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)

are available in the Git repository at:

  https://gitlab.com/thuth/qemu.git tags/pull-request-2023-01-06

for you to fetch changes up to 975f619662a46cb5dc7a3b17b84a1b540fb7df5c:

  .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job (2023-01-05 21:50:21 +0100)

----------------------------------------------------------------
* s390x header clean-ups from Philippe
* Rework and improvements of the EINTR handling by Nikita
* Deprecate the -no-hpet command line option
* Disable the qtests in the 32-bit Windows CI job again
* Some other misc fixes here and there

----------------------------------------------------------------
Alessandro Di Federico (1):
      Update scripts/meson-buildoptions.sh

Christian Borntraeger (1):
      qemu-iotests/stream-under-throttle: do not shutdown QEMU

Marc-André Lureau (1):
      tests/readconfig: spice doesn't support unix socket on windows yet

Nikita Ivanov (2):
      Refactoring: refactor TFR() macro to RETRY_ON_EINTR()
      error handling: Use RETRY_ON_EINTR() macro where applicable

Philippe Mathieu-Daudé (6):
      tests/vm: Update get_default_jobs() to work on non-x86_64 non-KVM hosts
      exec/memory: Expose memory_region_access_valid()
      hw/s390x/pv: Restrict Protected Virtualization to sysemu
      target/s390x/tcg/misc_helper: Remove unused "memory.h" include
      target/s390x/tcg/excp_helper: Restrict system headers to sysemu
      target/s390x: Restrict sysemu/reset.h to system emulation

Thomas Huth (4):
      MAINTAINERS: Add MIPS-related docs and configs to the MIPS architecture section
      i386: Deprecate the -no-hpet QEMU command line option
      docs/interop: Change the vnc-ledstate-Pseudo-encoding doc into .rst
      .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

 docs/about/deprecated.rst                          |  6 ++++
 docs/interop/index.rst                             |  1 +
 ...coding.txt => vnc-ledstate-pseudo-encoding.rst} |  0
 include/exec/memory-internal.h                     |  4 ---
 include/exec/memory.h                              |  4 +++
 include/qemu/osdep.h                               |  8 ++++-
 block/file-posix.c                                 | 37 ++++++++++------------
 chardev/char-fd.c                                  |  2 +-
 chardev/char-pipe.c                                |  8 +++--
 chardev/char-pty.c                                 |  4 +--
 hw/9pfs/9p-local.c                                 |  8 ++---
 hw/s390x/s390-pci-inst.c                           |  2 +-
 net/l2tpv3.c                                       | 17 +++-------
 net/socket.c                                       | 16 ++++------
 net/tap-bsd.c                                      |  6 ++--
 net/tap-linux.c                                    |  2 +-
 net/tap-solaris.c                                  |  8 ++---
 net/tap.c                                          | 10 ++----
 os-posix.c                                         |  2 +-
 qga/commands-posix.c                               |  4 +--
 semihosting/syscalls.c                             |  4 +--
 softmmu/vl.c                                       |  1 +
 target/s390x/cpu.c                                 |  4 ++-
 target/s390x/cpu_features.c                        |  4 +++
 target/s390x/cpu_models.c                          |  4 ++-
 target/s390x/tcg/excp_helper.c                     |  8 ++---
 target/s390x/tcg/misc_helper.c                     |  1 -
 tests/qtest/libqtest.c                             |  6 ++--
 tests/qtest/readconfig-test.c                      |  6 ++--
 tests/vhost-user-bridge.c                          |  4 +--
 util/main-loop.c                                   |  4 +--
 util/osdep.c                                       |  4 +--
 util/vfio-helpers.c                                | 12 +++----
 .gitlab-ci.d/windows.yml                           |  3 +-
 MAINTAINERS                                        |  2 ++
 qemu-options.hx                                    |  2 +-
 scripts/meson-buildoptions.sh                      | 18 +++++++----
 tests/qemu-iotests/tests/stream-under-throttle     |  2 ++
 tests/vm/basevm.py                                 |  3 +-
 39 files changed, 120 insertions(+), 121 deletions(-)
 rename docs/interop/{vnc-ledstate-Pseudo-encoding.txt => vnc-ledstate-pseudo-encoding.rst} (100%)


Re: [PULL 00/15] First batch of s390x, qtests and misc fixes in 2023
Posted by Peter Maydell 1 year, 4 months ago
On Fri, 6 Jan 2023 at 08:29, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter!
>
> The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:
>
>   .gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/thuth/qemu.git tags/pull-request-2023-01-06
>
> for you to fetch changes up to 975f619662a46cb5dc7a3b17b84a1b540fb7df5c:
>
>   .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job (2023-01-05 21:50:21 +0100)
>
> ----------------------------------------------------------------
> * s390x header clean-ups from Philippe
> * Rework and improvements of the EINTR handling by Nikita
> * Deprecate the -no-hpet command line option
> * Disable the qtests in the 32-bit Windows CI job again
> * Some other misc fixes here and there

Hi -- this produces new warnings during 'make check' on the bios-tables-test:

qemu-system-i386: -no-hpet: warning: -no-hpet is deprecated, use
'-machine hpet=off' instead

If we're deprecating that option, can we update the test suite
to not use it, please ?

thanks
-- PMM
Re: [PULL 00/15] First batch of s390x, qtests and misc fixes in 2023
Posted by Thomas Huth 1 year, 4 months ago
On 07/01/2023 15.25, Peter Maydell wrote:
> On Fri, 6 Jan 2023 at 08:29, Thomas Huth <thuth@redhat.com> wrote:
>>
>>   Hi Peter!
>>
>> The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:
>>
>>    .gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/thuth/qemu.git tags/pull-request-2023-01-06
>>
>> for you to fetch changes up to 975f619662a46cb5dc7a3b17b84a1b540fb7df5c:
>>
>>    .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job (2023-01-05 21:50:21 +0100)
>>
>> ----------------------------------------------------------------
>> * s390x header clean-ups from Philippe
>> * Rework and improvements of the EINTR handling by Nikita
>> * Deprecate the -no-hpet command line option
>> * Disable the qtests in the 32-bit Windows CI job again
>> * Some other misc fixes here and there
> 
> Hi -- this produces new warnings during 'make check' on the bios-tables-test:
> 
> qemu-system-i386: -no-hpet: warning: -no-hpet is deprecated, use
> '-machine hpet=off' instead
> 
> If we're deprecating that option, can we update the test suite
> to not use it, please ?

Oh, looks like these warnings now only show up in meson-logs/testlog.txt and 
not in the standard output anymore as they did in the past? ... that's why I 
didn't notice this.

Thanks for the hint, I'll write a patch to fix it.

Do you want me then to respin the pull request with the patch included?

  Thomas
Re: [PULL 00/15] First batch of s390x, qtests and misc fixes in 2023
Posted by Peter Maydell 1 year, 4 months ago
On Mon, 9 Jan 2023 at 07:50, Thomas Huth <thuth@redhat.com> wrote:
>
> On 07/01/2023 15.25, Peter Maydell wrote:
> > On Fri, 6 Jan 2023 at 08:29, Thomas Huth <thuth@redhat.com> wrote:
> >>
> >>   Hi Peter!
> >>
> >> The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:
> >>
> >>    .gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)
> >>
> >> are available in the Git repository at:
> >>
> >>    https://gitlab.com/thuth/qemu.git tags/pull-request-2023-01-06
> >>
> >> for you to fetch changes up to 975f619662a46cb5dc7a3b17b84a1b540fb7df5c:
> >>
> >>    .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job (2023-01-05 21:50:21 +0100)
> >>
> >> ----------------------------------------------------------------
> >> * s390x header clean-ups from Philippe
> >> * Rework and improvements of the EINTR handling by Nikita
> >> * Deprecate the -no-hpet command line option
> >> * Disable the qtests in the 32-bit Windows CI job again
> >> * Some other misc fixes here and there
> >
> > Hi -- this produces new warnings during 'make check' on the bios-tables-test:
> >
> > qemu-system-i386: -no-hpet: warning: -no-hpet is deprecated, use
> > '-machine hpet=off' instead
> >
> > If we're deprecating that option, can we update the test suite
> > to not use it, please ?
>
> Oh, looks like these warnings now only show up in meson-logs/testlog.txt and
> not in the standard output anymore as they did in the past? ... that's why I
> didn't notice this.
>
> Thanks for the hint, I'll write a patch to fix it.
>
> Do you want me then to respin the pull request with the patch included?

Yes, please.

thanks
-- PMM