tests/qemu-iotests/262: Check for availability of "blkverify" first

[PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first

Thomas Huth posted 1 patch 1 year, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230104112850.261480-1-thuth@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

tests/qemu-iotests/262 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first

Posted by Thomas Huth 1 year, 3 months ago

In downstream RHEL builds, we do not have "blkverify" enabled, so
iotest 262 is currently failing there. Thus let's list "blkverify"
as required item so that the test properly gets skipped instead if
"blkverify" is missing.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qemu-iotests/262 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/262 b/tests/qemu-iotests/262
index 2294fd5ecb..a4a92de45a 100755
--- a/tests/qemu-iotests/262
+++ b/tests/qemu-iotests/262
@@ -25,7 +25,8 @@ import iotests
 import os
 
 iotests.script_initialize(supported_fmts=['qcow2'],
-                          supported_platforms=['linux'])
+                          supported_platforms=['linux'],
+                          required_fmts=['blkverify'])
 
 with iotests.FilePath('img') as img_path, \
      iotests.FilePath('mig_fifo') as fifo, \
-- 
2.31.1

Re: [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first

Posted by Kevin Wolf 1 year, 3 months ago

Am 04.01.2023 um 12:28 hat Thomas Huth geschrieben:
> In downstream RHEL builds, we do not have "blkverify" enabled, so
> iotest 262 is currently failing there. Thus let's list "blkverify"
> as required item so that the test properly gets skipped instead if
> "blkverify" is missing.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [PATCH] tests/qemu-iotests/262: Check for availability of "blkverify" first

Posted by Philippe Mathieu-Daudé 1 year, 3 months ago

On 4/1/23 12:28, Thomas Huth wrote:
> In downstream RHEL builds, we do not have "blkverify" enabled, so
> iotest 262 is currently failing there. Thus let's list "blkverify"
> as required item so that the test properly gets skipped instead if
> "blkverify" is missing.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qemu-iotests/262 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>