[v1] hw/arm/virt: Handle HVF in finalize_gic_version()

[PATCH 0/2] hw/arm/virt: Handle HVF in finalize_gic_version()

Alexander Graf posted 2 patches 1 year, 4 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221220230414.47876-1-agraf@csgraf.de

Maintainers: Peter Maydell <peter.maydell@linaro.org>

There is a newer version of this series

hw/arm/virt.c         | 199 ++++++++++++++++++++++--------------------
include/hw/arm/virt.h |  12 +--
2 files changed, 110 insertions(+), 101 deletions(-)

Expand all Fold all

[PATCH 0/2] hw/arm/virt: Handle HVF in finalize_gic_version()

Posted by Alexander Graf 1 year, 4 months ago

The finalize_gic_version() function tries to determine which GIC version
the current accelerator / host combination supports. During the initial
HVF porting efforts, I didn't realize that I also had to touch this
function. Then Zenghui brought up this function as reply to my HVF GICv3
enablement patch - and boy it is a mess.

This patch set cleans up all of the GIC finalization so that we can
easily plug HVF in and also hopefully will have a better time extending
it in the future. As second step, it explicitly adds HVF support and
fails loudly for any unsupported accelerators.

Alex

Alexander Graf (2):
  hw/arm/virt: Consolidate GIC finalize logic
  hw/arm/virt: Make accels in GIC finalize logic explicit

 hw/arm/virt.c         | 199 ++++++++++++++++++++++--------------------
 include/hw/arm/virt.h |  12 +--
 2 files changed, 110 insertions(+), 101 deletions(-)

-- 
2.37.1 (Apple Git-137.1)

Re: [PATCH 0/2] hw/arm/virt: Handle HVF in finalize_gic_version()

Posted by Zenghui Yu via 1 year, 4 months ago

[ +Eric who wrote finalize_gic_version() ]

On 2022/12/21 7:04, Alexander Graf wrote:
> The finalize_gic_version() function tries to determine which GIC version
> the current accelerator / host combination supports. During the initial
> HVF porting efforts, I didn't realize that I also had to touch this
> function. Then Zenghui brought up this function as reply to my HVF GICv3
> enablement patch - and boy it is a mess.
> 
> This patch set cleans up all of the GIC finalization so that we can
> easily plug HVF in and also hopefully will have a better time extending
> it in the future. As second step, it explicitly adds HVF support and
> fails loudly for any unsupported accelerators.
> 
> Alex
> 
> Alexander Graf (2):
>   hw/arm/virt: Consolidate GIC finalize logic
>   hw/arm/virt: Make accels in GIC finalize logic explicit
> 
>  hw/arm/virt.c         | 199 ++++++++++++++++++++++--------------------
>  include/hw/arm/virt.h |  12 +--
>  2 files changed, 110 insertions(+), 101 deletions(-)
>