accel: Silent few -Wmissing-field-initializers warning

[PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning

Philippe Mathieu-Daudé posted 3 patches 1 year, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221220143532.24958-1-philmd@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>

accel/kvm/kvm-all.c | 4 ++--
softmmu/vl.c        | 2 +-
tcg/tcg-common.c    | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

Expand all Fold all

[PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

Silent few -Wmissing-field-initializers warnings enabled by -Wextra.

Philippe Mathieu-Daudé (3):
  tcg: Silent -Wmissing-field-initializers warning
  accel/kvm: Silent -Wmissing-field-initializers warning
  softmmu: Silent -Wmissing-field-initializers warning

 accel/kvm/kvm-all.c | 4 ++--
 softmmu/vl.c        | 2 +-
 tcg/tcg-common.c    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.38.1

Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning

Posted by Daniel P. Berrangé 1 year, 4 months ago

On Tue, Dec 20, 2022 at 03:35:29PM +0100, Philippe Mathieu-Daudé wrote:
> Silent few -Wmissing-field-initializers warnings enabled by -Wextra.
> 
> Philippe Mathieu-Daudé (3):
>   tcg: Silent -Wmissing-field-initializers warning
>   accel/kvm: Silent -Wmissing-field-initializers warning
>   softmmu: Silent -Wmissing-field-initializers warning
> 
>  accel/kvm/kvm-all.c | 4 ++--
>  softmmu/vl.c        | 2 +-
>  tcg/tcg-common.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)

If we're going to the trouble of fixing violations (which is
good), then we shouuld also add  -Wmissing-field-initializers
(or -Wextra) to warn_flags in configure, to prevent regressions
again in future.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH 0/3] accel: Silent few -Wmissing-field-initializers warning

Posted by Philippe Mathieu-Daudé 1 year, 4 months ago

On 20/12/22 15:42, Daniel P. Berrangé wrote:
> On Tue, Dec 20, 2022 at 03:35:29PM +0100, Philippe Mathieu-Daudé wrote:
>> Silent few -Wmissing-field-initializers warnings enabled by -Wextra.
>>
>> Philippe Mathieu-Daudé (3):
>>    tcg: Silent -Wmissing-field-initializers warning
>>    accel/kvm: Silent -Wmissing-field-initializers warning
>>    softmmu: Silent -Wmissing-field-initializers warning
>>
>>   accel/kvm/kvm-all.c | 4 ++--
>>   softmmu/vl.c        | 2 +-
>>   tcg/tcg-common.c    | 2 +-
>>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> If we're going to the trouble of fixing violations (which is
> good), then we shouuld also add  -Wmissing-field-initializers
> (or -Wextra) to warn_flags in configure, to prevent regressions
> again in future.

Yes, I plan to add it at the end. I choose to split in small
contained series to avoid spamming every maintainers, but this
is actually that trivial that I could have sent as a big one...

Thanks for the review!