From nobody Tue May 14 04:35:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671385872; cv=none; d=zohomail.com; s=zohoarc; b=Q9vz2qSWBaJdzZ8t1yxcahxQN6c6Hu3qygHHMx/wZBgWSH+BW8i4TxyZwRQDkrmUyJOniFCi8MEegmc5NaBcIfu9pS+uj7Jo66mHz9ZPNfmT6wqjEKPCCpbrRdiPdgUE53lEoSpZmkteDNcb2K0+WXbh3EAL8w+HMDxEZW0c56s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671385872; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ChM3sc+CzkwOQP5vDmtYYgkxWLAHmyAWfx0/hRvgZJM=; b=BVT/kqGKsCqLGc3Rt5m1W93bdh0ml74Oif4rSGBAjijzgBvFzBV3ivr7d7zMIlztzFg1SzAM+iuaccoV0FqFDb4VPsi7QHQUVffdA61kn1hI+A/EN6Y3bk3tcSmeHk/C/TyhPqYi7aV+1040gvve/kqlpS341KIrGtkAO6s8VnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671385872655257.058020744803; Sun, 18 Dec 2022 09:51:12 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6xoA-0007R3-IK; Sun, 18 Dec 2022 12:50:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6xo8-0007Q7-SJ for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:50:40 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6xo7-0000L4-BU for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:50:40 -0500 Received: by mail-pl1-x629.google.com with SMTP id a9so6983527pld.7 for ; Sun, 18 Dec 2022 09:50:38 -0800 (PST) Received: from stoup.. ([2602:47:d48c:8101:3808:f064:41b8:eb9e]) by smtp.gmail.com with ESMTPSA id n9-20020a170902d2c900b00176b84eb29asm5318837plc.301.2022.12.18.09.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 09:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ChM3sc+CzkwOQP5vDmtYYgkxWLAHmyAWfx0/hRvgZJM=; b=aUTDnrC1x//mLA6hkNfbMg8ksldr4oU22bQtO0rpFjQKuWxfHvchU8EkjAU958j1oR 0NSP3F9MrVaCV04v2F09lG198oOz3pMAjBrIeHs/ZmQUnwiQQkEt2nbP1bNWCHzo/fHm ghxnNqkI5IQXnhHdQY6RIjf2geIzfggR/7WdKWP2neD1rsIV0YKoN+zcpwOcY4vlFyhb HKQrWnlJUBSgrRDAhukIYLRigo3KB9zG0GRJvdbCl6LcUJUF5DAANcRsjusWwMHR3qQQ FghiZRdF8JHsqbKfHsL1nFQAbaDI2cbKBqZ3w+Vn/hgyTvgd8/gSgNYeGSaJjGyKYRHo bnZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ChM3sc+CzkwOQP5vDmtYYgkxWLAHmyAWfx0/hRvgZJM=; b=wyzGZ2cZXDeY70D7rT3/VCLe54IpL2B7t4eitjMENIi6Z3FDklW5Ht8Age3LWxYR5X NCfRJATXFAEjrOgSihnB0n2rM+d9GAx14mw6x6Y5nMEZgN+BRLr9PKGUzUwTAvbbRAOe t+2vbGOOUvULCD1vTttbtgSTisyuLLP77yoxnir5oFUEYManXYLRjtxEV9WxJcudknjf F0LSbaVwOXA6nubxso3m/bBvaKRC9fw+oaJehqNNpl4zGzJtBrlaHKhBYEmKiM3aEgRA ZoC4QumI5bAFucytSr/3r5b2PBnOYhD+Vq5XNMy4ddiFabWBITv46biIwcxKhuL0/od1 AASg== X-Gm-Message-State: ANoB5pmOHuoc8YX1Vo17yOVchYBADZMX1yOHdwHgnx2gpXMbMHYkQEjE 9mJckV8uyFeIqR0poG2rzmlLN3Vu3VQV5Lbu X-Google-Smtp-Source: AA0mqf6W6ACqOi1fhN2yePBqFUx9GVW+mqnwz04lLSjlZi/GviyF+6fwohhxrOT/azgL6gTB0ft6zA== X-Received: by 2002:a17:903:2481:b0:189:b0ff:e316 with SMTP id p1-20020a170903248100b00189b0ffe316mr37262655plw.38.1671385837906; Sun, 18 Dec 2022 09:50:37 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Guenter Roeck , qemu-stable@nongnu.org Subject: [PULL 1/2] target/sh4: Mask restore of env->flags from tb->flags Date: Sun, 18 Dec 2022 09:50:34 -0800 Message-Id: <20221218175035.449904-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221218175035.449904-1-richard.henderson@linaro.org> References: <20221218175035.449904-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671385873486100005 Content-Type: text/plain; charset="utf-8" From: Guenter Roeck The values in env->flags are a subset of tb->flags. Restore only the bits that belong. Cc: qemu-stable@nongnu.org Fixes: ab419fd8a035 ("target/sh4: Fix TB_FLAG_UNALIGN") Signed-off-by: Guenter Roeck Message-ID: <20221212011345.GA2235238@roeck-us.net> [rth: Reduce to only the the superh_cpu_synchronize_from_tb change] Signed-off-by: Richard Henderson --- target/sh4/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index 951eb6b9c8..f0934b20fa 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -47,7 +47,7 @@ static void superh_cpu_synchronize_from_tb(CPUState *cs, SuperHCPU *cpu =3D SUPERH_CPU(cs); =20 cpu->env.pc =3D tb_pc(tb); - cpu->env.flags =3D tb->flags; + cpu->env.flags =3D tb->flags & TB_FLAG_ENVFLAGS_MASK; } =20 static void superh_restore_state_to_opc(CPUState *cs, --=20 2.34.1 From nobody Tue May 14 04:35:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1671385885; cv=none; d=zohomail.com; s=zohoarc; b=HHhsXtRUokYfwpHt/Q96MzTy4oBNZ8iTQ5K37R18JSrDe4u77a+uRKKrwRDxbU6Pf+4hYWx3UlAxl/taW1aruT915r3dP+ZgFbgm2tG2eu87qIXMmLVq8IOo25gxWFJOllTcS+CF7ifv8w7GXK2wS+ZhEyotsqXglnIxVtI8O2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671385885; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h5VmXk62ylG0x2kw8eeCrfeTg9zdaLaKYI3gkMyaAsI=; b=etvM0OVRSDHRrkAiGCED6n1Hf3z+zwRt40rs9nuXBxT0k3GsSENh0l1VpbhxDTlVrrewP3J5NJj6e2cwHo3MvJijpVdMhka+Kk+HMEQSDfWEAcJsZ1CkRAC8UbflYxevtQ0jvEmLEBq7+D+GwDXAb4qrBdBjQ9iitQWUh5sIS5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1671385885250837.7402537836123; Sun, 18 Dec 2022 09:51:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6xoB-0007SM-Jo; Sun, 18 Dec 2022 12:50:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6xoA-0007Qt-Ba for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:50:42 -0500 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6xo8-0000Lm-5B for qemu-devel@nongnu.org; Sun, 18 Dec 2022 12:50:42 -0500 Received: by mail-pl1-x62f.google.com with SMTP id d3so6967099plr.10 for ; Sun, 18 Dec 2022 09:50:39 -0800 (PST) Received: from stoup.. ([2602:47:d48c:8101:3808:f064:41b8:eb9e]) by smtp.gmail.com with ESMTPSA id n9-20020a170902d2c900b00176b84eb29asm5318837plc.301.2022.12.18.09.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 09:50:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h5VmXk62ylG0x2kw8eeCrfeTg9zdaLaKYI3gkMyaAsI=; b=u+Oeh66MXglvKNCFiCuNaeItHcCiSCE+MSZwJzwZjAqqJdgnKTmFJOYQ3RBPVUJuxg 57sv2CXliYcJlr0U6Zpy+JVwSPalANH2JhAqk/eY0pYdAjQQLaUv6L43/z5IY4idMeK/ xSvTWjWKw2PCELAbCOVLxq9iddGG38F9ThIf4fN/Wrsve8VoKkAQVpRcWQWxWFrrlZAE fifCnYsQDI/asdE9Wtt+3fQukXaGbb0nXSikT5Vjlryy5qNOmNg7YDHt2giD/oSMf9Dd nm6gawvHU9q+PVzCSiI1R2AZSyUzlkxg7ZkHzPCHmKA1TtFTDs4Qa31Q6u9YheYYkdwm rwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h5VmXk62ylG0x2kw8eeCrfeTg9zdaLaKYI3gkMyaAsI=; b=VAc60Uo9+yiUFiSqtAF9Klz3vFzufLuMjnHVYz3xEnPb6L/Wd7OyGHmEcXAWwVhElI X+oVGNzj3uXeWoJOlk5XMXO53g6y8YZm6LMI/3cEpLQiJ2BfTlTw3f+L9I+50UsXyc2Y F70V0RX9+ckOY6dAww2TJK3ftseegVqxDfmfngbd+qaAwwDE9KNVIUmJI6t+a4eRDRyn pw85UCUXXjwvKj5IzWP3QQ7i1d6Sa6FdSriKesni9rSsiagOKbuEMUMKXqV611/9Y9Nz ZQcvo1PNPdiQFy6u0w2Vp3aE+ps8lKy4fwRSc051lrRX0fuT0ztDFepbM03wDuynRfiy 6JjA== X-Gm-Message-State: ANoB5plQFicDYJzgfut+FKtiKQ0LUEykH1TgJGt75w7ju7j1M9+z72ry vuxa4dkLswfaow4VMFqR1nk00DD4rjm5nWMy X-Google-Smtp-Source: AA0mqf5ht5LTPHfNxQB/9183Uk0u7hm8dKfwvwZ5x1bu0v9/GlW1sXkkBNVF3yAI9Y90lWuuLHQS9w== X-Received: by 2002:a17:903:264b:b0:189:ec62:3b2d with SMTP id je11-20020a170903264b00b00189ec623b2dmr42081235plb.4.1671385838887; Sun, 18 Dec 2022 09:50:38 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 2/2] target/tricore: Fix gdbstub write to address registers Date: Sun, 18 Dec 2022 09:50:35 -0800 Message-Id: <20221218175035.449904-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221218175035.449904-1-richard.henderson@linaro.org> References: <20221218175035.449904-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62f; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1671385887568100003 Typo had double-writes to data registers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1363 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- target/tricore/gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/tricore/gdbstub.c b/target/tricore/gdbstub.c index ebf32defde..3a27a7e65d 100644 --- a/target/tricore/gdbstub.c +++ b/target/tricore/gdbstub.c @@ -130,7 +130,7 @@ int tricore_cpu_gdb_write_register(CPUState *cs, uint8_= t *mem_buf, int n) if (n < 16) { /* data registers */ env->gpr_d[n] =3D tmp; } else if (n < 32) { /* address registers */ - env->gpr_d[n - 16] =3D tmp; + env->gpr_a[n - 16] =3D tmp; } else { tricore_cpu_gdb_write_csfr(env, n, tmp); } --=20 2.34.1