tests/avocado: add machine:none tag to version.py

[PATCH] tests/avocado: add machine:none tag to version.py

Posted by Fabiano Rosas 3 years, 1 month ago

This test currently fails when run on a host for which the QEMU target
has no default machine set:

ERROR| Output: qemu-system-aarch64: No machine specified, and there is
no default

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/avocado/version.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/avocado/version.py b/tests/avocado/version.py
index ded7f039c1..dd775955eb 100644
--- a/tests/avocado/version.py
+++ b/tests/avocado/version.py
@@ -15,6 +15,7 @@
 class Version(QemuSystemTest):
     """
     :avocado: tags=quick
+    :avocado: tags=machine:none
     """
     def test_qmp_human_info_version(self):
         self.vm.add_args('-nodefaults')
-- 
2.35.3

Re: [PATCH] tests/avocado: add machine:none tag to version.py

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

On 15/12/22 23:47, Fabiano Rosas wrote:
> This test currently fails when run on a host for which the QEMU target
> has no default machine set:
> 
> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
> no default
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   tests/avocado/version.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
> index ded7f039c1..dd775955eb 100644
> --- a/tests/avocado/version.py
> +++ b/tests/avocado/version.py
> @@ -15,6 +15,7 @@
>   class Version(QemuSystemTest):
>       """
>       :avocado: tags=quick
> +    :avocado: tags=machine:none
>       """
>       def test_qmp_human_info_version(self):
>           self.vm.add_args('-nodefaults')

Looking at previous attempt in 
https://lore.kernel.org/qemu-devel/20220104122104.849084-1-alex.bennee@linaro.org/

* tests/avocado/empty_cpu_model.py

   Forced via vm.add_args('-machine', 'none')

   tags=machine:none would be cleaner.

* tests/avocado/info_usernet.py and
* tests/avocado/vnc.py

   -> Fixed by 5104b73824 ("tests/avocado: set -machine none
   for userfwd and vnc tests")

* tests/avocado/version.py

   -> This patch

* tests/avocado/migration.py

   => Missing

Maybe we can squash to this patch?

Meanwhile:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] tests/avocado: add machine:none tag to version.py

Posted by Fabiano Rosas 3 years, 1 month ago

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 15/12/22 23:47, Fabiano Rosas wrote:
>> This test currently fails when run on a host for which the QEMU target
>> has no default machine set:
>> 
>> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
>> no default
>> 
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>>   tests/avocado/version.py | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
>> index ded7f039c1..dd775955eb 100644
>> --- a/tests/avocado/version.py
>> +++ b/tests/avocado/version.py
>> @@ -15,6 +15,7 @@
>>   class Version(QemuSystemTest):
>>       """
>>       :avocado: tags=quick
>> +    :avocado: tags=machine:none
>>       """
>>       def test_qmp_human_info_version(self):
>>           self.vm.add_args('-nodefaults')
>
> Looking at previous attempt in 
> https://lore.kernel.org/qemu-devel/20220104122104.849084-1-alex.bennee@linaro.org/
>
> * tests/avocado/empty_cpu_model.py
>
>    Forced via vm.add_args('-machine', 'none')
>
>    tags=machine:none would be cleaner.
>
> * tests/avocado/info_usernet.py and
> * tests/avocado/vnc.py
>
>    -> Fixed by 5104b73824 ("tests/avocado: set -machine none
>    for userfwd and vnc tests")
>
> * tests/avocado/version.py
>
>    -> This patch
>
> * tests/avocado/migration.py
>
>    => Missing

I think the migration test is a bit harder because the machine type
would probably influnce the test. We would have to find a way to
specificy the different -machine options for each architecture. Or a way
of saying "use default machine, except for arm".

>
> Maybe we can squash to this patch?
>
> Meanwhile:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks

Re: [PATCH] tests/avocado: add machine:none tag to version.py

Posted by Fabiano Rosas 3 years, 1 month ago

Fabiano Rosas <farosas@suse.de> writes:

> This test currently fails when run on a host for which the QEMU target
> has no default machine set:
>
> ERROR| Output: qemu-system-aarch64: No machine specified, and there is
> no default
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  tests/avocado/version.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/avocado/version.py b/tests/avocado/version.py
> index ded7f039c1..dd775955eb 100644
> --- a/tests/avocado/version.py
> +++ b/tests/avocado/version.py
> @@ -15,6 +15,7 @@
>  class Version(QemuSystemTest):
>      """
>      :avocado: tags=quick
> +    :avocado: tags=machine:none
>      """
>      def test_qmp_human_info_version(self):
>          self.vm.add_args('-nodefaults')

Ping