From nobody Sat May 11 21:31:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669045868; cv=none; d=zohomail.com; s=zohoarc; b=BzEEEph5/gfBNhBLTkrLr0EOmpdLCt5Pcf/ScmjmPFky3ENz+PWujmmSI3z9SZGulS3O113ZgNkfGNvCU57qYDF+nEZf+fBgTB8MEhHeilaRIbf3ZT3xza+bUCIJmJNAvns3+W4lx0ZvzgHZrxLqCzaRZ/BCr52djuziUCCiqpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669045868; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KW8qyJw9+BwOequ/igbnYDwU1KGG6p1xzQ1NgHCaNuc=; b=a/IXYePg9GuHUEbOqA12V/1EIDsRSrwQAGH3S3vD+8aqOedZzMIBaqxkgi/kRIqRWxgaUeOqZtEJdkzT1BES+RNmx3G45lFDDyTQbgS5JNSanRZJWRbBKhPwinCT+xklJnhHaaCGcPBVElYHDzRuogxR9oJWt3VwyMhW7HTjxgM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16690458687161008.1114623394309; Mon, 21 Nov 2022 07:51:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox93Y-00009h-3v; Mon, 21 Nov 2022 10:50:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92T-0008CZ-AN for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:48:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92R-00023y-Mq for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:48:53 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-PEbcmzSjM1K75Jo4yDuKEA-1; Mon, 21 Nov 2022 10:48:49 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D71BF85A5B6; Mon, 21 Nov 2022 15:48:48 +0000 (UTC) Received: from localhost (unknown [10.39.195.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B04840C6E13; Mon, 21 Nov 2022 15:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669045730; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KW8qyJw9+BwOequ/igbnYDwU1KGG6p1xzQ1NgHCaNuc=; b=LAjFqRWTKyGk9Gi9/KCqfZHsYnBaHvUvw26NrC0FuJgIY0Gu6tRAmd0K3biTQuIGpD1i6b CVvhbCawT7kPblo9iWTVETd3KFpCs+QfLrZk40C2pws2qH7TcL1/5ZCw6KaaMKRT0O/inO Q+mFfXpXJcXFK5U2S9Xiq5QiEMvGjXI= X-MC-Unique: PEbcmzSjM1K75Jo4yDuKEA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson , Daniel Henrique Barboza , Fam Zheng , David Hildenbrand , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Hanna Reitz , Laurent Vivier , Paolo Bonzini , Greg Kurz , Amit Shah , Jason Wang , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Vaibhav Jain , Kowshik Jois B S , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kowshik Jois B S Subject: [PATCH v3 1/3] target/ppc: Fix build warnings when building with 'disable-tcg' Date: Mon, 21 Nov 2022 10:48:31 -0500 Message-Id: <20221121154833.1914768-2-stefanha@redhat.com> In-Reply-To: <20221121154833.1914768-1-stefanha@redhat.com> References: <20221121154833.1914768-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669045869557100009 From: Vaibhav Jain Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu' target is failing due to following build warnings: ../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' define= d but not used [-Werror=3Dunused-function] 7018 | static void ppc_restore_state_to_opc(CPUState *cs, Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so th= at they are only defined if qemu is compiled with '--enable-tcg' Reported-by: Kowshik Jois B S Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc") Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk") Fixes: 53ae2aeb94 ("target/ppc: Implement hashstp and hashchkp") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319 Signed-off-by: Vaibhav Jain Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Kowshik Jois B S Message-Id: <20221116131743.658708-1-vaibhav@linux.ibm.com> Signed-off-by: Daniel Henrique Barboza --- target/ppc/cpu_init.c | 2 ++ target/ppc/excp_helper.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 32e94153d1..cbf0081374 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7015,6 +7015,7 @@ static vaddr ppc_cpu_get_pc(CPUState *cs) return cpu->env.nip; } =20 +#ifdef CONFIG_TCG static void ppc_restore_state_to_opc(CPUState *cs, const TranslationBlock *tb, const uint64_t *data) @@ -7023,6 +7024,7 @@ static void ppc_restore_state_to_opc(CPUState *cs, =20 cpu->env.nip =3D data[0]; } +#endif /* CONFIG_TCG */ =20 static bool ppc_cpu_has_work(CPUState *cs) { diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index a05a2ed595..94adcb766b 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -2842,6 +2842,7 @@ void helper_td(CPUPPCState *env, target_ulong arg1, t= arget_ulong arg2, #endif #endif =20 +#ifdef CONFIG_TCG static uint32_t helper_SIMON_LIKE_32_64(uint32_t x, uint64_t key, uint32_t= lane) { const uint16_t c =3D 0xfffc; @@ -2924,6 +2925,7 @@ HELPER_HASH(HASHST, env->spr[SPR_HASHKEYR], true) HELPER_HASH(HASHCHK, env->spr[SPR_HASHKEYR], false) HELPER_HASH(HASHSTP, env->spr[SPR_HASHPKEYR], true) HELPER_HASH(HASHCHKP, env->spr[SPR_HASHPKEYR], false) +#endif /* CONFIG_TCG */ =20 #if !defined(CONFIG_USER_ONLY) =20 --=20 2.38.1 From nobody Sat May 11 21:31:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669045865; cv=none; d=zohomail.com; s=zohoarc; b=da4T5CzxBbjxKFBRn359g7qivPtg50n28NF7oKdQ78ZgKLnTt7brsVWo/FqRn62Ic7MC/xZx/tWuCfnL0G7V9QV7+cubh2tUyKCME8PPON9AI3u0BOEcNumBY0SRknGWv3wvRScA5g+U/kXmQ7VuFlOqpCtZhLNaM5IqI/MgHQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669045865; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GbXxy3/v2uvLVjEq5DdIOJGY/XwsjiRfYT55l8YARbY=; b=EppfnawB0X9xE6pECQC1atXIPTYEoSC5KC6bhma6EaJQyWbqNLRo7O2WEioHEdMUKfwl2rkKaAslv2wNbLyOaEtBELoWOd30Ni8KQG8vs0nvWPB6yb/okSvmWQh8BnsuBiMWSZhXJj3ogRkt1wZA7znmJm/PQeDaozW8wjxw4Ek= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1669045865693713.0965763227429; Mon, 21 Nov 2022 07:51:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox93w-0000AD-Nz; Mon, 21 Nov 2022 10:50:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92i-0008GL-Oz for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:49:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92g-000254-VV for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:49:08 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-VLZ3QA-BM96INDXpAwzdcw-1; Mon, 21 Nov 2022 10:48:53 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 88730886066; Mon, 21 Nov 2022 15:48:52 +0000 (UTC) Received: from localhost (unknown [10.39.195.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9BAF17582; Mon, 21 Nov 2022 15:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669045737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GbXxy3/v2uvLVjEq5DdIOJGY/XwsjiRfYT55l8YARbY=; b=iKmRkQoF8Ygecm9pBIsgBm5p61Sju0VyBGIGVh0Zv04dn1LoRicUdQO+kH9iYz6l8bzhx3 CR18N7FvHh1qVoDNnR4+NwT13SYGr0qrV65v8Ed4OMVsUur5xzMgE4GGTidC9cw3ksFr99 3X5VkgostWcYDBEquyscCdnh6SvneLE= X-MC-Unique: VLZ3QA-BM96INDXpAwzdcw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson , Daniel Henrique Barboza , Fam Zheng , David Hildenbrand , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Hanna Reitz , Laurent Vivier , Paolo Bonzini , Greg Kurz , Amit Shah , Jason Wang , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cornelia Huck Subject: [PATCH v3 2/3] virtio: document ->host_features usage in vdc->get_features() callback Date: Mon, 21 Nov 2022 10:48:32 -0500 Message-Id: <20221121154833.1914768-3-stefanha@redhat.com> In-Reply-To: <20221121154833.1914768-1-stefanha@redhat.com> References: <20221121154833.1914768-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669045867655100003 Content-Type: text/plain; charset="utf-8" Suggested-by: Cornelia Huck Signed-off-by: Stefan Hajnoczi --- include/hw/virtio/virtio.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index a973811cbf..b6e09c6d4b 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -138,9 +138,16 @@ struct VirtioDeviceClass { /* This is what a VirtioDevice must implement */ DeviceRealize realize; DeviceUnrealize unrealize; + + /* + * Called with vdev->host_features in requested_features. Returns devi= ce + * feature bits to be stored in vdev->host_features after factoring in + * device-specific feature bits. + */ uint64_t (*get_features)(VirtIODevice *vdev, uint64_t requested_features, Error **errp); + uint64_t (*bad_features)(VirtIODevice *vdev); void (*set_features)(VirtIODevice *vdev, uint64_t val); int (*validate_features)(VirtIODevice *vdev); --=20 2.38.1 From nobody Sat May 11 21:31:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1669045868; cv=none; d=zohomail.com; s=zohoarc; b=b6TeOuDKhPlDCVlBJhnKxgKfvh7ZNzzFZVMzV4ks+DdFWDZb1g0q7Vu9pH+TjRALeTJ+bSCpiHbhoy11GqkEOzb5w35KUtLdZvnkbDnqsdsUr4PdAonfa7CsARArYK8x+T/qObHogQZaMJDDg00rx0WTGuKtzlXFfWG6dW4LPgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1669045868; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=11mQA/05+pSppc252k7+Qv9UxlTrd3BcJ4pTHErcORk=; b=BPCcxVWf7aG+GAymP4kILbLNDAqVivVfvQxRaPawi24JNELsclu1yqkd47J2RPhMSu/CO32p2yYCqSiLrtwqKx4OjrNK+d9Vvja1SLNobP8AFE7OdZxjyWq7OUK3ue/RAvW1MZ2zvpHVaxuBmB6R4tfZZNOUyEyjGXFbc4nFHNo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166904586805751.33094288830614; Mon, 21 Nov 2022 07:51:08 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ox94I-0000Nb-L4; Mon, 21 Nov 2022 10:50:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92o-0008H8-8b for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:49:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ox92h-00025Y-DF for qemu-devel@nongnu.org; Mon, 21 Nov 2022 10:49:10 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-64-ndC_SXfoOXOdFLR1FfqllA-1; Mon, 21 Nov 2022 10:48:55 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 05460803533; Mon, 21 Nov 2022 15:48:55 +0000 (UTC) Received: from localhost (unknown [10.39.195.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6008940C83AA; Mon, 21 Nov 2022 15:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669045739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=11mQA/05+pSppc252k7+Qv9UxlTrd3BcJ4pTHErcORk=; b=ZvBvVvjwDWIfq1CFanfOwMhFLSVmfewb56piVLU55oNDy0UhdCfnHssr6A1Ql1I7oqDHjb OfN1A0p7LUKmJbgRaGREcoi9IsomLtYijborL+nCnKEIQkvhqCVDzsJZ4NU31L1oTjjng1 xFW7W6B5/ZDlHoqCp1eH0ACLYnrfyCo= X-MC-Unique: ndC_SXfoOXOdFLR1FfqllA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, "Michael S . Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , David Gibson , Daniel Henrique Barboza , Fam Zheng , David Hildenbrand , Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, Hanna Reitz , Laurent Vivier , Paolo Bonzini , Greg Kurz , Amit Shah , Jason Wang , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Cornelia Huck Subject: [PATCH v3 3/3] virtio: remove unnecessary host_features in ->get_features() Date: Mon, 21 Nov 2022 10:48:33 -0500 Message-Id: <20221121154833.1914768-4-stefanha@redhat.com> In-Reply-To: <20221121154833.1914768-1-stefanha@redhat.com> References: <20221121154833.1914768-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1669045869568100010 Content-Type: text/plain; charset="utf-8" Since at least commit 6b8f1020540c27246277377aa2c3331ad2bfb160 ("virtio: move host_features") the ->get_features() function has been called with host_features as an argument. Some devices manually add host_features in ->get_features() although the features argument already contains host_features. Make all devices consistent by dropping the unnecessary code. Cc: Cornelia Huck Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 3 --- hw/char/virtio-serial-bus.c | 1 - hw/net/virtio-net.c | 3 --- hw/scsi/vhost-scsi-common.c | 3 --- hw/scsi/virtio-scsi.c | 4 ---- hw/virtio/virtio-balloon.c | 2 -- 6 files changed, 16 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index f717550fdc..a744012fec 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/virtio-blk.c @@ -983,9 +983,6 @@ static uint64_t virtio_blk_get_features(VirtIODevice *v= dev, uint64_t features, { VirtIOBlock *s =3D VIRTIO_BLK(vdev); =20 - /* Firstly sync all virtio-blk possible supported features */ - features |=3D s->host_features; - virtio_add_feature(&features, VIRTIO_BLK_F_SEG_MAX); virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY); virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY); diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 7d4601cb5d..1414fb85ae 100644 --- a/hw/char/virtio-serial-bus.c +++ b/hw/char/virtio-serial-bus.c @@ -557,7 +557,6 @@ static uint64_t get_features(VirtIODevice *vdev, uint64= _t features, =20 vser =3D VIRTIO_SERIAL(vdev); =20 - features |=3D vser->host_features; if (vser->bus.max_nr_ports > 1) { virtio_add_feature(&features, VIRTIO_CONSOLE_F_MULTIPORT); } diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index aba12759d5..35b45eb6e3 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -777,9 +777,6 @@ static uint64_t virtio_net_get_features(VirtIODevice *v= dev, uint64_t features, VirtIONet *n =3D VIRTIO_NET(vdev); NetClientState *nc =3D qemu_get_queue(n->nic); =20 - /* Firstly sync all virtio-net possible supported features */ - features |=3D n->host_features; - virtio_add_feature(&features, VIRTIO_NET_F_MAC); =20 if (!peer_has_vnet_hdr(n)) { diff --git a/hw/scsi/vhost-scsi-common.c b/hw/scsi/vhost-scsi-common.c index 767f827e55..8b26f90aa1 100644 --- a/hw/scsi/vhost-scsi-common.c +++ b/hw/scsi/vhost-scsi-common.c @@ -124,9 +124,6 @@ uint64_t vhost_scsi_common_get_features(VirtIODevice *v= dev, uint64_t features, { VHostSCSICommon *vsc =3D VHOST_SCSI_COMMON(vdev); =20 - /* Turn on predefined features supported by this device */ - features |=3D vsc->host_features; - return vhost_get_features(&vsc->dev, vsc->feature_bits, features); } =20 diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6f6e2e32ba..40e10322fb 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -817,10 +817,6 @@ static uint64_t virtio_scsi_get_features(VirtIODevice = *vdev, uint64_t requested_features, Error **errp) { - VirtIOSCSI *s =3D VIRTIO_SCSI(vdev); - - /* Firstly sync all virtio-scsi possible supported features */ - requested_features |=3D s->host_features; return requested_features; } =20 diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 73ac5eb675..0e9ca71b15 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -796,8 +796,6 @@ static void virtio_balloon_set_config(VirtIODevice *vde= v, static uint64_t virtio_balloon_get_features(VirtIODevice *vdev, uint64_t f, Error **errp) { - VirtIOBalloon *dev =3D VIRTIO_BALLOON(vdev); - f |=3D dev->host_features; virtio_add_feature(&f, VIRTIO_BALLOON_F_STATS_VQ); =20 return f; --=20 2.38.1