hw/loongarch: Fix setprop_sized method in fdt rtc node.

[PATCH] hw/loongarch: Fix setprop_sized method in fdt rtc node.

Xiaojuan Yang posted 1 patch 1 year, 5 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221116040300.3459818-1-yangxiaojuan@loongson.cn

Maintainers: Xiaojuan Yang <yangxiaojuan@loongson.cn>, Song Gao <gaosong@loongson.cn>

hw/loongarch/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/loongarch: Fix setprop_sized method in fdt rtc node.

Posted by Xiaojuan Yang 1 year, 5 months ago

Fix setprop_sized method in fdt rtc node.

Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
---
 hw/loongarch/virt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
index b9c18ee517..958be74fa1 100644
--- a/hw/loongarch/virt.c
+++ b/hw/loongarch/virt.c
@@ -53,7 +53,7 @@ static void fdt_add_rtc_node(LoongArchMachineState *lams)
     nodename = g_strdup_printf("/rtc@%" PRIx64, base);
     qemu_fdt_add_subnode(ms->fdt, nodename);
     qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "loongson,ls7a-rtc");
-    qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 0x0, base, size);
+    qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size);
     g_free(nodename);
 }
 
-- 
2.31.1

Re: [PATCH] hw/loongarch: Fix setprop_sized method in fdt rtc node.

Posted by gaosong@loongson.cn 1 year, 5 months ago

在 2022/11/16 12:03, Xiaojuan Yang 写道:
> Fix setprop_sized method in fdt rtc node.
>
> Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
> ---
>   hw/loongarch/virt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Song Gao <gaosong@loongson.cn>

Thanks.
Song Gao
> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
> index b9c18ee517..958be74fa1 100644
> --- a/hw/loongarch/virt.c
> +++ b/hw/loongarch/virt.c
> @@ -53,7 +53,7 @@ static void fdt_add_rtc_node(LoongArchMachineState *lams)
>       nodename = g_strdup_printf("/rtc@%" PRIx64, base);
>       qemu_fdt_add_subnode(ms->fdt, nodename);
>       qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "loongson,ls7a-rtc");
> -    qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 0x0, base, size);
> +    qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, base, 2, size);
>       g_free(nodename);
>   }
>

Re: [PATCH] hw/loongarch: Fix setprop_sized method in fdt rtc node.

Posted by Richard Henderson 1 year, 5 months ago

On 11/15/22 20:03, Xiaojuan Yang wrote:
> Fix setprop_sized method in fdt rtc node.
> 
> Signed-off-by: Xiaojuan Yang<yangxiaojuan@loongson.cn>
> ---
>   hw/loongarch/virt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~