From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519532; cv=none; d=zohomail.com; s=zohoarc; b=MtScsbsui4UsmtZlJ2pwDGkzu8K6WtLd51b9bAXyvjDkG+IubKOft9p69MpbkfFeE/QuvZ0e7y9H5PeNiPmTXdFBnsXDYAGgPFnfCdJbESppqtlbcVt05IC9I8r3CTCOV1UnShtr/wkDEGMgzdG0Hc5LHIrXZVZgGH7mq9U2X/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519532; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D1q/nYWnv7CC9RJOw7+MRs0h1KGh/HdTVV3GAzdd4uM=; b=K3NOHmNdgObXV1cGaIFFbvmfK6dFc1A9KTjTU2yA9Q/vyMOW3woSbFPFsYkGZ59tNMCnSTLJKs5glR5rNqxnySDad9KF16FeK/jBFvNITziGKOo6HRDkyechJBbU/VhkKpZCivvmbgT36vuEqXh7MLrgRJztyyFUh3endL9OuCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519532586976.8506045702629; Tue, 15 Nov 2022 05:38:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6q-0006zE-GL; Tue, 15 Nov 2022 08:36:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5O-0006I3-Lg for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:49 -0500 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5L-0004Ia-W8 for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:46 -0500 Received: by mail-wr1-x429.google.com with SMTP id h9so24317995wrt.0 for ; Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id t67-20020a1c4646000000b003cfa622a18asm21515616wma.3.2022.11.15.05.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:40 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 521EB1FFB8; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D1q/nYWnv7CC9RJOw7+MRs0h1KGh/HdTVV3GAzdd4uM=; b=ye8AjOgVDLjvAN3QziHEMI3XCoTwtN7ulYk9iRWj7PZ+TBZK/y3rfS7GG3syvUSiR1 kyLjJ4T2mVh+yhC8rfTPP5xdtUnZeZ+say91r6PImvoVgxdRCM1FzEo9dOYCJXMpxmYj k7yDpYSeRoGJ4gvNLOhtLQM5MlfcoykLwIDGg/pzU7Kd/DNl2t3D/+3UdD+LQ5Fg9tWB 7i/rZLXNGd4aHxO77g4vPRs2jbyVQlcIxcZHUIpk/SVOEVzfwqWjk2rLIwggbBjF/Brs 6WgwsDVZPPIrJH0rNalApYLxuYENGJUPXcCWDxi4TS/X9jkIUrb+sim9xsPrdyxBMbxs bJzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D1q/nYWnv7CC9RJOw7+MRs0h1KGh/HdTVV3GAzdd4uM=; b=gl0qLoarUeQgd40uId8LhTeztiLRP9wSSVKAPK39Li9kH3hkyiPXCvodQrs/g2wj3O iSeNvWHtGQQdQvhBLfleZ09wiLmUPIaKQsQ01HJBHlAE/4waRQsJ+1dz7AN5CTfpne4L yZk9T5sK8Anow+nCh6wpc5pv56oqgHbcOHAHVmrBrdT9wJpKJK03bAG1I77fepAErK96 J8GmXL+N0cMWSJzISMxftxqUVyFD1qeZAo6Tl5+sMKSnohr5BQLA2/u7Aesuy3smHjlX c8ECWGwnptY5G1EX3VEauUp7Bxg6tzhFGNyk/cRJND33zW0r9U2d7xsLhViOuy7atC+2 gO1w== X-Gm-Message-State: ANoB5pliR4JNwEBewnmWmXtLyXlclkdTb9TRFDDqi4sytwN/0fstwYDb JbE4vRSqDV4onBxg1knVHESBug== X-Google-Smtp-Source: AA0mqf4i+d8yYefomhrCcD6l4a8rLs1UBaUFuuGduqgNseYnP30cbp4vSbpuqdOw5JHxvgPn4DOIGw== X-Received: by 2002:a5d:42c6:0:b0:235:cebf:8a0f with SMTP id t6-20020a5d42c6000000b00235cebf8a0fmr10738827wrr.220.1668519282145; Tue, 15 Nov 2022 05:34:42 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, Stefan Weil , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Thomas Huth , Paolo Bonzini Subject: [PULL 01/10] Run docker probe only if docker or podman are available Date: Tue, 15 Nov 2022 13:34:30 +0000 Message-Id: <20221115133439.2348929-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519533742100003 From: Stefan Weil The docker probe uses "sudo -n" which can cause an e-mail with a security w= arning each time when configure is run. Therefore run docker probe only if either = docker or podman are available. That avoids the problematic "sudo -n" on build environments which have neit= her docker nor podman installed. Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.= mak") Signed-off-by: Stefan Weil Message-Id: <20221030083510.310584-1-sw@weilnetz.de> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth Message-Id: <20221111145529.4020801-2-alex.bennee@linaro.org> diff --git a/configure b/configure index 66928692b0..26c7bc5154 100755 --- a/configure +++ b/configure @@ -1780,7 +1780,7 @@ fi # functions to probe cross compilers =20 container=3D"no" -if test $use_containers =3D "yes"; then +if test $use_containers =3D "yes" && (has "docker" || has "podman"); then case $($python "$source_path"/tests/docker/docker.py probe) in *docker) container=3Ddocker ;; podman) container=3Dpodman ;; --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519344; cv=none; d=zohomail.com; s=zohoarc; b=EFmehDh3JBPX08fQ4NFNCjwJMA+NyC8ftCAy+UwfD4+c3Ms7O9MuBWaH7p5hUx6iNr4076WYj+OWJVXfTBUvlDumwiDnEgkr6n/sSfO+yHWvpDEidWYuYvvdzKY+lLDUH48UeO+VS434ljvGymNJKH5xzwtqUjmef8cw2tpmLvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519344; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Hd677+bfuIhpkyc3PSGbpAuJqC4YjdSOyP8U5M+NGW8=; b=Zdr8TZGgSR1I6R+MeCcirVVB/iK4vjvXutQBQf4TPkS8HP3gPQeM7nntnSKa3kqmzpRgbn+4gDPqIajGwMl00bZCOL5GvMFdvuHvcoq7i4GmWLjIucJOeEB9nkUHlDw0aSvcsg9JjSv3YwTN+wAIRgJ6U/OOc1IW/5yEyEPpgUE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519344146419.69027774589233; Tue, 15 Nov 2022 05:35:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw5y-0006Rf-QQ; Tue, 15 Nov 2022 08:35:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5N-0006HV-LN for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:45 -0500 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5L-0004IV-Nw for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:45 -0500 Received: by mail-wm1-x332.google.com with SMTP id l39-20020a05600c1d2700b003cf93c8156dso10249267wms.4 for ; Tue, 15 Nov 2022 05:34:42 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id bt17-20020a056000081100b0023677e1157fsm12636017wrb.56.2022.11.15.05.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:39 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6CDAE1FFBA; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hd677+bfuIhpkyc3PSGbpAuJqC4YjdSOyP8U5M+NGW8=; b=Io5WJ/Gw51NkOBE3tns9bK4v7JsGaoqxFdxvzkYEPrWxAHc2mqy8DZMe9vROJXqUDo y4MqKzPpB5m0QJQECFh9nJU/yfq31ICmu8gW5wFunPaDh5B53rG4/2q9PpGSlRkyZMcb 2uMm7vwqiv7MBd4JkQASICxgWQ7ZqQwy59jcoNvoitmBSbe+/j8HfbZ2kpq3NwCru3Lz SjATSG5Lr1StiIxa2zeGj9/lpzXZDXmbx/fb6Q5/+MWBCYa0PErS5cbiKWVv0kMv3ece NikSFAp4FqDpYMsWc0rxuY9hG9GGMrjRGo044c3fnD/rC2Ra1LFBNetTUnmgsGjNKbxm TxpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Hd677+bfuIhpkyc3PSGbpAuJqC4YjdSOyP8U5M+NGW8=; b=peswpJ5mK4rQvdywv29WB2TnOgMpJN9v7gmHjsfWlb6WsAseWRVEQfnRIQrrzanwzi yKkJ7L+IK8jrX1J1Wo9W1n53ejKqKy0jmr3kPh8vFgu+mO8XvyRA91HWIdN7ejVjA4Oe EqXKMP+6EJDF7Fd9BoC3hLsI1TsxSJL+1DQzeKLR3dSFh3xZVmzmor4z91fTlxWJs1CB tt96QyhCbvzvPEY5Gx+sJWII9eyX2dSNhIdGeTghGtwWH2Ofq5Mw5PUU+FQjN3pQuOlD su75H5sW9mkOsCio3vOtNdRdJYD3Y3HsDwVmBmHvLZgRDQ5zIYnTPEvuSKw4EfVPkgvF Jr9g== X-Gm-Message-State: ANoB5pnVUvZAkzaG2q9DXIorv7eRUYF5S721K2w4APWlFyD/xVER0StS XOaoXqggx36UYW4l2WMbYkGSOw== X-Google-Smtp-Source: AA0mqf7ucE3+0KIU1AJbwkdCfooB5q1vHKbiE27xlOh52wclbCaLe7PA2YvrDQ83d3TDNkE0Lo5eLw== X-Received: by 2002:a05:600c:5390:b0:3cf:9b4d:ec4f with SMTP id hg16-20020a05600c539000b003cf9b4dec4fmr413974wmb.114.1668519281351; Tue, 15 Nov 2022 05:34:41 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Cleber Rosa , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL 02/10] tests/avocado: improve behaviour waiting for login prompts Date: Tue, 15 Nov 2022 13:34:31 +0000 Message-Id: <20221115133439.2348929-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519346411100007 This attempts to deal with the problem of login prompts not being guaranteed to be terminated with a newline. The solution to this is to peek at the incoming data looking to see if we see an up-coming match before we fall back to the old readline() logic. The reason to mostly rely on readline is because I am occasionally seeing the peek stalling despite data being there. This seems kinda hacky and gross so I'm open to alternative approaches and cleaner python code. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20221111145529.4020801-3-alex.bennee@linaro.org> diff --git a/tests/avocado/avocado_qemu/__init__.py b/tests/avocado/avocado= _qemu/__init__.py index 910f3ba1ea..7469a06804 100644 --- a/tests/avocado/avocado_qemu/__init__.py +++ b/tests/avocado/avocado_qemu/__init__.py @@ -131,6 +131,59 @@ def pick_default_qemu_bin(bin_prefix=3D'qemu-system-',= arch=3DNone): return path return None =20 +def _peek_ahead(console, min_match, success_as_str): + """ + peek ahead in the console stream keeping an eye out for the + success message. Because we are partially peeking into the data + stream we do everything as bytes to avoid partial UTF decode + issues. + + Returns some message to process or None, indicating the normal + readline should occur. + """ + console_logger =3D logging.getLogger('console') + success_message =3D bytes(success_as_str, 'utf-8') + peek_len =3D 0 + retries =3D 0 + + while True: + old_peek_len =3D peek_len + peek_ahead =3D console.peek(min_match) + peek_len =3D len(peek_ahead) + + # if we get stuck too long lets just fallback to readline + if peek_len <=3D old_peek_len: + time.sleep(0.001 * retries) + retries +=3D 1 + if retries > 20: + return None + else: + retries =3D 0 + + # if we see a newline in the peek we can let safely bail + # and let the normal readline() deal with it + if peek_ahead.endswith((b'\n', b'\r')): + return None + + # if we haven't seen enough for the whole message but the + # first part matches lets just loop again + if len(peek_ahead) < min_match and \ + success_message[:peek_len] in peek_ahead: + continue + + # if we see the whole success_message we are done, consume + # it and pass back so we can exit to the user + if success_message in peek_ahead: + return console.read(peek_len).decode() + + # of course if we've seen enough then this line probably + # doesn't contain what we are looking for, fallback + if peek_len > min_match: + return None + + # we should never get here + return None + =20 def _console_interaction(test, success_message, failure_message, send_string, keep_sending=3DFalse, vm=3DNone): @@ -139,17 +192,52 @@ def _console_interaction(test, success_message, failu= re_message, vm =3D test.vm console =3D vm.console_socket.makefile(mode=3D'rb', encoding=3D'utf-8') console_logger =3D logging.getLogger('console') + + # Establish the minimum number of bytes we would need to + # potentially match against success_message + if success_message is not None: + min_match =3D len(success_message) + else: + min_match =3D 0 + + console_logger.debug("looking for %d:(%s), sending %s (always=3D%s)", + min_match, success_message, send_string, keep_sen= ding) + while True: + msg =3D None + + # First send our string, optionally repeating the send next + # cycle. if send_string: vm.console_socket.sendall(send_string.encode()) if not keep_sending: send_string =3D None # send only once + + # If the console has no data to read we briefly + # sleep before continuing. + if not console.readable(): + time.sleep(0.1) + continue + try: - msg =3D console.readline().decode().strip() + + # First we shall peek ahead for a potential match to cover wai= ting + # for lines without any newlines. + if min_match > 0: + msg =3D _peek_ahead(console, min_match, success_message) + + # otherwise we block here for a full line + if not msg: + msg =3D console.readline().decode().strip() + except UnicodeDecodeError: + console_logger.debug("skipped unicode error") msg =3D None + + # if nothing came out we continue and try again if not msg: continue + console_logger.debug(msg) if success_message is None or success_message in msg: break --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519406; cv=none; d=zohomail.com; s=zohoarc; b=kktIRDYRJN/kleHILFZNdQUg2a8tG9tkR7Cy49giFJ/bA4pTK1e5CpTuRNEd1t9bzI9qAi892iPvR9OmnO36VIULKSygHVxa99EaNUv9Wq3UMmmAbd5JzFe3A/PH8XJfk40WjxLzpUOmtz49ry0QnwoEV6j7fAZ48b3nkOwwBuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519406; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YEwk4mG4SDl4i6e5vGNuhjwgLf2dcKmgfAwFXe8VUyU=; b=RPfxl/5PSvNSFFP2BWgcWhWUPzMBUjeSu1I90xP+4okpMjT7yteXqJ0Gy7CK7DPiLGua5KiRwQMeClOPDGr6j0RZW4/fYl38M/7k7xwLdekqb+StE8uii5TR5JMX+ehfjfdU6s1c3iEh9oZlpmUXpYic0+nZvNjUs1qPGX3R5EU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519406589565.3287624178014; Tue, 15 Nov 2022 05:36:46 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6z-00076p-Rv; Tue, 15 Nov 2022 08:36:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5O-0006I6-S9 for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:51 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5M-0004Id-1U for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:46 -0500 Received: by mail-wr1-x42b.google.com with SMTP id j15so24315719wrq.3 for ; Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id g10-20020a5d488a000000b0022cc3e67fc5sm12265749wrq.65.2022.11.15.05.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:41 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 84E141FFBB; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEwk4mG4SDl4i6e5vGNuhjwgLf2dcKmgfAwFXe8VUyU=; b=qKQkMNyY3q5A21V1pJiD/QReq4xatEQHJwbGWmHW0oHcJZhPA+hoywlhLsITII30TE VuEjXqMFvja/IRyp36QmK4aSCQKJOzZBDdpz0u0wpL5Sk1K5sQQjlTS3NK4l1cyCoWDh SnSrvSnftaJBNuLzW+U+EaIMqVa4wKxQpQHxCFfqTX+r8rbG42JHkPHdkzZuClGvmXU7 9JXRB8zUVqM1ihLu0Y6A0361bBPe3emUAidNXVpUENKjtdSg7LmaXw+VqI5VnoTeIM7n aODDgj/yVMDloyjiAngIKdl9pNNAL6RJWlmO7TmcH4VjpX7ZiNSppaZBnXo38ad7E0AD /PpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YEwk4mG4SDl4i6e5vGNuhjwgLf2dcKmgfAwFXe8VUyU=; b=e8VFoNArhNdL0Xdbs3Ck9sIkUv+dQXnK9X0AlDBOGmRq9/u2diUAU1mjFJUCba8OFv JUAzQyiCOxVm9QEL/puWlDjivaM/2fAklawsyqSCaYZHHCiFafqW1zu4ccOt46TS/iKE 0hqX4iaXCBdLfx3oACX/9NK3skRpu/nvLjCD9YnFEf9pj18bMPswQOP7CoNVsqu1l5ev +w1NUhLHxDyooICD5X9JesWPpdHdNZCJHL+Pp0d65kabJ+DmaDHCO2vxaeSp2jkjtaPW JuO6h4ZJf9jbL7uYtiZyG69WGCHQCIhclrc02LBG5T4OB23EYVy9/bJuUf7QSVoMcjK2 xWAw== X-Gm-Message-State: ANoB5pk9JH4qupNjFeU3nZN2RGcQJ161fJmsjRmXwpCE8wc4kT2ay7zx ymOtuGJLhKJRqrpJniGyuW5rZQ== X-Google-Smtp-Source: AA0mqf6rrqUEoPwBNOXGM/dv1jj9gD/VcWD07zYrcBMkVwLJVqByj4KjR9e+sn1QP+g+4t+eJXX2FQ== X-Received: by 2002:adf:aa44:0:b0:236:651d:60d4 with SMTP id q4-20020adfaa44000000b00236651d60d4mr10739076wrd.609.1668519282567; Tue, 15 Nov 2022 05:34:42 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL 03/10] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Date: Tue, 15 Nov 2022 13:34:32 +0000 Message-Id: <20221115133439.2348929-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519408745100005 From: C=C3=A9dric Le Goater The Aspeed SDK images are based on OpenBMC which starts a lot of services. The output noise on the console can break from time to time the test waiting for the logging prompt. Change the U-Boot bootargs variable to add "quiet" to the kernel command line and reduce the output volume. This also drops the test on the CPU id which was nice to have but not essential. Signed-off-by: C=C3=A9dric Le Goater Message-Id: <20221104075347.370503-1-clg@kaod.org> Signed-off-by: Alex Benn=C3=A9e Message-Id: <20221111145529.4020801-4-alex.bennee@linaro.org> diff --git a/tests/avocado/machine_aspeed.py b/tests/avocado/machine_aspeed= .py index fba6527026..1fc385e1c8 100644 --- a/tests/avocado/machine_aspeed.py +++ b/tests/avocado/machine_aspeed.py @@ -12,6 +12,7 @@ from avocado_qemu import wait_for_console_pattern from avocado_qemu import exec_command from avocado_qemu import exec_command_and_wait_for_pattern +from avocado_qemu import interrupt_interactive_console_until_pattern from avocado.utils import archive from avocado import skipIf =20 @@ -182,6 +183,8 @@ def test_arm_ast2600_evb_buildroot(self): =20 class AST2x00MachineSDK(QemuSystemTest): =20 + EXTRA_BOOTARGS =3D ' quiet' + # FIXME: Although these tests boot a whole distro they are still # slower than comparable machine models. There may be some # optimisations which bring down the runtime. In the meantime they @@ -194,7 +197,7 @@ def wait_for_console_pattern(self, success_message, vm= =3DNone): failure_message=3D'Kernel panic - not syn= cing', vm=3Dvm) =20 - def do_test_arm_aspeed_sdk_start(self, image, cpu_id): + def do_test_arm_aspeed_sdk_start(self, image): self.require_netdev('user') self.vm.set_console() self.vm.add_args('-drive', 'file=3D' + image + ',if=3Dmtd,format= =3Draw', @@ -202,9 +205,13 @@ def do_test_arm_aspeed_sdk_start(self, image, cpu_id): self.vm.launch() =20 self.wait_for_console_pattern('U-Boot 2019.04') - self.wait_for_console_pattern('## Loading kernel from FIT Image') + interrupt_interactive_console_until_pattern( + self, 'Hit any key to stop autoboot:', 'ast#') + exec_command_and_wait_for_pattern( + self, 'setenv bootargs ${bootargs}' + self.EXTRA_BOOTARGS, 'as= t#') + exec_command_and_wait_for_pattern( + self, 'boot', '## Loading kernel from FIT Image') self.wait_for_console_pattern('Starting kernel ...') - self.wait_for_console_pattern('Booting Linux on physical CPU ' + c= pu_id) =20 @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') def test_arm_ast2500_evb_sdk(self): @@ -221,7 +228,7 @@ def test_arm_ast2500_evb_sdk(self): archive.extract(image_path, self.workdir) =20 self.do_test_arm_aspeed_sdk_start( - self.workdir + '/ast2500-default/image-bmc', '0x0') + self.workdir + '/ast2500-default/image-bmc') self.wait_for_console_pattern('ast2500-default login:') =20 @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab') @@ -243,7 +250,7 @@ def test_arm_ast2600_evb_sdk(self): self.vm.add_args('-device', 'ds1338,bus=3Daspeed.i2c.bus.5,address=3D0x32'); self.do_test_arm_aspeed_sdk_start( - self.workdir + '/ast2600-default/image-bmc', '0xf00') + self.workdir + '/ast2600-default/image-bmc') self.wait_for_console_pattern('ast2600-default login:') exec_command_and_wait_for_pattern(self, 'root', 'Password:') exec_command_and_wait_for_pattern(self, '0penBmc', 'root@ast2600-d= efault:~#') --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519377; cv=none; d=zohomail.com; s=zohoarc; b=AzmQCL/r2kRRaVp10gZWkqLIlncoBsdIDlou5/dQ4l796fwDuuJdRqT8CSQieEKMKz0lFxFq+Bp6kO8zesS4YYtA9ruIuOeoE5+/awdChUg2ceG3n9htG2BgTL99ZGhvKjN2MdpVhKVhuNGud9TrqqfZbY+tAD+IZMIcV/TgNYE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519377; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zmtOF1FOfTVQ/UMG540fiUZpW6VglR6cjorQt52ST+E=; b=NA4m0ckwGHMCeD+/Ws0oWJjb5DE1xs2eNqAC2D2HcveIWjqX+HD8KnfzYMvkteeTLAwVfU8UTBFCCT3K1GaONh8g+z6sChCtZUBQ4kR0p7+GJNzmDcPPAmbUwv5p0LbXBRi1OtPNFZHHUm2VrQg4+YupXKjpRkIwYXROCb7zFMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519377833236.12861319802198; Tue, 15 Nov 2022 05:36:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw60-0006Rx-AN; Tue, 15 Nov 2022 08:35:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5O-0006I4-Of for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:51 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5M-0004Ir-Ox for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:46 -0500 Received: by mail-wr1-x42d.google.com with SMTP id j15so24315778wrq.3 for ; Tue, 15 Nov 2022 05:34:44 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id k34-20020a05600c1ca200b003b47b80cec3sm24556815wms.42.2022.11.15.05.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:41 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id A18D91FFBC; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zmtOF1FOfTVQ/UMG540fiUZpW6VglR6cjorQt52ST+E=; b=yQtaUFm7Qmv9Y7PgtR57DZFE6aQoJobYUhCR83MIhMsHw6+vBtpBKvDkwKyDLb+iXD XyLui49oMy1V+OF6w77Ae0+dPGfXnRjtRHfda4jz/tNJCFnPOJBiTgFvVvXzCz8Ke3dj MvsWLNxzTfCoy6uA5E5VMQfe5dqUNLCWVVDR3LDv2UDUulAkhXTCzXa6uUGIrjwCqVQ4 ktxVEdBSEl5E6b2UQA2m3ncmFRaM9xzi4EeFjUQr0T18A8TT2aU1VvmsO952L+04IT/d bodHyp0FptQDnfQpgjkta+2HToXXRu0PJXUi9YQbKpfUWGGmH503MdabUAhBy5vLOa+q mBKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zmtOF1FOfTVQ/UMG540fiUZpW6VglR6cjorQt52ST+E=; b=lM4ICzBN6clTV+wZ5vhTa87egKbnifvDYpxuNdUd+h1ml2SMOKZ3Jun0kyq8XNkD47 hoZrTiDZCSIIPiAnL1IvZeIq1aCrbviYIR3b/TsWavGehS2XhTK2sX0IytA4IIGJWEoJ xE3mr9Z27058C5biMgRcCymZ43AJQcpOIU+9/Okp24HwXoOs98Td4IGoK2hmX4grqOUi kax8UDQI/H0U7QOEknc4B2q5y5R8DU3blbq5kk5oONBD5PWTjCtlswBZ2SO++cfilHw5 LySRFoWSVipCrpdsZaNM1yXN94swzVK60A2rfrpl/CAbc+4TbWP2A5gLE2qUD85hm9rU N6QQ== X-Gm-Message-State: ANoB5plchaMjVtzsgOwc7QCdudBcc7dcy3LV2ygWfOsLX87blCIFUSqL YBqlcwHzxRS5BrP3In7KGHACFg== X-Google-Smtp-Source: AA0mqf6YdPx5zMu1qc47QOtGcSvltgjKspyxJwMeaRZjGfaOBmtH/Kx6u1xXmiVMxkjfEKh0JYpUBw== X-Received: by 2002:a5d:4c82:0:b0:236:56a6:823e with SMTP id z2-20020a5d4c82000000b0023656a6823emr10749492wrs.495.1668519283328; Tue, 15 Nov 2022 05:34:43 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL 04/10] tests/docker: allow user to override check target Date: Tue, 15 Nov 2022 13:34:33 +0000 Message-Id: <20221115133439.2348929-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519378519100003 This is useful when trying to bisect a particular failing test behind a docker run. For example: make docker-test-clang@fedora \ TARGET_LIST=3Darm-softmmu \ TEST_COMMAND=3D"meson test qtest-arm/qos-test" \ J=3D9 V=3D1 Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20221111145529.4020801-5-alex.bennee@linaro.org> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index c87f14477a..fc7a3b7e71 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -184,6 +184,7 @@ docker: @echo ' TARGET_LIST=3Da,b,c Override target list in builds.' @echo ' EXTRA_CONFIGURE_OPTS=3D"..."' @echo ' Extra configure options.' + @echo ' TEST_COMMAND=3D"..." Override the default `make check` targe= t.' @echo ' IMAGES=3D"a b c ..": Restrict available images to subset.' @echo ' TESTS=3D"x y z .." Restrict available tests to subset.' @echo ' J=3D[0..9]* Overrides the -jN parameter for make co= mmands' @@ -230,6 +231,7 @@ docker-run: docker-qemu-src $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=3D$(NETWORK)),--net= =3Dnone) \ -e TARGET_LIST=3D$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \ -e EXTRA_CONFIGURE_OPTS=3D"$(EXTRA_CONFIGURE_OPTS)" \ + -e TEST_COMMAND=3D"$(TEST_COMMAND)" \ -e V=3D$V -e J=3D$J -e DEBUG=3D$(DEBUG) \ -e SHOW_ENV=3D$(SHOW_ENV) \ $(if $(NOUSER),, \ diff --git a/tests/docker/common.rc b/tests/docker/common.rc index e6f8cee0d6..9a33df2832 100755 --- a/tests/docker/common.rc +++ b/tests/docker/common.rc @@ -63,12 +63,12 @@ check_qemu() { # default to make check unless the caller specifies if [ $# =3D 0 ]; then - INVOCATION=3D"check" + INVOCATION=3D"${TEST_COMMAND:-make $MAKEFLAGS check}" else - INVOCATION=3D"$@" + INVOCATION=3D"make $MAKEFLAGS $@" fi =20 - make $MAKEFLAGS $INVOCATION + $INVOCATION } =20 test_fail() --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519496; cv=none; d=zohomail.com; s=zohoarc; b=X6ITG9juZXIzrhy4CH1h5NWDI+jGlmGEZTlzP+26AaaivoHaUok9rmu7JygxYK7dtLteCASeB99zXjq6BsNf+l3ZuhzYX85C2TGojTIyCluwHRCPmnP+t7SfNBFkmfwOT0uyhz+0ISgZViI+i/ik0c28kHMagg3pG3o8wTcxeug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519496; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ezaTyadfOi9kcEwGFI3M4gMhHH8IqwlOJysS9HSV8Ek=; b=DQaQN4njoFff5ksf+5rSncuavgEmIAeIcPZrEHeemN7Yxyrtw+HZoUyGfELdFaPlbCmYWpzNdfyD3Kf0weVqbgHRcnOAmDmNsCOfCmHgny8uzyRr/dd6ITXj2pUN8ZV7T2oJqyjS0ke+7X5Ea0A9na3ljC87Zwpy1hS9uaCOzrg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519496102658.0787134148682; Tue, 15 Nov 2022 05:38:16 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6s-00072n-Da; Tue, 15 Nov 2022 08:36:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5Q-0006II-9s for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:51 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5O-0004J4-1G for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:48 -0500 Received: by mail-wr1-x42b.google.com with SMTP id y16so24277184wrt.12 for ; Tue, 15 Nov 2022 05:34:45 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id q13-20020adfea0d000000b0023677fd2657sm12297579wrm.52.2022.11.15.05.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:42 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id C02771FFBD; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ezaTyadfOi9kcEwGFI3M4gMhHH8IqwlOJysS9HSV8Ek=; b=isAtVXMndF6URNkfyBEL+g1kVjBWc9a05537yYfjX1Qytp9Vqq7hUv03VHg3UV7cHi 2hQlpZZri0MhVGnSipYhedH48T3pxkUj2nO65VhTBjPl7tL25Ql6sC8FmxZqU0A1lQha red8XRZhTaD/1WLsKoqi5XuXVCvnK9xgV/M50sNoRe9/kdnYoXFYs+J+xMj21oO1AIg8 nmOXWlhhHYpHKG9JRDcEANwYn/9WjLITUOla1IV6P3CCvwEZT3FMTn6ojNKhMl/by55e pDVlHk3iKeixaeDwo/FxYTRImWB0WnXLkRfuwa5tQ29wDtywAEvFpymPGElbkrLZmvOE bx0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ezaTyadfOi9kcEwGFI3M4gMhHH8IqwlOJysS9HSV8Ek=; b=J+qGsdYL7kp5XuLiuxD01VKaYIIPWAXc3Vv3XWA2RpgdDcNa5oatZeKuqJpO2psLRL t8j71X092k19hbiZ45lOWUYM5nWLzVGLPeR849g+rguQ65vSTNlckm7QF1gYt2asoTvS mrpOTNgzxQ6bAahbA9Vzah0SYmrh2j1btdWNJ30db58EGEXI2gPOtH5Ai71gXT6YzjbE 5kGd7U84fuyCfQtlSqTBkMJe7j4yMe5LvjNHqUnMzsaWlMMfCb1J+V09G4azDORKAUuo 8aiAvoYmvYT8kMO/QonB6TmOy0i/1FoLgcTA/JU9ACDf7qOjFI+RA1ezc4HcnCY7RAEV NS9w== X-Gm-Message-State: ANoB5pkgTCE8gjbPAM0yatKZ+CvV7RstS3b8F6X2qV0LORSIU0TYVnZo fuR31nGJQ41kfvo4U6cLWRYYpA== X-Google-Smtp-Source: AA0mqf4UiXYkUBzQpStlKaZ8OjEgRHyeoYMJG4Jy0KN1ytdmvdxpbiDTKoyZztCMw3XsZGenIYMb8Q== X-Received: by 2002:adf:dfc2:0:b0:236:7805:48d3 with SMTP id q2-20020adfdfc2000000b00236780548d3mr10659589wrn.644.1668519284350; Tue, 15 Nov 2022 05:34:44 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini Subject: [PULL 05/10] docs/devel: add a maintainers section to development process Date: Tue, 15 Nov 2022 13:34:34 +0000 Message-Id: <20221115133439.2348929-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519497167100003 We don't currently have a clear place in the documentation to describe the roles and responsibilities of a maintainer. Lets create one so we can. I've moved a few small bits out of other files to try and keep everything in one place. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-6-alex.bennee@linaro.org> diff --git a/docs/devel/code-of-conduct.rst b/docs/devel/code-of-conduct.rst index 195444d1b4..f734ed0317 100644 --- a/docs/devel/code-of-conduct.rst +++ b/docs/devel/code-of-conduct.rst @@ -1,3 +1,5 @@ +.. _code_of_conduct: + Code of Conduct =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 diff --git a/docs/devel/index-process.rst b/docs/devel/index-process.rst index d0d7a200fd..d50dd74c3e 100644 --- a/docs/devel/index-process.rst +++ b/docs/devel/index-process.rst @@ -8,6 +8,7 @@ Notes about how to interact with the community and how and = where to submit patch =20 code-of-conduct conflict-resolution + maintainers style submitting-a-patch trivial-patches diff --git a/docs/devel/maintainers.rst b/docs/devel/maintainers.rst new file mode 100644 index 0000000000..05110909d1 --- /dev/null +++ b/docs/devel/maintainers.rst @@ -0,0 +1,106 @@ +.. _maintainers: + +The Role of Maintainers +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Maintainers are a critical part of the project's contributor ecosystem. +They come from a wide range of backgrounds from unpaid hobbyists +working in their spare time to employees who work on the project as +part of their job. Maintainer activities include: + + - reviewing patches and suggesting changes + - collecting patches and preparing pull requests + - tending to the long term health of their area + - participating in other project activities + +They are also human and subject to the same pressures as everyone else +including overload and burnout. Like everyone else they are subject +to project's :ref:`code_of_conduct` and should also be exemplars of +excellent community collaborators. + +The MAINTAINERS file +-------------------- + +The `MAINTAINERS +`__ +file contains the canonical list of who is a maintainer. The file +is machine readable so an appropriately configured git (see +:ref:`cc_the_relevant_maintainer`) can automatically Cc them on +patches that touch their area of code. + +The file also describes the status of the area of code to give an idea +of how actively that section is maintained. + +.. list-table:: Meaning of support status in MAINTAINERS + :widths: 25 75 + :header-rows: 1 + + * - Status + - Meaning + * - Supported + - Someone is actually paid to look after this. + * - Maintained + - Someone actually looks after it. + * - Odd Fixes + - It has a maintainer but they don't have time to do + much other than throw the odd patch in. + * - Orphan + - No current maintainer. + * - Obsolete + - Old obsolete code, should use something else. + +Please bear in mind that even if someone is paid to support something +it does not mean they are paid to support you. This is open source and +the code comes with no warranty and the project makes no guarantees +about dealing with bugs or features requests. + + + +Becoming a reviewer +------------------- + +Most maintainers start by becoming subsystem reviewers. While anyone +is welcome to review code on the mailing list getting added to the +MAINTAINERS file with a line like:: + + R: Random Hacker + +will ensure that patches touching a given subsystem will automatically +be CC'd to you. + +Becoming a maintainer +--------------------- + +Maintainers are volunteers who put themselves forward or have been +asked by others to keep an eye on an area of code. They have generally +demonstrated to the community, usually via contributions and code +reviews, that they have a good understanding of the subsystem. They +are also trusted to make a positive contribution to the project and +work well with the other contributors. + +The process is simple - simply send a patch to the list that updates +the ``MAINTAINERS`` file. Sometimes this is done as part of a larger +series when a new sub-system is being added to the code base. This can +also be done by a retiring maintainer who nominates their replacement +after discussion with other contributors. + +Once the patch is reviewed and merged the only other step is to make +sure your GPG key is signed. + +.. _maintainer_keys: + +Maintainer GPG Keys +~~~~~~~~~~~~~~~~~~~ + +GPG is used to sign pull requests so they can be identified as really +coming from the maintainer. If your key is not already signed by +members of the QEMU community, you should make arrangements to attend +a `KeySigningParty `__ (for +example at KVM Forum) or make alternative arrangements to have your +key signed by an attendee. Key signing requires meeting another +community member **in person** [#]_ so please make appropriate +arrangements. + +.. [#] In recent pandemic times we have had to exercise some + flexibility here. Maintainers still need to sign their pull + requests though. diff --git a/docs/devel/submitting-a-pull-request.rst b/docs/devel/submitti= ng-a-pull-request.rst index c9d1e8afd9..a4cd7ebbb6 100644 --- a/docs/devel/submitting-a-pull-request.rst +++ b/docs/devel/submitting-a-pull-request.rst @@ -53,14 +53,10 @@ series) and that "make check" passes before sending out= the pull request. As a submaintainer you're one of QEMU's lines of defense against bad code, so double check the details. =20 -**All pull requests must be signed**. If your key is not already signed -by members of the QEMU community, you should make arrangements to attend -a `KeySigningParty `__ (for -example at KVM Forum) or make alternative arrangements to have your key -signed by an attendee. Key signing requires meeting another community -member \*in person\* so please make appropriate arrangements. By -"signed" here we mean that the pullreq email should quote a tag which is -a GPG-signed tag (as created with 'gpg tag -s ...'). +**All pull requests must be signed**. By "signed" here we mean that +the pullreq email should quote a tag which is a GPG-signed tag (as +created with 'gpg tag -s ...'). See :ref:`maintainer_keys` for +details. =20 **Pull requests not for master should say "not for master" and have "PULL SUBSYSTEM whatever" in the subject tag**. If your pull request is --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519344; cv=none; d=zohomail.com; s=zohoarc; b=DQ1ESLvs3Ir1cSIcMkhdG/eYKVwcw72EijjGfSljr9/cK4zBjkhFtvvnGbbinf9yPDo8ZVzh4iTou2danLdZzwH5Fum9XhdYzaS7EVaVviz6frkZeqnZTQL1T1jjltB8Go1+QfzLQ5/JAtZrF+iIczc4oYPmXS/G0+m5Ez6Ewow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519344; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sww7S1L4kgQAku0tJMD0FzqA1RW7m8mrVqehdeq+qRo=; b=F0UclQchQmPlCK1n1JEZLSCuu322ow7P/nJivadmEAT0jY8vmJ+Efq5QGSEbyRpzAa2qztxfRSbOw/TKVcyMg0CjI5DEaOc7VMwCiyXizOERLv5wDdWHiPy4MfdDirH5onsUa1xdHp30GV7fiLnXtwHWRBPcsMzlWFlI+O1xO6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519344179460.50083916837013; Tue, 15 Nov 2022 05:35:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6B-0006Wk-5o; Tue, 15 Nov 2022 08:35:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5S-0006IK-AI for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:53 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5Q-0004L1-Tu for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:50 -0500 Received: by mail-wr1-x42f.google.com with SMTP id bs21so24290697wrb.4 for ; Tue, 15 Nov 2022 05:34:48 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id o39-20020a05600c33a700b003b47e75b401sm20164310wmp.37.2022.11.15.05.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D65A51FFBE; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sww7S1L4kgQAku0tJMD0FzqA1RW7m8mrVqehdeq+qRo=; b=duXxXBbL5Qh8cwi5tQgBdx+Jg5P20Wv+tAX5bwAJD98fbL+VMU4ttsel7oVDNXC03N pPXEH6+yD18Ge4231W/+PLGfdJQeQmqOixv2uQm05EsZeMUzzKn7fPsLauFCY/zkkg6o sR5sndPfuJn2TusJwMWzNxm2BXnR7Y6v9zQA4llOJYSd+dm1aD0n4TD13GV2aEB3iQIv Sc6/Zdy53f6PkVzMNYOooMa2yddPG47vhf3sWBUd1LKJmuXkIX5fEaNikRd3BexRzr6Q 8jcYEkxfT2yPXttl1ECGm3miFLp1gq2gX0nexf8Wm/2XGsb5qChg3M7tt/0h0W5259vI ZnEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sww7S1L4kgQAku0tJMD0FzqA1RW7m8mrVqehdeq+qRo=; b=BObBIFHhyJzeP7g3+VLeH7ldQDMbV7SptCOVJ3a5s8hR7iJlmoBSI32j06vZKlykrN tILx7CecRHYyHSe5ZTq4BSjwnJ5K+hMuGH69URTuruUqqZ2SubPe/FvZdeH0UTxYlIde 2oAz1x+vF9aJ1KSoqZSudrVgePR2Q1LQJ1zxepEHFw1J3/IabMgofUrJEzgNsL5qWbWM hfPgIBuZlKf0+bCKAgCK2XmVHT/zT838RBeUl3/iJ3enoyHI3TWbEUV9NrzpSYnDgtyj +3A60LKqvgu1AmIj7MO6AOh/LexuUngg18yKx7ao+U/sCAfde7kGzuXqt5KiSvh9ZsJj r8/w== X-Gm-Message-State: ANoB5pkStRM6T41sKse3gNmmDZOZhqokfXWh6Dx5xNTke5MlSlR28Dni IZ/xcdwllv8JS1yBOaC7uwuC9rPNHkRjzw== X-Google-Smtp-Source: AA0mqf5XQlzr+IHiELXCHyBn73AaCF4wSu/v1T8j4cTFJfq80+KqxXgn5sPU4HBjboBHPqxOmgAMDw== X-Received: by 2002:a5d:6e07:0:b0:238:3d63:5736 with SMTP id h7-20020a5d6e07000000b002383d635736mr11077813wrz.513.1668519287147; Tue, 15 Nov 2022 05:34:47 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini Subject: [PULL 06/10] docs/devel: make language a little less code centric Date: Tue, 15 Nov 2022 13:34:35 +0000 Message-Id: <20221115133439.2348929-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519346335100005 We welcome all sorts of patches. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-7-alex.bennee@linaro.org> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index fec33ce148..9c7c4331f3 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -3,11 +3,11 @@ Submitting a Patch =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 -QEMU welcomes contributions of code (either fixing bugs or adding new -functionality). However, we get a lot of patches, and so we have some -guidelines about submitting patches. If you follow these, you'll help -make our task of code review easier and your patch is likely to be -committed faster. +QEMU welcomes contributions to fix bugs, add functionality or improve +the documentation. However, we get a lot of patches, and so we have +some guidelines about submitting them. If you follow these, you'll +help make our task of code review easier and your patch is likely to +be committed faster. =20 This page seems very long, so if you are only trying to post a quick one-shot fix, the bare minimum we ask is that: --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519407; cv=none; d=zohomail.com; s=zohoarc; b=mviUblpRIQYqeFNajF4UAYp3GCTAwogjFomZZ11hSIGa9gIsNFJT00BT69WLzEH47FlapjGDvSbF0NKrzFobgM+BumEW/lC9xbW2nozrFCLW7/Au4SqcsNHEX2KqGum8ibdQwUToLJevETspwFzvLNcFF4JXyU8f/sC5l2CSA8s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519407; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vFHZHnJKPSci7uDkM2NVwinZ5Gudl28BkgH8YMFGrRU=; b=K6iTtipsSMRdgAk76aQui6Hu/Vmk6Iwq9mng1EI7WOZNNQACa0BpPg9DAZpQiyJKXg4D6MmZ1mdpkYKvijbfDeMoAUEPPGEx7PGHc0sZnpa9ZKipXvL+tx5Mj05VrlyrDrgctCm0tt63kP26N08n2B9dm7ykldcEKK+NrRE0RPQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1668519407794234.44841595050968; Tue, 15 Nov 2022 05:36:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6d-0006XF-6H; Tue, 15 Nov 2022 08:36:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5U-0006IX-KL for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:54 -0500 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5S-0004LA-EX for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:52 -0500 Received: by mail-wr1-x431.google.com with SMTP id d9so19575102wrm.13 for ; Tue, 15 Nov 2022 05:34:50 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id p5-20020a05600c358500b003c6b9749505sm24354238wmq.30.2022.11.15.05.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id ED98E1FFBF; Tue, 15 Nov 2022 13:34:39 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vFHZHnJKPSci7uDkM2NVwinZ5Gudl28BkgH8YMFGrRU=; b=ZVL59jkOKVkXnx6SEWK9U9dTL40k22JvWICIao1xXW6z+SemjxzwUhTL3Q6HefH5sX pK5W3I/0LyFDiXjSDCoup3qQ+yV5Lp4Le/kZgk8Z8kX4ClVGgAyhMOLiCZVW8KUdZBqj PPfP34F4KOaDRCbMZ4PvnzRtb75cPgmss8EvH6/TjvNI7T2QPs8LyhGpgTkEjNNXwF/Y 2oXBijRQ1rqjStQkn/9ZxUqdJHqFdi2w52T9xt+btOXiM79rJTb/Q8QyE1cZXvVweXZq KS2eIQoCZN9R5TDGpbP9PM5uauT3xvsbOZiO4PJYJmoG1tT3cnNz9GODjHDSXw9XiZIJ 6rRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vFHZHnJKPSci7uDkM2NVwinZ5Gudl28BkgH8YMFGrRU=; b=mgqQuTjAmcGcPFGuSxVKBOCImz7b0+oY7Nw5XUo1mpWYsHkc6CVQ7xFSDntyrYIdE9 IssgUGEfoxBcrIQSALMP1AqeUyb4i6PffcLrSvOBV1VNpjl7GXKMfATjedwl5Y7XTbUU Wtkgwc+SYrvgQ84RNCRAOZaMa2+bYPuRSqrr+y8kB/JIwRge0Glch6tEAfwfuqrmvJU/ Vr/CnFvVaZis4I5CR0V0v8l0SttglfMqaK7EFKtcn4OEZ5yX+clmXEmFQjHi/0iqR6v3 VyWKqHwx/qyw3ic0fQnOjoE1di7lq6G0BzICesj9cRn2fIeihixDDy6ZcauQQYALHWTY sqdw== X-Gm-Message-State: ANoB5pminho0tBb8IlJfizoy0oHBdMxcWxWisCqK/TjO4di82eAD3yub Po8vvp/ti1IAirhnkgLXUeoG4nMX98ZMOA== X-Google-Smtp-Source: AA0mqf4a6QvkZQxQI9TepkgA7+tkD0Zc4VGb09pci8ajeK8vetLvyca326R2ij3ZIK51s1JQxHJ+qg== X-Received: by 2002:a5d:4c44:0:b0:236:c45d:e268 with SMTP id n4-20020a5d4c44000000b00236c45de268mr11225596wrt.74.1668519289028; Tue, 15 Nov 2022 05:34:49 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini Subject: [PULL 07/10] docs/devel: simplify the minimal checklist Date: Tue, 15 Nov 2022 13:34:36 +0000 Message-Id: <20221115133439.2348929-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519408784100006 The bullet points are quite long and contain process tips. Move those bits of the bullet to the relevant sections and link to them. Use a table for nicer formatting of the checklist. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-8-alex.bennee@linaro.org> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index 9c7c4331f3..1f2bde0625 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -12,25 +12,18 @@ be committed faster. This page seems very long, so if you are only trying to post a quick one-shot fix, the bare minimum we ask is that: =20 -- You **must** provide a Signed-off-by: line (this is a hard - requirement because it's how you say "I'm legally okay to contribute - this and happy for it to go into QEMU", modeled after the `Linux kernel - `__ - policy.) ``git commit -s`` or ``git format-patch -s`` will add one. -- All contributions to QEMU must be **sent as patches** to the - qemu-devel `mailing list `__. - Patch contributions should not be posted on the bug tracker, posted on - forums, or externally hosted and linked to. (We have other mailing list= s too, - but all patches must go to qemu-devel, possibly with a Cc: to another - list.) ``git send-email`` (`step-by-step setup - guide `__ and `hints and - tips `__) - works best for delivering the patch without mangling it, but - attachments can be used as a last resort on a first-time submission. -- You must read replies to your message, and be willing to act on them. - Note, however, that maintainers are often willing to manually fix up - first-time contributions, since there is a learning curve involved in - making an ideal patch submission. +.. list-table:: Minimal Checklist for Patches + :widths: 35 65 + :header-rows: 1 + + * - Check + - Reason + * - Patches contain Signed-off-by: Real Name + - States you are legally able to contribute the code. See :ref:`patch= _emails_must_include_a_signed_off_by_line` + * - Sent as patch emails to ``qemu-devel@nongnu.org`` + - The project uses an email list based workflow. See :ref:`submitting= _your_patches` + * - Be prepared to respond to review comments + - Code that doesn't pass review will not get merged. See :ref:`partic= ipating_in_code_review` =20 You do not have to subscribe to post (list policy is to reply-to-all to preserve CCs and keep non-subscribers in the loop on the threads they @@ -229,6 +222,19 @@ bisection doesn't land on a known-broken state. Submitting your Patches ----------------------- =20 +The QEMU project uses a public email based workflow for reviewing and +merging patches. As a result all contributions to QEMU must be **sent +as patches** to the qemu-devel `mailing list +`__. Patch +contributions should not be posted on the bug tracker, posted on +forums, or externally hosted and linked to. (We have other mailing +lists too, but all patches must go to qemu-devel, possibly with a Cc: +to another list.) ``git send-email`` (`step-by-step setup guide +`__ and `hints and tips +`__) +works best for delivering the patch without mangling it, but +attachments can be used as a last resort on a first-time submission. + .. _if_you_cannot_send_patch_emails: =20 If you cannot send patch emails @@ -314,10 +320,12 @@ git repository to fetch the original commit. Patch emails must include a ``Signed-off-by:`` line ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ =20 -For more information see `SubmittingPatches 1.12 -`__. -This is vital or we will not be able to apply your patch! Please use -your real name to sign a patch (not an alias or acronym). +Your patches **must** include a Signed-off-by: line. This is a hard +requirement because it's how you say "I'm legally okay to contribute +this and happy for it to go into QEMU". The process is modelled after +the `Linux kernel +`__ +policy. =20 If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling. It's okay if you subscribe or contribute to @@ -327,6 +335,11 @@ include a "From:" line in the body of the email (diffe= rent from your envelope From:) that will give credit to the correct author; but again, that author's Signed-off-by: line is mandatory, with the same spelling. =20 +There are various tooling options for automatically adding these tags +include using ``git commit -s`` or ``git format-patch -s``. For more +information see `SubmittingPatches 1.12 +`__. + .. _include_a_meaningful_cover_letter: =20 Include a meaningful cover letter @@ -397,9 +410,19 @@ Participating in Code Review ---------------------------- =20 All patches submitted to the QEMU project go through a code review -process before they are accepted. Some areas of code that are well -maintained may review patches quickly, lesser-loved areas of code may -have a longer delay. +process before they are accepted. This will often mean a series will +go through a number of iterations before being picked up by +:ref:`maintainers`. You therefore should be prepared to +read replies to your messages and be willing to act on them. + +Maintainers are often willing to manually fix up first-time +contributions, since there is a learning curve involved in making an +ideal patch submission. However for the best results you should +proactively respond to suggestions with changes or justifications for +your current approach. + +Some areas of code that are well maintained may review patches +quickly, lesser-loved areas of code may have a longer delay. =20 .. _stay_around_to_fix_problems_raised_in_code_review: =20 --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519603; cv=none; d=zohomail.com; s=zohoarc; b=C67TRnnzg8+Bk31QIqwC9ePANtTFz3qU5LFe0wkLJ0QtLnZArv9r3azE3Uk82BX+yx9LbaZFZmsE7TrpMvViKZpZZ6UW4+l7dcVfcvwu+25hsJrh8pWKGSrpDUZFPkTbb2/XwbZ62YhtkauDpnHHmg82Vs5Zt5B1nJLKIOOaSeY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=myZkMlZktQPErK97Kj4g305BOscpcO6cBnY3bef4npFAwgSIqeHtmYNF6jGsUGZV6x+mChEwXAKZjKXwz46oRWKEBVjgMfhIyE+KI6qsXyHupBrgUP1FaHqlRW+CNCxTDdP57fZ7CAyokzxqGt/gezU7GHXJQl04L0MzEp1AcpA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166851960393642.05758772527804; Tue, 15 Nov 2022 05:40:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6n-0006rX-SF; Tue, 15 Nov 2022 08:36:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5Y-0006JF-0u for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:58 -0500 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5W-0004LV-1L for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:55 -0500 Received: by mail-wm1-x32c.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso13122183wme.5 for ; Tue, 15 Nov 2022 05:34:52 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id fc18-20020a05600c525200b003b49bd61b19sm23605563wmb.15.2022.11.15.05.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:43 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 119911FFC0; Tue, 15 Nov 2022 13:34:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=rnEokUju9x1/kOw2T+ajwmb79WymaOYNfjgU3wpdoW1bf2srEF6jqXxE1cJ3gjduas 55iBpdr01tqskVYjSeTk0ZuPCkq1GGlDuPqktegNe0yu8ggC//Crzzx54XPaRCbXIDdn julCoznnbK007JwVUzwj/UsuVYVcAWe7kY6DKBOKUekV5QAKvzQC6hODg6s5hW1V6IKi Z6EAB/3Xkvx3sQ3YWvdNP3/f01vN49xRfUJ/tWGbJTn1541KbFFrBNJdKmPZ9SNFrDIT ANf94hcdnZqIFmCrwX2+hq4WkuktrXa16cYIlm+bqSBxQyTiQMjJBwruZ4S8xtbOCWRP 6Ejg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aRZ/eD6ZaUedeEXWQl7NVWa5eF5sUkL83SXNmlmtL6M=; b=rRzprAJy7pRZCIZrEoVhaGefsaA9G92epitcInua2JUO5I5YMfYEt7WRQmEFmEg0TU PoYlods14yLXAB+a1uvG+rwwVfCAqvJIBNJb/OGxRzntEIPXeVfiFk3u5bF+xfERiAMY +5P9JAu3ZaJn0oS2AB9+U6R0f00J9kKfaxMxgtFCEwBJ1FgbK28XLCfr51Cwi/DGa6yB HCPp1t4Yskd5F7aqmni8OVB7insTvEZ0MQyAdP51Gh3BQhgpj6YxeOjxymSGEPY/9gzz Fteb58oIDCUPoXt+hrle0hejhNetf2MGGhMM66W4jD3a6nt1s1gEVwxrpHNaUjTCgzRe eEYQ== X-Gm-Message-State: ANoB5pn9NzLJZHSGww2j+pEWZr6JnSQxgdAFzy6ESdn43m68rnTrJlAB hSbewF0Golfil9o4vshYQQ7gWg== X-Google-Smtp-Source: AA0mqf5p8Uqr+hNcKGRYsL193LPI2w6TVLd46K7nR761Omo4SFxNug1Y36kGJsoh2fWz8Poc+2KUaQ== X-Received: by 2002:a1c:f204:0:b0:3cf:6fe0:b16a with SMTP id s4-20020a1cf204000000b003cf6fe0b16amr514899wmc.28.1668519291557; Tue, 15 Nov 2022 05:34:51 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Markus Armbruster , Paolo Bonzini Subject: [PULL 08/10] docs/devel: try and improve the language around patch review Date: Tue, 15 Nov 2022 13:34:37 +0000 Message-Id: <20221115133439.2348929-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519605762100003 It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Message-Id: <20221111145529.4020801-9-alex.bennee@linaro.org> diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-pa= tch.rst index 1f2bde0625..80e8693bb6 100644 --- a/docs/devel/submitting-a-patch.rst +++ b/docs/devel/submitting-a-patch.rst @@ -434,14 +434,20 @@ developers will identify bugs, or suggest a cleaner a= pproach, or even just point out code style issues or commit message typos. You'll need to respond to these, and then send a second version of your patches with the issues fixed. This takes a little time and effort on your part, but -if you don't do it then your changes will never get into QEMU. It's also -just polite -- it is quite disheartening for a developer to spend time -reviewing your code and suggesting improvements, only to find that -you're not going to do anything further and it was all wasted effort. +if you don't do it then your changes will never get into QEMU. + +Remember that a maintainer is under no obligation to take your +patches. If someone has spent the time reviewing your code and +suggesting improvements and you simply re-post without either +addressing the comment directly or providing additional justification +for the change then it becomes wasted effort. You cannot demand others +merge and then fix up your code after the fact. =20 When replying to comments on your patches **reply to all and not just the sender** -- keeping discussion on the mailing list means everybody -can follow it. +can follow it. Remember the spirit of the :ref:`code_of_conduct` and +keep discussions respectful and collaborative and avoid making +personal comments. =20 .. _pay_attention_to_review_comments: =20 --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519489; cv=none; d=zohomail.com; s=zohoarc; b=Ts4LkbL7nMYvZA6eSAmg1m53PeSeejyBekEfYMeLzm5yrVO7GiW5pUu7KmKj9mNYVgYErTAJbA5kCneyBHdwMxmCZwIXg4EzeZoRiJXl8msgKVNLL9Jh5gzA+3oSWm5DoJ5QJfOUsw6h7PqSMzhXTb16zFklrglUVGUHRSDrdLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519489; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=m8ejrVwLiLoS+pUm7oqY+yG/9wMKF0S3iW/Yln0D5sU=; b=oGfnj6MITq0B/fRUwkMIK3lfVzFgjsKN6J5rJai6c1IygSKgOIEdCqkdb5xpTEGtHQ2jeGYAlT4h8WtUEhP30wbtLexLDuoEZAjaTwWj3NscfYtEE7lW03yG2OVF/qyhqjj/MoU4h2uIdsm2vMi3kYGqdOMG3j9+xymr8VWvGB8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166851948910198.560331798314; Tue, 15 Nov 2022 05:38:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6p-0006wM-AE; Tue, 15 Nov 2022 08:36:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5a-0006Jp-5m for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:59 -0500 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5Y-0004Ll-Nn for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:57 -0500 Received: by mail-wr1-x42f.google.com with SMTP id a14so24304161wru.5 for ; Tue, 15 Nov 2022 05:34:55 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id j13-20020a5d452d000000b0022cbf4cda62sm14865421wra.27.2022.11.15.05.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:44 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2A4871FFC1; Tue, 15 Nov 2022 13:34:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m8ejrVwLiLoS+pUm7oqY+yG/9wMKF0S3iW/Yln0D5sU=; b=H4fvM+jcpWaWe9EgIc/A338bMvcnlB4oVKZiUfcP8quCr1xxVVUm8bQecjECRuMu2I U9rvqH8owCzhHlL8//nz9zXogsj8adbT6l8y3OA62RpPuKCqZATkF/W4cgZsl0DAZPtf ay4kXBvpdMA+Gtiae2BnnjnsgAoXuZE+UWQRv2hQ84E4GtCpw3QlYeHDDMVGlv/khP7p d7uYtegpvu42aAFa6sQD1SyH1rZrBzj5t4TSxc8rPlEkaTke3BLiJktAe6a2RifN8SYR eYvjLRIFk1CuITJZpw26aol0ums9kRtck+UPICOidMh0WfLPtUekfokshS7ZXHi+Xjpb MfbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m8ejrVwLiLoS+pUm7oqY+yG/9wMKF0S3iW/Yln0D5sU=; b=FNtBJeSwrjC/MAC1WhvtEX7hksoTZPWWaAQekf5YUbxxgLfRJJC6iHsv394E2Sc/vf ZXvooXdzZFB5ZxlG1sbHq/mxfx1oIL5XBFveV4Dt/ViMjmKCEsXZCFVMIEdTt2xEViKD 9S/uG6/2AmkhGfz63w6Y4tOaxEEGUhO9ztcW1pUTkoxy84xegrxqXSqjZBiXKqXaFswv hDuCrgZCxtXWfrDDOkZzY4i0fTCEy6G4vM8fGOIsXUrNW7zV1JTTUpJNCht+aTesNi6B CwxrX63UjbpEa0EIfuVVPF69FF7/CJlNZ7xNP2iF+9OTLlj03I1ONek1929aupvrtwCh nAyg== X-Gm-Message-State: ANoB5plxQI6o5Lk0DOFfN5rh4CrD8wDSXMC3Mb2mEIkJv6wwyPq/dzZq t022DEWpctg+vza5aAeLjY/UVw== X-Google-Smtp-Source: AA0mqf6Oj5Scr7ZFq1D1a9oUP6YFMSNbIk0KY5HDj2TlLsRudxg9mnRoVWhSykG14H+U3wUPJwZWRA== X-Received: by 2002:a5d:6289:0:b0:236:ea8:a410 with SMTP id k9-20020a5d6289000000b002360ea8a410mr10256026wru.128.1668519294796; Tue, 15 Nov 2022 05:34:54 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL 09/10] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg Date: Tue, 15 Nov 2022 13:34:38 +0000 Message-Id: <20221115133439.2348929-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519491341100003 From: Peter Maydell On my machine, a debug build of QEMU takes about 260 seconds to complete this test, so with the current timeout value of 180 seconds it always times out. Double the timeout value to 360 so the test definitely has enough time to complete. Signed-off-by: Peter Maydell Signed-off-by: Alex Benn=C3=A9e Message-Id: <20221110142901.3832318-1-peter.maydell@linaro.org> Message-Id: <20221111145529.4020801-11-alex.bennee@linaro.org> diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 571d33882a..2be4be395d 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -116,7 +116,7 @@ class BootLinuxPPC64(LinuxTest): :avocado: tags=3Darch:ppc64 """ =20 - timeout =3D 180 + timeout =3D 360 =20 def test_pseries_tcg(self): """ --=20 2.34.1 From nobody Mon May 13 12:21:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1668519365; cv=none; d=zohomail.com; s=zohoarc; b=TfwvjxhJe8pAPrVltDSL6tNas6gSmYupPK0v1dkZF8lkLZsWRBd9gWNNzzddVtHTLtxdoAGJcrZUKLfP20/bu1qGa19K5MVObs+FAbcpSvVKXR89/GgMvtRVL45W3TXeAaFM9Lv1pWgZmn9/S6O9rInHDTr+WgzEc6j9rbJMB6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1668519365; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y/ae5vrQTt28MH0oBWTUQhGDSwBFm3CuIig1VKCkfko=; b=HEANhH6UpCC3bGjSyHjtRUIG8iz3RKzI1MtZb0x8xr3zp42Zi8cKLn/ixGnsvvGTSXhkn85pMFpGtPNygwcqB54EvplfiWVB4uO8dhorDUtsDea0Bdxz9ZXHrjFQ23BiZm+Ea+fNRxjo67iMA6WBeKZ5Y+zwzmG/psj9RIAtUB4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166851936545877.25564211748394; Tue, 15 Nov 2022 05:36:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouw6A-0006WK-VC; Tue, 15 Nov 2022 08:35:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouw5Y-0006JR-UW for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:59 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouw5W-0004Lf-Nm for qemu-devel@nongnu.org; Tue, 15 Nov 2022 08:34:55 -0500 Received: by mail-wr1-x42e.google.com with SMTP id w14so24273448wru.8 for ; Tue, 15 Nov 2022 05:34:54 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id n13-20020adff08d000000b002364c77bcacsm12435054wro.38.2022.11.15.05.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 05:34:44 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 407751FFC2; Tue, 15 Nov 2022 13:34:40 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y/ae5vrQTt28MH0oBWTUQhGDSwBFm3CuIig1VKCkfko=; b=VbhstaIGZSoipOm6VtzHLRWCMMPE+qGdt9UAk6pQtmLhP08uqG+TOM64tLI1RGhIoe +o86PjLoAs3nCMvC7DRj3mBtgNY02x+8HyGAX3xC+tJItB/xOnF5PHZ8Rc0QrI8Y9ByP B6Oeqiy/PK41wcpcSjUChA5imKerQTItV3/Rts+HmvUzeYXF2i0rBXvcCSG9ISCHSPgq jouz/OdzFTv5Y/l4wNUlSuMVQ2zyrXZH009CWUkSfj/fP44DVeRH70qtsCEluD+lnIAe G9qolV2wA1DcwjVW/q9YSAf+JEAC1RwaYS4vPAfCepEfZny8XMOEah2YU6wmnwFTqMtW Z4Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y/ae5vrQTt28MH0oBWTUQhGDSwBFm3CuIig1VKCkfko=; b=6laLkot7v3vItAwBOFYqjwdGT2+30rwxp8f+nUfdfV98owwPm665ioOmG3jW5iWRue g14jB7o0kItlljdSX8tPIwtkk8CBMlv6z8GoKJYi3wX8kf+P5L5pqTt1L6+eOBCpyE7w 0uqSCWBmmrdZyg76rqID0MYBKm5k6V4DjCVrdIE9qL9mSvjDhH7qQL+FS7V75fZwfuIT toN/ncn4j1/Z5b3AzolqGTDSBwgTzhmF15gP6QcskT5PO+NPyWKBfyLQPK1QZEUSazP3 QiWI/SBiMu5QQ5pxlw0qXJSJAQB3ONw+MJT+aDPu9ZJv0KyR1GFHaXKihfG3gOWF3fWf lLMg== X-Gm-Message-State: ANoB5pkEE+saCLuLgVr2g6VAP4a6T5LmwCs3MIwFnW/V4LQu9yPnnHeQ V0hQlmpsoKsUqD/U8ykjh6eGBw== X-Google-Smtp-Source: AA0mqf4jgkL65zsj/XJcnO4MAIdgMJOV5v1JmfhtRRnNypihy0siMwtqoX4A0XYVPhqoni1E/YaW9w== X-Received: by 2002:adf:e552:0:b0:236:7a97:12da with SMTP id z18-20020adfe552000000b002367a9712damr10691495wrm.237.1668519293233; Tue, 15 Nov 2022 05:34:53 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Subject: [PULL 10/10] gitlab: integrate coverage report Date: Tue, 15 Nov 2022 13:34:39 +0000 Message-Id: <20221115133439.2348929-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115133439.2348929-1-alex.bennee@linaro.org> References: <20221115133439.2348929-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1668519366512100003 This should hopefully give is nice coverage information about what our tests (or at least the subset we are running) have hit. Ideally we would want a way to trigger coverage on tests likely to be affected by the current commit. Signed-off-by: Alex Benn=C3=A9e Acked-by: Stefan Hajnoczi Message-Id: <20221111145529.4020801-12-alex.bennee@linaro.org> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 7173749c52..d21b4a1fd4 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -494,7 +494,17 @@ check-gprof-gcov: IMAGE: ubuntu2004 MAKE_CHECK_ARGS: check after_script: - - ${CI_PROJECT_DIR}/scripts/ci/coverage-summary.sh + - cd build + - gcovr --xml-pretty --exclude-unreachable-branches --print-summary + -o coverage.xml --root ${CI_PROJECT_DIR} . *.p + coverage: /^\s*lines:\s*\d+.\d+\%/ + artifacts: + name: ${CI_JOB_NAME}-${CI_COMMIT_REF_NAME}-${CI_COMMIT_SHA} + expire_in: 2 days + reports: + coverage_report: + coverage_format: cobertura + path: build/coverage.xml =20 build-oss-fuzz: extends: .native_build_job_template --=20 2.34.1