[PATCH for 8.0 0/8] Refactor cryptodev

zhenwei pi posted 8 patches 1 year, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221111064553.246932-1-pizhenwei@bytedance.com
Maintainers: "Gonglei (Arei)" <arei.gonglei@huawei.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>
There is a newer version of this series
MAINTAINERS                     |   1 +
backends/cryptodev-builtin.c    |  46 +++++++---
backends/cryptodev-lkcf.c       |  11 +--
backends/cryptodev-vhost-user.c |  13 ++-
backends/cryptodev-vhost.c      |   4 +-
backends/cryptodev.c            | 101 ++++++++++++++++++----
hmp-commands-info.hx            |  14 ++++
hw/virtio/virtio-crypto.c       |  41 +++++++--
include/monitor/hmp.h           |   1 +
include/sysemu/cryptodev.h      |  61 ++++++++------
monitor/hmp-cmds.c              |  36 ++++++++
qapi/cryptodev.json             | 144 ++++++++++++++++++++++++++++++++
qapi/meson.build                |   1 +
qapi/qapi-schema.json           |   1 +
14 files changed, 401 insertions(+), 74 deletions(-)
create mode 100644 qapi/cryptodev.json
[PATCH for 8.0 0/8] Refactor cryptodev
Posted by zhenwei pi 1 year, 6 months ago
The main changes in this series:
- introduce cryptodev.json to describe the attributes of crypto device, then
  drop duplicated type declare, remove some virtio related dependence.
- add statistics: OPS and bandwidth.
- add QMP command: query-cryptodev
- add HMP info command: cryptodev
- misc fix: detect akcipher capability instead of exposing akcipher service
  unconditionally.

Zhenwei Pi (8):
  cryptodev: Introduce cryptodev.json
  cryptodev: Remove 'name' & 'model' fields
  cryptodev: Introduce cryptodev alg type in QAPI
  cryptodev: Introduce server type in QAPI
  cryptodev: Introduce 'query-cryptodev' QMP command
  cryptodev: Support statistics
  cryptodev-builtin: Detect akcipher capability
  hmp: add cryptodev info command

 MAINTAINERS                     |   1 +
 backends/cryptodev-builtin.c    |  46 +++++++---
 backends/cryptodev-lkcf.c       |  11 +--
 backends/cryptodev-vhost-user.c |  13 ++-
 backends/cryptodev-vhost.c      |   4 +-
 backends/cryptodev.c            | 101 ++++++++++++++++++----
 hmp-commands-info.hx            |  14 ++++
 hw/virtio/virtio-crypto.c       |  41 +++++++--
 include/monitor/hmp.h           |   1 +
 include/sysemu/cryptodev.h      |  61 ++++++++------
 monitor/hmp-cmds.c              |  36 ++++++++
 qapi/cryptodev.json             | 144 ++++++++++++++++++++++++++++++++
 qapi/meson.build                |   1 +
 qapi/qapi-schema.json           |   1 +
 14 files changed, 401 insertions(+), 74 deletions(-)
 create mode 100644 qapi/cryptodev.json

-- 
2.20.1
PING: [PATCH for 8.0 0/8] Refactor cryptodev
Posted by zhenwei pi 1 year, 6 months ago
Hi, Lei

Dr. David Alan Gilbert has already reviewed the hmp part, could you 
please review the cryptodev/virtio-crypto part?

I volunteer to co-maintain the cryptodev part, I'd like to add myself as 
cryptodev maintainer in the next version, do you have any suggestion?

On 11/11/22 14:45, zhenwei pi wrote:
> The main changes in this series:
> - introduce cryptodev.json to describe the attributes of crypto device, then
>    drop duplicated type declare, remove some virtio related dependence.
> - add statistics: OPS and bandwidth.
> - add QMP command: query-cryptodev
> - add HMP info command: cryptodev
> - misc fix: detect akcipher capability instead of exposing akcipher service
>    unconditionally.
> 
> Zhenwei Pi (8):
>    cryptodev: Introduce cryptodev.json
>    cryptodev: Remove 'name' & 'model' fields
>    cryptodev: Introduce cryptodev alg type in QAPI
>    cryptodev: Introduce server type in QAPI
>    cryptodev: Introduce 'query-cryptodev' QMP command
>    cryptodev: Support statistics
>    cryptodev-builtin: Detect akcipher capability
>    hmp: add cryptodev info command
> 
>   MAINTAINERS                     |   1 +
>   backends/cryptodev-builtin.c    |  46 +++++++---
>   backends/cryptodev-lkcf.c       |  11 +--
>   backends/cryptodev-vhost-user.c |  13 ++-
>   backends/cryptodev-vhost.c      |   4 +-
>   backends/cryptodev.c            | 101 ++++++++++++++++++----
>   hmp-commands-info.hx            |  14 ++++
>   hw/virtio/virtio-crypto.c       |  41 +++++++--
>   include/monitor/hmp.h           |   1 +
>   include/sysemu/cryptodev.h      |  61 ++++++++------
>   monitor/hmp-cmds.c              |  36 ++++++++
>   qapi/cryptodev.json             | 144 ++++++++++++++++++++++++++++++++
>   qapi/meson.build                |   1 +
>   qapi/qapi-schema.json           |   1 +
>   14 files changed, 401 insertions(+), 74 deletions(-)
>   create mode 100644 qapi/cryptodev.json
> 

-- 
zhenwei pi