[v2] Fix the "-nic help" option

[PATCH v2 0/3] Fix the "-nic help" option

Thomas Huth posted 3 patches 1 year, 5 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221110125224.99596-1-thuth@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Jason Wang <jasowang@redhat.com>

include/net/net.h | 14 +++++++++++++
hw/pci/pci.c      | 29 +--------------------------
net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
3 files changed, 62 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH v2 0/3] Fix the "-nic help" option

Posted by Thomas Huth 1 year, 5 months ago

Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier
versions, but since QEMU 6.0 it just complains that "help" is not
a valid value here. This patch series fixes this problem and also
extends the help output here to list the available NIC models, too.

v2: 
 - Add function comment in the first patch
 - Add Reviewed-by in the third patch

Thomas Huth (3):
  net: Move the code to collect available NIC models to a separate
    function
  net: Restore printing of the help text with "-nic help"
  net: Replace "Supported NIC models" with "Available NIC models"

 include/net/net.h | 14 +++++++++++++
 hw/pci/pci.c      | 29 +--------------------------
 net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
 3 files changed, 62 insertions(+), 31 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/3] Fix the "-nic help" option

Posted by Thomas Huth 1 year, 4 months ago

On 10/11/2022 13.52, Thomas Huth wrote:
> Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier
> versions, but since QEMU 6.0 it just complains that "help" is not
> a valid value here. This patch series fixes this problem and also
> extends the help output here to list the available NIC models, too.
> 
> v2:
>   - Add function comment in the first patch
>   - Add Reviewed-by in the third patch
> 
> Thomas Huth (3):
>    net: Move the code to collect available NIC models to a separate
>      function
>    net: Restore printing of the help text with "-nic help"
>    net: Replace "Supported NIC models" with "Available NIC models"
> 
>   include/net/net.h | 14 +++++++++++++
>   hw/pci/pci.c      | 29 +--------------------------
>   net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
>   3 files changed, 62 insertions(+), 31 deletions(-)
> 

Friendly ping!

  Thomas

Re: [PATCH v2 0/3] Fix the "-nic help" option

Posted by Jason Wang 1 year, 4 months ago

On Thu, Dec 15, 2022 at 11:23 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 10/11/2022 13.52, Thomas Huth wrote:
> > Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier
> > versions, but since QEMU 6.0 it just complains that "help" is not
> > a valid value here. This patch series fixes this problem and also
> > extends the help output here to list the available NIC models, too.
> >
> > v2:
> >   - Add function comment in the first patch
> >   - Add Reviewed-by in the third patch
> >
> > Thomas Huth (3):
> >    net: Move the code to collect available NIC models to a separate
> >      function
> >    net: Restore printing of the help text with "-nic help"
> >    net: Replace "Supported NIC models" with "Available NIC models"
> >
> >   include/net/net.h | 14 +++++++++++++
> >   hw/pci/pci.c      | 29 +--------------------------
> >   net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
> >   3 files changed, 62 insertions(+), 31 deletions(-)
> >
>
> Friendly ping!

I've queued this series.

Thanks

>
>   Thomas
>