tests/qtest/libqos/e1000e: Correctly group register accesses

[PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses

Akihiko Odaki posted 1 patch 1 year, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221110114549.66081-1-akihiko.odaki@daynix.com

Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/libqos/e1000e.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses

Posted by Akihiko Odaki 1 year, 6 months ago

Add a newline after E1000_TCTL write and make it clear that E1000_TCTL
write is what enabling transmit.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/qtest/libqos/e1000e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
index 80b3e3db90..0e5cceafe4 100644
--- a/tests/qtest/libqos/e1000e.c
+++ b/tests/qtest/libqos/e1000e.c
@@ -152,6 +152,7 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)
 
     /* Enable transmit */
     e1000e_macreg_write(&d->e1000e, E1000_TCTL, E1000_TCTL_EN);
+
     e1000e_macreg_write(&d->e1000e, E1000_RDBAL,
                            (uint32_t)d->e1000e.rx_ring);
     e1000e_macreg_write(&d->e1000e, E1000_RDBAH,
-- 
2.38.1

Re: [PATCH] tests/qtest/libqos/e1000e: Correctly group register accesses

Posted by Thomas Huth 1 year, 5 months ago

On 10/11/2022 12.45, Akihiko Odaki wrote:
> Add a newline after E1000_TCTL write and make it clear that E1000_TCTL
> write is what enabling transmit.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   tests/qtest/libqos/e1000e.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c
> index 80b3e3db90..0e5cceafe4 100644
> --- a/tests/qtest/libqos/e1000e.c
> +++ b/tests/qtest/libqos/e1000e.c
> @@ -152,6 +152,7 @@ static void e1000e_pci_start_hw(QOSGraphObject *obj)
>   
>       /* Enable transmit */
>       e1000e_macreg_write(&d->e1000e, E1000_TCTL, E1000_TCTL_EN);
> +
>       e1000e_macreg_write(&d->e1000e, E1000_RDBAL,
>                              (uint32_t)d->e1000e.rx_ring);
>       e1000e_macreg_write(&d->e1000e, E1000_RDBAH,

Thanks, queued:

  https://gitlab.com/thuth/qemu/-/commits/testing-next/

  Thomas