Add missing include statement for global xml_builtin

[PATCH] Add missing include statement for global xml_builtin

Stefan Weil via posted 1 patch 1 year, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221103083815.464612-1-sw@weilnetz.de

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

scripts/feature_to_c.sh | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] Add missing include statement for global xml_builtin

Posted by Stefan Weil via 1 year, 6 months ago

This fixes some compiler warnings with compiler flag
-Wmissing-variable-declarations (tested with clang):

    aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]
    aarch64-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]
    aarch64-softmmu-gdbstub-xml.c:1763:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 scripts/feature_to_c.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/feature_to_c.sh b/scripts/feature_to_c.sh
index b1169899c1..c1f67c8f6a 100644
--- a/scripts/feature_to_c.sh
+++ b/scripts/feature_to_c.sh
@@ -56,6 +56,7 @@ for input; do
 done
 
 echo
+echo '#include "exec/gdbstub.h"'
 echo "const char *const xml_builtin[][2] = {"
 
 for input; do
-- 
2.30.2

Re: [PATCH] Add missing include statement for global xml_builtin

Posted by Paolo Bonzini 1 year, 6 months ago

Queued, thanks.

Paolo

Re: [PATCH] Add missing include statement for global xml_builtin

Posted by Philippe Mathieu-Daudé 1 year, 6 months ago

On 3/11/22 09:38, Stefan Weil via wrote:
> This fixes some compiler warnings with compiler flag
> -Wmissing-variable-declarations (tested with clang):
> 
>      aarch64_be-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]
>      aarch64-linux-user-gdbstub-xml.c:564:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]
>      aarch64-softmmu-gdbstub-xml.c:1763:19: warning: no previous extern declaration for non-static variable 'xml_builtin' [-Wmissing-variable-declarations]
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>   scripts/feature_to_c.sh | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>