From nobody Sun May 19 03:12:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1667118985; cv=none; d=zohomail.com; s=zohoarc; b=jZQ9viE3Rii2PeE/irD/D4HjL8h6pt8uKAkNWEv+FuwQ9dKZ3cExkrAJUeQPowtfI12oezHR3SYUc67y0ONfVeqz5vLDztS5NlFn/C0l/x5Ee0PZPB7q05OMpT/cIEJ6TF1VGUF60qjW5DmezwMlCn8qgRu/rTcuxzASDlKQL1Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667118985; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=tVHd5DS8dK+tN94EjwwIlbikT3uEgw7TyKJkg0OO81U=; b=M/rTqCbIb3n/MF3oyrAu3KdmGIaHNpaD/usq/2K7HJV1czw3XVNapUAoO/34TMr3B34b8PB5k2J5axrhXpCCHacX020WkUnl5FD+V+3pYJ5ibUd1qil+hKAfJHbxQeTgCttCpVoJMO5fsXpvM3gc4MFCkHHMvpeK9A6IdTANbWk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 166711898577471.43955409380692; Sun, 30 Oct 2022 01:36:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op3n0-0003YJ-M6; Sun, 30 Oct 2022 04:35:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op3my-0003Y2-T2 for qemu-devel@nongnu.org; Sun, 30 Oct 2022 04:35:28 -0400 Received: from mail.weilnetz.de ([37.120.169.71] helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op3mu-0004BW-Fz for qemu-devel@nongnu.org; Sun, 30 Oct 2022 04:35:28 -0400 Received: from qemu.weilnetz.de (qemu.weilnetz.de [188.68.58.204]) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTP id 8F959DA08AD; Sun, 30 Oct 2022 09:35:20 +0100 (CET) Received: by qemu.weilnetz.de (Postfix, from userid 1000) id 4E27A46001C; Sun, 30 Oct 2022 09:35:20 +0100 (CET) To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefan Weil Subject: [PATCH] Run docker probe only if docker or podman are available Date: Sun, 30 Oct 2022 09:35:10 +0100 Message-Id: <20221030083510.310584-1-sw@weilnetz.de> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=37.120.169.71; envelope-from=stefan@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Reply-to: Stefan Weil From: Stefan Weil via Errors-To: qemu-devel-bounces+importer=patchew.org+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1667118988329100001 Content-Type: text/plain; charset="utf-8" The docker probe uses "sudo -n" which can cause an e-mail with a security w= arning each time when configure is run. Therefore run docker probe only if either = docker or podman are available. That avoids the problematic "sudo -n" on build environments which have neit= her docker nor podman installed. Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.= mak") Signed-off-by: Stefan Weil --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 81561be7c1..3af99282b7 100755 --- a/configure +++ b/configure @@ -1779,7 +1779,7 @@ fi # functions to probe cross compilers =20 container=3D"no" -if test $use_containers =3D "yes"; then +if test $use_containers =3D "yes" && (has "docker" || has "podman"); then case $($python "$source_path"/tests/docker/docker.py probe) in *docker) container=3Ddocker ;; podman) container=3Dpodman ;; --=20 2.30.2