[PULL 00/62] ppc queue

Daniel Henrique Barboza posted 62 patches 1 year, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221028163951.810456-1-danielhb413@gmail.com
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Cédric Le Goater" <clg@kaod.org>, Daniel Henrique Barboza <danielhb413@gmail.com>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>, Bin Meng <bin.meng@windriver.com>
There is a newer version of this series
docs/system/ppc/ppce500.rst                    |  25 +-
hw/block/pflash_cfi01.c                        |   8 +-
hw/block/pflash_cfi02.c                        |   5 +
hw/ppc/Kconfig                                 |   1 +
hw/ppc/e500.c                                  |  79 +++
hw/ppc/meson.build                             |   3 +-
hw/ppc/pnv_core.c                              |   1 +
hw/ppc/ppc.c                                   |  17 +-
hw/ppc/ppc440_uc.c                             | 332 ----------
hw/ppc/ppc4xx_devs.c                           | 414 ------------
hw/ppc/ppc4xx_sdram.c                          | 757 ++++++++++++++++++++++
hw/ppc/spapr_hcall.c                           |   6 +
hw/ppc/spapr_rtas.c                            |   2 +-
hw/ppc/trace-events                            |   3 +-
hw/sd/sdhci-internal.h                         |  20 -
hw/sd/sdhci.c                                  |  63 +-
include/hw/ppc/ppc4xx.h                        |  20 +-
target/ppc/cpu.c                               |   4 +
target/ppc/cpu.h                               |  47 +-
target/ppc/cpu_init.c                          | 212 +-----
target/ppc/excp_helper.c                       | 863 ++++++++++++++++++++++---
target/ppc/fpu_helper.c                        | 137 ++--
target/ppc/helper.h                            |  44 +-
target/ppc/helper_regs.c                       |   8 +
target/ppc/insn32.decode                       |  58 ++
target/ppc/int_helper.c                        | 107 +--
target/ppc/misc_helper.c                       |  11 +-
target/ppc/power8-pmu.c                        |  74 +--
target/ppc/power8-pmu.h                        |   3 +
target/ppc/translate.c                         | 130 ++--
target/ppc/translate/processor-ctrl-impl.c.inc | 105 +++
target/ppc/translate/vmx-impl.c.inc            | 352 ++++++++--
target/ppc/translate/vmx-ops.c.inc             |  15 +-
target/ppc/translate/vsx-impl.c.inc            | 375 +++++++++--
target/ppc/translate/vsx-ops.c.inc             |  21 -
35 files changed, 2715 insertions(+), 1607 deletions(-)
create mode 100644 hw/ppc/ppc4xx_sdram.c
create mode 100644 target/ppc/translate/processor-ctrl-impl.c.inc
[PULL 00/62] ppc queue
Posted by Daniel Henrique Barboza 1 year, 6 months ago
The following changes since commit 344744e148e6e865f5a57e745b02a87e5ea534ad:

  Merge tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2022-10-26 10:53:49 -0400)

are available in the Git repository at:

  https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20221028

for you to fetch changes up to 1a4ef9d45dbe6be588735a989e8ed3764a2fcf49:

  hw/ppc/e500: Implement pflash handling (2022-10-28 13:26:20 -0300)

----------------------------------------------------------------
ppc patch queue for 2022-10-28:

This queue has the second part of the ppc4xx_sdram cleanups, doorbell
instructions for POWER8 and new pflash handling for the e500 machine.

It also has a lot of performance optimizations in the PowerPC emulation
done by the researchers of the Eldorado institute. Between using gvec
for VMX/VSX instructions, a full rework of the interrupt model and PMU
optimizations, they managed to drastically speed up the emulation of
powernv8/9/10 machines.  Here's an example with avocado tests:

- with master:

tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv8:
PASS (38.89 s)
tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv9:
PASS (43.89 s)

- with this queue applied:

tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv8:
PASS (21.23 s)
tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv9:
PASS (22.58 s)

Other ppc machines, like pseries, also had a noticeable performance
boost.

----------------------------------------------------------------
BALATON Zoltan (8):
      ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.c
      ppc4xx_devs.c: Move DDR SDRAM controller model to ppc4xx_sdram.c
      ppc4xx_sdram: Move ppc4xx_sdram_banks() to ppc4xx_sdram.c
      ppc4xx_sdram: Use hwaddr for memory bank size
      ppc4xx_sdram: Rename local state variable for brevity
      ppc4xx_sdram: Generalise bank setup
      ppc4xx_sdram: Convert DDR SDRAM controller to new bank handling
      ppc4xx_sdram: Add errp parameter to ppc4xx_sdram_banks()

Bernhard Beschow (5):
      docs/system/ppc/ppce500: Use qemu-system-ppc64 across the board(s)
      hw/block/pflash_cfi0{1, 2}: Error out if device length isn't a power of two
      hw/sd/sdhci-internal: Unexport ESDHC defines
      hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*
      hw/ppc/e500: Implement pflash handling

Leandro Lupori (2):
      target/ppc: Add new PMC HFLAGS
      target/ppc: Increment PMC5 with inline insns

Lucas Mateus Castro (alqotel) (12):
      target/ppc: Moved VMLADDUHM to decodetree and use gvec
      target/ppc: Move VMH[R]ADDSHS instruction to decodetree
      target/ppc: Move V(ADD|SUB)CUW to decodetree and use gvec
      target/ppc: Move VNEG[WD] to decodtree and use gvec
      target/ppc: Move VPRTYB[WDQ] to decodetree and use gvec
      target/ppc: Move VAVG[SU][BHW] to decodetree and use gvec
      target/ppc: Move VABSDU[BHW] to decodetree and use gvec
      target/ppc: Use gvec to decode XV[N]ABS[DS]P/XVNEG[DS]P
      target/ppc: Use gvec to decode XVCPSGN[SD]P
      target/ppc: Moved XVTSTDC[DS]P to decodetree
      target/ppc: Moved XSTSTDC[QDS]P to decodetree
      target/ppc: Use gvec to decode XVTSTDC[DS]P

Matheus Ferst (35):
      target/ppc: fix msgclr/msgsnd insns flags
      target/ppc: fix msgsync insns flags
      target/ppc: fix REQUIRE_HV macro definition
      target/ppc: move msgclr/msgsnd to decodetree
      target/ppc: move msgclrp/msgsndp to decodetree
      target/ppc: move msgsync to decodetree
      target/ppc: define PPC_INTERRUPT_* values directly
      target/ppc: always use ppc_set_irq to set env->pending_interrupts
      target/ppc: split interrupt masking and delivery from ppc_hw_interrupt
      target/ppc: prepare to split interrupt masking and delivery by excp_model
      target/ppc: create an interrupt masking method for POWER9/POWER10
      target/ppc: remove unused interrupts from p9_next_unmasked_interrupt
      target/ppc: create an interrupt deliver method for POWER9/POWER10
      target/ppc: remove unused interrupts from p9_deliver_interrupt
      target/ppc: remove generic architecture checks from p9_deliver_interrupt
      target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER9
      target/ppc: add power-saving interrupt masking logic to p9_next_unmasked_interrupt
      target/ppc: create an interrupt masking method for POWER8
      target/ppc: remove unused interrupts from p8_next_unmasked_interrupt
      target/ppc: create an interrupt deliver method for POWER8
      target/ppc: remove unused interrupts from p8_deliver_interrupt
      target/ppc: remove generic architecture checks from p8_deliver_interrupt
      target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER8
      target/ppc: add power-saving interrupt masking logic to p8_next_unmasked_interrupt
      target/ppc: create an interrupt masking method for POWER7
      target/ppc: remove unused interrupts from p7_next_unmasked_interrupt
      target/ppc: create an interrupt deliver method for POWER7
      target/ppc: remove unused interrupts from p7_deliver_interrupt
      target/ppc: remove generic architecture checks from p7_deliver_interrupt
      target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER7
      target/ppc: add power-saving interrupt masking logic to p7_next_unmasked_interrupt
      target/ppc: remove ppc_store_lpcr from CONFIG_USER_ONLY builds
      target/ppc: introduce ppc_maybe_interrupt
      target/ppc: unify cpu->has_work based on cs->interrupt_request
      target/ppc: move the p*_interrupt_powersave methods to excp_helper.c

 docs/system/ppc/ppce500.rst                    |  25 +-
 hw/block/pflash_cfi01.c                        |   8 +-
 hw/block/pflash_cfi02.c                        |   5 +
 hw/ppc/Kconfig                                 |   1 +
 hw/ppc/e500.c                                  |  79 +++
 hw/ppc/meson.build                             |   3 +-
 hw/ppc/pnv_core.c                              |   1 +
 hw/ppc/ppc.c                                   |  17 +-
 hw/ppc/ppc440_uc.c                             | 332 ----------
 hw/ppc/ppc4xx_devs.c                           | 414 ------------
 hw/ppc/ppc4xx_sdram.c                          | 757 ++++++++++++++++++++++
 hw/ppc/spapr_hcall.c                           |   6 +
 hw/ppc/spapr_rtas.c                            |   2 +-
 hw/ppc/trace-events                            |   3 +-
 hw/sd/sdhci-internal.h                         |  20 -
 hw/sd/sdhci.c                                  |  63 +-
 include/hw/ppc/ppc4xx.h                        |  20 +-
 target/ppc/cpu.c                               |   4 +
 target/ppc/cpu.h                               |  47 +-
 target/ppc/cpu_init.c                          | 212 +-----
 target/ppc/excp_helper.c                       | 863 ++++++++++++++++++++++---
 target/ppc/fpu_helper.c                        | 137 ++--
 target/ppc/helper.h                            |  44 +-
 target/ppc/helper_regs.c                       |   8 +
 target/ppc/insn32.decode                       |  58 ++
 target/ppc/int_helper.c                        | 107 +--
 target/ppc/misc_helper.c                       |  11 +-
 target/ppc/power8-pmu.c                        |  74 +--
 target/ppc/power8-pmu.h                        |   3 +
 target/ppc/translate.c                         | 130 ++--
 target/ppc/translate/processor-ctrl-impl.c.inc | 105 +++
 target/ppc/translate/vmx-impl.c.inc            | 352 ++++++++--
 target/ppc/translate/vmx-ops.c.inc             |  15 +-
 target/ppc/translate/vsx-impl.c.inc            | 375 +++++++++--
 target/ppc/translate/vsx-ops.c.inc             |  21 -
 35 files changed, 2715 insertions(+), 1607 deletions(-)
 create mode 100644 hw/ppc/ppc4xx_sdram.c
 create mode 100644 target/ppc/translate/processor-ctrl-impl.c.inc
Re: [PULL 00/62] ppc queue
Posted by Daniel Henrique Barboza 1 year, 6 months ago
Stefan,

I'll re-send this pull request due to a last minute regression that was
fixed a couple hours ago.


Thanks,


Daniel

On 10/28/22 13:38, Daniel Henrique Barboza wrote:
> The following changes since commit 344744e148e6e865f5a57e745b02a87e5ea534ad:
> 
>    Merge tag 'dump-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2022-10-26 10:53:49 -0400)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/danielhb/qemu.git tags/pull-ppc-20221028
> 
> for you to fetch changes up to 1a4ef9d45dbe6be588735a989e8ed3764a2fcf49:
> 
>    hw/ppc/e500: Implement pflash handling (2022-10-28 13:26:20 -0300)
> 
> ----------------------------------------------------------------
> ppc patch queue for 2022-10-28:
> 
> This queue has the second part of the ppc4xx_sdram cleanups, doorbell
> instructions for POWER8 and new pflash handling for the e500 machine.
> 
> It also has a lot of performance optimizations in the PowerPC emulation
> done by the researchers of the Eldorado institute. Between using gvec
> for VMX/VSX instructions, a full rework of the interrupt model and PMU
> optimizations, they managed to drastically speed up the emulation of
> powernv8/9/10 machines.  Here's an example with avocado tests:
> 
> - with master:
> 
> tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv8:
> PASS (38.89 s)
> tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv9:
> PASS (43.89 s)
> 
> - with this queue applied:
> 
> tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv8:
> PASS (21.23 s)
> tests/avocado/boot_linux_console.py:BootLinuxConsole.test_ppc_powernv9:
> PASS (22.58 s)
> 
> Other ppc machines, like pseries, also had a noticeable performance
> boost.
> 
> ----------------------------------------------------------------
> BALATON Zoltan (8):
>        ppc440_uc.c: Move DDR2 SDRAM controller model to ppc4xx_sdram.c
>        ppc4xx_devs.c: Move DDR SDRAM controller model to ppc4xx_sdram.c
>        ppc4xx_sdram: Move ppc4xx_sdram_banks() to ppc4xx_sdram.c
>        ppc4xx_sdram: Use hwaddr for memory bank size
>        ppc4xx_sdram: Rename local state variable for brevity
>        ppc4xx_sdram: Generalise bank setup
>        ppc4xx_sdram: Convert DDR SDRAM controller to new bank handling
>        ppc4xx_sdram: Add errp parameter to ppc4xx_sdram_banks()
> 
> Bernhard Beschow (5):
>        docs/system/ppc/ppce500: Use qemu-system-ppc64 across the board(s)
>        hw/block/pflash_cfi0{1, 2}: Error out if device length isn't a power of two
>        hw/sd/sdhci-internal: Unexport ESDHC defines
>        hw/sd/sdhci: Rename ESDHC_* defines to USDHC_*
>        hw/ppc/e500: Implement pflash handling
> 
> Leandro Lupori (2):
>        target/ppc: Add new PMC HFLAGS
>        target/ppc: Increment PMC5 with inline insns
> 
> Lucas Mateus Castro (alqotel) (12):
>        target/ppc: Moved VMLADDUHM to decodetree and use gvec
>        target/ppc: Move VMH[R]ADDSHS instruction to decodetree
>        target/ppc: Move V(ADD|SUB)CUW to decodetree and use gvec
>        target/ppc: Move VNEG[WD] to decodtree and use gvec
>        target/ppc: Move VPRTYB[WDQ] to decodetree and use gvec
>        target/ppc: Move VAVG[SU][BHW] to decodetree and use gvec
>        target/ppc: Move VABSDU[BHW] to decodetree and use gvec
>        target/ppc: Use gvec to decode XV[N]ABS[DS]P/XVNEG[DS]P
>        target/ppc: Use gvec to decode XVCPSGN[SD]P
>        target/ppc: Moved XVTSTDC[DS]P to decodetree
>        target/ppc: Moved XSTSTDC[QDS]P to decodetree
>        target/ppc: Use gvec to decode XVTSTDC[DS]P
> 
> Matheus Ferst (35):
>        target/ppc: fix msgclr/msgsnd insns flags
>        target/ppc: fix msgsync insns flags
>        target/ppc: fix REQUIRE_HV macro definition
>        target/ppc: move msgclr/msgsnd to decodetree
>        target/ppc: move msgclrp/msgsndp to decodetree
>        target/ppc: move msgsync to decodetree
>        target/ppc: define PPC_INTERRUPT_* values directly
>        target/ppc: always use ppc_set_irq to set env->pending_interrupts
>        target/ppc: split interrupt masking and delivery from ppc_hw_interrupt
>        target/ppc: prepare to split interrupt masking and delivery by excp_model
>        target/ppc: create an interrupt masking method for POWER9/POWER10
>        target/ppc: remove unused interrupts from p9_next_unmasked_interrupt
>        target/ppc: create an interrupt deliver method for POWER9/POWER10
>        target/ppc: remove unused interrupts from p9_deliver_interrupt
>        target/ppc: remove generic architecture checks from p9_deliver_interrupt
>        target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER9
>        target/ppc: add power-saving interrupt masking logic to p9_next_unmasked_interrupt
>        target/ppc: create an interrupt masking method for POWER8
>        target/ppc: remove unused interrupts from p8_next_unmasked_interrupt
>        target/ppc: create an interrupt deliver method for POWER8
>        target/ppc: remove unused interrupts from p8_deliver_interrupt
>        target/ppc: remove generic architecture checks from p8_deliver_interrupt
>        target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER8
>        target/ppc: add power-saving interrupt masking logic to p8_next_unmasked_interrupt
>        target/ppc: create an interrupt masking method for POWER7
>        target/ppc: remove unused interrupts from p7_next_unmasked_interrupt
>        target/ppc: create an interrupt deliver method for POWER7
>        target/ppc: remove unused interrupts from p7_deliver_interrupt
>        target/ppc: remove generic architecture checks from p7_deliver_interrupt
>        target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER7
>        target/ppc: add power-saving interrupt masking logic to p7_next_unmasked_interrupt
>        target/ppc: remove ppc_store_lpcr from CONFIG_USER_ONLY builds
>        target/ppc: introduce ppc_maybe_interrupt
>        target/ppc: unify cpu->has_work based on cs->interrupt_request
>        target/ppc: move the p*_interrupt_powersave methods to excp_helper.c
> 
>   docs/system/ppc/ppce500.rst                    |  25 +-
>   hw/block/pflash_cfi01.c                        |   8 +-
>   hw/block/pflash_cfi02.c                        |   5 +
>   hw/ppc/Kconfig                                 |   1 +
>   hw/ppc/e500.c                                  |  79 +++
>   hw/ppc/meson.build                             |   3 +-
>   hw/ppc/pnv_core.c                              |   1 +
>   hw/ppc/ppc.c                                   |  17 +-
>   hw/ppc/ppc440_uc.c                             | 332 ----------
>   hw/ppc/ppc4xx_devs.c                           | 414 ------------
>   hw/ppc/ppc4xx_sdram.c                          | 757 ++++++++++++++++++++++
>   hw/ppc/spapr_hcall.c                           |   6 +
>   hw/ppc/spapr_rtas.c                            |   2 +-
>   hw/ppc/trace-events                            |   3 +-
>   hw/sd/sdhci-internal.h                         |  20 -
>   hw/sd/sdhci.c                                  |  63 +-
>   include/hw/ppc/ppc4xx.h                        |  20 +-
>   target/ppc/cpu.c                               |   4 +
>   target/ppc/cpu.h                               |  47 +-
>   target/ppc/cpu_init.c                          | 212 +-----
>   target/ppc/excp_helper.c                       | 863 ++++++++++++++++++++++---
>   target/ppc/fpu_helper.c                        | 137 ++--
>   target/ppc/helper.h                            |  44 +-
>   target/ppc/helper_regs.c                       |   8 +
>   target/ppc/insn32.decode                       |  58 ++
>   target/ppc/int_helper.c                        | 107 +--
>   target/ppc/misc_helper.c                       |  11 +-
>   target/ppc/power8-pmu.c                        |  74 +--
>   target/ppc/power8-pmu.h                        |   3 +
>   target/ppc/translate.c                         | 130 ++--
>   target/ppc/translate/processor-ctrl-impl.c.inc | 105 +++
>   target/ppc/translate/vmx-impl.c.inc            | 352 ++++++++--
>   target/ppc/translate/vmx-ops.c.inc             |  15 +-
>   target/ppc/translate/vsx-impl.c.inc            | 375 +++++++++--
>   target/ppc/translate/vsx-ops.c.inc             |  21 -
>   35 files changed, 2715 insertions(+), 1607 deletions(-)
>   create mode 100644 hw/ppc/ppc4xx_sdram.c
>   create mode 100644 target/ppc/translate/processor-ctrl-impl.c.inc