Endianess and coding style fixes for SVQ event idx support

[PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

Posted by Eugenio Pérez 1 year, 6 months ago

Some fixes that did not get in time for the last net pull request.

Eugenio Pérez (4):
  vhost: Delete useless casting
  vhost: convert byte order on SVQ used event write
  vhost: Fix lines over 80 characters
  vhost: convert byte order on avail_event read

 hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

-- 
2.31.1

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

Posted by Jason Wang 1 year, 6 months ago

On Sat, Oct 29, 2022 at 12:02 AM Eugenio Pérez <eperezma@redhat.com> wrote:
>
> Some fixes that did not get in time for the last net pull request.
>
> Eugenio Pérez (4):
>   vhost: Delete useless casting
>   vhost: convert byte order on SVQ used event write
>   vhost: Fix lines over 80 characters
>   vhost: convert byte order on avail_event read

I've queued this for rc1.

Thanks

>
>  hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> --
> 2.31.1
>
>

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

Posted by Michael S. Tsirkin 1 year, 6 months ago

On Fri, Oct 28, 2022 at 06:02:47PM +0200, Eugenio Pérez wrote:
> Some fixes that did not get in time for the last net pull request.


Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Jason's tree since he has some bits this depends on.

> Eugenio Pérez (4):
>   vhost: Delete useless casting
>   vhost: convert byte order on SVQ used event write
>   vhost: Fix lines over 80 characters
>   vhost: convert byte order on avail_event read
> 
>  hw/virtio/vhost-shadow-virtqueue.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> -- 
> 2.31.1
>

Re: [PATCH 0/4] Endianess and coding style fixes for SVQ event idx support

Posted by Philippe Mathieu-Daudé 1 year, 6 months ago

On 29/10/22 10:24, Michael S. Tsirkin wrote:
> On Fri, Oct 28, 2022 at 06:02:47PM +0200, Eugenio Pérez wrote:
>> Some fixes that did not get in time for the last net pull request.
> 
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Jason's tree since he has some bits this depends on.
FYI I made 2 comments/questions whether using the virtio LD/ST API
isn't more appropriate here.