[PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN

clay.mayers@kioxia.com posted 4 patches 1 year, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20221021001835.942642-1-clay.mayers@kioxia.com
Maintainers: Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>, Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
There is a newer version of this series
docs/system/devices/nvme.rst |   5 ++
hw/nvme/ctrl.c               | 166 +++++++++++++++++++++++++++++++++--
hw/nvme/ns.c                 |  15 ++++
hw/nvme/nvme.h               |  37 +++++++-
hw/nvme/trace-events         |   3 +-
include/block/nvme.h         |  14 ++-
6 files changed, 225 insertions(+), 15 deletions(-)
[PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN
Posted by clay.mayers@kioxia.com 1 year, 6 months ago
From: Clay Mayers <clay.mayers@kioxia.com>

ZNS controllers have the option to limit the time a zone can remain in
the active state.  It begins with a background process in the controller
setting the finish-zone-recommended FZR attribute for a zone.  As part of
setting this attribute, the zone's id is added to the namespace's
zone-descriptor-changed (ZDC) log page. If enabled, items added to the
ZDC log page generate a ZDC "asynchronous event notification" AEN. Optionally,
the control can induce a "zone excursion" forcing the zone into the finished
state that also generates a ZDC event.

Zone enabled applications need to properly handle ZDC events. In a real device,
the timeout is many hours making testing an application difficult.
Implemented is the generation of FZR ZDC events to speed up O/S and application
testing.

Added to the zoned NVMe command set is an optional, per-namespace timer
(zoned.finish_time) to set the FZR attr for long-lived active zones; A per
namespace ZDC log page; AEN results to including CQE.DW1 (the NSID of the ZDC
AEN) and generating a ZDC AEN if it's been enabled. Zone excursions are not
modeled.

See section 5.5 of the NVMe Zoned Namespace Command Set Specification v1.1
for more details.

Clay Mayers (4):
  hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality
  hw/block/nvme: add zone descriptor changed log page
  hw/block/nvme: supply dw1 for aen result
  hw/block/nvme: add zone descriptor changed AEN

 docs/system/devices/nvme.rst |   5 ++
 hw/nvme/ctrl.c               | 166 +++++++++++++++++++++++++++++++++--
 hw/nvme/ns.c                 |  15 ++++
 hw/nvme/nvme.h               |  37 +++++++-
 hw/nvme/trace-events         |   3 +-
 include/block/nvme.h         |  14 ++-
 6 files changed, 225 insertions(+), 15 deletions(-)

-- 
2.27.0
Re: [PATCH 0/4] hw/block/nvme: Implement ZNS finish-zone ZDC AEN
Posted by Klaus Jensen 1 year, 6 months ago
On Okt 20 17:18, clay.mayers@kioxia.com wrote:
> From: Clay Mayers <clay.mayers@kioxia.com>
> 
> ZNS controllers have the option to limit the time a zone can remain in
> the active state.  It begins with a background process in the controller
> setting the finish-zone-recommended FZR attribute for a zone.  As part of
> setting this attribute, the zone's id is added to the namespace's
> zone-descriptor-changed (ZDC) log page. If enabled, items added to the
> ZDC log page generate a ZDC "asynchronous event notification" AEN. Optionally,
> the control can induce a "zone excursion" forcing the zone into the finished
> state that also generates a ZDC event.
> 
> Zone enabled applications need to properly handle ZDC events. In a real device,
> the timeout is many hours making testing an application difficult.
> Implemented is the generation of FZR ZDC events to speed up O/S and application
> testing.
> 
> Added to the zoned NVMe command set is an optional, per-namespace timer
> (zoned.finish_time) to set the FZR attr for long-lived active zones; A per
> namespace ZDC log page; AEN results to including CQE.DW1 (the NSID of the ZDC
> AEN) and generating a ZDC AEN if it's been enabled. Zone excursions are not
> modeled.
> 
> See section 5.5 of the NVMe Zoned Namespace Command Set Specification v1.1
> for more details.
> 
> Clay Mayers (4):
>   hw/block/nvme: add ZONE_FINISH_RECOMMENDED functionality
>   hw/block/nvme: add zone descriptor changed log page
>   hw/block/nvme: supply dw1 for aen result
>   hw/block/nvme: add zone descriptor changed AEN
> 
>  docs/system/devices/nvme.rst |   5 ++
>  hw/nvme/ctrl.c               | 166 +++++++++++++++++++++++++++++++++--
>  hw/nvme/ns.c                 |  15 ++++
>  hw/nvme/nvme.h               |  37 +++++++-
>  hw/nvme/trace-events         |   3 +-
>  include/block/nvme.h         |  14 ++-
>  6 files changed, 225 insertions(+), 15 deletions(-)
> 
> -- 
> 2.27.0
> 


Hi Clay,

Thanks! Very nicely done, I have only a few comments on the individual
patches.

Adding Dmitry on CC.