Event idx helps to reduce the number of notifications between the device
and the driver. It allows them to specify an index on the circular
descriptors rings where to issue the notification, instead of a single
binary indicator.

Adding support for SVQ.

These patches are sent on top of [1] series, so trivial conflicts could arise
if it is applied directly on master. Future versions can be not based on
it is more convenient.

[1] https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg03280.html

Eugenio Pérez (4):
  vhost: allocate event_idx fields on vring
  vhost: toggle device callbacks using used event idx
  vhost: use avail event idx on vhost_svq_kick
  vhost: Accept event idx flag

 hw/virtio/vhost-shadow-virtqueue.c | 39 ++++++++++++++++++++++++------
 1 file changed, 31 insertions(+), 8 deletions(-)

-- 
2.31.1

On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote:
> Event idx helps to reduce the number of notifications between the device
> and the driver. It allows them to specify an index on the circular
> descriptors rings where to issue the notification, instead of a single
> binary indicator.
> 
> Adding support for SVQ.


Jason seems to be taking this through net

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> These patches are sent on top of [1] series, so trivial conflicts could arise
> if it is applied directly on master. Future versions can be not based on
> it is more convenient.
> 
> [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg03280.html
> 
> Eugenio Pérez (4):
>   vhost: allocate event_idx fields on vring
>   vhost: toggle device callbacks using used event idx
>   vhost: use avail event idx on vhost_svq_kick
>   vhost: Accept event idx flag
> 
>  hw/virtio/vhost-shadow-virtqueue.c | 39 ++++++++++++++++++++++++------
>  1 file changed, 31 insertions(+), 8 deletions(-)
> 
> -- 
> 2.31.1
> 

在 2022/10/27 04:58, Michael S. Tsirkin 写道:
> On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote:
>> Event idx helps to reduce the number of notifications between the device
>> and the driver. It allows them to specify an index on the circular
>> descriptors rings where to issue the notification, instead of a single
>> binary indicator.
>>
>> Adding support for SVQ.
>
> Jason seems to be taking this through net
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


Ok, I've queued this.

Eugenio, please post the fix for endian on top.

Thanks


>
>> These patches are sent on top of [1] series, so trivial conflicts could arise
>> if it is applied directly on master. Future versions can be not based on
>> it is more convenient.
>>
>> [1] https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg03280.html
>>
>> Eugenio Pérez (4):
>>    vhost: allocate event_idx fields on vring
>>    vhost: toggle device callbacks using used event idx
>>    vhost: use avail event idx on vhost_svq_kick
>>    vhost: Accept event idx flag
>>
>>   hw/virtio/vhost-shadow-virtqueue.c | 39 ++++++++++++++++++++++++------
>>   1 file changed, 31 insertions(+), 8 deletions(-)
>>
>> -- 
>> 2.31.1
>>

On Fri, Oct 28, 2022 at 4:44 AM Jason Wang <jasowang@redhat.com> wrote:
>
>
> 在 2022/10/27 04:58, Michael S. Tsirkin 写道:
> > On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote:
> >> Event idx helps to reduce the number of notifications between the device
> >> and the driver. It allows them to specify an index on the circular
> >> descriptors rings where to issue the notification, instead of a single
> >> binary indicator.
> >>
> >> Adding support for SVQ.
> >
> > Jason seems to be taking this through net
> >
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
>
> Ok, I've queued this.
>
> Eugenio, please post the fix for endian on top.
>

I've got a v2 ready to send, would it be possible to send it right now
and send a v2 pull? That would save a few commits where the vdpa
devices do not work with big endian architectures.

Thanks!

On Fri, Oct 28, 2022 at 2:50 PM Eugenio Perez Martin
<eperezma@redhat.com> wrote:
>
> On Fri, Oct 28, 2022 at 4:44 AM Jason Wang <jasowang@redhat.com> wrote:
> >
> >
> > 在 2022/10/27 04:58, Michael S. Tsirkin 写道:
> > > On Thu, Oct 20, 2022 at 05:52:47PM +0200, Eugenio Pérez wrote:
> > >> Event idx helps to reduce the number of notifications between the device
> > >> and the driver. It allows them to specify an index on the circular
> > >> descriptors rings where to issue the notification, instead of a single
> > >> binary indicator.
> > >>
> > >> Adding support for SVQ.
> > >
> > > Jason seems to be taking this through net
> > >
> > > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >
> >
> > Ok, I've queued this.
> >
> > Eugenio, please post the fix for endian on top.
> >
>
> I've got a v2 ready to send, would it be possible to send it right now
> and send a v2 pull? That would save a few commits where the vdpa
> devices do not work with big endian architectures.

Probably too late, but I queue the fixes on top to rc1.

Thanks

>
> Thanks!
>