From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209002; cv=none; d=zohomail.com; s=zohoarc; b=ZneUJAkSuWSE/XN7fIN8ZS0b9M4IazmIQ48loMq+xn8ubmff2SGtGGGh4RcTn/mNHkpzeg6+njHD07TrVdX83Ah/J97Mf7PJKejgiiDmXVjo/+7lUoe0VJCbCWq+IP+LkYX7jH9S7kb3zSrUoauSHzlFDjLRGF7jGhdnZki9KN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209002; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=h/Rq0T4qHdj5P4fsrjuVBaKf49W5WppINvxKA/pkbYI=; b=TqnE9T2FesymE0/9MduMkr8qHQDrAdtwy4yuJjktx6giAAT5+7j0/6/iFo7Y7dYSfN72j5r0wGBfoRRw4ktix03GMyvcYkHu1+zlxfnadEglDGdHw0XrV05wqQG0qORGJQ64GvvCiRBeF7QMffkiZmwzDtO8G/A6b9kcVZ6JdMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209002920616.959224497949; Tue, 14 Jun 2022 05:16:42 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348864.575054 (Exim 4.92) (envelope-from ) id 1o15T3-0008IB-Df; Tue, 14 Jun 2022 12:16:21 +0000 Received: by outflank-mailman (output) from mailman id 348864.575054; Tue, 14 Jun 2022 12:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T3-0008Gt-87; Tue, 14 Jun 2022 12:16:21 +0000 Received: by outflank-mailman (input) for mailman id 348864; Tue, 14 Jun 2022 12:16:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T1-0008Ek-Ul for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:20 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca8d1326-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:18 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-zNJqENUwOG2iqDFpqj-GJA-1; Tue, 14 Jun 2022 08:16:13 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADF9E1C0514E; Tue, 14 Jun 2022 12:16:12 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4089418EA5; Tue, 14 Jun 2022 12:16:12 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EEC8E18000B3; Tue, 14 Jun 2022 14:16:10 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca8d1326-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/Rq0T4qHdj5P4fsrjuVBaKf49W5WppINvxKA/pkbYI=; b=VRCtOH04hwZfrb/TggkWASGePToizBoas/O3n1C94GglalKMjOBx0+GEEZaE6MRTlLTbYm 3abrJpKreCgSMZa1Bu5FKVZSCBEaO7WYBRKmmO+RVhy+mFjVZsPO/nz5eWjB8sbKKFTB4h +yfIHHSj/7OCAQzUxINUz86SgIBVrLo= X-MC-Unique: zNJqENUwOG2iqDFpqj-GJA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann , =?UTF-8?q?Volker=20R=C3=BCmelin?= Subject: [PULL 01/15] ui/gtk-gl-area: implement GL context destruction Date: Tue, 14 Jun 2022 14:15:56 +0200 Message-Id: <20220614121610.508356-2-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209004209100002 From: Volker R=C3=BCmelin The counterpart function for gd_gl_area_create_context() is currently empty. Implement the gd_gl_area_destroy_context() function to avoid GL context leaks. Signed-off-by: Volker R=C3=BCmelin Message-Id: <20220605085131.7711-1-vr_qemu@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 8 +++++++- ui/trace-events | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index fc5a082eb846..0e20ea031d34 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -201,7 +201,13 @@ QEMUGLContext gd_gl_area_create_context(DisplayGLCtx *= dgc, =20 void gd_gl_area_destroy_context(DisplayGLCtx *dgc, QEMUGLContext ctx) { - /* FIXME */ + GdkGLContext *current_ctx =3D gdk_gl_context_get_current(); + + trace_gd_gl_area_destroy_context(ctx, current_ctx); + if (ctx =3D=3D current_ctx) { + gdk_gl_context_clear_current(); + } + g_clear_object(&ctx); } =20 void gd_gl_area_scanout_texture(DisplayChangeListener *dcl, diff --git a/ui/trace-events b/ui/trace-events index f78b5e66061f..1040ba0f88c7 100644 --- a/ui/trace-events +++ b/ui/trace-events @@ -26,6 +26,7 @@ gd_key_event(const char *tab, int gdk_keycode, int qkeyco= de, const char *action) gd_grab(const char *tab, const char *device, const char *reason) "tab=3D%s= , dev=3D%s, reason=3D%s" gd_ungrab(const char *tab, const char *device) "tab=3D%s, dev=3D%s" gd_keymap_windowing(const char *name) "backend=3D%s" +gd_gl_area_destroy_context(void *ctx, void *current_ctx) "ctx=3D%p, curren= t_ctx=3D%p" =20 # vnc-auth-sasl.c # vnc-auth-vencrypt.c --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209003; cv=none; d=zohomail.com; s=zohoarc; b=Bmnbt6WTf5HR+E8mQBC2OH2x6E4ma+ZyOwQPsOUes5PQpeS72/AMqusHHjJacVLk3n6aZ1j84xnT+eCZ56r9IqF6ReXQPMNCJPxPQf87rQ4W06YLyKQyqQFvt7MwgHOITpkDO54B2o+P4VwOmcyrbQt9iucdW136qJJUw6nAjOU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209003; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wx3J1U/WRMVytLzUKnVNwgCHbbzsbHu+DjsV7mqclmI=; b=JPldmSHpQhXyPnKAWZH4NFKMEUShNq6VTebxiFfh40pgDJefs2SVqYFujwSFhNGdnT4kToIILKG/LoCeKXcT7+zMbP13oFBNoKoXGUPGfy6yfZNvYFI5O/pH/qi7uADDaV9Br81v+Xle8Hx39PY6Ty/Wz/4FWz88tSf172NRYAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 165520900330916.544018840934427; Tue, 14 Jun 2022 05:16:43 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348866.575082 (Exim 4.92) (envelope-from ) id 1o15T5-0000bL-WC; Tue, 14 Jun 2022 12:16:24 +0000 Received: by outflank-mailman (output) from mailman id 348866.575082; Tue, 14 Jun 2022 12:16:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T5-0000Zv-SQ; Tue, 14 Jun 2022 12:16:23 +0000 Received: by outflank-mailman (input) for mailman id 348866; Tue, 14 Jun 2022 12:16:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T4-0008Ek-0H for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:22 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc47154d-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:20 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-651-wv2AtMAeNLyZQMhe_ogqMQ-1; Tue, 14 Jun 2022 08:16:14 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C4E4101E9B9; Tue, 14 Jun 2022 12:16:14 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0FD140CF8E5; Tue, 14 Jun 2022 12:16:13 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 08BE21800394; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc47154d-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wx3J1U/WRMVytLzUKnVNwgCHbbzsbHu+DjsV7mqclmI=; b=OirqH9wYqTGhJQiCjAbwtwaUkjAo8xKxw8kPD1mzrqlfNMAydjysS+HWU3jO+efIAvFfEz /DySSivZ6/TK8G0n9sftWtfUp+MH3mBrm+9czpuwyt4nda0M/aUVizH3Lq5ckVtD6j8fW2 YVGtXTZWmtG5n63SXsNVI1T5MhejAzk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wx3J1U/WRMVytLzUKnVNwgCHbbzsbHu+DjsV7mqclmI=; b=P9m/I5ISyZXS9xCLwC6D2Z0CeqwpX22GL6IEkIxouMY7AtlBvSd0H0NA+wdykE3pNrav6W kKkC7+d6U4duaFBKusweOtuf9g1SM45bm3soviRWn4T1IPTGetJd14HhXEOYLX0LyX/JVN Cvdz9zlYuEfySweP/9NY7aY7btTvkE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wx3J1U/WRMVytLzUKnVNwgCHbbzsbHu+DjsV7mqclmI=; b=P9m/I5ISyZXS9xCLwC6D2Z0CeqwpX22GL6IEkIxouMY7AtlBvSd0H0NA+wdykE3pNrav6W kKkC7+d6U4duaFBKusweOtuf9g1SM45bm3soviRWn4T1IPTGetJd14HhXEOYLX0LyX/JVN Cvdz9zlYuEfySweP/9NY7aY7btTvkE4= X-MC-Unique: wv2AtMAeNLyZQMhe_ogqMQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann , =?UTF-8?q?Volker=20R=C3=BCmelin?= Subject: [PULL 02/15] ui/gtk-gl-area: create the requested GL context version Date: Tue, 14 Jun 2022 14:15:57 +0200 Message-Id: <20220614121610.508356-3-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-ZohoMail-DKIM: pass (identity @redhat.com) (identity @redhat.com) X-ZM-MESSAGEID: 1655209004204100001 From: Volker R=C3=BCmelin Since about 2018 virglrenderer (commit fa835b0f88 "vrend: don't hardcode context version") tries to open the highest available GL context version. This is done by creating the known GL context versions from the highest to the lowest until (*create_gl_context) returns a context !=3D NULL. This does not work properly with the current QEMU gd_gl_area_create_context() function, because gdk_gl_context_realize() on Wayland creates a version 3.0 legacy context if the requested GL context version can't be created. In order for virglrenderer to find the highest available GL context version, return NULL if the created context version is lower than the requested version. This fixes the following error: QEMU started with -device virtio-vga-gl -display gtk,gl=3Don. Under Wayland, the guest window remains black and the following information can be seen on the host. gl_version 30 - compat profile (qemu:5978): Gdk-WARNING **: 16:19:01.533: gdk_gl_context_set_required_version - GL context versions less than 3.2 are not supported. (qemu:5978): Gdk-WARNING **: 16:19:01.537: gdk_gl_context_set_required_version - GL context versions less than 3.2 are not supported. (qemu:5978): Gdk-WARNING **: 16:19:01.554: gdk_gl_context_set_required_version - GL context versions less than 3.2 are not supported. vrend_renderer_fill_caps: Entering with stale GL error: 1282 To reproduce this error, an OpenGL driver is required on the host that doesn't have the latest OpenGL extensions fully implemented. An example for this is the Intel i965 driver on a Haswell processor. Signed-off-by: Volker R=C3=BCmelin Message-Id: <20220605085131.7711-2-vr_qemu@t-online.de> Signed-off-by: Gerd Hoffmann --- ui/gtk-gl-area.c | 31 ++++++++++++++++++++++++++++++- ui/trace-events | 1 + 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 0e20ea031d34..2e0129c28cd4 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -170,6 +170,23 @@ void gd_gl_area_switch(DisplayChangeListener *dcl, } } =20 +static int gd_cmp_gl_context_version(int major, int minor, QEMUGLParams *p= arams) +{ + if (major > params->major_ver) { + return 1; + } + if (major < params->major_ver) { + return -1; + } + if (minor > params->minor_ver) { + return 1; + } + if (minor < params->minor_ver) { + return -1; + } + return 0; +} + QEMUGLContext gd_gl_area_create_context(DisplayGLCtx *dgc, QEMUGLParams *params) { @@ -177,8 +194,8 @@ QEMUGLContext gd_gl_area_create_context(DisplayGLCtx *d= gc, GdkWindow *window; GdkGLContext *ctx; GError *err =3D NULL; + int major, minor; =20 - gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); window =3D gtk_widget_get_window(vc->gfx.drawing_area); ctx =3D gdk_window_create_gl_context(window, &err); if (err) { @@ -196,6 +213,18 @@ QEMUGLContext gd_gl_area_create_context(DisplayGLCtx *= dgc, g_clear_object(&ctx); return NULL; } + + gdk_gl_context_make_current(ctx); + gdk_gl_context_get_version(ctx, &major, &minor); + gdk_gl_context_clear_current(); + gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); + + if (gd_cmp_gl_context_version(major, minor, params) =3D=3D -1) { + /* created ctx version < requested version */ + g_clear_object(&ctx); + } + + trace_gd_gl_area_create_context(ctx, params->major_ver, params->minor_= ver); return ctx; } =20 diff --git a/ui/trace-events b/ui/trace-events index 1040ba0f88c7..a922f00e10b4 100644 --- a/ui/trace-events +++ b/ui/trace-events @@ -26,6 +26,7 @@ gd_key_event(const char *tab, int gdk_keycode, int qkeyco= de, const char *action) gd_grab(const char *tab, const char *device, const char *reason) "tab=3D%s= , dev=3D%s, reason=3D%s" gd_ungrab(const char *tab, const char *device) "tab=3D%s, dev=3D%s" gd_keymap_windowing(const char *name) "backend=3D%s" +gd_gl_area_create_context(void *ctx, int major, int minor) "ctx=3D%p, majo= r=3D%d, minor=3D%d" gd_gl_area_destroy_context(void *ctx, void *current_ctx) "ctx=3D%p, curren= t_ctx=3D%p" =20 # vnc-auth-sasl.c --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209003; cv=none; d=zohomail.com; s=zohoarc; b=H8yeu4whptd2vcnaMJLhHF28GKA2aJCqEo8QRP47W++D+g+nud2t+rg3GGsEo0YHV6u4uWS1Ud9AwxzCTy6LsuTpCbPk3UswKnoud46B2sLr0E53G34c2ic8StylzYBJwBQ9aPJZQIrrHG5IscEq21bjVLG7Kr3Jozeu8FSSmrM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209003; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qgE0u/psF+5HbFaMEFEBF+1+y1Gn5UXWEs7HICOeN3Q=; b=howUe3tO99myLUXgMrO+tTbZMzclFNvhRH0Re84ErYEpSgTLOAfZ1fyKKBEiIjYLou8mk06DUgsYj/pJtJNlzH71xW024TnET6gVj816P/w2jawG2zHdQqQ50Wh3D3Zx00e7Xnh4A9tHeYyuGrwmCzpg1pua6dhgqMaErxxDTDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209003063272.82446301435687; Tue, 14 Jun 2022 05:16:43 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348865.575071 (Exim 4.92) (envelope-from ) id 1o15T4-0000Jy-NA; Tue, 14 Jun 2022 12:16:22 +0000 Received: by outflank-mailman (output) from mailman id 348865.575071; Tue, 14 Jun 2022 12:16:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T4-0000It-I3; Tue, 14 Jun 2022 12:16:22 +0000 Received: by outflank-mailman (input) for mailman id 348865; Tue, 14 Jun 2022 12:16:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T2-0008Ek-Tv for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:20 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb66a6fa-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:19 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-pVihZslYPXmGc_VmJgPZPg-1; Tue, 14 Jun 2022 08:16:14 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 417BF85A58E; Tue, 14 Jun 2022 12:16:14 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0829E400F3FF; Tue, 14 Jun 2022 12:16:14 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 14D011800395; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb66a6fa-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgE0u/psF+5HbFaMEFEBF+1+y1Gn5UXWEs7HICOeN3Q=; b=ioqB0tc4u6bdrtzSqbNjGjgG6E+z6UAYTY0C0CnUoyry+J2n3rnG0n4G8B3xRoKtnANif3 YXETPnTTAzlwdZ87ikgU14unKr+R+xeYVj7UYrvgphMTiyjbadJ5YHW+3xAqzHoe08NNru PB85iVBUZLNE7eF9ppzXvSaUngxRHQI= X-MC-Unique: pVihZslYPXmGc_VmJgPZPg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 03/15] ui/cocoa: Fix poweroff request code Date: Tue, 14 Jun 2022 14:15:58 +0200 Message-Id: <20220614121610.508356-4-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209004320100005 From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20220529082508.89097-1-akihiko.odaki@gmail.com> Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 09a62817f2a9..84c84e98fc5e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -35,6 +35,7 @@ #include "ui/kbd-state.h" #include "sysemu/sysemu.h" #include "sysemu/runstate.h" +#include "sysemu/runstate-action.h" #include "sysemu/cpu-throttle.h" #include "qapi/error.h" #include "qapi/qapi-commands-block.h" @@ -1290,7 +1291,10 @@ - (void)applicationWillTerminate:(NSNotification *)a= Notification { COCOA_DEBUG("QemuCocoaAppController: applicationWillTerminate\n"); =20 - qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_UI); + with_iothread_lock(^{ + shutdown_action =3D SHUTDOWN_ACTION_POWEROFF; + qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_UI); + }); =20 /* * Sleep here, because returning will cause OSX to kill us --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209004; cv=none; d=zohomail.com; s=zohoarc; b=aSwZ9OWXlDPmDUlhX+NvRiRGF7nlQUiCIgIMobLASiReeNsPukyob/wmz1CA5clYYV0LcAO7obrDGZRqmgWCWF5w/IYeS/wd4fCzv9HSSZawAlNd6mzihZNxLmte6RZqaUsUXt+Jfo/qotyuwfjRQvA6PpavuxqElCRcMs9HZO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209004; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=70clork2yZyYjdUXKnsu9VZIWlpSX2dH9Nrdwr2C7Z4=; b=A3a7SYBpHx0SswmH6X1B56yS2q2Tj9XjPHDIidz+o9ugLx8S+IhR3kKWz0lrDtDjSDt2HdhiWEyUHywMq5R+uOHhHxm4/G3bA/k7DZ6Blr+i7Ox86veCriaggdmtPswLqyaAHnmBYhQitfWhBuoHIpvEjoAME285wfJkpGcHMVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209004687790.2776429811387; Tue, 14 Jun 2022 05:16:44 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348867.575087 (Exim 4.92) (envelope-from ) id 1o15T6-0000jZ-KK; Tue, 14 Jun 2022 12:16:24 +0000 Received: by outflank-mailman (output) from mailman id 348867.575087; Tue, 14 Jun 2022 12:16:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T6-0000hv-F2; Tue, 14 Jun 2022 12:16:24 +0000 Received: by outflank-mailman (input) for mailman id 348867; Tue, 14 Jun 2022 12:16:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T5-0008Ek-4h for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:23 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc6274b5-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:21 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-434-1DFfCUIxMnaPAZGvCK7x2A-1; Tue, 14 Jun 2022 08:16:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6342805F72; Tue, 14 Jun 2022 12:16:15 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CDD61415103; Tue, 14 Jun 2022 12:16:15 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 25C2718003AA; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc6274b5-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=70clork2yZyYjdUXKnsu9VZIWlpSX2dH9Nrdwr2C7Z4=; b=e5powEpN/ZJtDWNV9sS2q+bY940oRXIgLewyDEVU0rzsjfbwE7WRopzTqHgLSPNOvDFY0f K3kjEM2b/TRsl6B4AbPLph+OealtBZMFzz3M6kYt02CPWOZITfeeGH99Hl+IwBpBcD5nss xWIEso4AfBMZEEkkAfgcMNRdrSlWBs8= X-MC-Unique: 1DFfCUIxMnaPAZGvCK7x2A-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 04/15] hw/usb: Add CanoKey Implementation Date: Tue, 14 Jun 2022 14:15:59 +0200 Message-Id: <20220614121610.508356-5-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209006174100010 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" This commit added a new emulated device called CanoKey to QEMU. CanoKey implements platform independent features in canokey-core https://github.com/canokeys/canokey-core, and leaves the USB implementation to the platform. In this commit the USB part was implemented in QEMU using QEMU's USB APIs, therefore the emulated CanoKey can communicate with the guest OS using USB. Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann Acked-by: YuanYang Meng --- hw/usb/canokey.h | 69 +++++++++++ hw/usb/canokey.c | 300 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 369 insertions(+) create mode 100644 hw/usb/canokey.h create mode 100644 hw/usb/canokey.c diff --git a/hw/usb/canokey.h b/hw/usb/canokey.h new file mode 100644 index 000000000000..24cf30420346 --- /dev/null +++ b/hw/usb/canokey.h @@ -0,0 +1,69 @@ +/* + * CanoKey QEMU device header. + * + * Copyright (c) 2021-2022 Canokeys.org + * Written by Hongren (Zenithal) Zheng + * + * This code is licensed under the Apache-2.0. + */ + +#ifndef CANOKEY_H +#define CANOKEY_H + +#include "hw/qdev-core.h" + +#define TYPE_CANOKEY "canokey" +#define CANOKEY(obj) \ + OBJECT_CHECK(CanoKeyState, (obj), TYPE_CANOKEY) + +/* + * State of Canokey (i.e. hw/canokey.c) + */ + +/* CTRL INTR BULK */ +#define CANOKEY_EP_NUM 3 +/* BULK/INTR IN can be up to 1352 bytes, e.g. get key info */ +#define CANOKEY_EP_IN_BUFFER_SIZE 2048 +/* BULK OUT can be up to 270 bytes, e.g. PIV import cert */ +#define CANOKEY_EP_OUT_BUFFER_SIZE 512 + +typedef enum { + CANOKEY_EP_IN_WAIT, + CANOKEY_EP_IN_READY, + CANOKEY_EP_IN_STALL +} CanoKeyEPState; + +typedef struct CanoKeyState { + USBDevice dev; + + /* IN packets from canokey device loop */ + uint8_t ep_in[CANOKEY_EP_NUM][CANOKEY_EP_IN_BUFFER_SIZE]; + /* + * See canokey_emu_transmit + * + * For large INTR IN, receive multiple data from canokey device loop + * in this case ep_in_size would increase with every call + */ + uint32_t ep_in_size[CANOKEY_EP_NUM]; + /* + * Used in canokey_handle_data + * for IN larger than p->iov.size, we would do multiple handle_data() + * + * The difference between ep_in_pos and ep_in_size: + * We first increase ep_in_size to fill ep_in buffer in device_loop, + * then use ep_in_pos to submit data from ep_in buffer in handle_data + */ + uint32_t ep_in_pos[CANOKEY_EP_NUM]; + CanoKeyEPState ep_in_state[CANOKEY_EP_NUM]; + + /* OUT pointer to canokey recv buffer */ + uint8_t *ep_out[CANOKEY_EP_NUM]; + uint32_t ep_out_size[CANOKEY_EP_NUM]; + /* For large BULK OUT, multiple write to ep_out is needed */ + uint8_t ep_out_buffer[CANOKEY_EP_NUM][CANOKEY_EP_OUT_BUFFER_SIZE]; + + /* Properties */ + char *file; /* canokey-file */ +} CanoKeyState; + +#endif /* CANOKEY_H */ diff --git a/hw/usb/canokey.c b/hw/usb/canokey.c new file mode 100644 index 000000000000..6cb8b7cdb089 --- /dev/null +++ b/hw/usb/canokey.c @@ -0,0 +1,300 @@ +/* + * CanoKey QEMU device implementation. + * + * Copyright (c) 2021-2022 Canokeys.org + * Written by Hongren (Zenithal) Zheng + * + * This code is licensed under the Apache-2.0. + */ + +#include "qemu/osdep.h" +#include + +#include "qemu/module.h" +#include "qapi/error.h" +#include "hw/usb.h" +#include "hw/qdev-properties.h" +#include "desc.h" +#include "canokey.h" + +#define CANOKEY_EP_IN(ep) ((ep) & 0x7F) + +#define CANOKEY_VENDOR_NUM 0x20a0 +#define CANOKEY_PRODUCT_NUM 0x42d2 + +/* + * placeholder, canokey-qemu implements its own usb desc + * Namely we do not use usb_desc_handle_contorl + */ +enum { + STR_MANUFACTURER =3D 1, + STR_PRODUCT, + STR_SERIALNUMBER +}; + +static const USBDescStrings desc_strings =3D { + [STR_MANUFACTURER] =3D "canokeys.org", + [STR_PRODUCT] =3D "CanoKey QEMU", + [STR_SERIALNUMBER] =3D "0" +}; + +static const USBDescDevice desc_device_canokey =3D { + .bcdUSB =3D 0x0, + .bMaxPacketSize0 =3D 16, + .bNumConfigurations =3D 0, + .confs =3D NULL, +}; + +static const USBDesc desc_canokey =3D { + .id =3D { + .idVendor =3D CANOKEY_VENDOR_NUM, + .idProduct =3D CANOKEY_PRODUCT_NUM, + .bcdDevice =3D 0x0100, + .iManufacturer =3D STR_MANUFACTURER, + .iProduct =3D STR_PRODUCT, + .iSerialNumber =3D STR_SERIALNUMBER, + }, + .full =3D &desc_device_canokey, + .high =3D &desc_device_canokey, + .str =3D desc_strings, +}; + + +/* + * libcanokey-qemu.so side functions + * All functions are called from canokey_emu_device_loop + */ +int canokey_emu_stall_ep(void *base, uint8_t ep) +{ + CanoKeyState *key =3D base; + uint8_t ep_in =3D CANOKEY_EP_IN(ep); /* INTR IN has ep 129 */ + key->ep_in_size[ep_in] =3D 0; + key->ep_in_state[ep_in] =3D CANOKEY_EP_IN_STALL; + return 0; +} + +int canokey_emu_set_address(void *base, uint8_t addr) +{ + CanoKeyState *key =3D base; + key->dev.addr =3D addr; + return 0; +} + +int canokey_emu_prepare_receive( + void *base, uint8_t ep, uint8_t *pbuf, uint16_t size) +{ + CanoKeyState *key =3D base; + key->ep_out[ep] =3D pbuf; + key->ep_out_size[ep] =3D size; + return 0; +} + +int canokey_emu_transmit( + void *base, uint8_t ep, const uint8_t *pbuf, uint16_t size) +{ + CanoKeyState *key =3D base; + uint8_t ep_in =3D CANOKEY_EP_IN(ep); /* INTR IN has ep 129 */ + memcpy(key->ep_in[ep_in] + key->ep_in_size[ep_in], + pbuf, size); + key->ep_in_size[ep_in] +=3D size; + key->ep_in_state[ep_in] =3D CANOKEY_EP_IN_READY; + /* + * ready for more data in device loop + * + * Note: this is a quirk for CanoKey CTAPHID + * because it calls multiple emu_transmit in one device_loop + * but w/o data_in it would stuck in device_loop + * This has no side effect for CCID as it is strictly + * OUT then IN transfer + * However it has side effect for Control transfer + */ + if (ep_in !=3D 0) { + canokey_emu_data_in(ep_in); + } + return 0; +} + +uint32_t canokey_emu_get_rx_data_size(void *base, uint8_t ep) +{ + CanoKeyState *key =3D base; + return key->ep_out_size[ep]; +} + +/* + * QEMU side functions + */ +static void canokey_handle_reset(USBDevice *dev) +{ + CanoKeyState *key =3D CANOKEY(dev); + for (int i =3D 0; i !=3D CANOKEY_EP_NUM; ++i) { + key->ep_in_state[i] =3D CANOKEY_EP_IN_WAIT; + key->ep_in_pos[i] =3D 0; + key->ep_in_size[i] =3D 0; + } + canokey_emu_reset(); +} + +static void canokey_handle_control(USBDevice *dev, USBPacket *p, + int request, int value, int index, int length, uint8_t *dat= a) +{ + CanoKeyState *key =3D CANOKEY(dev); + + canokey_emu_setup(request, value, index, length); + + uint32_t dir_in =3D request & DeviceRequest; + if (!dir_in) { + /* OUT */ + if (key->ep_out[0] !=3D NULL) { + memcpy(key->ep_out[0], data, length); + } + canokey_emu_data_out(p->ep->nr, data); + } + + canokey_emu_device_loop(); + + /* IN */ + switch (key->ep_in_state[0]) { + case CANOKEY_EP_IN_WAIT: + p->status =3D USB_RET_NAK; + break; + case CANOKEY_EP_IN_STALL: + p->status =3D USB_RET_STALL; + break; + case CANOKEY_EP_IN_READY: + memcpy(data, key->ep_in[0], key->ep_in_size[0]); + p->actual_length =3D key->ep_in_size[0]; + /* reset state */ + key->ep_in_state[0] =3D CANOKEY_EP_IN_WAIT; + key->ep_in_size[0] =3D 0; + key->ep_in_pos[0] =3D 0; + break; + } +} + +static void canokey_handle_data(USBDevice *dev, USBPacket *p) +{ + CanoKeyState *key =3D CANOKEY(dev); + + uint8_t ep_in =3D CANOKEY_EP_IN(p->ep->nr); + uint8_t ep_out =3D p->ep->nr; + uint32_t in_len; + uint32_t out_pos; + uint32_t out_len; + switch (p->pid) { + case USB_TOKEN_OUT: + usb_packet_copy(p, key->ep_out_buffer[ep_out], p->iov.size); + out_pos =3D 0; + while (out_pos !=3D p->iov.size) { + /* + * key->ep_out[ep_out] set by prepare_receive + * to be a buffer inside libcanokey-qemu.so + * key->ep_out_size[ep_out] set by prepare_receive + * to be the buffer length + */ + out_len =3D MIN(p->iov.size - out_pos, key->ep_out_size[ep_out= ]); + memcpy(key->ep_out[ep_out], + key->ep_out_buffer[ep_out] + out_pos, out_len); + out_pos +=3D out_len; + /* update ep_out_size to actual len */ + key->ep_out_size[ep_out] =3D out_len; + canokey_emu_data_out(ep_out, NULL); + } + break; + case USB_TOKEN_IN: + if (key->ep_in_pos[ep_in] =3D=3D 0) { /* first time IN */ + canokey_emu_data_in(ep_in); + canokey_emu_device_loop(); /* may call transmit multiple times= */ + } + switch (key->ep_in_state[ep_in]) { + case CANOKEY_EP_IN_WAIT: + /* NAK for early INTR IN */ + p->status =3D USB_RET_NAK; + break; + case CANOKEY_EP_IN_STALL: + p->status =3D USB_RET_STALL; + break; + case CANOKEY_EP_IN_READY: + /* submit part of ep_in buffer to USBPacket */ + in_len =3D MIN(key->ep_in_size[ep_in] - key->ep_in_pos[ep_in], + p->iov.size); + usb_packet_copy(p, + key->ep_in[ep_in] + key->ep_in_pos[ep_in], in_len); + key->ep_in_pos[ep_in] +=3D in_len; + /* reset state if all data submitted */ + if (key->ep_in_pos[ep_in] =3D=3D key->ep_in_size[ep_in]) { + key->ep_in_state[ep_in] =3D CANOKEY_EP_IN_WAIT; + key->ep_in_size[ep_in] =3D 0; + key->ep_in_pos[ep_in] =3D 0; + } + break; + } + break; + default: + p->status =3D USB_RET_STALL; + break; + } +} + +static void canokey_realize(USBDevice *base, Error **errp) +{ + CanoKeyState *key =3D CANOKEY(base); + + if (key->file =3D=3D NULL) { + error_setg(errp, "You must provide file=3D/path/to/canokey-file"); + return; + } + + usb_desc_init(base); + + for (int i =3D 0; i !=3D CANOKEY_EP_NUM; ++i) { + key->ep_in_state[i] =3D CANOKEY_EP_IN_WAIT; + key->ep_in_size[i] =3D 0; + key->ep_in_pos[i] =3D 0; + } + + if (canokey_emu_init(key, key->file)) { + error_setg(errp, "canokey can not create or read %s", key->file); + return; + } +} + +static void canokey_unrealize(USBDevice *base) +{ +} + +static Property canokey_properties[] =3D { + DEFINE_PROP_STRING("file", CanoKeyState, file), + DEFINE_PROP_END_OF_LIST(), +}; + +static void canokey_class_init(ObjectClass *klass, void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + USBDeviceClass *uc =3D USB_DEVICE_CLASS(klass); + + uc->product_desc =3D "CanoKey QEMU"; + uc->usb_desc =3D &desc_canokey; + uc->handle_reset =3D canokey_handle_reset; + uc->handle_control =3D canokey_handle_control; + uc->handle_data =3D canokey_handle_data; + uc->handle_attach =3D usb_desc_attach; + uc->realize =3D canokey_realize; + uc->unrealize =3D canokey_unrealize; + dc->desc =3D "CanoKey QEMU"; + device_class_set_props(dc, canokey_properties); + set_bit(DEVICE_CATEGORY_MISC, dc->categories); +} + +static const TypeInfo canokey_info =3D { + .name =3D TYPE_CANOKEY, + .parent =3D TYPE_USB_DEVICE, + .instance_size =3D sizeof(CanoKeyState), + .class_init =3D canokey_class_init +}; + +static void canokey_register_types(void) +{ + type_register_static(&canokey_info); +} + +type_init(canokey_register_types) --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209007; cv=none; d=zohomail.com; s=zohoarc; b=Ag66/7xQxUwcz00CSZE0bwAnXDwubon52SJa/+LZc2qlyOMC+FcV+Wvld8WTvh0H527P6lGLHj4Zo4sR4M6/gUxubCJkRUXNDCFIB19n+tc8SpR0HqZQIZx+qV5I4aVoCXjtt0PSL+3Km3D3xAO2hnj6ejWpU7xhnJJ1XqGFofk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209007; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XMFb51C69E0Si128czVwJqlqgwkrMEmsc4JCjQtiyLU=; b=KoIfHEkmA/kVVOhy9PEeQ0EpweBnnp2cwlBkpQKIDnwBLzgUjiNxmbUH+RPUGEkDhpNq8jr8iX562fnOJOVgZ98KyVQ0JwRnPoqWh+h4ayXu6OKASb5PAuwjSj96eJfuNutHoPQJaOAtJ0QBypBg/JamyoLD54K21YncOQX34es= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209007729148.2592518874178; Tue, 14 Jun 2022 05:16:47 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348870.575120 (Exim 4.92) (envelope-from ) id 1o15TA-0001Zu-FO; Tue, 14 Jun 2022 12:16:28 +0000 Received: by outflank-mailman (output) from mailman id 348870.575120; Tue, 14 Jun 2022 12:16:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TA-0001YW-4a; Tue, 14 Jun 2022 12:16:28 +0000 Received: by outflank-mailman (input) for mailman id 348870; Tue, 14 Jun 2022 12:16:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T7-0008Ek-V0 for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:26 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd53b940-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:22 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-77cUT6WpNIy3Zzv5R7gyFA-1; Tue, 14 Jun 2022 08:16:17 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4840938041D8; Tue, 14 Jun 2022 12:16:16 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BE7331415132; Tue, 14 Jun 2022 12:16:15 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 34EE718003BA; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd53b940-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMFb51C69E0Si128czVwJqlqgwkrMEmsc4JCjQtiyLU=; b=SrDegPrayZibgORa6z+ku62SoFinTM7GGDaWiJ11yogpuDLugoaibao2TbR5TCkOz8xS99 jksoLesj3n5R43C2cm+0U2//Lrn7vyyxV9GZXokstABtotRpXKnTPJMqtMoD7cBEml8K6T jRag5S+Px3KMVBIei3+MrNK3iHxAFg4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMFb51C69E0Si128czVwJqlqgwkrMEmsc4JCjQtiyLU=; b=SrDegPrayZibgORa6z+ku62SoFinTM7GGDaWiJ11yogpuDLugoaibao2TbR5TCkOz8xS99 jksoLesj3n5R43C2cm+0U2//Lrn7vyyxV9GZXokstABtotRpXKnTPJMqtMoD7cBEml8K6T jRag5S+Px3KMVBIei3+MrNK3iHxAFg4= X-MC-Unique: 77cUT6WpNIy3Zzv5R7gyFA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 05/15] hw/usb/canokey: Add trace events Date: Tue, 14 Jun 2022 14:16:00 +0200 Message-Id: <20220614121610.508356-6-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209009421100004 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- hw/usb/canokey.c | 13 +++++++++++++ hw/usb/trace-events | 16 ++++++++++++++++ 2 files changed, 29 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canokey.c index 6cb8b7cdb089..4a08b1cbd776 100644 --- a/hw/usb/canokey.c +++ b/hw/usb/canokey.c @@ -14,6 +14,7 @@ #include "qapi/error.h" #include "hw/usb.h" #include "hw/qdev-properties.h" +#include "trace.h" #include "desc.h" #include "canokey.h" =20 @@ -66,6 +67,7 @@ static const USBDesc desc_canokey =3D { */ int canokey_emu_stall_ep(void *base, uint8_t ep) { + trace_canokey_emu_stall_ep(ep); CanoKeyState *key =3D base; uint8_t ep_in =3D CANOKEY_EP_IN(ep); /* INTR IN has ep 129 */ key->ep_in_size[ep_in] =3D 0; @@ -75,6 +77,7 @@ int canokey_emu_stall_ep(void *base, uint8_t ep) =20 int canokey_emu_set_address(void *base, uint8_t addr) { + trace_canokey_emu_set_address(addr); CanoKeyState *key =3D base; key->dev.addr =3D addr; return 0; @@ -83,6 +86,7 @@ int canokey_emu_set_address(void *base, uint8_t addr) int canokey_emu_prepare_receive( void *base, uint8_t ep, uint8_t *pbuf, uint16_t size) { + trace_canokey_emu_prepare_receive(ep, size); CanoKeyState *key =3D base; key->ep_out[ep] =3D pbuf; key->ep_out_size[ep] =3D size; @@ -92,6 +96,7 @@ int canokey_emu_prepare_receive( int canokey_emu_transmit( void *base, uint8_t ep, const uint8_t *pbuf, uint16_t size) { + trace_canokey_emu_transmit(ep, size); CanoKeyState *key =3D base; uint8_t ep_in =3D CANOKEY_EP_IN(ep); /* INTR IN has ep 129 */ memcpy(key->ep_in[ep_in] + key->ep_in_size[ep_in], @@ -125,6 +130,7 @@ uint32_t canokey_emu_get_rx_data_size(void *base, uint8= _t ep) */ static void canokey_handle_reset(USBDevice *dev) { + trace_canokey_handle_reset(); CanoKeyState *key =3D CANOKEY(dev); for (int i =3D 0; i !=3D CANOKEY_EP_NUM; ++i) { key->ep_in_state[i] =3D CANOKEY_EP_IN_WAIT; @@ -137,6 +143,7 @@ static void canokey_handle_reset(USBDevice *dev) static void canokey_handle_control(USBDevice *dev, USBPacket *p, int request, int value, int index, int length, uint8_t *dat= a) { + trace_canokey_handle_control_setup(request, value, index, length); CanoKeyState *key =3D CANOKEY(dev); =20 canokey_emu_setup(request, value, index, length); @@ -144,6 +151,7 @@ static void canokey_handle_control(USBDevice *dev, USBP= acket *p, uint32_t dir_in =3D request & DeviceRequest; if (!dir_in) { /* OUT */ + trace_canokey_handle_control_out(); if (key->ep_out[0] !=3D NULL) { memcpy(key->ep_out[0], data, length); } @@ -163,6 +171,7 @@ static void canokey_handle_control(USBDevice *dev, USBP= acket *p, case CANOKEY_EP_IN_READY: memcpy(data, key->ep_in[0], key->ep_in_size[0]); p->actual_length =3D key->ep_in_size[0]; + trace_canokey_handle_control_in(p->actual_length); /* reset state */ key->ep_in_state[0] =3D CANOKEY_EP_IN_WAIT; key->ep_in_size[0] =3D 0; @@ -182,6 +191,7 @@ static void canokey_handle_data(USBDevice *dev, USBPack= et *p) uint32_t out_len; switch (p->pid) { case USB_TOKEN_OUT: + trace_canokey_handle_data_out(ep_out, p->iov.size); usb_packet_copy(p, key->ep_out_buffer[ep_out], p->iov.size); out_pos =3D 0; while (out_pos !=3D p->iov.size) { @@ -226,6 +236,7 @@ static void canokey_handle_data(USBDevice *dev, USBPack= et *p) key->ep_in_size[ep_in] =3D 0; key->ep_in_pos[ep_in] =3D 0; } + trace_canokey_handle_data_in(ep_in, in_len); break; } break; @@ -237,6 +248,7 @@ static void canokey_handle_data(USBDevice *dev, USBPack= et *p) =20 static void canokey_realize(USBDevice *base, Error **errp) { + trace_canokey_realize(); CanoKeyState *key =3D CANOKEY(base); =20 if (key->file =3D=3D NULL) { @@ -260,6 +272,7 @@ static void canokey_realize(USBDevice *base, Error **er= rp) =20 static void canokey_unrealize(USBDevice *base) { + trace_canokey_unrealize(); } =20 static Property canokey_properties[] =3D { diff --git a/hw/usb/trace-events b/hw/usb/trace-events index 9773cb53300d..914ca7166829 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -345,3 +345,19 @@ usb_serial_set_baud(int bus, int addr, int baud) "dev = %d:%u baud rate %d" usb_serial_set_data(int bus, int addr, int parity, int data, int stop) "de= v %d:%u parity %c, data bits %d, stop bits %d" usb_serial_set_flow_control(int bus, int addr, int index) "dev %d:%u flow = control %d" usb_serial_set_xonxoff(int bus, int addr, uint8_t xon, uint8_t xoff) "dev = %d:%u xon 0x%x xoff 0x%x" + +# canokey.c +canokey_emu_stall_ep(uint8_t ep) "ep %d" +canokey_emu_set_address(uint8_t addr) "addr %d" +canokey_emu_prepare_receive(uint8_t ep, uint16_t size) "ep %d size %d" +canokey_emu_transmit(uint8_t ep, uint16_t size) "ep %d size %d" +canokey_thread_start(void) +canokey_thread_stop(void) +canokey_handle_reset(void) +canokey_handle_control_setup(int request, int value, int index, int length= ) "request 0x%04X value 0x%04X index 0x%04X length 0x%04X" +canokey_handle_control_out(void) +canokey_handle_control_in(int actual_len) "len %d" +canokey_handle_data_out(uint8_t ep_out, uint32_t out_len) "ep %d len %d" +canokey_handle_data_in(uint8_t ep_in, uint32_t in_len) "ep %d len %d" +canokey_realize(void) +canokey_unrealize(void) --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209008; cv=none; d=zohomail.com; s=zohoarc; b=OpEWri8yLR1xnJWjlCbmLJTQ7qCbxaMQWSbpwXtUII7ctrI+E2hjNdfl1J7zF0pn/NfNI/jgMeIGtr6IJFcsQWrPBXMlLcqNc8JtwzfWp7OsD4PWjrZiQYaOyV3R75T104rxpLG2hxav7iiI8EGNmuB38zTJQESAuqvI+6W69dE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209008; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HZ4OtpGl92/4vTO64NR8x1+3AJHChGb6d9Bq7oyIeKQ=; b=TKPX1nhdhPxZ2TKIcCNvK/XjMKiCNcKlT3TyLVaTgZDdYgFyMCE9EPHNVHxiTYqY4aujNr3gqNhuC0gOPKFa791e+HyuRTz0o2N7l9y4lDv/DdRF52E053BJBuUI4FPHL9cCI+2J/Z9z1BBhCgR1goQZfE/HH3KDClFRLuDMguw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209008688720.7570689273969; Tue, 14 Jun 2022 05:16:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348871.575126 (Exim 4.92) (envelope-from ) id 1o15TB-0001g4-3m; Tue, 14 Jun 2022 12:16:29 +0000 Received: by outflank-mailman (output) from mailman id 348871.575126; Tue, 14 Jun 2022 12:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TA-0001e8-MQ; Tue, 14 Jun 2022 12:16:28 +0000 Received: by outflank-mailman (input) for mailman id 348871; Tue, 14 Jun 2022 12:16:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T8-0008Ek-Vy for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:27 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce949b87-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:24 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-D6qPa_PhO0qFlLmH-rztdw-1; Tue, 14 Jun 2022 08:16:18 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CD253C025CE; Tue, 14 Jun 2022 12:16:17 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43577C53360; Tue, 14 Jun 2022 12:16:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 48BBC1800620; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce949b87-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZ4OtpGl92/4vTO64NR8x1+3AJHChGb6d9Bq7oyIeKQ=; b=AEZGA9QmHFlvx96HFAhkp4w+MXKeuVWO/cWRX1D9/uUfwUdL6iuXNbIhL/vyA8kYzENQ+v F7lNqB0NKc/SZe8h5h5sNc7I6RE34HSxJgJDFN7rBm4h2AeKqw+rCV9feDunPxryvBYinA /+2JN/7NhRd1iVg6TJq/SAFwariEVHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZ4OtpGl92/4vTO64NR8x1+3AJHChGb6d9Bq7oyIeKQ=; b=AEZGA9QmHFlvx96HFAhkp4w+MXKeuVWO/cWRX1D9/uUfwUdL6iuXNbIhL/vyA8kYzENQ+v F7lNqB0NKc/SZe8h5h5sNc7I6RE34HSxJgJDFN7rBm4h2AeKqw+rCV9feDunPxryvBYinA /+2JN/7NhRd1iVg6TJq/SAFwariEVHY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZ4OtpGl92/4vTO64NR8x1+3AJHChGb6d9Bq7oyIeKQ=; b=AEZGA9QmHFlvx96HFAhkp4w+MXKeuVWO/cWRX1D9/uUfwUdL6iuXNbIhL/vyA8kYzENQ+v F7lNqB0NKc/SZe8h5h5sNc7I6RE34HSxJgJDFN7rBm4h2AeKqw+rCV9feDunPxryvBYinA /+2JN/7NhRd1iVg6TJq/SAFwariEVHY= X-MC-Unique: D6qPa_PhO0qFlLmH-rztdw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 06/15] meson: Add CanoKey Date: Tue, 14 Jun 2022 14:16:01 +0200 Message-Id: <20220614121610.508356-7-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209009394100002 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- meson_options.txt | 2 ++ hw/usb/Kconfig | 5 +++++ hw/usb/meson.build | 5 +++++ meson.build | 6 ++++++ scripts/meson-buildoptions.sh | 3 +++ 5 files changed, 21 insertions(+) diff --git a/meson_options.txt b/meson_options.txt index 2de94af03712..0e8197386b99 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -189,6 +189,8 @@ option('spice_protocol', type : 'feature', value : 'aut= o', description: 'Spice protocol support') option('u2f', type : 'feature', value : 'auto', description: 'U2F emulation support') +option('canokey', type : 'feature', value : 'auto', + description: 'CanoKey support') option('usb_redir', type : 'feature', value : 'auto', description: 'libusbredir support') option('l2tpv3', type : 'feature', value : 'auto', diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 53f8283ffdc1..ce4f4339763e 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -119,6 +119,11 @@ config USB_U2F default y depends on USB =20 +config USB_CANOKEY + bool + default y + depends on USB + config IMX_USBPHY bool default y diff --git a/hw/usb/meson.build b/hw/usb/meson.build index de853d780dd8..793df42e2127 100644 --- a/hw/usb/meson.build +++ b/hw/usb/meson.build @@ -63,6 +63,11 @@ if u2f.found() softmmu_ss.add(when: 'CONFIG_USB_U2F', if_true: [u2f, files('u2f-emulate= d.c')]) endif =20 +# CanoKey +if canokey.found() + softmmu_ss.add(when: 'CONFIG_USB_CANOKEY', if_true: [canokey, files('can= okey.c')]) +endif + # usb redirect if usbredir.found() usbredir_ss =3D ss.source_set() diff --git a/meson.build b/meson.build index 21cd949082dc..0c2e11ff0715 100644 --- a/meson.build +++ b/meson.build @@ -1408,6 +1408,12 @@ if have_system method: 'pkg-config', kwargs: static_kwargs) endif +canokey =3D not_found +if have_system + canokey =3D dependency('canokey-qemu', required: get_option('canokey'), + method: 'pkg-config', + kwargs: static_kwargs) +endif usbredir =3D not_found if not get_option('usb_redir').auto() or have_system usbredir =3D dependency('libusbredirparser-0.5', required: get_option('u= sb_redir'), diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index 00ea4d8cd169..1fc1d2e2c362 100644 --- a/scripts/meson-buildoptions.sh +++ b/scripts/meson-buildoptions.sh @@ -73,6 +73,7 @@ meson_options_help() { printf "%s\n" ' bpf eBPF support' printf "%s\n" ' brlapi brlapi character device driver' printf "%s\n" ' bzip2 bzip2 support for DMG images' + printf "%s\n" ' canokey CanoKey support' printf "%s\n" ' cap-ng cap_ng support' printf "%s\n" ' capstone Whether and how to find the capstone li= brary' printf "%s\n" ' cloop cloop image format support' @@ -204,6 +205,8 @@ _meson_option_parse() { --disable-brlapi) printf "%s" -Dbrlapi=3Ddisabled ;; --enable-bzip2) printf "%s" -Dbzip2=3Denabled ;; --disable-bzip2) printf "%s" -Dbzip2=3Ddisabled ;; + --enable-canokey) printf "%s" -Dcanokey=3Denabled ;; + --disable-canokey) printf "%s" -Dcanokey=3Ddisabled ;; --enable-cap-ng) printf "%s" -Dcap_ng=3Denabled ;; --disable-cap-ng) printf "%s" -Dcap_ng=3Ddisabled ;; --enable-capstone) printf "%s" -Dcapstone=3Denabled ;; --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209008; cv=none; d=zohomail.com; s=zohoarc; b=b5dzu4434MCEYjppoIUAPf3BITPob1008f8x8XhbyWJMK6ka9I37BYfrelcDg9e76P8nfBldXMwK7mggyr60nGL/GaD7jj+3r0nxk+Fun6kEBaxxBQnG1a1MQOsQJ/HIIxZfxD5ng8PuFjpbyaqGZQaY+qqy8uqaxtLbirPaCRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209008; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Iypp4lhP0vK8zaOIYv4YGS15C6hr5eRaL+NEXu7qlj4=; b=mxLYRIYlG0GVcsG4KmUoJrrPQEryNVHt5F0jJs3Hg3c+KmObAJ2zozhWPVE97LLdJSMTl/SpR3lbIwsmd8Kvi7e3tigF9Uqx2mXO9m4GuW13C8wDCEKY3VfheYzNB1Twn8g++LBWgRDTsZVABvlicx8sgLNRiHLEnHdLW36m46M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209008257511.2500974227614; Tue, 14 Jun 2022 05:16:48 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348869.575114 (Exim 4.92) (envelope-from ) id 1o15T9-0001SW-KJ; Tue, 14 Jun 2022 12:16:27 +0000 Received: by outflank-mailman (output) from mailman id 348869.575114; Tue, 14 Jun 2022 12:16:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T9-0001Ru-CF; Tue, 14 Jun 2022 12:16:27 +0000 Received: by outflank-mailman (input) for mailman id 348869; Tue, 14 Jun 2022 12:16:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T7-0008Ek-0Q for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:25 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cda789d3-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:23 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-uS3o44O8OS2SpFNP5fHGSA-1; Tue, 14 Jun 2022 08:16:18 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3AE9C1C05149; Tue, 14 Jun 2022 12:16:18 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4E17416164; Tue, 14 Jun 2022 12:16:17 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 5832B1800622; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cda789d3-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iypp4lhP0vK8zaOIYv4YGS15C6hr5eRaL+NEXu7qlj4=; b=ByYhOQoGo5lpU9WjWTlMduyw18WYF4e8z/qeOlNrQSXqGj0pdYvao7zwETV0qNFZqJAapL El5go6ddDPML3GUGREhmEgSfjiTV6HNhmgh46JQoopiMjoGwIY1Pu8305Mtf1vZbF65r7j a2oqAjOjNSM9TP9uBU2aOYy4rIfggsQ= X-MC-Unique: uS3o44O8OS2SpFNP5fHGSA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 07/15] docs: Add CanoKey documentation Date: Tue, 14 Jun 2022 14:16:02 +0200 Message-Id: <20220614121610.508356-8-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209009410100003 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/device-emulation.rst | 1 + docs/system/devices/canokey.rst | 168 +++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) create mode 100644 docs/system/devices/canokey.rst diff --git a/docs/system/device-emulation.rst b/docs/system/device-emulatio= n.rst index 3b729b920d7c..05060060563f 100644 --- a/docs/system/device-emulation.rst +++ b/docs/system/device-emulation.rst @@ -92,3 +92,4 @@ Emulated Devices devices/vhost-user.rst devices/virtio-pmem.rst devices/vhost-user-rng.rst + devices/canokey.rst diff --git a/docs/system/devices/canokey.rst b/docs/system/devices/canokey.= rst new file mode 100644 index 000000000000..169f99b8eb82 --- /dev/null +++ b/docs/system/devices/canokey.rst @@ -0,0 +1,168 @@ +.. _canokey: + +CanoKey QEMU +------------ + +CanoKey [1]_ is an open-source secure key with supports of + +* U2F / FIDO2 with Ed25519 and HMAC-secret +* OpenPGP Card V3.4 with RSA4096, Ed25519 and more [2]_ +* PIV (NIST SP 800-73-4) +* HOTP / TOTP +* NDEF + +All these platform-independent features are in canokey-core [3]_. + +For different platforms, CanoKey has different implementations, +including both hardware implementions and virtual cards: + +* CanoKey STM32 [4]_ +* CanoKey Pigeon [5]_ +* (virt-card) CanoKey USB/IP +* (virt-card) CanoKey FunctionFS + +In QEMU, yet another CanoKey virt-card is implemented. +CanoKey QEMU exposes itself as a USB device to the guest OS. + +With the same software configuration as a hardware key, +the guest OS can use all the functionalities of a secure key as if +there was actually an hardware key plugged in. + +CanoKey QEMU provides much convenience for debuging: + +* libcanokey-qemu supports debuging output thus developers can + inspect what happens inside a secure key +* CanoKey QEMU supports trace event thus event +* QEMU USB stack supports pcap thus USB packet between the guest + and key can be captured and analysed + +Then for developers: + +* For developers on software with secure key support (e.g. FIDO2, OpenPGP), + they can see what happens inside the secure key +* For secure key developers, USB packets between guest OS and CanoKey + can be easily captured and analysed + +Also since this is a virtual card, it can be easily used in CI for testing +on code coping with secure key. + +Building +=3D=3D=3D=3D=3D=3D=3D=3D + +libcanokey-qemu is required to use CanoKey QEMU. + +.. code-block:: shell + + git clone https://github.com/canokeys/canokey-qemu + mkdir canokey-qemu/build + pushd canokey-qemu/build + +If you want to install libcanokey-qemu in a different place, +add ``-DCMAKE_INSTALL_PREFIX=3D/path/to/your/place`` to cmake below. + +.. code-block:: shell + + cmake .. + make + make install # may need sudo + popd + +Then configuring and building: + +.. code-block:: shell + + # depending on your env, lib/pkgconfig can be lib64/pkgconfig + export PKG_CONFIG_PATH=3D/path/to/your/place/lib/pkgconfig:$PKG_CONFIG= _PATH + ./configure --enable-canokey && make + +Using CanoKey QEMU +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +CanoKey QEMU stores all its data on a file of the host specified by the ar= gument +when invoking qemu. + +.. parsed-literal:: + + |qemu_system| -usb -device canokey,file=3D$HOME/.canokey-file + +Note: you should keep this file carefully as it may contain your private k= ey! + +The first time when the file is used, it is created and initialized by Can= oKey, +afterwards CanoKey QEMU would just read this file. + +After the guest OS boots, you can check that there is a USB device. + +For example, If the guest OS is an Linux machine. You may invoke lsusb +and find CanoKey QEMU there: + +.. code-block:: shell + + $ lsusb + Bus 001 Device 002: ID 20a0:42d4 Clay Logic CanoKey QEMU + +You may setup the key as guided in [6]_. The console for the key is at [7]= _. + +Debuging +=3D=3D=3D=3D=3D=3D=3D=3D + +CanoKey QEMU consists of two parts, ``libcanokey-qemu.so`` and ``canokey.c= ``, +the latter of which resides in QEMU. The former provides core functionality +of a secure key while the latter provides platform-dependent functions: +USB packet handling. + +If you want to trace what happens inside the secure key, when compiling +libcanokey-qemu, you should add ``-DQEMU_DEBUG_OUTPUT=3DON`` in cmake comm= and +line: + +.. code-block:: shell + + cmake .. -DQEMU_DEBUG_OUTPUT=3DON + +If you want to trace events happened in canokey.c, use + +.. parsed-literal:: + + |qemu_system| --trace "canokey_*" \\ + -usb -device canokey,file=3D$HOME/.canokey-file + +If you want to capture USB packets between the guest and the host, you can: + +.. parsed-literal:: + + |qemu_system| -usb -device canokey,file=3D$HOME/.canokey-file,pcap=3Dk= ey.pcap + +Limitations +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Currently libcanokey-qemu.so has dozens of global variables as it was orig= inally +designed for embedded systems. Thus one qemu instance can not have +multiple CanoKey QEMU running, namely you can not + +.. parsed-literal:: + + |qemu_system| -usb -device canokey,file=3D$HOME/.canokey-file \\ + -device canokey,file=3D$HOME/.canokey-file2 + +Also, there is no lock on canokey-file, thus two CanoKey QEMU instance +can not read one canokey-file at the same time. + +Another limitation is that this device is not compatible with ``qemu-xhci`= `, +in that this device would hang when there are FIDO2 packets (traffic on +interrupt endpoints). If you do not use FIDO2 then it works as intended, +but for full functionality you should use old uhci/ehci bus and attach can= okey +to it, for example + +.. parsed-literal:: + + |qemu_system| -device piix3-usb-uhci,id=3Duhci -device canokey,bus=3Duh= ci.0 + +References +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +.. [1] ``_ +.. [2] `= `_ +.. [3] ``_ +.. [4] ``_ +.. [5] ``_ +.. [6] ``_ +.. [7] ``_ --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209003; cv=none; d=zohomail.com; s=zohoarc; b=hOX0j9mS6sna4T9aZBzsBOpoDvMbRoSE2qDrPip0xyWDpwZAvG6ePNnSTvlcMsnI6GFf1mCUu0YhMdrYRWar466n1H5WtEXA9PN82QgUy7+lq5EpRH43b2as4SCO1EEpiKJlDt903y/p/WlYokSGi/S1lgyoV2lyRcObmv1EMxI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209003; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TqkIe5B5GmtLHYDEQNksBwY0pKybp1zEh7xnID9ieAU=; b=bI1p820Sabw1E+KALgg7NlgRCw7ghCCTV/rGo3KwmvINxCr3c3dBb9u+sAVGGUH8ZV8EQfU9A8PI8Dc1t68J+Z16IKx497eWhIIeLBzVoqMG7xN37oKzXa8Cq8lSWFjsfJX3YEY/lfr0AKETq7wPaB3EwRCgpIP3xNq2r2BUghs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209003296490.5098637159424; Tue, 14 Jun 2022 05:16:43 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348868.575103 (Exim 4.92) (envelope-from ) id 1o15T8-00017A-0p; Tue, 14 Jun 2022 12:16:26 +0000 Received: by outflank-mailman (output) from mailman id 348868.575103; Tue, 14 Jun 2022 12:16:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T7-000162-RC; Tue, 14 Jun 2022 12:16:25 +0000 Received: by outflank-mailman (input) for mailman id 348868; Tue, 14 Jun 2022 12:16:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T5-0008Ek-V5 for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:23 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd46dad5-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:22 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-562-gh_vAfIkM3yhrdpogkCCfQ-1; Tue, 14 Jun 2022 08:16:19 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 37F61299E75F; Tue, 14 Jun 2022 12:16:19 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E95EC1121319; Tue, 14 Jun 2022 12:16:18 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 63FB01800626; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd46dad5-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqkIe5B5GmtLHYDEQNksBwY0pKybp1zEh7xnID9ieAU=; b=L045pJYrpxdM5PdDnsGhNf3P9JpUqJUrDw6AFPdhTGlauVkdHzGPrA/q/rppWixEspWze+ Ivz4vU0qCCrXLWr9mJ2tQ+PrwpA6mwpZBjl4L0BT8RTgUOY7TX7+BPvr3cwcKG9BpCWXbK nHQoS0ylcrYhH6zswyhaHhJoEjEg12E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TqkIe5B5GmtLHYDEQNksBwY0pKybp1zEh7xnID9ieAU=; b=L045pJYrpxdM5PdDnsGhNf3P9JpUqJUrDw6AFPdhTGlauVkdHzGPrA/q/rppWixEspWze+ Ivz4vU0qCCrXLWr9mJ2tQ+PrwpA6mwpZBjl4L0BT8RTgUOY7TX7+BPvr3cwcKG9BpCWXbK nHQoS0ylcrYhH6zswyhaHhJoEjEg12E= X-MC-Unique: gh_vAfIkM3yhrdpogkCCfQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 08/15] docs/system/devices/usb: Add CanoKey to USB devices examples Date: Tue, 14 Jun 2022 14:16:03 +0200 Message-Id: <20220614121610.508356-9-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209004335100006 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- docs/system/devices/usb.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst index afb7d6c2268d..872d9167589b 100644 --- a/docs/system/devices/usb.rst +++ b/docs/system/devices/usb.rst @@ -199,6 +199,10 @@ option or the ``device_add`` monitor command. Availabl= e devices are: ``u2f-{emulated,passthru}`` Universal Second Factor device =20 +``canokey`` + An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more. + For more information, see :ref:`canokey`. + Physical port addressing ^^^^^^^^^^^^^^^^^^^^^^^^ =20 --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209009; cv=none; d=zohomail.com; s=zohoarc; b=KcMifU+51b7w1RCoEDWqEhGaPdrq9FWunSJYMnwrSehu3wxTOva3AZYHYTwwqjDdy/kL6y9YTRToQnhxsQ5407g9AP9yujd4uRMhxJLxQ7epvtNU0+wSzep39XBh1c4ZSp5+q5SKnKlEWL7FpY5NFBBbeDfMVavGMea1YRW14Io= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209009; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PVva2fRC3vGqvRDPoZrUChjHwOIX197Reg0ezh6aFRw=; b=m7UZefYzWq4/+p/q9lwrz7XAPxWg6Y/slGF8F/cRkdZ/eNNVzAvOIKWJxPwoa8pdrdguwjHVFw0Zdtvd8XYvzsUnBIglCdTW5TLrhIveSLG5fmK0d+AYBQpKY9VBern6pLPa196wprVZ3f+X7SRgYA6O09uSNcOc3GSv/wf8WHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209009002711.6645489429773; Tue, 14 Jun 2022 05:16:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348872.575135 (Exim 4.92) (envelope-from ) id 1o15TC-0001zb-AW; Tue, 14 Jun 2022 12:16:30 +0000 Received: by outflank-mailman (output) from mailman id 348872.575135; Tue, 14 Jun 2022 12:16:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TB-0001vn-TM; Tue, 14 Jun 2022 12:16:29 +0000 Received: by outflank-mailman (input) for mailman id 348872; Tue, 14 Jun 2022 12:16:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15T9-0008Ek-VW for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:28 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cecb6f1b-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:25 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-35-j3ECH_JHNIaqhgvfOeUaig-1; Tue, 14 Jun 2022 08:16:20 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A513085A580; Tue, 14 Jun 2022 12:16:19 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CA1A492CA2; Tue, 14 Jun 2022 12:16:19 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 6F585180062D; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cecb6f1b-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PVva2fRC3vGqvRDPoZrUChjHwOIX197Reg0ezh6aFRw=; b=hGTCtB7IjZbhA0aoXp8rLCQNRfd8XQ90ulnxua1YeNj3lyu1RUt/ESBjnwxL73yo3NsDXL wN5Q3YlYxOHwVwMLNczsQI1/gxmXB+fJEoG8o/Iy4pnQnqoWY+uWE40DyRmzDOI+idAGph bRAN8e341aQij1VMGxRlb1oQVRsXeO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PVva2fRC3vGqvRDPoZrUChjHwOIX197Reg0ezh6aFRw=; b=hGTCtB7IjZbhA0aoXp8rLCQNRfd8XQ90ulnxua1YeNj3lyu1RUt/ESBjnwxL73yo3NsDXL wN5Q3YlYxOHwVwMLNczsQI1/gxmXB+fJEoG8o/Iy4pnQnqoWY+uWE40DyRmzDOI+idAGph bRAN8e341aQij1VMGxRlb1oQVRsXeO8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PVva2fRC3vGqvRDPoZrUChjHwOIX197Reg0ezh6aFRw=; b=hGTCtB7IjZbhA0aoXp8rLCQNRfd8XQ90ulnxua1YeNj3lyu1RUt/ESBjnwxL73yo3NsDXL wN5Q3YlYxOHwVwMLNczsQI1/gxmXB+fJEoG8o/Iy4pnQnqoWY+uWE40DyRmzDOI+idAGph bRAN8e341aQij1VMGxRlb1oQVRsXeO8= X-MC-Unique: j3ECH_JHNIaqhgvfOeUaig-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 09/15] MAINTAINERS: add myself as CanoKey maintainer Date: Tue, 14 Jun 2022 14:16:04 +0200 Message-Id: <20220614121610.508356-10-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209009385100001 Content-Type: text/plain; charset="utf-8" From: "Hongren (Zenithal) Zheng" Signed-off-by: Hongren (Zenithal) Zheng Message-Id: Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0df25ed4b0a3..4cf6174f9f37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2427,6 +2427,14 @@ F: hw/intc/s390_flic*.c F: include/hw/s390x/s390_flic.h L: qemu-s390x@nongnu.org =20 +CanoKey +M: Hongren (Zenithal) Zheng +S: Maintained +R: Canokeys.org +F: hw/usb/canokey.c +F: hw/usb/canokey.h +F: docs/system/devices/canokey.rst + Subsystems ---------- Overall Audio backends --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209129; cv=none; d=zohomail.com; s=zohoarc; b=WlxV9VwdEPZ4QrWco8w6XADBXQlN4wFPaHWb/qik7wwGwXEz8gwM8jCsoaHVyOIHZ0lhGCfvlhznO60zTOIs+UT1hvK3DhtQC7cFp6IUCLg1eS10E5uuXaPvh/5Sf8Xo3LCFEWKTpM66cq/8oxjZ8slgeKDVAgZM2nl/SKZexNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209129; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=obSiKgR2g439N1NCymTkGuD5ZtC+AWQDUPf1CsA55V4=; b=BhFj4bym6QNs381Lp0jbdoW7G3WKG6LR3i2AHhVqZ4SMyxs+LoyE0kMYqQPu+cPLii5iu00g3Fw2sFykTva+IQ6rVPy4wWuAonDE65rlpLZp3TZc/V0stSRdLRtKMqCaVYA0e378ohjbHeOQQk4XRHkXLbuzPfvmwYUtddsLncE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209129935345.0581011184381; Tue, 14 Jun 2022 05:18:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348907.575181 (Exim 4.92) (envelope-from ) id 1o15V7-0006Cu-8R; Tue, 14 Jun 2022 12:18:29 +0000 Received: by outflank-mailman (output) from mailman id 348907.575181; Tue, 14 Jun 2022 12:18:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15V7-0006Cn-4D; Tue, 14 Jun 2022 12:18:29 +0000 Received: by outflank-mailman (input) for mailman id 348907; Tue, 14 Jun 2022 12:18:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TA-0008Ek-VC for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:29 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf5a055f-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:26 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-ShlgDFknNeqfm4GcSjjXPw-1; Tue, 14 Jun 2022 08:16:21 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF5B0185A7B2; Tue, 14 Jun 2022 12:16:20 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 737951121319; Tue, 14 Jun 2022 12:16:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7B3B1180062F; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf5a055f-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=obSiKgR2g439N1NCymTkGuD5ZtC+AWQDUPf1CsA55V4=; b=QiDiqnXQIkJSVpc0dFJ8BUa3AsWf4q0hc1vNipk51ZxvPoiRIOsRJRGjp/Bi9wu0jCAqWE Mt9FOo6nf3ebpyILAmKPa13btdAPHrus2vDeIqoIILmuV4oe51iMqUhBa84SXu3xGKdYdl NTyUQF788Fn744Sqp3V8x5qrpwPtsus= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=obSiKgR2g439N1NCymTkGuD5ZtC+AWQDUPf1CsA55V4=; b=QiDiqnXQIkJSVpc0dFJ8BUa3AsWf4q0hc1vNipk51ZxvPoiRIOsRJRGjp/Bi9wu0jCAqWE Mt9FOo6nf3ebpyILAmKPa13btdAPHrus2vDeIqoIILmuV4oe51iMqUhBa84SXu3xGKdYdl NTyUQF788Fn744Sqp3V8x5qrpwPtsus= X-MC-Unique: ShlgDFknNeqfm4GcSjjXPw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann , Arnout Engelen Subject: [PULL 10/15] hw/usb/hcd-ehci: fix writeback order Date: Tue, 14 Jun 2022 14:16:05 +0200 Message-Id: <20220614121610.508356-11-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209130400100002 Content-Type: text/plain; charset="utf-8" From: Arnout Engelen The 'active' bit passes control over a qTD between the guest and the controller: set to 1 by guest to enable execution by the controller, and the controller sets it to '0' to hand back control to the guest. ehci_state_writeback write two dwords to main memory using DMA: the third dword of the qTD (containing dt, total bytes to transfer, cpage, cerr and status) and the fourth dword of the qTD (containing the offset). This commit makes sure the fourth dword is written before the third, avoiding a race condition where a new offset written into the qTD by the guest after it observed the status going to go to '0' gets overwritten by a 'late' DMA writeback of the previous offset. This race condition could lead to 'cpage out of range (5)' errors, and reproduced by: ./qemu-system-x86_64 -enable-kvm -bios $SEABIOS/bios.bin -m 4096 -device us= b-ehci -blockdev driver=3Dfile,read-only=3Don,filename=3D/home/aengelen/Dow= nloads/openSUSE-Tumbleweed-DVD-i586-Snapshot20220428-Media.iso,node-name=3D= iso -device usb-storage,drive=3Diso,bootindex=3D0 -chardev pipe,id=3Dshell,= path=3D/tmp/pipe -device virtio-serial -device virtconsole,chardev=3Dshell = -device virtio-rng-pci -serial mon:stdio -nographic (press a key, select 'Installation' (2), and accept the default values. On my machine the 'cpage out of range' is reproduced while loading the Linux Kernel about once per 7 attempts. With the fix in this commit it no longer fails) This problem was previously reported as a seabios problem in https://mail.coreboot.org/hyperkitty/list/seabios@seabios.org/thread/OUTHT5= ISSQJGXPNTUPY3O5E5EPZJCHM3/ and as a nixos CI build failure in https://github.com/NixOS/nixpkgs/issues/170803 Signed-off-by: Arnout Engelen Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 33a8a377bd95..d4da8dcb8d15 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -2011,7 +2011,10 @@ static int ehci_state_writeback(EHCIQueue *q) ehci_trace_qtd(q, NLPTR_GET(p->qtdaddr), (EHCIqtd *) &q->qh.next_qtd); qtd =3D (uint32_t *) &q->qh.next_qtd; addr =3D NLPTR_GET(p->qtdaddr); - put_dwords(q->ehci, addr + 2 * sizeof(uint32_t), qtd + 2, 2); + /* First write back the offset */ + put_dwords(q->ehci, addr + 3 * sizeof(uint32_t), qtd + 3, 1); + /* Then write back the token, clearing the 'active' bit */ + put_dwords(q->ehci, addr + 2 * sizeof(uint32_t), qtd + 2, 1); ehci_free_packet(p); =20 /* --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209153; cv=none; d=zohomail.com; s=zohoarc; b=ihKN+3JGD5tj0YQvFy5fdGLcJs2TgjC/hb0fOktYGfRwR0qyrvsBrJ8xHfDYt/dFgIw1yIHBo/NxEhu5GXL5Op31f4icl9Oik711TEjfqpedzM6OrzxVQUSpMrjh9G5an5C5qpiHQZIL8jYKU3UnA9lVj2JndLqpI0zTmsO5Cxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209153; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZStqjDDMtLMpDsz58F8O29JWAJ6F3RkNGXfWxICk7zU=; b=PqySCy8chqYiZ88JMp779cor94MMyIiSd7wU8+kI8XHlzvf43hO4EEJ+1w2UNPJdW/Hnl12LsejrLN8jYp/RULb4EEj/pzjVkx51YlLpGJjFZsq8VelJQex5rCMT4dlJwhiFWGZtmbqDiqF7Fm2+ht7Cbn65lEoseI4rSFvZ6Zg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209153766768.2314259148543; Tue, 14 Jun 2022 05:19:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348956.575224 (Exim 4.92) (envelope-from ) id 1o15Vc-00008W-N2; Tue, 14 Jun 2022 12:19:00 +0000 Received: by outflank-mailman (output) from mailman id 348956.575224; Tue, 14 Jun 2022 12:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15Vc-000088-KF; Tue, 14 Jun 2022 12:19:00 +0000 Received: by outflank-mailman (input) for mailman id 348956; Tue, 14 Jun 2022 12:18:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TK-0008Ek-4I for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:38 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d533a08d-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:35 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-iSDuPmZxN-GLRmezrfI0Zg-1; Tue, 14 Jun 2022 08:16:21 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25D9B3C025C4; Tue, 14 Jun 2022 12:16:21 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD2C09D7F; Tue, 14 Jun 2022 12:16:20 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 870F21800630; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d533a08d-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZStqjDDMtLMpDsz58F8O29JWAJ6F3RkNGXfWxICk7zU=; b=RpJLr7OezkVjRLe+lbEbgutREiOb2/wEzx21PzzEhJFGnnCkIYQORXDLX15IdUpWkdDG0e 1mI5ho30CUVUeU+u+xmMBF3NQS2+WRrqcn2Ga05FO3isvkyvKVL4theqblcu/TB1fMpt/e yX0CD2kC5AWFnp2efzAYtSIUg+Kvcuk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZStqjDDMtLMpDsz58F8O29JWAJ6F3RkNGXfWxICk7zU=; b=RpJLr7OezkVjRLe+lbEbgutREiOb2/wEzx21PzzEhJFGnnCkIYQORXDLX15IdUpWkdDG0e 1mI5ho30CUVUeU+u+xmMBF3NQS2+WRrqcn2Ga05FO3isvkyvKVL4theqblcu/TB1fMpt/e yX0CD2kC5AWFnp2efzAYtSIUg+Kvcuk= X-MC-Unique: iSDuPmZxN-GLRmezrfI0Zg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann , Joelle van Dyne Subject: [PULL 11/15] usbredir: avoid queuing hello packet on snapshot restore Date: Tue, 14 Jun 2022 14:16:06 +0200 Message-Id: <20220614121610.508356-12-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209154479100001 Content-Type: text/plain; charset="utf-8" From: Joelle van Dyne When launching QEMU with "-loadvm", usbredir_create_parser() should avoid setting up the hello packet (just as with "-incoming". On the latest version of libusbredir, usbredirparser_unserialize() will return error if the parser is not "pristine." Signed-off-by: Joelle van Dyne Message-Id: <20220507041850.98716-1-j@getutm.app> Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index fd7df599bc0b..1bd30efc3ef0 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1280,7 +1280,8 @@ static void usbredir_create_parser(USBRedirDevice *de= v) } #endif =20 - if (runstate_check(RUN_STATE_INMIGRATE)) { + if (runstate_check(RUN_STATE_INMIGRATE) || + runstate_check(RUN_STATE_PRELAUNCH)) { flags |=3D usbredirparser_fl_no_hello; } usbredirparser_init(dev->parser, VERSION, caps, USB_REDIR_CAPS_SIZE, --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209144; cv=none; d=zohomail.com; s=zohoarc; b=HIo9x6gb1Hc7DvHDOBeXepmLbezpGR1zh5I77SVw/8+Y11KApXPPRY9vljTEilc5d6vdfU6v1tHQ0MrcyrTh24OVTjiTyvXZJUttD6NkEvNk1JEWgf68DbV115s0bCfhfiQqRgVZL1fVXX8IwxDP+Y1ri7sirvcF7rqoSEVC4ug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209144; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nK8ui8MGXo28dreQTzjS6bbhtNnN1TEyDDyCd/Q1Dgo=; b=GXJmRs9TadbBZPkzAwRxnDAyMxryiKS0IszaZt/tO1sVW4m+XRQBbEzsp8vxC6zuOjzMMA3hUNwmCCgh4N1d54GBMHkUY7ZOFXFzFFRJzAvfM56J93DSS8ZQWs95WmBQx/JMkRJQc8NWzVDD2V8rIxi0L//pYLyORS60WnqO/Qg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 165520914412832.35610806084662; Tue, 14 Jun 2022 05:19:04 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348936.575203 (Exim 4.92) (envelope-from ) id 1o15VO-0007LJ-23; Tue, 14 Jun 2022 12:18:46 +0000 Received: by outflank-mailman (output) from mailman id 348936.575203; Tue, 14 Jun 2022 12:18:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15VN-0007Kz-Uc; Tue, 14 Jun 2022 12:18:45 +0000 Received: by outflank-mailman (input) for mailman id 348936; Tue, 14 Jun 2022 12:18:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TD-0008Ek-24 for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:31 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d08ed4dc-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:28 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-wdmex2yGOJ-VOeDajZfdxQ-1; Tue, 14 Jun 2022 08:16:22 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 28842801E6B; Tue, 14 Jun 2022 12:16:22 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA58A1402403; Tue, 14 Jun 2022 12:16:21 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 936FD1800634; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d08ed4dc-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nK8ui8MGXo28dreQTzjS6bbhtNnN1TEyDDyCd/Q1Dgo=; b=QaGyse8WQpqV+Fb1sk4omhhfdkGDM2MjkpCujnwXgfqDaF53IoaW1Y3ohMRe9lkb03JjV7 P1QmkJ+sn3HZzAfAEd+LKFv2NL86MuF7f00rPmSNlLrG7bvPWWeusZ24dlmqjKsdnxRYnm HXaRAIHc/wuvMMnap7J+T0Jw1YTou+A= X-MC-Unique: wdmex2yGOJ-VOeDajZfdxQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann , Dongwon Kim , Vivek Kasireddy Subject: [PULL 12/15] virtio-gpu: update done only on the scanout associated with rect Date: Tue, 14 Jun 2022 14:16:07 +0200 Message-Id: <20220614121610.508356-13-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209144421100001 Content-Type: text/plain; charset="utf-8" From: Dongwon Kim It only needs to update the scanouts containing the rect area coming with the resource-flush request from the guest. Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Message-Id: <20220505214030.4261-1-dongwon.kim@intel.com> Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index cd4a56056fd9..55c6dd576318 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -514,6 +514,9 @@ static void virtio_gpu_resource_flush(VirtIOGPU *g, for (i =3D 0; i < g->parent_obj.conf.max_outputs; i++) { scanout =3D &g->parent_obj.scanout[i]; if (scanout->resource_id =3D=3D res->resource_id && + rf.r.x >=3D scanout->x && rf.r.y >=3D scanout->y && + rf.r.x + rf.r.width <=3D scanout->x + scanout->width && + rf.r.y + rf.r.height <=3D scanout->y + scanout->height && console_has_gl(scanout->con)) { dpy_gl_update(scanout->con, 0, 0, scanout->width, scanout->height); --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209129; cv=none; d=zohomail.com; s=zohoarc; b=TVkcLd0B2sdZFChEcE1Spe6sMhEkRF3dcqcUU6NL+kC/xbZvxOp8Ns95Fz0IMMS5VAKC5M0B8VZ0JxLVO3CkjzeGrrHTrVji1RRP4UsT8clntLEnCaQRVOZ32rwaB8cWp+0oLzg8+YeGZp5mVHZ2k3OqNNgzZfBl27OzM3NrpDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209129; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hTTJvnegxxvfJsWseZ7+SmUjba5GRnY9ME/e3uOvaP0=; b=GPCQEzcVOKWjQqAnCZKIJkVU8+RlyJ45BFlT5b5Llo1xawVj77N9OdV0bfQa9xIcQ+8QcZmmq75xQsbUD+tHvcLoyw65119Qr3ltoKlzkz6hnKP5krgCmc7VC6r6h8fOr5vVw51/f1cFuNvZdDzMRcfye4OQ6pRdJLFGBWSZ28k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209129834181.2452011100022; Tue, 14 Jun 2022 05:18:49 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348902.575170 (Exim 4.92) (envelope-from ) id 1o15V5-0005vU-Vl; Tue, 14 Jun 2022 12:18:27 +0000 Received: by outflank-mailman (output) from mailman id 348902.575170; Tue, 14 Jun 2022 12:18:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15V5-0005vN-SG; Tue, 14 Jun 2022 12:18:27 +0000 Received: by outflank-mailman (input) for mailman id 348902; Tue, 14 Jun 2022 12:18:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TE-0008Ek-0O for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:32 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1a756ad-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:29 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-SPez3mJKOCOnjtiYtyhytA-1; Tue, 14 Jun 2022 08:16:23 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C031F811E75; Tue, 14 Jun 2022 12:16:22 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87A64492CA2; Tue, 14 Jun 2022 12:16:22 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A63A51800795; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1a756ad-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTTJvnegxxvfJsWseZ7+SmUjba5GRnY9ME/e3uOvaP0=; b=fM0UcOn3HF8EuPfT/s9sr9Cy2VW8NGbn3nnyQMVRu0zkJ/xs3WY01nkNh5ZEOvng9YPeHy O+3ry2BTSPrfRkdfnV76RPVl+66eXydPINuOucAw13NtKxcwPhXbgCA+0GH4FdJTgu417+ DP8T0sXmlxEjh/dcHpmOM33rCe+9qhI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTTJvnegxxvfJsWseZ7+SmUjba5GRnY9ME/e3uOvaP0=; b=fM0UcOn3HF8EuPfT/s9sr9Cy2VW8NGbn3nnyQMVRu0zkJ/xs3WY01nkNh5ZEOvng9YPeHy O+3ry2BTSPrfRkdfnV76RPVl+66eXydPINuOucAw13NtKxcwPhXbgCA+0GH4FdJTgu417+ DP8T0sXmlxEjh/dcHpmOM33rCe+9qhI= X-MC-Unique: SPez3mJKOCOnjtiYtyhytA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 13/15] ui/console: Do not return a value with ui_info Date: Tue, 14 Jun 2022 14:16:08 +0200 Message-Id: <20220614121610.508356-14-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209130391100001 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki The returned value is not used and misleading. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-2-akihiko.odaki@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- hw/display/virtio-gpu-base.c | 6 +++--- hw/display/virtio-vga.c | 5 ++--- hw/vfio/display.c | 8 +++----- 4 files changed, 9 insertions(+), 12 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index c44b28a972ca..642d6f5248cf 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -432,7 +432,7 @@ typedef struct GraphicHwOps { bool gfx_update_async; /* if true, calls graphic_hw_update_done() */ void (*text_update)(void *opaque, console_ch_t *text); void (*update_interval)(void *opaque, uint64_t interval); - int (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info); + void (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info); void (*gl_block)(void *opaque, bool block); } GraphicHwOps; =20 diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index 790cec333c8c..b21d6e5b0be8 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw/display/virtio-gpu-base.c @@ -69,12 +69,12 @@ static void virtio_gpu_notify_event(VirtIOGPUBase *g, u= int32_t event_type) virtio_notify_config(&g->parent_obj); } =20 -static int virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) +static void virtio_gpu_ui_info(void *opaque, uint32_t idx, QemuUIInfo *inf= o) { VirtIOGPUBase *g =3D opaque; =20 if (idx >=3D g->conf.max_outputs) { - return -1; + return; } =20 g->req_state[idx].x =3D info->xoff; @@ -92,7 +92,7 @@ static int virtio_gpu_ui_info(void *opaque, uint32_t idx,= QemuUIInfo *info) =20 /* send event to guest */ virtio_gpu_notify_event(g, VIRTIO_GPU_EVENT_DISPLAY); - return 0; + return; } =20 static void diff --git a/hw/display/virtio-vga.c b/hw/display/virtio-vga.c index c206b5da384b..4dcb34c4a740 100644 --- a/hw/display/virtio-vga.c +++ b/hw/display/virtio-vga.c @@ -47,15 +47,14 @@ static void virtio_vga_base_text_update(void *opaque, c= onsole_ch_t *chardata) } } =20 -static int virtio_vga_base_ui_info(void *opaque, uint32_t idx, QemuUIInfo = *info) +static void virtio_vga_base_ui_info(void *opaque, uint32_t idx, QemuUIInfo= *info) { VirtIOVGABase *vvga =3D opaque; VirtIOGPUBase *g =3D vvga->vgpu; =20 if (g->hw_ops->ui_info) { - return g->hw_ops->ui_info(g, idx, info); + g->hw_ops->ui_info(g, idx, info); } - return -1; } =20 static void virtio_vga_base_gl_block(void *opaque, bool block) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index 89bc90508fb8..78f4d82c1c35 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@ -106,14 +106,14 @@ err: return; } =20 -static int vfio_display_edid_ui_info(void *opaque, uint32_t idx, - QemuUIInfo *info) +static void vfio_display_edid_ui_info(void *opaque, uint32_t idx, + QemuUIInfo *info) { VFIOPCIDevice *vdev =3D opaque; VFIODisplay *dpy =3D vdev->dpy; =20 if (!dpy->edid_regs) { - return 0; + return; } =20 if (info->width && info->height) { @@ -121,8 +121,6 @@ static int vfio_display_edid_ui_info(void *opaque, uint= 32_t idx, } else { vfio_display_edid_update(vdev, false, 0, 0); } - - return 0; } =20 static void vfio_display_edid_init(VFIOPCIDevice *vdev) --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209145; cv=none; d=zohomail.com; s=zohoarc; b=lO54Y5XOL5iZy5+1LNFwh0orZfGWWs7lTaJRu9vW8txwk0/t6zagKl9my92qW/JNdO+M2vxDzGEa734KH1tRsXjZcj7Dp516HwFRp/CqDfyo7ZGSpLkeU8kNA5jFRKY+BHUZqPF+3BfQsEO/I8/wvq7oQf+KJbqN5KlodssKIUw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209145; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ebiRccH2awWxGwAppvEzoFJ/M1x++CURc9+zFzjg06Y=; b=ArYI2kHNxM0NUrhV+AGv/STxjPHHMHGp9v/wMcX8xGRYUGyE47ZN38UUgvoT69TwevEk++SEm9ryUxyhy2MzT9RBJUwWI2iy0/2N1p0ikR1mZ+tiD8IIXrLyLWFoWfy/YUvaCV1snUTcTgWrktRF99HgFlIs0X8UzSBc86r8RDs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 16552091456511009.2728345559111; Tue, 14 Jun 2022 05:19:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348940.575214 (Exim 4.92) (envelope-from ) id 1o15VP-0007fV-F4; Tue, 14 Jun 2022 12:18:47 +0000 Received: by outflank-mailman (output) from mailman id 348940.575214; Tue, 14 Jun 2022 12:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15VP-0007eh-8j; Tue, 14 Jun 2022 12:18:47 +0000 Received: by outflank-mailman (input) for mailman id 348940; Tue, 14 Jun 2022 12:18:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TF-0008Ek-27 for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:33 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d18fc4cf-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:30 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-Wfr5vr_lM5eHXKXnMWOPLw-1; Tue, 14 Jun 2022 08:16:25 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE1AD299E753; Tue, 14 Jun 2022 12:16:23 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5DC97202699A; Tue, 14 Jun 2022 12:16:23 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id BEF1F1800799; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d18fc4cf-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ebiRccH2awWxGwAppvEzoFJ/M1x++CURc9+zFzjg06Y=; b=cdEHgiUlJr/ftFnmDkEMFMJRp+OODbF4jE9u4pjJ8J+ZIA36MShHXUu+voydYdBn2q1IZ3 Rulq2uCMbSivnMhdgfTp2ELon7At9OMtlXu7L+80cj6C89e0NRMnQA6+kHuxEo9PruVIXU Gjs1MDEiq81/yNRAtQdgvjnSwQot/Sg= X-MC-Unique: Wfr5vr_lM5eHXKXnMWOPLw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 14/15] ui: Deliver refresh rate via QemuUIInfo Date: Tue, 14 Jun 2022 14:16:09 +0200 Message-Id: <20220614121610.508356-15-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209146450100003 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki This change adds a new member, refresh_rate to QemuUIInfo in include/ui/console.h. It represents the refresh rate of the physical display backend, and it is more appropriate than GUI update interval as the refresh rate which the emulated device reports: - sdl may set GUI update interval shorter than the refresh rate of the physical display to respond to user-generated events. - sdl and vnc aggressively changes GUI update interval, but a guests is typically not designed to respond to frequent refresh rate changes, or frequent "display mode" changes in general. The frequency of refresh rate changes of the physical display backend matches better to the guest's expectation. QemuUIInfo also has other members representing "display mode", which makes it suitable for refresh rate representation. It has a throttling of update notifications, and prevents frequent changes of the display mode. Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-3-akihiko.odaki@gmail.com> Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- include/ui/gtk.h | 2 +- hw/display/xenfb.c | 14 +++++++++++--- ui/console.c | 6 ------ ui/gtk-egl.c | 4 ++-- ui/gtk-gl-area.c | 3 +-- ui/gtk.c | 45 +++++++++++++++++++++++++------------------- 7 files changed, 42 insertions(+), 34 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 642d6f5248cf..b64d82436097 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width; uint32_t height; + uint32_t refresh_rate; } QemuUIInfo; =20 /* cursor data format is 32bit RGBA */ @@ -431,7 +432,6 @@ typedef struct GraphicHwOps { void (*gfx_update)(void *opaque); bool gfx_update_async; /* if true, calls graphic_hw_update_done() */ void (*text_update)(void *opaque, console_ch_t *text); - void (*update_interval)(void *opaque, uint64_t interval); void (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info); void (*gl_block)(void *opaque, bool block); } GraphicHwOps; diff --git a/include/ui/gtk.h b/include/ui/gtk.h index 101b147d1b98..ae0f53740d19 100644 --- a/include/ui/gtk.h +++ b/include/ui/gtk.h @@ -155,7 +155,7 @@ extern bool gtk_use_gl_area; =20 /* ui/gtk.c */ void gd_update_windowsize(VirtualConsole *vc); -int gd_monitor_update_interval(GtkWidget *widget); +void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget); void gd_hw_gl_flushed(void *vc); =20 /* ui/gtk-egl.c */ diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c index cea10fe3c780..50857cd97a0b 100644 --- a/hw/display/xenfb.c +++ b/hw/display/xenfb.c @@ -777,16 +777,24 @@ static void xenfb_update(void *opaque) xenfb->up_fullscreen =3D 0; } =20 -static void xenfb_update_interval(void *opaque, uint64_t interval) +static void xenfb_ui_info(void *opaque, uint32_t idx, QemuUIInfo *info) { struct XenFB *xenfb =3D opaque; + uint32_t refresh_rate; =20 if (xenfb->feature_update) { #ifdef XENFB_TYPE_REFRESH_PERIOD if (xenfb_queue_full(xenfb)) { return; } - xenfb_send_refresh_period(xenfb, interval); + + refresh_rate =3D info->refresh_rate; + if (!refresh_rate) { + refresh_rate =3D 75; + } + + /* T =3D 1 / f =3D 1 [s*Hz] / f =3D 1000*1000 [ms*mHz] / f */ + xenfb_send_refresh_period(xenfb, 1000 * 1000 / refresh_rate); #endif } } @@ -983,5 +991,5 @@ struct XenDevOps xen_framebuffer_ops =3D { static const GraphicHwOps xenfb_ops =3D { .invalidate =3D xenfb_invalidate, .gfx_update =3D xenfb_update, - .update_interval =3D xenfb_update_interval, + .ui_info =3D xenfb_ui_info, }; diff --git a/ui/console.c b/ui/console.c index 36c80cd1de85..9331b85203a0 100644 --- a/ui/console.c +++ b/ui/console.c @@ -160,7 +160,6 @@ static void gui_update(void *opaque) uint64_t dcl_interval; DisplayState *ds =3D opaque; DisplayChangeListener *dcl; - QemuConsole *con; =20 ds->refreshing =3D true; dpy_refresh(ds); @@ -175,11 +174,6 @@ static void gui_update(void *opaque) } if (ds->update_interval !=3D interval) { ds->update_interval =3D interval; - QTAILQ_FOREACH(con, &consoles, next) { - if (con->hw_ops->update_interval) { - con->hw_ops->update_interval(con->hw, interval); - } - } trace_console_refresh(interval); } ds->last_update =3D qemu_clock_get_ms(QEMU_CLOCK_REALTIME); diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index e3bd4bc27431..b5bffbab2522 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -140,8 +140,8 @@ void gd_egl_refresh(DisplayChangeListener *dcl) { VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); =20 - vc->gfx.dcl.update_interval =3D gd_monitor_update_interval( - vc->window ? vc->window : vc->gfx.drawing_area); + gd_update_monitor_refresh_rate( + vc, vc->window ? vc->window : vc->gfx.drawing_area); =20 if (!vc->gfx.esurface) { gd_egl_init(vc); diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 2e0129c28cd4..682638a197d2 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -121,8 +121,7 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl) { VirtualConsole *vc =3D container_of(dcl, VirtualConsole, gfx.dcl); =20 - vc->gfx.dcl.update_interval =3D gd_monitor_update_interval( - vc->window ? vc->window : vc->gfx.drawing_area); + gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : vc->gfx.d= rawing_area); =20 if (!vc->gfx.gls) { if (!gtk_widget_get_realized(vc->gfx.drawing_area)) { diff --git a/ui/gtk.c b/ui/gtk.c index c57c36749e0e..2a791dd2aa04 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -710,11 +710,20 @@ static gboolean gd_window_close(GtkWidget *widget, Gd= kEvent *event, return TRUE; } =20 -static void gd_set_ui_info(VirtualConsole *vc, gint width, gint height) +static void gd_set_ui_refresh_rate(VirtualConsole *vc, int refresh_rate) { QemuUIInfo info; =20 - memset(&info, 0, sizeof(info)); + info =3D *dpy_get_ui_info(vc->gfx.dcl.con); + info.refresh_rate =3D refresh_rate; + dpy_set_ui_info(vc->gfx.dcl.con, &info, true); +} + +static void gd_set_ui_size(VirtualConsole *vc, gint width, gint height) +{ + QemuUIInfo info; + + info =3D *dpy_get_ui_info(vc->gfx.dcl.con); info.width =3D width; info.height =3D height; dpy_set_ui_info(vc->gfx.dcl.con, &info, true); @@ -738,33 +747,32 @@ static void gd_resize_event(GtkGLArea *area, { VirtualConsole *vc =3D (void *)opaque; =20 - gd_set_ui_info(vc, width, height); + gd_set_ui_size(vc, width, height); } =20 #endif =20 -/* - * If available, return the update interval of the monitor in ms, - * else return 0 (the default update interval). - */ -int gd_monitor_update_interval(GtkWidget *widget) +void gd_update_monitor_refresh_rate(VirtualConsole *vc, GtkWidget *widget) { #ifdef GDK_VERSION_3_22 GdkWindow *win =3D gtk_widget_get_window(widget); + int refresh_rate; =20 if (win) { GdkDisplay *dpy =3D gtk_widget_get_display(widget); GdkMonitor *monitor =3D gdk_display_get_monitor_at_window(dpy, win= ); - int refresh_rate =3D gdk_monitor_get_refresh_rate(monitor); /* [mH= z] */ - - if (refresh_rate) { - /* T =3D 1 / f =3D 1 [s*Hz] / f =3D 1000*1000 [ms*mHz] / f */ - return MIN(1000 * 1000 / refresh_rate, - GUI_REFRESH_INTERVAL_DEFAULT); - } + refresh_rate =3D gdk_monitor_get_refresh_rate(monitor); /* [mHz] */ + } else { + refresh_rate =3D 0; } + + gd_set_ui_refresh_rate(vc, refresh_rate); + + /* T =3D 1 / f =3D 1 [s*Hz] / f =3D 1000*1000 [ms*mHz] / f */ + vc->gfx.dcl.update_interval =3D refresh_rate ? + MIN(1000 * 1000 / refresh_rate, GUI_REFRESH_INTERVAL_DEFAULT) : + GUI_REFRESH_INTERVAL_DEFAULT; #endif - return 0; } =20 static gboolean gd_draw_event(GtkWidget *widget, cairo_t *cr, void *opaque) @@ -801,8 +809,7 @@ static gboolean gd_draw_event(GtkWidget *widget, cairo_= t *cr, void *opaque) return FALSE; } =20 - vc->gfx.dcl.update_interval =3D - gd_monitor_update_interval(vc->window ? vc->window : s->window); + gd_update_monitor_refresh_rate(vc, vc->window ? vc->window : s->window= ); =20 fbw =3D surface_width(vc->gfx.ds); fbh =3D surface_height(vc->gfx.ds); @@ -1691,7 +1698,7 @@ static gboolean gd_configure(GtkWidget *widget, { VirtualConsole *vc =3D opaque; =20 - gd_set_ui_info(vc, cfg->width, cfg->height); + gd_set_ui_size(vc, cfg->width, cfg->height); return FALSE; } =20 --=20 2.36.1 From nobody Mon May 20 01:44:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1655209125; cv=none; d=zohomail.com; s=zohoarc; b=jX5SJR4lKhb5oCZj9svCMb5F1jFe+BZrMwzDo4WbK3N0y/t2ftnWsmqD3spd+KtyfwIFPoTD2gAJ9xXzFFDJnEf3P/OgShXsDukiT8tm+ee/wgvCUJuAQ6iH0MIJ3qu1YdeyRgmtOlVISdm3pdvo3ahmG08iyZkxkxbYjD6J4oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655209125; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fjkT/ghvgIP+ASWCtRqN8cFZ3mDw+gAHZxFgoi4zHGM=; b=kUtsZDxNIcUcAsjo6wuNcSXVFmjlluP3/eIuAIypACc10z3ifGIWGRiGmDZjAMzv7ljQqKXhgkpMGOtX7DnRpV8KQzibmmPnv9ZBVhh11K9tXu5kFOvDZhKtuWi23EPUoij72DuPFTP4ht4KHtvQzzFw8VJJ+CmHFmE8quTxs/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1655209125401400.51467365692145; Tue, 14 Jun 2022 05:18:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.348900.575158 (Exim 4.92) (envelope-from ) id 1o15V2-0005dG-Mf; Tue, 14 Jun 2022 12:18:24 +0000 Received: by outflank-mailman (output) from mailman id 348900.575158; Tue, 14 Jun 2022 12:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15V2-0005d9-Jl; Tue, 14 Jun 2022 12:18:24 +0000 Received: by outflank-mailman (input) for mailman id 348900; Tue, 14 Jun 2022 12:18:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o15TB-0008Ek-VX for xen-devel@lists.xenproject.org; Tue, 14 Jun 2022 12:16:30 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d067031f-ebdb-11ec-bd2c-47488cf2e6aa; Tue, 14 Jun 2022 14:16:27 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-253-9-V6lrRoPN-wePOBAR4HAQ-1; Tue, 14 Jun 2022 08:16:25 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4430B185A7B2; Tue, 14 Jun 2022 12:16:24 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 009C72166B26; Tue, 14 Jun 2022 12:16:24 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id D094A180079D; Tue, 14 Jun 2022 14:16:11 +0200 (CEST) X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d067031f-ebdb-11ec-bd2c-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655208986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fjkT/ghvgIP+ASWCtRqN8cFZ3mDw+gAHZxFgoi4zHGM=; b=VgxUziE8uhLC+rQ0gEU5G9yqj1A8dNwFl4K/3PynYs4kaW2OCp8aV4XjFUNKHTY6uEMYsr fAP+U0U5nwu6aBES20zOKJ1h1R8tHVLMoy2WZ3JnlNlPznFWCb9nE59LqUEZ8Mb8U7lFm3 d/g7dIlu7FlYxru1ina1FXhhYSDP35M= X-MC-Unique: 9-V6lrRoPN-wePOBAR4HAQ-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Akihiko Odaki , Peter Maydell , Alex Williamson , xen-devel@lists.xenproject.org, Paul Durrant , Anthony Perard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Hongren (Zenithal) Zheng" , "Michael S. Tsirkin" , "Canokeys.org" , Stefano Stabellini , Gerd Hoffmann Subject: [PULL 15/15] virtio-gpu: Respect UI refresh rate for EDID Date: Tue, 14 Jun 2022 14:16:10 +0200 Message-Id: <20220614121610.508356-16-kraxel@redhat.com> In-Reply-To: <20220614121610.508356-1-kraxel@redhat.com> References: <20220614121610.508356-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1655209126357100001 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220226115516.59830-4-akihiko.odaki@gmail.com> Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 1 + hw/display/virtio-gpu.c | 1 + 3 files changed, 3 insertions(+) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index afff9e158e31..2e28507efe21 100644 --- a/include/hw/virtio/virtio-gpu.h +++ b/include/hw/virtio/virtio-gpu.h @@ -80,6 +80,7 @@ struct virtio_gpu_scanout { struct virtio_gpu_requested_state { uint16_t width_mm, height_mm; uint32_t width, height; + uint32_t refresh_rate; int x, y; }; =20 diff --git a/hw/display/virtio-gpu-base.c b/hw/display/virtio-gpu-base.c index b21d6e5b0be8..a29f191aa82e 100644 --- a/hw/display/virtio-gpu-base.c +++ b/hw/display/virtio-gpu-base.c @@ -79,6 +79,7 @@ static void virtio_gpu_ui_info(void *opaque, uint32_t idx= , QemuUIInfo *info) =20 g->req_state[idx].x =3D info->xoff; g->req_state[idx].y =3D info->yoff; + g->req_state[idx].refresh_rate =3D info->refresh_rate; g->req_state[idx].width =3D info->width; g->req_state[idx].height =3D info->height; g->req_state[idx].width_mm =3D info->width_mm; diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 55c6dd576318..20cc703dcc6e 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -217,6 +217,7 @@ virtio_gpu_generate_edid(VirtIOGPU *g, int scanout, .height_mm =3D b->req_state[scanout].height_mm, .prefx =3D b->req_state[scanout].width, .prefy =3D b->req_state[scanout].height, + .refresh_rate =3D b->req_state[scanout].refresh_rate, }; =20 edid->size =3D cpu_to_le32(sizeof(edid->edid)); --=20 2.36.1