From nobody Sat May 18 21:16:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585938005; cv=none; d=zohomail.com; s=zohoarc; b=XR5FwVnXFWteLntQJCi1jFrJAAJ6j1xxJFGl7SJjVjrDGKw7GAC36bpx4m6SlE0vNpteHut+Or634HO18H78F1LD2iT6oWizc1DCYvO3anD7MOQkKiXbYbOPWer2rSzL6U9WCgpUp5XfDmQoyVmXbRYS9RUc86xcHbjuA7Lx+7o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585938005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NHND7+mScEhgpgEgKhvx6knVFTH7cl7RolzgUKYwi8s=; b=j7y/4iB9XdYcN0lM+gZIgxmmFDdkZLFq3Y4lUo0ZuGdcZ/yMm/qFtciwUGbGvNxh19KSlUqF9hSyw56q87Ddaovxf/n/IUEkN1kgHxXMgAUZZNy5CsgAp8JtKo0aOizR8ZQR1h/d+V+5BGqxiwpMiSFpKds6yPgr1t33xR9gRu4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1585938005468227.45720713036076; Fri, 3 Apr 2020 11:20:05 -0700 (PDT) Received: from localhost ([::1]:59438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKQvD-0007jD-St for importer@patchew.org; Fri, 03 Apr 2020 14:20:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42778) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKQuV-0007Cx-M8 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 14:19:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKQuT-0000Jf-D9 for qemu-devel@nongnu.org; Fri, 03 Apr 2020 14:19:19 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:38899 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jKQuT-0000JD-AL for qemu-devel@nongnu.org; Fri, 03 Apr 2020 14:19:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-QU4vygijOoSZ2EmLnJdieg-1; Fri, 03 Apr 2020 14:19:10 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CBD6D107ACC4; Fri, 3 Apr 2020 18:19:09 +0000 (UTC) Received: from blue.redhat.com (ovpn-113-246.phx2.redhat.com [10.3.113.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id F05755C296; Fri, 3 Apr 2020 18:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585937957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NHND7+mScEhgpgEgKhvx6knVFTH7cl7RolzgUKYwi8s=; b=HJXjceoyf2jQOeILvqNHIt04bny3TC6rN+ltd0u6Z5fcXRVTfoMTm25+nEdvCW93mN06a6 fVMjy+EqLgK1nScruRZsdqPOrF5BCAuisNqhp2kGdcRUvDu5LK5qz7X1kcLW8rHXrNhAjF SQSgiNbEg2x3HeTitH3gaHsVmd/aAdg= X-MC-Unique: QU4vygijOoSZ2EmLnJdieg-1 From: Eric Blake To: qemu-devel@nongnu.org Subject: [PATCH for-5.0? v2] qcow2: Explicit mention of padding bytes Date: Fri, 3 Apr 2020 13:19:07 -0500 Message-Id: <20200403181907.878751-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , vsementsov@virtuozzo.com, "open list:qcow2" , mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and relied on the rest of the text for implicitly covering 7 padding bytes. For consistency with other parts of the header (such as the header extension format listing padding from n - m, or the snapshot table entry mentioning variable padding), we might as well call out the remaining 7 bytes as padding until such time (as any) as they gain another meaning. Signed-off-by: Eric Blake --- v2: Call out explicit byte range rather than '105 - m' [Max] Safe for 5.0 as it is just a doc fix, but only if we actually want it. docs/interop/qcow2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 640e0eca4000..80728bc2008d 100644 --- a/docs/interop/qcow2.txt +++ b/docs/interop/qcow2.txt @@ -210,3 +210,4 @@ version 2. Available compression type values: 0: zlib + 105 - 111: Padding, leave as zero. =3D=3D=3D Header padding =3D=3D=3D --=20 2.26.0.rc2