From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813329451473.47847161291645; Sat, 23 Jun 2018 21:08:49 -0700 (PDT) Received: from localhost ([::1]:40487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwKN-00053i-Fl for importer@patchew.org; Sun, 24 Jun 2018 00:08:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwII-0003jl-LI for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIG-0003hN-Jn for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:30 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:33878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIG-0003hF-FV; Sun, 24 Jun 2018 00:06:28 -0400 Received: by mail-qk0-x244.google.com with SMTP id b66-v6so348412qkj.1; Sat, 23 Jun 2018 21:06:28 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BXZ3TltxLVi5ZCRN6XIGUwCl7iIEoMwsENofQGK5k44=; b=UPKsU0YtaS2DkihuPbLpkfFWJ4rPwMuMw3k1g69eiwbCmb16JtsPu2szWtneWOcvcp vGhsD9SusZaXpo9byh0X0TolBWEsKID6uJDlKER1QAbPOjNbzSjo759xE0gtg+k+VjIU qIbszbsWNEKrzthVPrfGv6b2u+KDMadvos/A3czl1Gm8G5dkciNXtuyJny3mCVck8T6x qQ09eu3IZ3QUmQWnpM8hjscsX2UBDLUpmA71fTtgfbSO+ZxIZMRdHonoBULYhaq4RqM3 +wRF8jU69EnJrtuyAX8kaAf3KQ+OMTbXxi8nrkVixZStZUTAgx6tSoa6djlHM9yy8OqV 9SCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BXZ3TltxLVi5ZCRN6XIGUwCl7iIEoMwsENofQGK5k44=; b=te1NsdSzVx6mLSefMjqtMYKC9CQAwB9/g73nDf9wM40OehFfR2oKromEDXy6HE1Hw2 t0exm3WQJe0/TvNVr7LQxOFr5ajw+/PaYRuTCgeOSu63Qq6HL83rHYgmI17geP2XSmc7 3P5pjiSF4r8wcp7qGhzjoIIg19hrDOAVcdwlT7GO3MxkD2tG29WswVWPN8gf2yCogtSb NM7Rai3IFV/88orzYvI2sxB0d/MwTUycKvrqB7BWXb5MnLoxME7ZGQGvDKRvJq3J1U49 KSSODpYFUlNZhtEusEoTTQp9vibVwUqCEKSkpYrfGEZ/FrxNhA7CyP00fdCIZ1P96+AU JOcw== X-Gm-Message-State: APt69E2Y9TeQ633pE3Eo7NKBo+RdvoKsh5OS2Oop5OH8Lr/PeWWoEUjY 7mF9uX/0lK2dbcATfmwa58g= X-Google-Smtp-Source: ADUXVKK7s4naWFyv6AzaWrTmgj/bUO2MNV+vHym56+3u/zEIhs+f9bbaqtWTfTPI0Bf6DC8yaEurcA== X-Received: by 2002:a37:9a95:: with SMTP id c143-v6mr6538756qke.378.1529813188026; Sat, 23 Jun 2018 21:06:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:54 -0300 Message-Id: <20180624040609.17572-2-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/input/pckbd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c index f33e3fc63d..07c8801387 100644 --- a/hw/input/pckbd.c +++ b/hw/input/pckbd.c @@ -22,6 +22,7 @@ * THE SOFTWARE. */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/isa/isa.h" #include "hw/i386/pc.h" @@ -308,7 +309,8 @@ static void kbd_write_command(void *opaque, hwaddr addr, /* ignore that */ break; default: - fprintf(stderr, "qemu: unsupported keyboard cmd=3D0x%02x\n", (int)= val); + qemu_log_mask(LOG_GUEST_ERROR, + "unsupported keyboard cmd=3D0x%02" PRIx64 "\n", val); break; } } --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15298134820141000.5826606217238; Sat, 23 Jun 2018 21:11:22 -0700 (PDT) Received: from localhost ([::1]:40514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwMp-0007Cv-BN for importer@patchew.org; Sun, 24 Jun 2018 00:11:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIK-0003ju-Ah for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIJ-0003jO-DM for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:32 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:36336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIJ-0003jG-98; Sun, 24 Jun 2018 00:06:31 -0400 Received: by mail-qk0-x22d.google.com with SMTP id a195-v6so5836119qkg.3; Sat, 23 Jun 2018 21:06:31 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QxVwz/wTVhtCIfXlL0zThFvKYmMH8n7LNs7GLwqQ1Eg=; b=HV/gd35JsXB3wJ+TFyJmd/0AAPWEBn9J6kyjBvpsloteZ40FZv0Qn/tgK02AprdcqY 2jxcNlZGXK0cLNyoR02nK6B8yMT3w0pPaYgElvReYWj6654Uqb/RoDspxx1oycvffRee VDz9uYBFIljblZkgrAgguHDZsCC6mYYgIORxCn2cCNZEIgcIJ2OjEsTedef4r2LpQq6Y K6PLYbakl6dvxHinL2tEou7PjPkUMdXuv28QdlyK0T0Ni486T60WnLvGuGzpSgSK4HqU wRK8d113E0v8d1y+z/6skkXTDwAT8tqStV9+igHHn8JdaiLr5/yLyDsw+8gMi05ASGpC fj8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=QxVwz/wTVhtCIfXlL0zThFvKYmMH8n7LNs7GLwqQ1Eg=; b=pB598FItlOfOw8PfY2r9I1jN4yf5gvObfCdgQrBYAWhCGFfifgdgcvZVUlC5HY7QsS rdNCyHwS8WgiZKnlo6p0rGkVqBRMfmBfKW4761yKyrS0L6uklBWr6T2dJGSFlXgT9xo9 hflb8UgHFJi05B0XLMRNU1nVM+KLb0uIgZ1e5gb6Yqy7sw7nilrWFHHNAZNasHwtI4u4 am0QcTiRorDeSHmF/nIIevRtvWNE2AJQ1FkSsaSQkTVwAeEoF430SDL6B2Ii1M74YW8Y Wp4O2t4vSCu4mYYM2T1jqgxtyZclhyOsIu7ArVyztV7w9BZFsjia/cpMcIboFxiju7QZ i+QQ== X-Gm-Message-State: APt69E1qXkdvLgNk2P10Ldb9TdrxZKCzaFnZzotCaA8Vec3umjVakedc naQ7aYu5JaDlox2+61VEndI= X-Google-Smtp-Source: ADUXVKJuksannAkDWIrBbiamfKgU8az+McEOv8G9ppyj3iCdF06jGdoZOGURtAW1yEVNYYGMrbeVyg== X-Received: by 2002:a37:5b87:: with SMTP id p129-v6mr6666344qkb.178.1529813190781; Sat, 23 Jun 2018 21:06:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:55 -0300 Message-Id: <20180624040609.17572-3-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22d Subject: [Qemu-devel] [PATCH v3 02/16] hw/input/tsc2005: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/input/tsc2005.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c index 7990954b6c..4dd95596ab 100644 --- a/hw/input/tsc2005.c +++ b/hw/input/tsc2005.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "qemu/timer.h" #include "ui/console.h" @@ -208,9 +209,10 @@ static void tsc2005_write(TSC2005State *s, int reg, ui= nt16_t data) } s->nextprecision =3D (data >> 13) & 1; s->timing[0] =3D data & 0x1fff; - if ((s->timing[0] >> 11) =3D=3D 3) - fprintf(stderr, "%s: illegal conversion clock setting\n", - __func__); + if ((s->timing[0] >> 11) =3D=3D 3) { + qemu_log_mask(LOG_GUEST_ERROR, + "tsc2005_write: illegal conversion clock setting= \n"); + } break; case 0xd: /* CFR1 */ s->timing[1] =3D data & 0xf07; @@ -221,8 +223,9 @@ static void tsc2005_write(TSC2005State *s, int reg, uin= t16_t data) break; =20 default: - fprintf(stderr, "%s: write into read-only register %x\n", - __func__, reg); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: write into read-only register 0x%x\n", + __func__, reg); } } =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813606057799.7056200835463; Sat, 23 Jun 2018 21:13:26 -0700 (PDT) Received: from localhost ([::1]:40528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwOz-0000af-Ar for importer@patchew.org; Sun, 24 Jun 2018 00:13:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIM-0003lf-Ns for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIL-0003lG-Nr for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:34 -0400 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:46879) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIL-0003l0-JQ; Sun, 24 Jun 2018 00:06:33 -0400 Received: by mail-qk0-x22d.google.com with SMTP id o2-v6so5822350qkc.13; Sat, 23 Jun 2018 21:06:33 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9BJrfe3YsXs6O2ov28k+EgGRDFxXxxjtMYmwMWtaRlY=; b=L50UsBP56A6kQYytHBgjVB+2IkwYODPRw6w99sCL/dHKfscNTwq7luHrPD10XBj/B4 vx6nyoL3Cb6Mc+73BQ/Y+vCNrnggzOZs9/qZ9iQ/u9EadCgkJ0xegFqPFOOvwEzAQEMo e2T8nNT88rysqiFEaGG3qla70kcxsFdHvEfFa27pXxkyBQKua7yZcxtKxsfunhJWi1al 1nKYf5WBrjYdkGuVahG+2R3rsNDsR5zSkFhG5Gzm2cL0dO3WEsbfYWVxH6+I/M/NKtj2 B/vNo+DOWBRsAYYjAtaKfeIfsdlokYQirWEzq8lNd6gy7cUjJwt/g3MXDiTC/Nx0Q1O1 xH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9BJrfe3YsXs6O2ov28k+EgGRDFxXxxjtMYmwMWtaRlY=; b=oykA6JDfs+zH5TMKKj2lYmImX0syYaTKIEj2ElGAMccVnt+lwVybBVq2ERgkjE/qTr QhR5xeHX9kSCrIPrcUoa4m2paweVeQE/SqO3AR93TqiC/XY7N0K4h5eGFCOf3rwkvkNv PVm3343y9y3nAMte1kwWfj92df14RCQkc726XL1/w+x7SCNz4cs8H4P5AWOxlZ9/q8nB xHFsvwXVd4pVkwNGSv6fjhVXm41x2BHZAcEqyy1USA1A8jkYuPrNyd3RuTuz3ZNVhCCX M6VJIe3bx6hcGqSRDEgswVBpMgvba43wEto9hHt0vqt5yRADKLPAd4LjCa2EmDO0yvfj q1hQ== X-Gm-Message-State: APt69E2KkJK9MfJhP2qS7It640fulP9cnXuiBO2POOaa5pLrSU0Qv9gB Euoes7IsU3+nCnzZCgA44wI= X-Google-Smtp-Source: AAOMgpdW0MCkN297rfJ8YYZqiOgvCbxa6e7aUPu1wfL4WB4rjCNO/YbssGJRqt5Nhk7XCVyP51/lCA== X-Received: by 2002:a37:16d1:: with SMTP id 78-v6mr6700828qkw.271.1529813193169; Sat, 23 Jun 2018 21:06:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:56 -0300 Message-Id: <20180624040609.17572-4-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22d Subject: [Qemu-devel] [PATCH v3 03/16] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/dma/omap_dma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index abd18c67ea..ab3a1b0451 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -18,6 +18,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qemu-common.h" #include "qemu/timer.h" #include "hw/arm/omap.h" @@ -1439,8 +1440,9 @@ static int omap_dma_sys_read(struct omap_dma_s *s, in= t offset, case 0x480: /* DMA_PCh0_SR */ case 0x482: /* DMA_PCh1_SR */ case 0x4c0: /* DMA_PChD_SR_0 */ - printf("%s: Physical Channel Status Registers not implemented.\n", - __func__); + qemu_log_mask(LOG_UNIMP, + "%s: Physical Channel Status Registers not implement= ed\n", + __func__); *ret =3D 0xff; break; =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813383676349.6910152227297; Sat, 23 Jun 2018 21:09:43 -0700 (PDT) Received: from localhost ([::1]:40493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwLO-0005tT-Ua for importer@patchew.org; Sun, 24 Jun 2018 00:09:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIT-0003sp-DG for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIO-0003o7-KM for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:41 -0400 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:35494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIO-0003np-FK; Sun, 24 Jun 2018 00:06:36 -0400 Received: by mail-qk0-x243.google.com with SMTP id u21-v6so244113qku.2; Sat, 23 Jun 2018 21:06:36 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=36on+xdgbXFxeBwwHxce84Ksqf4fOm9jRWSX1+NwhG8=; b=n57dpeieDdUQa1TjXoAPnFWyyrNm0SjjZ1g64Rd4aflPYkcjh65xqRrdQyU+M1Yb0d cgzG6ZdkEYxqrrYDmqlnpdhgMDB143v5rcQbJnEsEKvjsNX4yoQxXEHZuxgRM8HADmdO 8S768EE3dcw+KpMRpSl4Y0TedVYPyFMEXlY52Fzd9ryceozPmZqbX/AaEm8IjqfLtFVo /WzSwfX2BmsQg/RbcyiQrjoKawCJd76J5W4K3r3a90wFW83VuVxmIlnm9txCf0mtHpU8 fThXwqU4wQ/8icEWQE12MORSPP/6VWfgKvi2jzWQ9YPw0fBRsx9AoEu3a1l7FPn7rX9l gCOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=36on+xdgbXFxeBwwHxce84Ksqf4fOm9jRWSX1+NwhG8=; b=ZkXpgadq8/U6GGgMohMw65W/yl+W3dgZrUJKPJBXOEfWjDBw6JdfZXk/eOgxrlkMKu c3TPzZ5IMtwtwXvCA1GXu3t0Nofj0fThQnSBRdBbvQbC9nRKMJ5LDnNA8f5jl0bsMXNG AS1LQyriCpZnN1mKq8RLwGedueb0G9zqFWXCfYwcAHzqHC6DSwlnqEyKgwpZ8Bat7Q5+ /BKOyeqGwnIfa3Wm3WeUZT91IpwJke/6ZvNGYiEgybKzNVuBqQOjyYy7NCOxr2u9VmwR IFOf4HmgGZXH8YqlhoUBkUFh9u0QP2dD4pL5sTeyZ9g1Mm+TprAd7aVsJ6ryg6y8skP5 Rr6A== X-Gm-Message-State: APt69E1CLRyV9hRjcG+gAwMOiOSDuYlVMJCyBk6271Mp5hP/5cCIzsu5 jcNPJPPalXpaXrSohsRDRCY= X-Google-Smtp-Source: ADUXVKKr9TVRgh2enCcj60wEURz7Ib0Ol6IKEDqjgcZ7+S71gJOkTjY2gQvLVaiZ8rt1HtRkQUyTLw== X-Received: by 2002:a37:1328:: with SMTP id d40-v6mr6369523qkh.198.1529813195931; Sat, 23 Jun 2018 21:06:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:57 -0300 Message-Id: <20180624040609.17572-5-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH v3 04/16] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/dma/omap_dma.c | 64 +++++++++++++++++++++++++++++------------------ 1 file changed, 40 insertions(+), 24 deletions(-) diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index ab3a1b0451..cbb920f31d 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -879,15 +879,18 @@ static int omap_dma_ch_reg_write(struct omap_dma_s *s, ch->burst[0] =3D (value & 0x0180) >> 7; ch->pack[0] =3D (value & 0x0040) >> 6; ch->port[0] =3D (enum omap_dma_port) ((value & 0x003c) >> 2); - if (ch->port[0] >=3D __omap_dma_port_last) - printf("%s: invalid DMA port %i\n", __func__, - ch->port[0]); - if (ch->port[1] >=3D __omap_dma_port_last) - printf("%s: invalid DMA port %i\n", __func__, - ch->port[1]); + if (ch->port[0] >=3D __omap_dma_port_last) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid DMA port %i\n", + __func__, ch->port[0]); + } + if (ch->port[1] >=3D __omap_dma_port_last) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid DMA port %i\n", + __func__, ch->port[1]); + } ch->data_type =3D 1 << (value & 3); if ((value & 3) =3D=3D 3) { - printf("%s: bad data_type for DMA channel\n", __func__); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: bad data_type for DMA channel\n", __func__); ch->data_type >>=3D 1; } break; @@ -1899,14 +1902,18 @@ static void omap_dma4_write(void *opaque, hwaddr ad= dr, if (value & 2) /* SOFTRESET */ omap_dma_reset(s->dma); s->ocp =3D value & 0x3321; - if (((s->ocp >> 12) & 3) =3D=3D 3) /* MIDLEMODE */ - fprintf(stderr, "%s: invalid DMA power mode\n", __func__); + if (((s->ocp >> 12) & 3) =3D=3D 3) { /* MIDLEMODE */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid DMA power mode\n", + __func__); + } return; =20 case 0x78: /* DMA4_GCR */ s->gcr =3D value & 0x00ff00ff; - if ((value & 0xff) =3D=3D 0x00) /* MAX_CHANNEL_FIFO_DEPTH */ - fprintf(stderr, "%s: wrong FIFO depth in GCR\n", __func__); + if ((value & 0xff) =3D=3D 0x00) { /* MAX_CHANNEL_FIFO_DEPTH */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: wrong FIFO depth in GCR\n", + __func__); + } return; =20 case 0x80 ... 0xfff: @@ -1935,9 +1942,11 @@ static void omap_dma4_write(void *opaque, hwaddr add= r, case 0x00: /* DMA4_CCR */ ch->buf_disable =3D (value >> 25) & 1; ch->src_sync =3D (value >> 24) & 1; /* XXX For CamDMA must be 1 */ - if (ch->buf_disable && !ch->src_sync) - fprintf(stderr, "%s: Buffering disable is not allowed in " - "destination synchronised mode\n", __func__); + if (ch->buf_disable && !ch->src_sync) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Buffering disable is not allowed in " + "destination synchronised mode\n", __func__); + } ch->prefetch =3D (value >> 23) & 1; ch->bs =3D (value >> 18) & 1; ch->transparent_copy =3D (value >> 17) & 1; @@ -1947,9 +1956,11 @@ static void omap_dma4_write(void *opaque, hwaddr add= r, ch->suspend =3D (value & 0x0100) >> 8; ch->priority =3D (value & 0x0040) >> 6; ch->fs =3D (value & 0x0020) >> 5; - if (ch->fs && ch->bs && ch->mode[0] && ch->mode[1]) - fprintf(stderr, "%s: For a packet transfer at least one port " - "must be constant-addressed\n", __func__); + if (ch->fs && ch->bs && ch->mode[0] && ch->mode[1]) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: For a packet transfer at least one port " + "must be constant-addressed\n", __func__); + } ch->sync =3D (value & 0x001f) | ((value >> 14) & 0x0060); /* XXX must be 0x01 for CamDMA */ =20 @@ -1978,9 +1989,11 @@ static void omap_dma4_write(void *opaque, hwaddr add= r, ch->endian_lock[0] =3D(value >> 20) & 1; ch->endian[1] =3D(value >> 19) & 1; ch->endian_lock[1] =3D(value >> 18) & 1; - if (ch->endian[0] !=3D ch->endian[1]) - fprintf(stderr, "%s: DMA endianness conversion enable attempt\= n", - __func__); + if (ch->endian[0] !=3D ch->endian[1]) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: DMA endianness conversion enable attempt\n", + __func__); + } ch->write_mode =3D (value >> 16) & 3; ch->burst[1] =3D (value & 0xc000) >> 14; ch->pack[1] =3D (value & 0x2000) >> 13; @@ -1988,12 +2001,15 @@ static void omap_dma4_write(void *opaque, hwaddr ad= dr, ch->burst[0] =3D (value & 0x0180) >> 7; ch->pack[0] =3D (value & 0x0040) >> 6; ch->translate[0] =3D (value & 0x003c) >> 2; - if (ch->translate[0] | ch->translate[1]) - fprintf(stderr, "%s: bad MReqAddressTranslate sideband signal\= n", - __func__); + if (ch->translate[0] | ch->translate[1]) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: bad MReqAddressTranslate sideband signal\n", + __func__); + } ch->data_type =3D 1 << (value & 3); if ((value & 3) =3D=3D 3) { - printf("%s: bad data_type for DMA channel\n", __func__); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: bad data_type for DMA channel\n", __func__); ch->data_type >>=3D 1; } break; --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813782169381.6373770428727; Sat, 23 Jun 2018 21:16:22 -0700 (PDT) Received: from localhost ([::1]:40551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwRp-000333-E8 for importer@patchew.org; Sun, 24 Jun 2018 00:16:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIT-0003sl-BR for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIR-0003qB-MB for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:41 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:41520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIR-0003q5-Hy; Sun, 24 Jun 2018 00:06:39 -0400 Received: by mail-qk0-x22c.google.com with SMTP id d22-v6so169262qkc.8; Sat, 23 Jun 2018 21:06:39 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LBtULdpVGZHXXdJeP9a2uG196NqZT+OU//3yrTeMnA8=; b=pOnkILMuWfO0HuAyo+XYeTUaMt2K6Qc75xN/WW+oUY3iEEab+Qbl4z3liVa6wc2WyQ 8W7u/KsVqC/3tzOYDrUX1xaQISEBw9APaIKOqy64krxFsnCoV73XVWiDt+t5fyiGO9xW Jn45vvFox796GF39nwuHJL2mBdlr0Qq8v38lcChXPqJX+Ww7mDxHPtRzwRuWXLzTo870 p9yOrt2iTQ7oKg2dEiypyAmlaXaB0fxYD++Ynj91+z3NxCu+b6Dc5ZLIypIasBEOGXUA QXIgOyvyFhO00lmQJCfDsw2xw21plWKTC5JIvR2Mm+bEw1lSFEaoQ3WjfvIB+p+KsPWG FOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LBtULdpVGZHXXdJeP9a2uG196NqZT+OU//3yrTeMnA8=; b=cniuiamDKz+kMhVt+VG+jJZYy/6NI7xdm+uS6LZ2KzeGX+fAwYSe+zRNbIzP83mtxL TkCx84uVtfy74cZbQFtnVdGIZ2ju3LhofcmCkjgwqdTTkIwqaptHjfT/4WZsrDF1vHXI KmnqqgUHxL1WniTmU+C/9EQpT2GKu0lO09De3E0t4ZjZGqGbsGlaRSHhEHCqwwRCAv5M aDFr9s7mvx5o1GEs2ZFI5Tp3nXrx3eOj3+IrjjKRDeKzdpygj15gsdSmqmrICkyJn91K amVzaUVLhfooSHti7pkJlRR4VYlEeigm8UKSn65Xr702QlJfTqjnBQqERSNaw82XR8l/ bSDw== X-Gm-Message-State: APt69E1reYbEi/WHSUd+JPSdnmP+X75jmXsBnVWibGsGhYT+1N1saCZi 0af7TOmH5jKnJzGd1xUM3GY= X-Google-Smtp-Source: ADUXVKLhdu57UsJFQFnqcKeJbqyJbjBvWh7A/d/n/VcXfrn3ALNICpkXNIKMfbA+jKoy/kFNjQQzAQ== X-Received: by 2002:a37:be06:: with SMTP id o6-v6mr6531255qkf.162.1529813199058; Sat, 23 Jun 2018 21:06:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:58 -0300 Message-Id: <20180624040609.17572-6-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22c Subject: [Qemu-devel] [PATCH v3 05/16] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , qemu-trivial@nongnu.org, Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/ssi/omap_spi.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ssi/omap_spi.c b/hw/ssi/omap_spi.c index 34163e5646..f278a55160 100644 --- a/hw/ssi/omap_spi.c +++ b/hw/ssi/omap_spi.c @@ -20,6 +20,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" =20 @@ -294,11 +295,15 @@ static void omap_mcspi_write(void *opaque, hwaddr add= r, case 0x2c: /* MCSPI_CHCONF */ if ((value ^ s->ch[ch].config) & (3 << 14)) /* DMAR | DMAW */ omap_mcspi_dmarequest_update(s->ch + ch); - if (((value >> 12) & 3) =3D=3D 3) /* TRM */ - fprintf(stderr, "%s: invalid TRM value (3)\n", __func__); - if (((value >> 7) & 0x1f) < 3) /* WL */ - fprintf(stderr, "%s: invalid WL value (%" PRIx64 ")\n", - __func__, (value >> 7) & 0x1f); + if (((value >> 12) & 3) =3D=3D 3) { /* TRM */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid TRM value (3)\n", + __func__); + } + if (((value >> 7) & 0x1f) < 3) { /* WL */ + qemu_log_mask(LOG_GUEST_ERROR, + "%s: invalid WL value (%" PRIx64 ")\n", + __func__, (value >> 7) & 0x1f); + } s->ch[ch].config =3D value & 0x7fffff; break; =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813928320175.86019826311997; Sat, 23 Jun 2018 21:18:48 -0700 (PDT) Received: from localhost ([::1]:40562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwUB-0004mY-Ij for importer@patchew.org; Sun, 24 Jun 2018 00:18:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIV-0003u7-9x for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIU-0003rH-9N for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:43 -0400 Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:33964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIU-0003r6-5S; Sun, 24 Jun 2018 00:06:42 -0400 Received: by mail-qk0-x22a.google.com with SMTP id b66-v6so348540qkj.1; Sat, 23 Jun 2018 21:06:42 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hK9QEGg5qg6ckCjOXMcitnFzKOYf48jdhPmYlKTayek=; b=siNHgui5LVnwZh9ZfjiZyOGzJLyoVhHIr7vRxeVzBM8N742Ng6lqDepB5iml6pDI1k +7NN/yDWOFU927YGy4u923Vv56MgVJnLxAaOxrip8Rck6V9z1uevf4WdGqULFgqIFAbe lykaVitHxaPC40cS/O7wZkwTkjmoF+N3RSvxUMIcoI1Q9O7hRGyL8igBfiJpeSCZOGUz c8iszncxMHscwMCWFtDpM6qkn/T23cxGX2d4phV6RrjarFX6fdhyGOYwIPnqkH/Kp06D l0jFbEvU19HI8yv7hhHyA0S7IyFjdB6TylOXq7B/PkCyAtzmivYV0S2CGXgqWzXLzMd4 5Cuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hK9QEGg5qg6ckCjOXMcitnFzKOYf48jdhPmYlKTayek=; b=jbtH6lYGPrhUAm9hlInqUyY+mDiPjARAKGAeftw6WMv4TUr4MMIZYRJMN2VKqF68Bu 2CRyMIk0Z2wMJhR2sk7jm3u0sXpZRusd5XZzlH8JhJpb70ruOZPh9kA+xv73yNzPPchA WHdAGrenK02Pf3kaXDQsWj8oINtkg6/lsY4Mi8v+acCd6hM5Y8ziAOMsbswT1VX9Vw0I mBinajcJwFSm71p+AGntZNGDwu+7uyU54ftlrgGuujRrLY7OjiFxmgAiI81T0JSoDiae /hLQfwGI3n3QCp+XIpMfpnhOKDqifKvFeIZRi+Beebz0yUvQH812tdWx0Y4hyQlT2fCb IUBg== X-Gm-Message-State: APt69E0qmUUR2L4WoWpQFkWIDs9BbptWGhx7bn+Yfmn7EmwUG1o4AkLm ec72uEaSnx/X4OHRtUcJa3k= X-Google-Smtp-Source: AAOMgpdVmXRmnV3YyXU43Gbtm7TzpYU2BBiUPimbhR9sYj8ID20dIP9rJzWYJ8UsR184wtJGoJMVrA== X-Received: by 2002:a37:a3d2:: with SMTP id m201-v6mr6460403qke.121.1529813201676; Sat, 23 Jun 2018 21:06:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:05:59 -0300 Message-Id: <20180624040609.17572-7-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22a Subject: [Qemu-devel] [PATCH v3 06/16] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/sd/omap_mmc.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c index 5b47cadf11..aa2a816f76 100644 --- a/hw/sd/omap_mmc.c +++ b/hw/sd/omap_mmc.c @@ -17,6 +17,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" #include "hw/sd/sd.h" @@ -449,10 +450,14 @@ static void omap_mmc_write(void *opaque, hwaddr offse= t, s->enable =3D (value >> 11) & 1; s->be =3D (value >> 10) & 1; s->clkdiv =3D (value >> 0) & (s->rev >=3D 2 ? 0x3ff : 0xff); - if (s->mode !=3D 0) - printf("SD mode %i unimplemented!\n", s->mode); - if (s->be !=3D 0) - printf("SD FIFO byte sex unimplemented!\n"); + if (s->mode !=3D 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: mode #%i unimplemented\n", s->mode= ); + } + if (s->be !=3D 0) { + qemu_log_mask(LOG_UNIMP, + "omap_mmc_wr: Big Endian not implemented\n"); + } if (s->dw !=3D 0 && s->lines < 4) printf("4-bit SD bus enabled\n"); if (!s->enable) --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529814066120744.6302968785046; Sat, 23 Jun 2018 21:21:06 -0700 (PDT) Received: from localhost ([::1]:40584 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwWP-0006M5-E6 for importer@patchew.org; Sun, 24 Jun 2018 00:21:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIX-0003w4-TS for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIW-0003uK-T3 for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:45 -0400 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]:33965) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIW-0003tt-Ow; Sun, 24 Jun 2018 00:06:44 -0400 Received: by mail-qk0-x22b.google.com with SMTP id b66-v6so348569qkj.1; Sat, 23 Jun 2018 21:06:44 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zGB87WBZUxSYqYPuFSOnGGcEOOn/B+mDAgxK88CRyao=; b=tV5T+H4Dj8ANICMMuoasIMIFnuyPUBVIcbpjZLIpYM13neWGIp7M2mZO4zaRsSGFK/ FHDHvVfvUz5faegE9Endy5Fc/rdo0fIcpmwPdwkkhTLKlCWpHIsW3TLdzwLDTe8wfbum WJUwfZcxYtkg5T76VRwxjiMELYi4MMkhzgWwqhZzIndwk7Be7AT5Rg4peefl8UVURFfO sGhsqfzc0HU34O+eyY15M48dLeYjGF7R3ofCHxpfYdZ2KMEpcCpBqk2CYm5U74VVuVEO qh6bMonvxSMi7w2kLZHq98DIqMhV9ujgCSX+yB3QSGupalVW1WMJT4nA5LMaoP+PdmCB ZbFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zGB87WBZUxSYqYPuFSOnGGcEOOn/B+mDAgxK88CRyao=; b=QGbbvNFyOr8mVLig30QvEQKUL41KE7sWBXWkhNXL3TK2FJNFM2EBeWt8DYYdu4YAkR IvemWGLIhcCQCArshFechU0+4/67PxAWCBfw58lnhuZ/TStF4rgKX19aLA5vTqAK2B/b hlA4x7KtIm7CPKEDJ4PCKjplLTAJd+URCzRLn8T8qF2TIVoI6U7E+qSzN8RsfKzqoea/ TBctpM0V96TpVhxzUbKiMimugSedCJ/4LvTnt8m7iPocsfc2biEk6SiCnIDgMBuDfMVg /BjYJkK1BK6WheDTskSUtjJ2FxJc3DzP9xqzC6/fC+jMk45QCvEx1nZ31Rswyl5mC8zk lQMA== X-Gm-Message-State: APt69E2zFagdMlJqddrB/4dX19wP3MVOxo4QkZt305wNgv4/H+T7ewY9 8McA4feFagBetymCSGFxkOk= X-Google-Smtp-Source: AAOMgpdOSd/j5HLUqaaAv8eNLPPl91LORHLwmOEcpmMlaziqSt+3jvdxnLB/OnxzI3fUL0SfvwLz/A== X-Received: by 2002:a37:9286:: with SMTP id u128-v6mr6189282qkd.29.1529813204279; Sat, 23 Jun 2018 21:06:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:00 -0300 Message-Id: <20180624040609.17572-8-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22b Subject: [Qemu-devel] [PATCH v3 07/16] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- Thomas: I used 4 for 1 to keep checkpatch happy. hw/i2c/omap_i2c.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c index 26e3e5ebf6..cabd348b45 100644 --- a/hw/i2c/omap_i2c.c +++ b/hw/i2c/omap_i2c.c @@ -17,6 +17,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/i2c/i2c.h" #include "hw/arm/omap.h" @@ -339,14 +340,15 @@ static void omap_i2c_write(void *opaque, hwaddr addr, } break; } - if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */ - fprintf(stderr, "%s: I^2C slave mode not supported\n", - __func__); + if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */ + qemu_log_mask(LOG_UNIMP, "%s: I^2C slave mode not supported\n", + __func__); break; } - if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */ - fprintf(stderr, "%s: 10-bit addressing mode not supported\n", - __func__); + if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */ + qemu_log_mask(LOG_UNIMP, + "%s: 10-bit addressing mode not supported\n", + __func__); break; } if ((value & (1 << 15)) && value & (1 << 0)) { /* STT */ @@ -392,8 +394,10 @@ static void omap_i2c_write(void *opaque, hwaddr addr, s->stat |=3D 0x3f; omap_i2c_interrupts_update(s); } - if (value & (1 << 15)) /* ST_EN */ - fprintf(stderr, "%s: System Test not supported\n", __func__); + if (value & (1 << 15)) { /* ST_EN */ + qemu_log_mask(LOG_UNIMP, + "%s: System Test not supported\n", __func__); + } break; =20 default: --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529814223832221.91739264862736; Sat, 23 Jun 2018 21:23:43 -0700 (PDT) Received: from localhost ([::1]:40598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwYt-0007q9-Ll for importer@patchew.org; Sun, 24 Jun 2018 00:23:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIe-00044m-6s for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIZ-0003yk-F6 for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:52 -0400 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]:34952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIZ-0003xb-Aw; Sun, 24 Jun 2018 00:06:47 -0400 Received: by mail-qk0-x230.google.com with SMTP id u21-v6so244215qku.2; Sat, 23 Jun 2018 21:06:47 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lC2KgKibY6az3lIzgB/X94MigFbMELVxcth2+cI2ggM=; b=OUMgvQMw9RpMKChPiX/VVg+Uc2Y/7lzD8IUGIpsg5tQBM9TWGz+lUG4NdCQvASNc3a W89DO8qCeyrApzUlc+hB7W4a4O6m5lDK9BRj1lirop8FH8bacJplXZxeE16ceHubapKm 0p5s6obvEutfdVmSO9qssfOfpS/ej2lTWVQoSTaNsq1+jFp7llHuyRoMiXR6K1JMjK/e NZoBUMM/QzwfZPFOi1p7AJw6DZPsfJSTFeo66iOKxDK7ShvJBdJLXZyxjyQowRdmxxQC wG0FEWfVRShsPsa1206h8Vs3hQpmRO2KQ+QWUPx7IyTe7/SmG1fmorl08/8uXQM+gjLc tP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=lC2KgKibY6az3lIzgB/X94MigFbMELVxcth2+cI2ggM=; b=S+UMVyYyBCo6qWpBKb1V2cPpIKoOP+Z6qA7+Y01uA8OR/ni8A/tv1vi2DIdlOFqbp6 HJdHRDf6wgCV0DxwR2BEsGhjBBomP9lVwxn6oX9mxiXw0Dr6+lsIzOlS2bI055uTpGd2 kyHTGBoafub4nVMHuk2TtR2lx6VmMnRYzhbU+kUeWga8jxbgiA1orYy/vSiLkbQWt22Z mw2NWJrsPgf+2pAQ58jfPGt6WAVP4QPKrvYWBguUbJn0fjjRBWxt2RPHYRcKgIKtFQtX RayrD/nexMLduX5/goBFUJj0WIBQwAreYfiS+n8v+IkApPA/j6qVPcfKMFXYiFLIJ8cl j5EQ== X-Gm-Message-State: APt69E3d7aMqfRZ+uNo/mRr9xqBlXABwzWLyceEdCHtmErbAvu5CYb8W IgRuCOyHF46lWjm0FMJfl3Y= X-Google-Smtp-Source: AAOMgpd2bykr/TZTIYfjXqQHtFG4xPP2O7/7rm7ZP2u07r1agBkLpdu3Fz8w2d0jseV8VYh1K9qn+g== X-Received: by 2002:a37:a4d1:: with SMTP id n200-v6mr999491qke.348.1529813206815; Sat, 23 Jun 2018 21:06:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:01 -0300 Message-Id: <20180624040609.17572-9-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::230 Subject: [Qemu-devel] [PATCH v3 08/16] hw/arm/omap1: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 TCMI_VERBOSE is no more used, drop the OMAP_8/16/32B_REG macros. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- include/hw/arm/omap.h | 18 ------------------ hw/arm/omap1.c | 18 ++++++++++++------ 2 files changed, 12 insertions(+), 24 deletions(-) diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index b398607b06..39abba753d 100644 --- a/include/hw/arm/omap.h +++ b/include/hw/arm/omap.h @@ -993,24 +993,6 @@ enum { #define OMAP_GPIOSW_INVERTED 0x0001 #define OMAP_GPIOSW_OUTPUT 0x0002 =20 -# define TCMI_VERBOSE 1 - -# ifdef TCMI_VERBOSE -# define OMAP_8B_REG(paddr) \ - fprintf(stderr, "%s: 8-bit register " OMAP_FMT_plx "\n", \ - __func__, paddr) -# define OMAP_16B_REG(paddr) \ - fprintf(stderr, "%s: 16-bit register " OMAP_FMT_plx "\n", \ - __func__, paddr) -# define OMAP_32B_REG(paddr) \ - fprintf(stderr, "%s: 32-bit register " OMAP_FMT_plx "\n", \ - __func__, paddr) -# else -# define OMAP_8B_REG(paddr) -# define OMAP_16B_REG(paddr) -# define OMAP_32B_REG(paddr) -# endif - # define OMAP_MPUI_REG_MASK 0x000007ff =20 #endif /* hw_omap_h */ diff --git a/hw/arm/omap1.c b/hw/arm/omap1.c index 9af04728e3..539d29ef9c 100644 --- a/hw/arm/omap1.c +++ b/hw/arm/omap1.c @@ -34,12 +34,18 @@ #include "qemu/cutils.h" #include "qemu/bcd.h" =20 +static inline void omap_log_badwidth(const char *funcname, hwaddr addr, in= t sz) +{ + qemu_log_mask(LOG_GUEST_ERROR, "%s: %d-bit register %#08" HWADDR_PRIx = "\n", + funcname, 8 * sz, addr); +} + /* Should signal the TCMI/GPMC */ uint32_t omap_badwidth_read8(void *opaque, hwaddr addr) { uint8_t ret; =20 - OMAP_8B_REG(addr); + omap_log_badwidth(__func__, addr, 1); cpu_physical_memory_read(addr, &ret, 1); return ret; } @@ -49,7 +55,7 @@ void omap_badwidth_write8(void *opaque, hwaddr addr, { uint8_t val8 =3D value; =20 - OMAP_8B_REG(addr); + omap_log_badwidth(__func__, addr, 1); cpu_physical_memory_write(addr, &val8, 1); } =20 @@ -57,7 +63,7 @@ uint32_t omap_badwidth_read16(void *opaque, hwaddr addr) { uint16_t ret; =20 - OMAP_16B_REG(addr); + omap_log_badwidth(__func__, addr, 2); cpu_physical_memory_read(addr, &ret, 2); return ret; } @@ -67,7 +73,7 @@ void omap_badwidth_write16(void *opaque, hwaddr addr, { uint16_t val16 =3D value; =20 - OMAP_16B_REG(addr); + omap_log_badwidth(__func__, addr, 2); cpu_physical_memory_write(addr, &val16, 2); } =20 @@ -75,7 +81,7 @@ uint32_t omap_badwidth_read32(void *opaque, hwaddr addr) { uint32_t ret; =20 - OMAP_32B_REG(addr); + omap_log_badwidth(__func__, addr, 4); cpu_physical_memory_read(addr, &ret, 4); return ret; } @@ -83,7 +89,7 @@ uint32_t omap_badwidth_read32(void *opaque, hwaddr addr) void omap_badwidth_write32(void *opaque, hwaddr addr, uint32_t value) { - OMAP_32B_REG(addr); + omap_log_badwidth(__func__, addr, 4); cpu_physical_memory_write(addr, &value, 4); } =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529814164557543.5056297822883; Sat, 23 Jun 2018 21:22:44 -0700 (PDT) Received: from localhost ([::1]:40590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwXm-0007Ec-8S for importer@patchew.org; Sun, 24 Jun 2018 00:22:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIe-00044p-7J for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIc-00045j-4g for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:52 -0400 Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]:37508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIc-00044W-04; Sun, 24 Jun 2018 00:06:50 -0400 Received: by mail-qk0-x235.google.com with SMTP id j12-v6so5833380qkk.4; Sat, 23 Jun 2018 21:06:49 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=is7KX7DYXJQMvKVDeWgdn/GlkMgXVP6yLiPhgPPFzKY=; b=hW+4ZUOccUFBnx6pVtMcooaBIlJ+hVoLrhHnAeZcE/f9x1vwegFNjZfg6RkNhYPcsz velHqR416ck3qfD3XMf6leptS60DrvCSxlEFqVAtr8fXzP8GK6ej9gjq0bLMSI1FsXV4 btEMPycLiaDoJlJePfJ3H7tXcevbQ/VEFPtSQoP+LTwVCQvqcIJfdJ3lihNO1ahc3LFQ +3LJr4NvloMk5Xta+X1vsPu2SbvHHUgHdKRR9bq0JiMHbFzCTZQU9FC6izOznt11PmTM 1yiAJKlTD/CTjLRqgzaERUdkEepriK5YME3KGOpp1Xo4ETmk0Vc8+sDwqzMmN/TiowHL d6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=is7KX7DYXJQMvKVDeWgdn/GlkMgXVP6yLiPhgPPFzKY=; b=KNZA1FlpzXfOSbbZzeQh5DaznTegiGXTS5t7HZdztHaU07AmhVc/k6sCpUJcVrA/HT dyxAwbDl63r14DMeheGlBYuyzvf4YSOnxyhCWXzX6/h66DSLS8zAsSPrzbdL4hZ/+JMh 25nh55l7LtgLI7nq/V0s9dNPXOu7Bji5gSgXLBBDhf4JPiHksK8A+9lpj1Z3XiDSxB+E UmV4osjcUO5gfGQPiNTeQfoC+v7Dh4aGdMugcm8/OMXvDcctEEjDpE7oBSqitUK1L9uI 8mWSN7mhlvGR28lBG1PYCc8sixlZDWCvxVYYT0NFfkV4pBoKqj93wd9LQL10wyZYL1CO yRiQ== X-Gm-Message-State: APt69E2VthXLkihMZ8I/DK/k/zkQJGv+A2b6VjUK/40eI9Ebu0iq84Sv KX3gT7VbbzB+6jdHp2wBWjs= X-Google-Smtp-Source: ADUXVKKTFrlc8GAABIkyYV2pGeXvu84PRh7r754d4OUqJZbWX5Si9vE4jBMpF4aqeH/EvyBFNqGcJQ== X-Received: by 2002:a37:de02:: with SMTP id h2-v6mr6381027qkj.420.1529813209510; Sat, 23 Jun 2018 21:06:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:02 -0300 Message-Id: <20180624040609.17572-10-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::235 Subject: [Qemu-devel] [PATCH v3 09/16] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- include/hw/arm/omap.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index 39abba753d..e7fbd340f3 100644 --- a/include/hw/arm/omap.h +++ b/include/hw/arm/omap.h @@ -21,6 +21,7 @@ # define hw_omap_h "omap.h" #include "hw/irq.h" #include "target/arm/cpu-qom.h" +#include "qemu/log.h" =20 # define OMAP_EMIFS_BASE 0x00000000 # define OMAP2_Q0_BASE 0x00000000 @@ -944,8 +945,6 @@ struct omap_mpu_state_s *omap2420_mpu_init(MemoryRegion= *sysmem, unsigned long sdram_size, const char *core); =20 -#define OMAP_FMT_plx "%#08" HWADDR_PRIx - uint32_t omap_badwidth_read8(void *opaque, hwaddr addr); void omap_badwidth_write8(void *opaque, hwaddr addr, uint32_t value); @@ -959,11 +958,12 @@ void omap_badwidth_write32(void *opaque, hwaddr addr, void omap_mpu_wakeup(void *opaque, int irq, int req); =20 # define OMAP_BAD_REG(paddr) \ - fprintf(stderr, "%s: Bad register " OMAP_FMT_plx "\n", \ - __func__, paddr) + qemu_log_mask(LOG_GUEST_ERROR, "%s: Bad register %#08"HWADDR_PRIx"= \n", \ + __func__, paddr) # define OMAP_RO_REG(paddr) \ - fprintf(stderr, "%s: Read-only register " OMAP_FMT_plx "\n", \ - __func__, paddr) + qemu_log_mask(LOG_GUEST_ERROR, "%s: Read-only register %#08" \ + HWADDR_PRIx "\n", \ + __func__, paddr) =20 /* OMAP-specific Linux bootloader tags for the ATAG_BOARD area (Board-specifc tags are not here) */ --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813522705266.90205104232086; Sat, 23 Jun 2018 21:12:02 -0700 (PDT) Received: from localhost ([::1]:40519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwNZ-0007pH-02 for importer@patchew.org; Sun, 24 Jun 2018 00:11:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIf-000463-LG for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIe-0004Bt-PU for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:53 -0400 Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:34044) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIe-0004B4-KB; Sun, 24 Jun 2018 00:06:52 -0400 Received: by mail-qt0-x236.google.com with SMTP id b20-v6so116064qtp.1; Sat, 23 Jun 2018 21:06:52 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TIXNmx8bHFDGQeXkU9pywFHui8WZcwIyPpPA/o4klWw=; b=lfjZBlJybsLxH5E245eMIN8lxm+xpXOCXptjC+VJ7a06Hi/furEaEXwcRdKLIq/HgD y5pT6KJJmfCPGIB67s5LRmE/qHTrQZQXFveHy3KPdzL19wUELUtlLpBimVvzmqeqRmHM z037QUs0vl9yCSUe5XNjhD/Fi6ty6FhrkjQqEkkxo4S7ekKyKVaEIWzCBQJJcA2XuFYn Rg2+yPLrrkZN+pEOcsP3cD9aGGiDM7PJKeDaUrZJyRVcoxIJyQmXvO6dQykbOihSqq6D 15+pBpAd36QDxm/dGTn3RzgofEnJt+rBPz63vUGS2wNkYK9uygT+DV7gcV8PTcqYK39L wKPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TIXNmx8bHFDGQeXkU9pywFHui8WZcwIyPpPA/o4klWw=; b=mOA2/mdh5ipbVKihqMonZW3bUVTAXYkn0wYkOZTUQU62i0FNYyrOfxrnTuS1aA3shQ Wc9zKbCD4TR8mQI3/6/oOiB7sC/pnO2zoHumghli0vjlOIs/F0ANYwavOXMaOUb8PrwQ opAM792hssBcL27FQ3o30QFVaVdpelsGefSmryk8CA3fMHyIl4/+P86D143kqeZicFum srlhi44f2EaQDMLLdh4tEhbYnMdwso+O5pJfAwlSpXtvikytqpTFxRX1QRhBRfdTSQSa VD+e3PGpDPuYQp/Y9o0VyLQCf4lC3gFs+EQnUiXbW+oK/ZTwZ9GYqR4Ub5qvVpCcOBPy G8Dw== X-Gm-Message-State: APt69E1RKGTWSlvsIc0bQ7iWPy9ZY+40zDgOaku5TbTPpZLHM1xFrrSF yCbtxpOhkDXzgw2lGzn0fWo= X-Google-Smtp-Source: AAOMgpe2BGhn42RrXBKj3BKGQowRqHyV0OB8DS8GECZmZG2kG2gtXt7ahxLJgDPmGSgT5FCYMwKoiQ== X-Received: by 2002:aed:3bab:: with SMTP id r40-v6mr6466419qte.96.1529813212102; Sat, 23 Jun 2018 21:06:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:03 -0300 Message-Id: <20180624040609.17572-11-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::236 Subject: [Qemu-devel] [PATCH v3 10/16] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/arm/stellaris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index a8f1f6a912..d06e366402 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -560,7 +560,7 @@ static void ssys_write(void *opaque, hwaddr offset, case 0x040: /* SRCR0 */ case 0x044: /* SRCR1 */ case 0x048: /* SRCR2 */ - fprintf(stderr, "Peripheral reset not implemented\n"); + qemu_log_mask(LOG_UNIMP, "Peripheral reset not implemented\n"); break; case 0x054: /* IMC */ s->int_mask =3D value & 0x7f; --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813566208914.1592571121081; Sat, 23 Jun 2018 21:12:46 -0700 (PDT) Received: from localhost ([::1]:40522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwOL-0008VY-FL for importer@patchew.org; Sun, 24 Jun 2018 00:12:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIi-00046A-G9 for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIh-0004EC-Li for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:06:56 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:42966) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIh-0004E7-Hz; Sun, 24 Jun 2018 00:06:55 -0400 Received: by mail-qt0-x244.google.com with SMTP id y31-v6so9341255qty.9; Sat, 23 Jun 2018 21:06:55 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/GETBzD3viq9pszXR5PyIXw44iP0PfoCOiwkqQ3CKrA=; b=DpsKz51hoHH/hkFPla1/dZuFJzJoUfQDsCfMMeIcXIRIrfb9he+0m7oa6VJArjuW3R 5CCtoBfNj/PsGVrV8kipBm54l0Ve3BWTjEPyVtvrinzlqKUl9VH7Ey/hNip9JfjCvQ2Q o/MWF+A23XSLUYfL4OZiPGGaBgdeneyvchfo1+H0/AK6kIATy/9FF3w6EBuizk8/EWLZ UbfY9kt1jCoSCXdHztSpbLyjwp784HV3/Fiv9dYfiPaaO53nI3sEwCzV+VItJo/Z+i3K A4yoWtL3ZGoJJWREVHrP9cBDZMVc/8QF/J4VYmxrr+zR9ydH6Cahk2VjqUYoJxWeigEL F+Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/GETBzD3viq9pszXR5PyIXw44iP0PfoCOiwkqQ3CKrA=; b=VPZjXftfG02pGqC/7Ap9G6Hf8CAgYVHf2HOquoum6mysPQXARYuCevE6lxorRYbgP+ +mI3bCkpK1HM0k57MSKqz0eETMDwwG7rxtq7gudFhzr1CVHZwhiW2OMOAXVCMPRviOyz zUsyutX812BUw9TL0lijVVMTJDrYLCizeSAyhWHDRIrxkcdT1q/Y8pvVTeCLvQbNHdqI +jVH9Zoc+1Vwi5MZ0wxnZ0dGERvSiGYBLH/mxnlfJOXRD2SpAsrqcG7jQvhOWbVCrr9f oU1K1pk0gMkLhQdXNavWXNqCvkFmD5je+v5BN2J15Ugn+vRZ6EWAPR2ODgGgDd6AFlqq oyUg== X-Gm-Message-State: APt69E2c9Wmr5mupUlf1AyKk8G1Xe15wsF7pJWh+GDhPTfivasewOC5p 5Xu3kxuHkwfQOFqXHvPKRAc= X-Google-Smtp-Source: ADUXVKKNt6O/JDuf/yCMBZWzmiGiTwK3b4HRJ5s3k47QFOesWMRNEBz5CjKamORy2TZaTCmG7d4s8w== X-Received: by 2002:ac8:2f2a:: with SMTP id j39-v6mr6709140qta.74.1529813215096; Sat, 23 Jun 2018 21:06:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:04 -0300 Message-Id: <20180624040609.17572-12-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v3 11/16] hw/net/stellaris_enet: Fix a typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/stellaris_enet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 04bd10ada3..1e7329517c 100644 --- a/hw/net/stellaris_enet.c +++ b/hw/net/stellaris_enet.c @@ -340,7 +340,7 @@ static uint64_t stellaris_enet_read(void *opaque, hwadd= r offset, return s->np; case 0x38: /* TR */ return 0; - case 0x3c: /* Undocuented: Timestamp? */ + case 0x3c: /* Undocumented: Timestamp? */ return 0; default: hw_error("stellaris_enet_read: Bad offset %x\n", (int)offset); --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152981372901182.08560796197446; Sat, 23 Jun 2018 21:15:29 -0700 (PDT) Received: from localhost ([::1]:40543 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwQy-0002CP-4T for importer@patchew.org; Sun, 24 Jun 2018 00:15:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIo-0004Dk-T1 for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIk-0004Fm-AT for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:02 -0400 Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:35274) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIk-0004FT-78; Sun, 24 Jun 2018 00:06:58 -0400 Received: by mail-qt0-x236.google.com with SMTP id z6-v6so9356547qti.2; Sat, 23 Jun 2018 21:06:58 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hh/bp8CNMejKQ01C+jEYyVBD3Ry5ISVMzqeumMxnEr8=; b=o8wrqNsw9n1WYgRn3GyDDYij/JEouj7SO1BNlGYwmPllrZvnPh5apyhwPWRkcIRX2F 2z5nck82EF5jbnLAAQPncEwxsu2eRY50ew1XYV3asBCbgE31mdUHVGCRHHDc+2kZaxa0 zdN8MiHwGAM3RNocvyoVxHrlCQw6wz9k+pSw7yhvM/rXK2LmpwMJYoToWujmqbeT3g/0 Albjy6TS9cShN8BTl25vRApU1jKGHonM8qfrZyEbp2buM/W7buXoVz3Np47xTrvFmUXa 9NwXNMpXRJGwe2e29dQoQ0RswJsicCi7aJe3ZPUwLrzzWBEqiCMnZLtSYkdTrBb7W/iv azDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=hh/bp8CNMejKQ01C+jEYyVBD3Ry5ISVMzqeumMxnEr8=; b=OwlV2KP8pV6bxGS44yF6K4xdtzSFAQTPs6ZIoz3DqNrimgmvTqOdrHBNX1KuiL9+Z2 avbE8Sa/QoJw/JaUY7gr9udtVk1tDYr7kLi0jKnbSGMFpYb01xi+ffBEh6mr/EqSLw9d VHvjvhRXcpPCf3SGsem2uuwAJHbqY/AHN7h/shPuzjtwokW8qcK9z4EbVUu0M85PlNlJ vOOhXU475VSw2IwF74/KhwxYPVPsgjFJSYw7KES/2yiVTl3pg8VuRXVKAzY7Uf1hO8vf l5Pd1pW1UWIOJkW4gk1GbPNunDfvZy5N9Iq+PkRjpUfgrXCmNMtDKTrAsqAkD+q/bf4K IKvA== X-Gm-Message-State: APt69E2IUgFJ+ObxogLZQdLBjY1on7YOFQjjgXcxZnaoN5qJ2Er1B/yL DjuRW8samFkjssdvWMjGWuA= X-Google-Smtp-Source: AAOMgpdctpWU/JXiqvh28jR3pMypl1XSw5U2SeHlDOj4SyNZ7u3iFDu6g6I++vCPhruOekINVU/g+A== X-Received: by 2002:ac8:338a:: with SMTP id c10-v6mr6729460qtb.178.1529813217800; Sat, 23 Jun 2018 21:06:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:05 -0300 Message-Id: <20180624040609.17572-13-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::236 Subject: [Qemu-devel] [PATCH v3 12/16] hw/net/stellaris_enet: Use qemu_log_mask(GUEST_ERROR) instead of hw_error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw_error() finally calls abort(), but there is no need to abort here. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/stellaris_enet.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/net/stellaris_enet.c b/hw/net/stellaris_enet.c index 1e7329517c..165562d788 100644 --- a/hw/net/stellaris_enet.c +++ b/hw/net/stellaris_enet.c @@ -9,6 +9,7 @@ #include "qemu/osdep.h" #include "hw/sysbus.h" #include "net/net.h" +#include "qemu/log.h" #include =20 //#define DEBUG_STELLARIS_ENET 1 @@ -343,7 +344,9 @@ static uint64_t stellaris_enet_read(void *opaque, hwadd= r offset, case 0x3c: /* Undocumented: Timestamp? */ return 0; default: - hw_error("stellaris_enet_read: Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, "stellaris_enet_rd%d: Illegal regis= ter" + " 0x02%" HWADDR_PRIx "\n", + size * 8, offset); return 0; } } @@ -442,7 +445,9 @@ static void stellaris_enet_write(void *opaque, hwaddr o= ffset, /* Ignored. */ break; default: - hw_error("stellaris_enet_write: Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, "stellaris_enet_wr%d: Illegal regis= ter " + "0x02%" HWADDR_PRIx " =3D 0x%" PRIx= 64 "\n", + size * 8, offset, value); } } =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529814314845235.59428749934557; Sat, 23 Jun 2018 21:25:14 -0700 (PDT) Received: from localhost ([::1]:40603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwaQ-0000M2-8F for importer@patchew.org; Sun, 24 Jun 2018 00:25:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIo-0004Dl-TL for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIn-0004IS-73 for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:02 -0400 Received: from mail-qt0-x22e.google.com ([2607:f8b0:400d:c0d::22e]:38494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIn-0004Hu-29; Sun, 24 Jun 2018 00:07:01 -0400 Received: by mail-qt0-x22e.google.com with SMTP id e11-v6so8765864qtp.5; Sat, 23 Jun 2018 21:07:01 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.06.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vxqTVJOLmR8PB0jtklnVhYLlbJq8FYLX5wti/CVLsYo=; b=JRroiVHf4/kdsIImQj1Kw5bQt49Uie0JFm0CHYJqPOkt8uij8yYppxr+UemIO/XR5t 0eLDenKJQoBesVUVYXr6DI55iTcnqYS4+/42A41kNc7/A9seCCeIFTo9LTso/eK3vxd5 RHJsOfEncFQNGx1onl4INdzPZzlrdO1Uj32H4Sz392uqmesjfQSTIyVLr3cQdGzs3o3H ef6eV31TI25RDHnqPxTQP6v3B8g/9Cb6iJ1R7I9Duj5nyd/t5kXjKMknLBjfHFkxp1MJ zsoJIfrrjGc3nqJx/D3Z8W0324FFth0rmHl4+hu2JXLx4RVDP8FCNX9oZQkkPmwIbsIQ Rxtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vxqTVJOLmR8PB0jtklnVhYLlbJq8FYLX5wti/CVLsYo=; b=juYK+6NihNk+xhFXeTppcVvgDQjoeMZUeecjVHBsdiU8OTqIB5vT8GBYWzIun7VDHI IEAJGHIFCI124DCqLWfv+HaNNT+WfmVjJu9obdnZrtX+eVIH4wTKa8OBMSwjtAP/O7mv fyqFlF9BrWAlvmCHILFTcfcZexQDxdt/ozg6qWYcydrph8iFg3ABwtYEyJbGz3+v/yAg oGujWyEcoVPYLXj1VJI69Pf1Zi+rvAT+BPLgFvZ6WvEY9lOOmgUn5H6ZiXMRvlMnnVuF 9TlUmfS1TB/UdDX2VL7WznzwTfH8G9FWHUeS9Yo0K42IqBMMJ0LkleVckuDTVMsvhNWt FR/A== X-Gm-Message-State: APt69E3k0+CFHOIxzDb82RN3t9L4+OSS4KizV8xkIQg4Hz5gVUICeqlt O6mLNlOurD9jpzLEX3gv2Kg= X-Google-Smtp-Source: AAOMgpcWxZgDytA+DWh2qhXvuY2vHhDF0NI3htFnQLiTnSYf5imqvZ+57vJ/cR0KkZITcTvNKIiBqg== X-Received: by 2002:ac8:1b9a:: with SMTP id z26-v6mr6607134qtj.344.1529813220581; Sat, 23 Jun 2018 21:07:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:06 -0300 Message-Id: <20180624040609.17572-14-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22e Subject: [Qemu-devel] [PATCH v3 13/16] hw/net/smc91c111: Use qemu_log_mask(GUEST_ERROR) instead of hw_error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 hw_error() finally calls abort(), but there is no need to abort here. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/net/smc91c111.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index c8cc5379b7..9094c0b47c 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -11,6 +11,7 @@ #include "hw/sysbus.h" #include "net/net.h" #include "hw/devices.h" +#include "qemu/log.h" /* For crc32 */ #include =20 @@ -478,7 +479,9 @@ static void smc91c111_writeb(void *opaque, hwaddr offse= t, } break; } - hw_error("smc91c111_write: Bad reg %d:%x\n", s->bank, (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, "smc91c111_write(bank:%d) Illegal regis= ter" + " 0x%" HWADDR_PRIx " =3D 0x%x\n", + s->bank, offset, value); } =20 static uint32_t smc91c111_readb(void *opaque, hwaddr offset) @@ -621,7 +624,9 @@ static uint32_t smc91c111_readb(void *opaque, hwaddr of= fset) } break; } - hw_error("smc91c111_read: Bad reg %d:%x\n", s->bank, (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, "smc91c111_read(bank:%d) Illegal regist= er" + " 0x%" HWADDR_PRIx "\n", + s->bank, offset); return 0; } =20 --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813894674207.6896633017974; Sat, 23 Jun 2018 21:18:14 -0700 (PDT) Received: from localhost ([::1]:40561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwTa-0004QJ-19 for importer@patchew.org; Sun, 24 Jun 2018 00:18:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIq-0004Fp-OF for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIp-0004L8-Tu for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:04 -0400 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:37252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIp-0004Ks-PB; Sun, 24 Jun 2018 00:07:03 -0400 Received: by mail-qt0-x244.google.com with SMTP id a18-v6so9352901qtj.4; Sat, 23 Jun 2018 21:07:03 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.07.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CdRYXCWhsmUMH0swMo21YkdEym9cTZmwH2SpIoP+Acw=; b=pJi5+FIQaOnrJ5HEq97TOJtF23p/ZpX6NeRN/98BwA3XCehnup4zeDAC//K+ERpBjy hdsM/Kanvwf69ObR6mBH6v9EXQM30SwpJE0E1Ut919QjyakC2Pt2BjDpG6wnYL9MGx0O PJG7qXslFri1UL6JXBwLXuQPQX7goxPb3owLRwIyuNnQWn+6n11OuYlnkWAdgLNLqM5z lzjrVmYK2zla1zmXHiKMf+k0nFYmDz1jpfTKu8ez88FFMkTZztLV9BrmKMpx0pd4iRNj fqTtzXe8IsZN5krkbmSiQHzDmnz5aLAm2TZF3B7BOeaZ9wo7LX/3w2NzWA1yO4okwz7r Eu7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CdRYXCWhsmUMH0swMo21YkdEym9cTZmwH2SpIoP+Acw=; b=s7xrSbX6Lid2YMJFKBnyzZDkF5zAOI9pNfT/ARNu3dRXMmVU1NGoDsnCO0lPGktTgG WIvbSIiNvep6AFeLEuYeZMjJpBquV81ZVcEeVfIUIm9N+udLvmytkEkKDL7F6FHPV/Nn 57jg5C79PzcR8+gMp9SG8yWp46ljzOF9udS5ACkUrcpGcY90m5o9g0gBJ9LnmrUvrLho 7dLBAaQNNHkZq+Mi0IAbAB05ta8rHxdGWdwxrF307Wk/PMG2n6ZAohnJusIquDG6NZ3L ODFsIqx8pQfmaS4JQQ8mazziIXsrSm+4AXRuKn7uaT8PlIgG1IXZJZsXEnrarGwVR6Wq mmnw== X-Gm-Message-State: APt69E31aFH8J8ealIdAkcTxT0A5Dri8MCGABgp93zOs4r1Rrx4ZpkOK 8cvsaczJ2HlcrAgU//VwfJs= X-Google-Smtp-Source: AAOMgpcfkxPniD86wwFaxx+PSMW0el5QV45gVmxmyseW3tRzPFiXv1kNTJyC6iLvazDY5le28zMikA== X-Received: by 2002:a0c:e80b:: with SMTP id y11-v6mr6819845qvn.10.1529813223376; Sat, 23 Jun 2018 21:07:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:07 -0300 Message-Id: <20180624040609.17572-15-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v3 14/16] hw/net/smc91c111: Use qemu_log_mask(UNIMP) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/net/smc91c111.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index 9094c0b47c..d2fd2040e8 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -362,10 +362,14 @@ static void smc91c111_writeb(void *opaque, hwaddr off= set, SET_HIGH(gpr, value); return; case 12: /* Control */ - if (value & 1) - fprintf(stderr, "smc91c111:EEPROM store not implemented\n"= ); - if (value & 2) - fprintf(stderr, "smc91c111:EEPROM reload not implemented\n= "); + if (value & 1) { + qemu_log_mask(LOG_UNIMP, + "smc91c111: EEPROM store not implemented\n"); + } + if (value & 2) { + qemu_log_mask(LOG_UNIMP, + "smc91c111: EEPROM reload not implemented\n"= ); + } value &=3D ~3; SET_LOW(ctr, value); return; --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529814388424368.9980339184667; Sat, 23 Jun 2018 21:26:28 -0700 (PDT) Received: from localhost ([::1]:40613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwbb-00013g-MO for importer@patchew.org; Sun, 24 Jun 2018 00:26:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIt-0004JX-7M for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIs-0004NS-FB for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:07 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:46820) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIs-0004N2-BF; Sun, 24 Jun 2018 00:07:06 -0400 Received: by mail-qt0-x241.google.com with SMTP id h5-v6so9321598qtm.13; Sat, 23 Jun 2018 21:07:06 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ChrS/spx+A2v0ilF0tFUJ3RU9zfGVuplHoHQXfS1MYs=; b=LmdjT+PcmACB3Dm1t9cv3q01HuI6twQFKpowfoUkyiInMXPr/vFR6LgzWVo16fMjrz 6g2d9EjTdz4BnvURf3Z96lRGPftVcjMFZCWNyadIJ/ph/LYkcUjWuM2PeO2tbn9IBazk kOg933xt9GZcvrHX0ZbO02hWX+RdfsRq8yAQAakYFPRS5uBvi4TS5z75CxhfvoXNsLce 4u2iSBr2GyM7fUi9WzSI/skR7ZZzjHgF7HvresGxN9dhkV1YGlbDm/exdxJ6qYXV/3DX nQLuDUAtOrpTM3cVQUsKVUrZo+eEEaXnnJVse8w6afNDBm4J90IpKxGP6ZjdM5aufJQZ HNAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ChrS/spx+A2v0ilF0tFUJ3RU9zfGVuplHoHQXfS1MYs=; b=Uih+UmcRlA+M6Sv2G0Z3x/wnVznueXAEchCeUEpoRGdrceE1v6skHGb19bbfuC9NXj saOv+iYP//aKmCDChApoaA6lB90N17qaedu/0YKT9u56rTS/DsUnwIS+9OOQvfm+7SPs xK+gWDkf/tXeuoeRB4AlKP3CpoCJcLvW1AhOHrunuCuNnfdYgNVqiU28iybkpycxO12h bhwIitQvbMb5Jk54upfej0m38M82qOeWDA+o84dyNxTZXpLPhMTTBcFpmm4+8fa7SLVH uZuPJ7jCRyjcam9YRVwg6snG3u1ACBNne08tM7eLovBw4Sqmr0pFXPHo0GwM/IelEY7p o1YQ== X-Gm-Message-State: APt69E0h8k3kgUp0V80AvtADSZ1BBwleFVerKXr0D/8WKjN5Oh4ZSb5n pbYODWWs8kT6NYCsxW8XA28= X-Google-Smtp-Source: AAOMgpfLJtL/M1iKSLyGZBpQ623xycGtH0VZJv/6H87DRGP7lGj8JY0br5mTK3g/8rlHTKZ0YEgWOg== X-Received: by 2002:a0c:8c8a:: with SMTP id p10-v6mr6606448qvb.68.1529813225927; Sat, 23 Jun 2018 21:07:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:08 -0300 Message-Id: <20180624040609.17572-16-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH v3 15/16] hw/arm/stellaris: Fix gptm_write() error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Missed in df3692e04b2. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/stellaris.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index d06e366402..42baa768b2 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -294,7 +294,7 @@ static void gptm_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "GPTM: read at bad offset 0x%x\n", (int)offset); + "GPTM: write at bad offset 0x%x\n", (int)offset); } gptm_update_irq(s); } --=20 2.18.0 From nobody Thu May 16 09:34:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529813742244628.7271071422454; Sat, 23 Jun 2018 21:15:42 -0700 (PDT) Received: from localhost ([::1]:40545 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwRB-0002Pv-FD for importer@patchew.org; Sun, 24 Jun 2018 00:15:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWwIz-0004Ok-FI for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWwIv-0004P6-3Y for qemu-devel@nongnu.org; Sun, 24 Jun 2018 00:07:13 -0400 Received: from mail-qt0-x231.google.com ([2607:f8b0:400d:c0d::231]:34040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWwIu-0004Oo-VE; Sun, 24 Jun 2018 00:07:09 -0400 Received: by mail-qt0-x231.google.com with SMTP id b20-v6so116313qtp.1; Sat, 23 Jun 2018 21:07:08 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id d14-v6sm7145313qtn.90.2018.06.23.21.07.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jun 2018 21:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0813b3tZy7rwAPhFhDgW2zSrtA+q6aqQyRwlZWaHh0c=; b=dLRBr+Y0fdF+CbPtlsr6YFCANMK7JE5KsBQU/rfO2r2gvpPhTkQNF3mR5udCb+5Tz4 35RH2GhNIntlOL2qghjdI6bEi4lUN0iOrljxAE/WjoQAoHpqfKR+uqcV+scxuJXarTfI kxDxD/6VWyUwLp20H1HdYBZydp2D7mUAh2bsMKRzCOLdwvHfnI+T0ApwFsbAgIc29xDU k1N0jQz1lTA34Dxw9BDY9jLYMLIo4iWTQc2rKVHR1v+xGGjCmPxlgsDb/4R5BfPhMmXL 5u3WKNk2mCDZJCIJLiXeOVNwTjRYtWPnW6Bn0/I6Op6FUATCqiR6YH4bL6aT7ag+zVRw xq3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0813b3tZy7rwAPhFhDgW2zSrtA+q6aqQyRwlZWaHh0c=; b=FwLofxpC3PMCQXZ8v6zy2vvs4NMysbdfMftv1baxoAjwqSAWnyvr0A8oEYeBIN/8xm 5D2Ngxtj925BwB6jCO/NVhUKsnuG+mOrD3pfQ4sp8MTX0W5dyAH1F79Y2T69SKT7s5pQ 290z/RrGxNPGDqmZCT87fKwaImswT3/YgKeBAMTBrtrGBXSoDtf8mbu2AsApCYQ0gt/d Swz7cCVA0+A59ennml5OVMYxrTRDonX4HTMjwcbANQ1erODWVhKtfSfqTXvF7InCXEqy 1aR6K2u02aMPcaUJusRnBNp1y10v9V5n2FSG7LF85DJZYcVtDpSbhrBp+UtlpBhHifyO WxlQ== X-Gm-Message-State: APt69E2r1BOIh0pidlNDCxqKkvCwkiujeZvYlyRiVlHi6jxJ2H557mr7 UmfLiHe7eXS06En9oTHsN2Y= X-Google-Smtp-Source: ADUXVKLlmABEmEsPKkTBqITZ72/fI/WhzJuMtpYPCWRyieCo0cvEY4mwAqqJWYbjrxiw5P+WXESFMg== X-Received: by 2002:ac8:6045:: with SMTP id k5-v6mr6752064qtm.204.1529813228490; Sat, 23 Jun 2018 21:07:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Sun, 24 Jun 2018 01:06:09 -0300 Message-Id: <20180624040609.17572-17-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180624040609.17572-1-f4bug@amsat.org> References: <20180624040609.17572-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::231 Subject: [Qemu-devel] [PATCH v3 16/16] hw/arm/stellaris: Use HWADDR_PRIx to display register address X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/stellaris.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index 42baa768b2..dc521b4a5a 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -212,7 +212,8 @@ static uint64_t gptm_read(void *opaque, hwaddr offset, return 0; default: qemu_log_mask(LOG_GUEST_ERROR, - "GPTM: read at bad offset 0x%x\n", (int)offset); + "GPTM: read at bad offset 0x02%" HWADDR_PRIx "\n", + offset); return 0; } } @@ -294,7 +295,8 @@ static void gptm_write(void *opaque, hwaddr offset, break; default: qemu_log_mask(LOG_GUEST_ERROR, - "GPTM: write at bad offset 0x%x\n", (int)offset); + "GPTM: write at bad offset 0x02%" HWADDR_PRIx "\n", + offset); } gptm_update_irq(s); } --=20 2.18.0