[Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules

Philippe Mathieu-Daudé posted 1 patch 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180622021546.18178-1-f4bug@amsat.org
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
Posted by Philippe Mathieu-Daudé 5 years, 10 months ago
Builds only require:
- dtc
- keycodemapdb
- capstone

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Some tests might require ROMs. Can they clone submodules only when required?
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fabfe9ec34..415d703c91 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -67,7 +67,7 @@ before_install:
   - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
   - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
   - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-  - git submodule update --init --recursive
+  - git submodule update --init --recursive capstone dtc ui/keycodemapdb
 before_script:
   - ./configure ${CONFIG} || { cat config.log && exit 1; }
 script:
-- 
2.18.0.rc2


Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
Posted by Alex Bennée 5 years, 10 months ago
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fabfe9ec34..415d703c91 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,7 +67,7 @@ before_install:
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -  - git submodule update --init --recursive
> +  - git submodule update --init --recursive capstone dtc
> ui/keycodemapdb

Does that mean we could drop the wget hack? That's there mainly because
cloning all the submodules takes some time.

>  before_script:
>    - ./configure ${CONFIG} || { cat config.log && exit 1; }
>  script:


--
Alex Bennée

Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
Posted by Peter Maydell 5 years, 10 months ago
On 22 June 2018 at 03:15, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?

In general the ROM blobs should be in the main git repo; the submodules
are only the source for recompiling the blobs, I think.

thanks
-- PMM

Re: [Qemu-devel] [RFC PATCH] travis: Do not waste time cloning unused submodules
Posted by Alex Bennée 5 years, 10 months ago
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Builds only require:
> - dtc
> - keycodemapdb
> - capstone
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Some tests might require ROMs. Can they clone submodules only when required?
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index fabfe9ec34..415d703c91 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -67,7 +67,7 @@ before_install:
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; fi
>    - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew install libffi gettext glib pixman ; fi
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -  - git submodule update --init --recursive
> +  - git submodule update --init --recursive capstone dtc
> ui/keycodemapdb

Queued with drop of wget as well. Thanks.

>  before_script:
>    - ./configure ${CONFIG} || { cat config.log && exit 1; }
>  script:


--
Alex Bennée