1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set

Vladimir Sementsov-Ogievskiy posted 1 patch 7 years, 7 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180620152713.27309-1-vsementsov@virtuozzo.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
qapi/block-core.json | 4 ++--
blockdev.c           | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set
Posted by Vladimir Sementsov-Ogievskiy 7 years, 7 months ago 
Libvirt part is ready, let's drop x- prefix.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 qapi/block-core.json | 4 ++--
 blockdev.c           | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index cc3ede0630..dfaa050651 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -483,7 +483,7 @@
   'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
 
 ##
-# @x-block-latency-histogram-set:
+# @block-latency-histogram-set:
 #
 # Manage read, write and flush latency histograms for the device.
 #
@@ -547,7 +547,7 @@
 #      "arguments": { "device": "drive0" } }
 # <- { "return": {} }
 ##
-{ 'command': 'x-block-latency-histogram-set',
+{ 'command': 'block-latency-histogram-set',
   'data': {'device': 'str',
            '*boundaries': ['uint64'],
            '*boundaries-read': ['uint64'],
diff --git a/blockdev.c b/blockdev.c
index 58d7570932..6d4ae77041 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char *node_name, StrOrNull *iothread,
     aio_context_release(old_context);
 }
 
-void qmp_x_block_latency_histogram_set(
+void qmp_block_latency_histogram_set(
     const char *device,
     bool has_boundaries, uint64List *boundaries,
     bool has_boundaries_read, uint64List *boundaries_read,
-- 
2.11.1
Re: [Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set
Posted by Vladimir Sementsov-Ogievskiy 7 years, 7 months ago 
20.06.2018 18:27, Vladimir Sementsov-Ogievskiy wrote:
> Libvirt part is ready, let's drop x- prefix.

libvirt patches will be sent soon I hope.

>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   qapi/block-core.json | 4 ++--
>   blockdev.c           | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index cc3ede0630..dfaa050651 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -483,7 +483,7 @@
>     'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
>   
>   ##
> -# @x-block-latency-histogram-set:
> +# @block-latency-histogram-set:
>   #
>   # Manage read, write and flush latency histograms for the device.
>   #
> @@ -547,7 +547,7 @@
>   #      "arguments": { "device": "drive0" } }
>   # <- { "return": {} }
>   ##
> -{ 'command': 'x-block-latency-histogram-set',
> +{ 'command': 'block-latency-histogram-set',
>     'data': {'device': 'str',
>              '*boundaries': ['uint64'],
>              '*boundaries-read': ['uint64'],
> diff --git a/blockdev.c b/blockdev.c
> index 58d7570932..6d4ae77041 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char *node_name, StrOrNull *iothread,
>       aio_context_release(old_context);
>   }
>   
> -void qmp_x_block_latency_histogram_set(
> +void qmp_block_latency_histogram_set(
>       const char *device,
>       bool has_boundaries, uint64List *boundaries,
>       bool has_boundaries_read, uint64List *boundaries_read,


-- 
Best regards,
Vladimir
Re: [Qemu-devel] [Qemu-block] [PATCH] qapi: drop x- from x-block-latency-histogram-set
Posted by John Snow 7 years, 7 months ago 

On 06/20/2018 11:28 AM, Vladimir Sementsov-Ogievskiy wrote:
> 20.06.2018 18:27, Vladimir Sementsov-Ogievskiy wrote:
>> Libvirt part is ready, let's drop x- prefix.
> 
> libvirt patches will be sent soon I hope.
> 

OK, can you ping this patch with a link to the series when it is posted?

Thank you,
--js

>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>>   qapi/block-core.json | 4 ++--
>>   blockdev.c           | 2 +-
>>   2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index cc3ede0630..dfaa050651 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -483,7 +483,7 @@
>>     'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
>>     ##
>> -# @x-block-latency-histogram-set:
>> +# @block-latency-histogram-set:
>>   #
>>   # Manage read, write and flush latency histograms for the device.
>>   #
>> @@ -547,7 +547,7 @@
>>   #      "arguments": { "device": "drive0" } }
>>   # <- { "return": {} }
>>   ##
>> -{ 'command': 'x-block-latency-histogram-set',
>> +{ 'command': 'block-latency-histogram-set',
>>     'data': {'device': 'str',
>>              '*boundaries': ['uint64'],
>>              '*boundaries-read': ['uint64'],
>> diff --git a/blockdev.c b/blockdev.c
>> index 58d7570932..6d4ae77041 100644
>> --- a/blockdev.c
>> +++ b/blockdev.c
>> @@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char
>> *node_name, StrOrNull *iothread,
>>       aio_context_release(old_context);
>>   }
>>   -void qmp_x_block_latency_histogram_set(
>> +void qmp_block_latency_histogram_set(
>>       const char *device,
>>       bool has_boundaries, uint64List *boundaries,
>>       bool has_boundaries_read, uint64List *boundaries_read,
> 
>
Re: [Qemu-devel] [Qemu-block] [PATCH] qapi: drop x- from x-block-latency-histogram-set
Posted by Vladimir Sementsov-Ogievskiy 7 years, 4 months ago 
20.06.2018 19:07, John Snow wrote:
>
> On 06/20/2018 11:28 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 20.06.2018 18:27, Vladimir Sementsov-Ogievskiy wrote:
>>> Libvirt part is ready, let's drop x- prefix.
>> libvirt patches will be sent soon I hope.
>>
> OK, can you ping this patch with a link to the series when it is posted?

Done: 
https://www.redhat.com/archives/libvir-list/2018-September/msg00011.html

Can we merge this patch to Qemu, to continue dialog with Libvirt?

>
> Thank you,
> --js
>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>> ---
>>>    qapi/block-core.json | 4 ++--
>>>    blockdev.c           | 2 +-
>>>    2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>>> index cc3ede0630..dfaa050651 100644
>>> --- a/qapi/block-core.json
>>> +++ b/qapi/block-core.json
>>> @@ -483,7 +483,7 @@
>>>      'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
>>>      ##
>>> -# @x-block-latency-histogram-set:
>>> +# @block-latency-histogram-set:
>>>    #
>>>    # Manage read, write and flush latency histograms for the device.
>>>    #
>>> @@ -547,7 +547,7 @@
>>>    #      "arguments": { "device": "drive0" } }
>>>    # <- { "return": {} }
>>>    ##
>>> -{ 'command': 'x-block-latency-histogram-set',
>>> +{ 'command': 'block-latency-histogram-set',
>>>      'data': {'device': 'str',
>>>               '*boundaries': ['uint64'],
>>>               '*boundaries-read': ['uint64'],
>>> diff --git a/blockdev.c b/blockdev.c
>>> index 58d7570932..6d4ae77041 100644
>>> --- a/blockdev.c
>>> +++ b/blockdev.c
>>> @@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char
>>> *node_name, StrOrNull *iothread,
>>>        aio_context_release(old_context);
>>>    }
>>>    -void qmp_x_block_latency_histogram_set(
>>> +void qmp_block_latency_histogram_set(
>>>        const char *device,
>>>        bool has_boundaries, uint64List *boundaries,
>>>        bool has_boundaries_read, uint64List *boundaries_read,
>>


-- 
Best regards,
Vladimir

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.