From nobody Sat May 4 03:09:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1529454828041979.1562686471266; Tue, 19 Jun 2018 17:33:48 -0700 (PDT) Received: from localhost ([::1]:45480 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVR43-00052v-1E for importer@patchew.org; Tue, 19 Jun 2018 20:33:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVR2y-0004f7-9Z for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:32:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVR2v-0008Km-7i for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:32:28 -0400 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:37350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVR2v-0008Jf-0x for qemu-devel@nongnu.org; Tue, 19 Jun 2018 20:32:25 -0400 Received: by mail-pl0-x242.google.com with SMTP id 31-v6so738740plc.4 for ; Tue, 19 Jun 2018 17:32:24 -0700 (PDT) Received: from surajjs2.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id z10-v6sm988882pfh.83.2018.06.19.17.32.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 Jun 2018 17:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AK6iw5b+wOcq/psUG5d48y6oDQ1Ce9Y/svMfDFsnx84=; b=aEP8amw1kRBvwkKx7UAGM1Gi7u5E9XUDMSYgpntKZdxWK1OMP7IJIq/4/bD1fswsoe 5JhjJQ6XNtZe5Rai8AKfRkeoQULPEVsaCBy0wsLhhKF+JC0GcpSGeh+DE1YywQRnvWZF D823RjB6EXdoJPbDGUmeHsk8ekmwm7HfBo1KqydF79n4UtFipLuebIqXYMbGfVkBa+3L NpQc7uWw7yma0Y1bDBRZqww0nwY8kWsdS81jlPkD6EepcDPA1G+KyLpdCurrTdyKvyW/ Sy6WFDOzM3bXvj9OX/98xFM4lgZuA6Q8FmHRYVI83bsduux9dmvNR74R8KiHyuXtAoZW R2zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AK6iw5b+wOcq/psUG5d48y6oDQ1Ce9Y/svMfDFsnx84=; b=iplSipVltcK9lMROzcPuK8NakQ1LB5hgSvy9gTiIVtVuGHhPYCurm20bj9eKMjCIYV Ie04zZyxlrFx0TqGb9PIX1XzjcWy330wl145RiOMFbTkC4Bra7VoFcgGNP7NYQW4ksSK 7+u9U6GDa9Ds9D1kmY75MdgfiavGsQ3fzALkjjL6gYmC0CM1jRAlbnWaCBgrRoU+P1Nz HOrJydedEhiwdXaoWY6o5j/StAV07M3bHL6TRNpeKR0ql14rCgufDAX51+1UrfZa8VUm jp93SPjl2SCTYJhbyaaKvx4Dj+1Z2JIA5IeEmiwd2q3Q+G0clS/WrMMZMLP8LGwUozzI ouQg== X-Gm-Message-State: APt69E2xIFdzHmY3Mj3ooJZc/eQwvMvyJnf62URxLkpXdvrt23DxwMtj 3LQS2yA6PH4ECR6jwuHFg3VrxdTz X-Google-Smtp-Source: ADUXVKLh83dFZ6fYGYTZRtTH7Vg+33mjcFIOKyfHRX311FNNEotPVGlWesFCvnHip3N9WyVOGAGAlA== X-Received: by 2002:a17:902:3081:: with SMTP id v1-v6mr21761014plb.266.1529454743992; Tue, 19 Jun 2018 17:32:23 -0700 (PDT) From: Suraj Jitindar Singh To: qemu-devel@nongnu.org Date: Wed, 20 Jun 2018 10:32:02 +1000 Message-Id: <20180620003202.10546-1-sjitindarsingh@gmail.com> X-Mailer: git-send-email 2.13.6 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PATCH] [RESEND] hmp-commands: use long for begin and length in dump-guest-memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, Suraj Jitindar Singh Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The dump-guest-memory command is used to dump an area of guest memory to a file, the piece of memory is specified by a begin address and a length. These parameters are specified as ints and thus have a maximum value of 4GB. This means you can't dump the guest memory past the first 4GB and instead get: (qemu) dump-guest-memory tmp 0x100000000 0x100000000 'dump-guest-memory' has failed: integer is for 32-bit values Try "help dump-guest-memory" for more information This limitation is imposed in monitor_parse_arguments() since they are both ints. hmp_dump_guest_memory() uses 64 bit quantities to store both the begin and length values. Thus specify begin and length as long so that the entire guest memory space can be dumped. Signed-off-by: Suraj Jitindar Singh Reviewed-by: Dr. David Alan Gilbert --- hmp-commands.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 0734fea931..3b5c1f65db 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1116,7 +1116,7 @@ ETEXI =20 { .name =3D "dump-guest-memory", - .args_type =3D "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,file= name:F,begin:i?,length:i?", + .args_type =3D "paging:-p,detach:-d,zlib:-z,lzo:-l,snappy:-s,file= name:F,begin:l?,length:l?", .params =3D "[-p] [-d] [-z|-l|-s] filename [begin length]", .help =3D "dump guest memory into file 'filename'.\n\t\t\t" "-p: do paging to get guest's memory mapping.\n\t\t\= t" --=20 2.13.6