[Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default

Peter Xu posted 7 patches 5 years, 10 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/devel/qapi-code-gen.txt | 17 +++++----
include/chardev/char.h       | 11 +++++-
include/monitor/monitor.h    |  1 -
tests/libqtest.h             |  4 +--
monitor.c                    | 70 ++++++++++++++++++++----------------
tests/libqtest.c             | 10 +++---
tests/qmp-test.c             |  6 ++--
vl.c                         |  5 ---
tests/qemu-iotests/060       | 10 +++++-
tests/qemu-iotests/060.out   |  1 -
10 files changed, 78 insertions(+), 57 deletions(-)
[Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default
Posted by Peter Xu 5 years, 10 months ago
v4:
- collect some r-bs
- remove one extra s-o-b of mine in one patch [Thomas, Markus]
- split the qmp response flush patch into two; apply changes to commit
  message [Markus]
- fix up the doc update patch [Markus]

v3:
- drop patch "tests: iotests: don't compare SHUTDOWN event", replace
  it with "monitor: flush qmp responses when CLOSED" to fix up the
  race. [Eric, Markus]
- tweak the oob revert patch to not break qmp-test [Eric]
- quite a few comment and commit message fix-ups [Eric]
- add more comment in commit message, mention about why MUX can't be
  used for Out-Of-Band [Markus]
- one new patch to comment on chardev CLOSED event [Stefan]
- one new patch to fix iotest breakage on 060 specifically

Tests: make check, iotests

Please review.  Thanks,

Peter Xu (7):
  chardev: comment details for CLOSED event
  monitor: rename *_pop_one to *_pop_any
  monitor: flush qmp responses when CLOSED
  tests: iotests: drop some stderr line
  docs: mention shared state protect for OOB
  monitor: remove "x-oob", turn oob on by default
  Revert "tests: Add parameter to qtest_init_without_qmp_handshake"

 docs/devel/qapi-code-gen.txt | 17 +++++----
 include/chardev/char.h       | 11 +++++-
 include/monitor/monitor.h    |  1 -
 tests/libqtest.h             |  4 +--
 monitor.c                    | 70 ++++++++++++++++++++----------------
 tests/libqtest.c             | 10 +++---
 tests/qmp-test.c             |  6 ++--
 vl.c                         |  5 ---
 tests/qemu-iotests/060       | 10 +++++-
 tests/qemu-iotests/060.out   |  1 -
 10 files changed, 78 insertions(+), 57 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default
Posted by Thomas Huth 5 years, 10 months ago
On 19.06.2018 07:34, Peter Xu wrote:
> v4:
> - collect some r-bs
> - remove one extra s-o-b of mine in one patch [Thomas, Markus]

FYI: You've still got a duplicated s-o-b line in patch 3 and 4.

 Thomas

Re: [Qemu-devel] [PATCH v4 0/7] monitor: enable OOB by default
Posted by Peter Xu 5 years, 10 months ago
On Tue, Jun 19, 2018 at 07:51:47AM +0200, Thomas Huth wrote:
> On 19.06.2018 07:34, Peter Xu wrote:
> > v4:
> > - collect some r-bs
> > - remove one extra s-o-b of mine in one patch [Thomas, Markus]
> 
> FYI: You've still got a duplicated s-o-b line in patch 3 and 4.
> 
>  Thomas

Thanks.  I think it's caused by the lines in commit messages like

"""
--- /home/peterx/git/qemu/tests/qemu-iotests/087.out
+++ /home/peterx/git/qemu/bin/tests/qemu-iotests/087.out.bad
"""

Then git-format-patch does not work as expected (so the extra s-o-bs
are not in my local tree).

I remove these lines then git-format-patch works fine.

If to repost, I'll double confirm with these matters.

Regards,

-- 
Peter Xu