[Qemu-devel] [PATCH v4 00/12] pc-dimm: next bunch of cleanups

David Hildenbrand posted 12 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180618142536.23995-1-david@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
There is a newer version of this series
backends/hostmem.c       |  3 +-
hw/i386/pc.c             | 73 ++++++++++++++++----------------
hw/mem/nvdimm.c          | 91 +++++++++++++++++++++-------------------
hw/mem/pc-dimm.c         | 35 ++++++----------
hw/misc/ivshmem.c        |  3 +-
hw/ppc/spapr.c           | 18 +++-----
include/hw/mem/nvdimm.h  |  2 +-
include/hw/mem/pc-dimm.h | 17 ++++----
include/sysemu/hostmem.h |  3 +-
numa.c                   |  3 +-
10 files changed, 117 insertions(+), 131 deletions(-)
[Qemu-devel] [PATCH v4 00/12] pc-dimm: next bunch of cleanups
Posted by David Hildenbrand 5 years, 9 months ago
@Paolo I have r-b for all patches. If there are no further comments, can
you pick it up, please?


This is another set of cleanups as the result from
    [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers
And is based on
    [PATCH v1 0/2] memory: fix alignment checks/asserts

These cleanup are the last step before
- 1. moving pc-dimm address and slot assignment into pc_dimm_pre_plug
- 2. factoring out pre_plug, plug and unplug logic of memory devices
     completely

v3 -> v4:
- drop "nvdimm: allow setting the label-size to 0"

v2 -> v3:
- "nvdimm: no need to overwrite get_vmstate_memory_region()"
-- reshuffeld to avoid breaking compilation in between patches
- "nvdimm: convert "label-size" into a static property"
-- replace by "nvdimm: convert nvdimm_mr into a pointer"
-- and "nvdimm: allow setting the label-size to 0"

v1 -> v2:
- deferring "pc-dimm: assign and verify the "slot" property during pre_plug"
- deferring "pc-dimm: introduce and use pc_dimm_memory_pre_plug()"
- dropped "pc-dimm: get_memory_region() will never return a NULL pointer"
- dropped "pc-dimm: don't allow to access "size" before the device was realized"
- dropped "spapr: move memory hotplug size check into plug code"
- dropped "pc-dimm: get_memory_region() can never fail"
-- replaces by "pc-dimm: get_memory_region() will not fail after realize"
- added "pc: rename pc_dimm_(plug|unplug|...)* into ..."
- added "pc-dimm: rename pc_dimm_memory_* to pc_dimm_*"
- added "pc-dimm: remove pc_dimm_get_free_slot() from header"
- added "pc-dimm: merge get_(vmstate_)memory_region()"
- added "nvdimm: convert "unarmed" into a static property"
- added "nvdimm: convert "label-size" into a static property"
- added "nvdimm: make get_memory_region() perform checks and initialization"

David Hildenbrand (12):
  pc-dimm: remove leftover "struct pc_dimms_capacity"
  pc: rename pc_dimm_(plug|unplug|...)* into
    pc_memory_(plug|unplug|...)*
  pc-dimm: rename pc_dimm_memory_* to pc_dimm_*
  pc-dimm: remove pc_dimm_get_free_slot() from header
  pc: factor out pc specific dimm checks into pc_memory_pre_plug()
  nvdimm: no need to overwrite get_vmstate_memory_region()
  hostmem: drop error variable from host_memory_backend_get_memory()
  pc-dimm: merge get_(vmstate_)memory_region()
  nvdimm: convert "unarmed" into a static property
  nvdimm: convert nvdimm_mr into a pointer
  nvdimm: make get_memory_region() perform checks and initialization
  pc-dimm: get_memory_region() will not fail after realize

 backends/hostmem.c       |  3 +-
 hw/i386/pc.c             | 73 ++++++++++++++++----------------
 hw/mem/nvdimm.c          | 91 +++++++++++++++++++++-------------------
 hw/mem/pc-dimm.c         | 35 ++++++----------
 hw/misc/ivshmem.c        |  3 +-
 hw/ppc/spapr.c           | 18 +++-----
 include/hw/mem/nvdimm.h  |  2 +-
 include/hw/mem/pc-dimm.h | 17 ++++----
 include/sysemu/hostmem.h |  3 +-
 numa.c                   |  3 +-
 10 files changed, 117 insertions(+), 131 deletions(-)

-- 
2.17.1