mos6522: allow IRQs from external port pins

[Qemu-devel] [PATCH 0/3] mos6522: allow IRQs from external port pins

Mark Cave-Ayland posted 3 patches 5 years, 10 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180613083015.15749-1-mark.cave-ayland@ilande.co.uk

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

hw/misc/mos6522.c         | 5 +++--
include/hw/misc/mos6522.h | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] mos6522: allow IRQs from external port pins

Posted by Mark Cave-Ayland 5 years, 10 months ago

Whilst testing a conversion of Laurent's q800 patchset over to use mos6522
I discovered some issues which prevented IRQs being generated from inputs to
external port pins.

This is a requirement for the q800 patchset which uses external clocks to
generate periodic interrupts.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


Mark Cave-Ayland (3):
  mos6522: only clear the shift register interrupt upon write
  mos6522: remove additional interrupt flag filter from
    mos6522_update_irq()
  mos6522: expose mos6522_update_irq() through MOS6522DeviceClass

 hw/misc/mos6522.c         | 5 +++--
 include/hw/misc/mos6522.h | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH 0/3] mos6522: allow IRQs from external port pins

Posted by David Gibson 5 years, 10 months ago

On Wed, Jun 13, 2018 at 09:30:12AM +0100, Mark Cave-Ayland wrote:
> Whilst testing a conversion of Laurent's q800 patchset over to use mos6522
> I discovered some issues which prevented IRQs being generated from inputs to
> external port pins.
> 
> This is a requirement for the q800 patchset which uses external clocks to
> generate periodic interrupts.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Applied, thanks.

> 
> 
> Mark Cave-Ayland (3):
>   mos6522: only clear the shift register interrupt upon write
>   mos6522: remove additional interrupt flag filter from
>     mos6522_update_irq()
>   mos6522: expose mos6522_update_irq() through MOS6522DeviceClass
> 
>  hw/misc/mos6522.c         | 5 +++--
>  include/hw/misc/mos6522.h | 1 +
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson