[Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication

Markus Armbruster posted 18 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180612125821.4229-1-armbru@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
There is a newer version of this series
MAINTAINERS               |   2 +
block.c                   |   1 +
block/crypto.c            |   6 +-
block/gluster.c           |   1 +
block/iscsi.c             |  24 +-
block/nbd.c               |  16 +-
block/nfs.c               |   8 +-
block/parallels.c         |  11 +-
block/qcow.c              |  11 +-
block/qcow2.c             |  11 +-
block/qed.c               |  11 +-
block/quorum.c            |   1 +
block/rbd.c               |  85 +++--
block/sheepdog.c          |  23 +-
block/snapshot.c          |   1 +
block/ssh.c               |  16 +-
block/vdi.c               |   4 +-
block/vhdx.c              |  11 +-
block/vpc.c               |  11 +-
block/vvfat.c             |   1 +
block/vxhs.c              |   1 +
blockdev.c                |   1 +
include/block/qdict.h     |  34 ++
include/qapi/qmp/qdict.h  |  17 -
qapi/block-core.json      |  19 +
qobject/Makefile.objs     |   1 +
qobject/block-qdict.c     | 722 ++++++++++++++++++++++++++++++++++++++
qobject/qdict.c           | 628 ---------------------------------
tests/Makefile.include    |   4 +
tests/check-block-qdict.c | 690 ++++++++++++++++++++++++++++++++++++
tests/check-qdict.c       | 641 ---------------------------------
tests/check-qobject.c     |   1 +
tests/test-replication.c  |   1 +
util/qemu-config.c        |   1 +
34 files changed, 1577 insertions(+), 1439 deletions(-)
create mode 100644 include/block/qdict.h
create mode 100644 qobject/block-qdict.c
create mode 100644 tests/check-block-qdict.c
[Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication
Posted by Markus Armbruster 5 years, 9 months ago
PATCH 01-17 are configuration fixes and cleanup, in particular
-blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with
non-string scalars.

PATCH 18-19 provide support for configuring rbd authentication.

I'm happy to split the series if that helps.

Since the RFC post, I amended the documentation of the rbd
authentication parameters, and squashed PATCH 04 into 03.

Jeff Cody tested the RFC on his Ceph rig.  All results match
expectations.

The series clashes with Max's "[PATCH 00/13] block: Try to create well
typed json:{} filenames", but Max has rebased his work on mine.

Markus Armbruster (17):
  rbd: Drop deprecated -drive parameter "filename"
  iscsi: Drop deprecated -drive parameter "filename"
  qobject: Move block-specific qdict code to block-qdict.c
  block: Fix -blockdev for certain non-string scalars
  block: Fix -drive for certain non-string scalars
  block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts()
  block: Factor out qobject_input_visitor_new_flat_confused()
  block: Make remaining uses of qobject input visitor more robust
  block-qdict: Simplify qdict_flatten_qdict()
  block-qdict: Tweak qdict_flatten_qdict(), qdict_flatten_qlist()
  block-qdict: Clean up qdict_crumple() a bit
  block-qdict: Simplify qdict_is_list() some
  check-block-qdict: Rename qdict_flatten()'s variables for clarity
  check-block-qdict: Cover flattening of empty lists and dictionaries
  block: Fix -blockdev / blockdev-add for empty objects and arrays
  rbd: New parameter auth-client-required
  rbd: New parameter key-secret

Max Reitz (1):
  block: Add block-specific QDict header

 MAINTAINERS               |   2 +
 block.c                   |   1 +
 block/crypto.c            |   6 +-
 block/gluster.c           |   1 +
 block/iscsi.c             |  24 +-
 block/nbd.c               |  16 +-
 block/nfs.c               |   8 +-
 block/parallels.c         |  11 +-
 block/qcow.c              |  11 +-
 block/qcow2.c             |  11 +-
 block/qed.c               |  11 +-
 block/quorum.c            |   1 +
 block/rbd.c               |  85 +++--
 block/sheepdog.c          |  23 +-
 block/snapshot.c          |   1 +
 block/ssh.c               |  16 +-
 block/vdi.c               |   4 +-
 block/vhdx.c              |  11 +-
 block/vpc.c               |  11 +-
 block/vvfat.c             |   1 +
 block/vxhs.c              |   1 +
 blockdev.c                |   1 +
 include/block/qdict.h     |  34 ++
 include/qapi/qmp/qdict.h  |  17 -
 qapi/block-core.json      |  19 +
 qobject/Makefile.objs     |   1 +
 qobject/block-qdict.c     | 722 ++++++++++++++++++++++++++++++++++++++
 qobject/qdict.c           | 628 ---------------------------------
 tests/Makefile.include    |   4 +
 tests/check-block-qdict.c | 690 ++++++++++++++++++++++++++++++++++++
 tests/check-qdict.c       | 641 ---------------------------------
 tests/check-qobject.c     |   1 +
 tests/test-replication.c  |   1 +
 util/qemu-config.c        |   1 +
 34 files changed, 1577 insertions(+), 1439 deletions(-)
 create mode 100644 include/block/qdict.h
 create mode 100644 qobject/block-qdict.c
 create mode 100644 tests/check-block-qdict.c

-- 
2.17.1


Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication
Posted by Kevin Wolf 5 years, 9 months ago
Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
> PATCH 01-17 are configuration fixes and cleanup, in particular
> -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with
> non-string scalars.
> 
> PATCH 18-19 provide support for configuring rbd authentication.
> 
> I'm happy to split the series if that helps.
> 
> Since the RFC post, I amended the documentation of the rbd
> authentication parameters, and squashed PATCH 04 into 03.

I was still reviewing the RFC while you sent this, so I posted two
comments that are still relevant for this version in the RFC thread.
Please read them there, I'm not going to duplicate them here.

Will continue with the review on this one now.

Kevin

Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication
Posted by Kevin Wolf 5 years, 9 months ago
Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
> PATCH 01-17 are configuration fixes and cleanup, in particular
> -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with
> non-string scalars.
> 
> PATCH 18-19 provide support for configuring rbd authentication.
> 
> I'm happy to split the series if that helps.
> 
> Since the RFC post, I amended the documentation of the rbd
> authentication parameters, and squashed PATCH 04 into 03.
> 
> Jeff Cody tested the RFC on his Ceph rig.  All results match
> expectations.
> 
> The series clashes with Max's "[PATCH 00/13] block: Try to create well
> typed json:{} filenames", but Max has rebased his work on mine.

I had minor, but still non-trivial comments for patches 9 and 12. The
rest is:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>